From nobody Sat Oct 25 09:08:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343609771620.749994313214; Tue, 6 Mar 2018 05:40:09 -0800 (PST) Received: from localhost ([::1]:55809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCp3-000787-Li for importer@patchew.org; Tue, 06 Mar 2018 08:40:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVW-0004vp-0m for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVV-0006M9-3G for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:53 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:53346) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVU-0006Lg-T3 for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:53 -0500 Received: by mail-wm0-x244.google.com with SMTP id e194so3744853wmd.3 for ; Tue, 06 Mar 2018 05:19:52 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=dzAfTIDAO2KxlJFnLw5ZEBcbIF1HNoLCqsGJE0jjOPg=; b=rK7zlQRfOBUIZQ6gvLWICf7DnqwvVCwc/lyY37gFGsouUyttXMqKxOvr63Zf6UCspI vKvti8Q/IV4aK+K1ePQJNPy0g6+GmDQXq+3bv7Y1VHgKFO5/MqdlKsxKvISEB8ewW6ga QOLQmn9I1UB4wr1gqyyOPzorFz/n/SyrYcp9P+dlG6ZFC52/IOYoH4KKqYAikZ8UTB4t luCuv5Iyq0I1WojHAHjJ8Gu24yzCS1gf2MRMNNbmIc0DhUBHHz3kRPy2XNdpGS7Q860+ +GBXNko6YnNTEDYZPtuJ9T4wpJ1rH0ffIN/BvtVbcolFLRwrNSDvTUFhzt5enRopw90H J4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=dzAfTIDAO2KxlJFnLw5ZEBcbIF1HNoLCqsGJE0jjOPg=; b=reIHQAzY1Sz3lG8MX6v1QwKIm57YvN/fZ8NCxT7xhyEM/d+nL1EneVDjvfdXN+8JBz dgGZkPrhgfuBqETE1RxRB/lgg+/63IqycE+9WMKciaXpyNCWWrXOq2dJWWE+P/00wSUR /Cap7wSy1vanvMe4WAfd/l1Sa48P/6MWwAfPpRgZtH3uzZ4KsGCqdwgVnRZ/LP4ZGWT7 J0VLxnou0rBtueXLzacyfG4QrtPu1sxYTew0UKcM4cz2jUFvzaQpTFSbHDs1zgdS2YRO KYlMxgrUg4gcDjFwau8BCsm9HC1J+yQJ80yGKJnqC/dGKXiO8NJp0Imz12SEDlMb8EPY pofQ== X-Gm-Message-State: AElRT7HqzHlV3D+EcMT7bFQqwt1x7bakGuZGGDDZgMn4+zXJGvW4TyqR Lh4M1RT/1vmJ6yIWMaFSODEDjQX3 X-Google-Smtp-Source: AG47ELuE9xsMrPAY2zMy5dLOsqQZ6HwEzCDAWNdTH42faZUgk0avPq8i3yrnF6Tl0iNp9ZAn/ac4ag== X-Received: by 10.28.241.2 with SMTP id p2mr10570847wmh.105.1520342391738; Tue, 06 Mar 2018 05:19:51 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:11 +0100 Message-Id: <1520342370-123606-16-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PULL 15/34] openpic_kvm: drop address_space_to_flatview call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The MemoryListener is registered on address_space_memory, there is not much to assert. This currently works because the callback is invoked only once when the listener is registered, but section->fv is the _new_ FlatView, not the old one on later calls and that would break. This confines address_space_to_flatview to exec.c and memory.c. Acked-by: David Gibson Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- hw/intc/openpic_kvm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c index f1a59e5..928bc04 100644 --- a/hw/intc/openpic_kvm.c +++ b/hw/intc/openpic_kvm.c @@ -125,10 +125,6 @@ static void kvm_openpic_region_add(MemoryListener *lis= tener, uint64_t reg_base; int ret; =20 - if (section->fv !=3D address_space_to_flatview(&address_space_memory))= { - abort(); - } - /* Ignore events on regions that are not us */ if (section->mr !=3D &opp->mem) { return; --=20 1.8.3.1