From nobody Sat Oct 25 09:08:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343038785268.1346109991274; Tue, 6 Mar 2018 05:30:38 -0800 (PST) Received: from localhost ([::1]:55748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCfp-0007Vi-7S for importer@patchew.org; Tue, 06 Mar 2018 08:30:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVV-0004ue-2j for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVU-0006LO-4A for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:53 -0500 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:37515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVT-0006Ke-TK for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:52 -0500 Received: by mail-wr0-x243.google.com with SMTP id z12so20914668wrg.4 for ; Tue, 06 Mar 2018 05:19:51 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=gUYOTu54Gbb/O3JUTFVV2IsgSRSAgLKw/SO/h4nHON0=; b=bF92i0D3JR/z2dwdkp1C+XtWkra1gVrhBnEy9nHbseyyuCZTBQnijOfRqouJSLyVZv cCxwmuR32eR696pNwsCLG2PnfVeek/OoOI920Cv0JqvQ42ZEGLxQgJlcew1AlD6gCIDw OTHaLKjP6TR9RcxNTElzWrB23gu/SGesxjmZU77TKt96jbM0dbwYSxMZ4CNhDjD8tx6v IhtQSu2vRc7JDdIa95IvIYHZeDAEikQr6K+INv+tcfZQ7p6dwo6UDPTRoTqsmYK7FkKY FIhKEwTVTWXIJwTekbnS7k1/v9h/FXi4ZmqqN9ZFavkOWNYpHIG7J80k39Da74n8fUlc q2iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=gUYOTu54Gbb/O3JUTFVV2IsgSRSAgLKw/SO/h4nHON0=; b=p8yQ5pkCV98SSUu4KA4Vl8ojRWAimBJ0j+gMXmvc+sYxv1QgAJskWpZR+GvsV1uCU0 yBMSSUL1MHRcWvldf4IdM1RDWkz8TClNuoLELcxqKWltF7wyngXeMXn80Gtssd0j8d4K VtAjGg5sn4uH+aQAwA4W4BfO7Krx3i+47+imIOYcKyG4KbQ+bM403wjdpfExXdQW949j Tse7HgFZLWRBmeXxAGGoilCHrJVvwdWQP1rkDqdE7eQoz7pCHsKmHqGVKB7rw68nW6MW hmDOsKJGhD6t0UTtp1saTPv1q4K/LHOhU6ysrIHRWCOaYHlIARLPIkttNQIMf2l7W+iO EJaw== X-Gm-Message-State: APf1xPAvqO98WsrHZXrEdHoTf3M+1rGQFsTGfyTN+BjuY9xhnx/Sug5J 9Re0KPeUU7QJik2DiTTtK5YdplnQ X-Google-Smtp-Source: AG47ELtVkoEPfnu9lo+RcyDzvxGVQSfvt01+oHQ0AxKpuk0HHdonjxzAD3Al8ekaInLUfv1fHUt0iA== X-Received: by 10.223.130.176 with SMTP id 45mr15843418wrc.250.1520342390581; Tue, 06 Mar 2018 05:19:50 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:10 +0100 Message-Id: <1520342370-123606-15-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PULL 14/34] chardev: fix leak in tcp_chr_telnet_init_io() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Xu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Xu Need to free TCPChardevTelnetInit when session established. Since at it, switch to use G_SOURCE_* macros. Reviewed-by: Daniel P. Berrange Signed-off-by: Peter Xu Message-Id: <20180301084438.13594-2-peterx@redhat.com> Signed-off-by: Paolo Bonzini --- chardev/char-socket.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 22f6597..8401aae 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -592,19 +592,23 @@ static gboolean tcp_chr_telnet_init_io(QIOChannel *io= c, ret =3D 0; } else { tcp_chr_disconnect(init->chr); - return FALSE; + goto end; } } init->buflen -=3D ret; =20 if (init->buflen =3D=3D 0) { tcp_chr_connect(init->chr); - return FALSE; + goto end; } =20 memmove(init->buf, init->buf + ret, init->buflen); =20 - return TRUE; + return G_SOURCE_CONTINUE; + +end: + g_free(init); + return G_SOURCE_REMOVE; } =20 static void tcp_chr_telnet_init(Chardev *chr) --=20 1.8.3.1