From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519675631178445.8797553855526; Mon, 26 Feb 2018 12:07:11 -0800 (PST) Received: from localhost ([::1]:60467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMNX-0008Lf-Ly for importer@patchew.org; Mon, 26 Feb 2018 12:15:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLr-0007IP-RU for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLo-0004dA-1K for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:11 -0500 Received: from mail-sn1nam02on0115.outbound.protection.outlook.com ([104.47.36.115]:20112 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLn-0004c7-Rf for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:07 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wcNkVN89RhhGbxC9++l3UwTKyXzUp+xSLnXiS6kD4os=; b=cYPGdrws1CIl3+YjQB+JEEOQRSIWqxLi0+wbAsYBRKVay5DBOK7SVQMnyymGXYWn5OvVPxeVKObnFZAaY9vnnCOwkfrKW6k4R2ixVOV7vaeoq8PO7RcRKWgo7m2KJCm5uga4TsHQc2r1EQK1eXPxWqb+HeF9Hoeis4Ifdo6iCoI= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:29 -0800 Message-Id: <1519665216-1078-2-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9c32ca98-e645-45a3-c906-08d57d3c5744 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:i+DXkjdmnFyUJUwF0aA40ag1r4y9NdC4v54PCteEKfdqGKcqsniebvtdMcjuNKwZDFcFa+lRQWGeIT/SgGQx/r20JjpH8myExNni2k3YAKCNS0i2HwVv777RllJ9f9BxekmUmj5NL6zL93qcSYgTqbTKRmyojdyS2E/X+icK0ogrl6uox4v99Kt/eRrDrmJeBbNvJvYnVlc7/C1ohi2L3m6O+zBaYny1oN7HSKjavHmCE569BuuikYk3ablu3/5T; 25:2r84eSaZSA1Hqtm/FHEd0gTA4rvuE4DqIrs6UQDK+dRULoZW9eBrfNcM9LngUBeVmbkEHCRIlnsJE7zcKvhWfWVzJ9QGmHf8Nn1FqFixNiGCQLP/L6Pp1xcyNvSZv1vAE9HBNqmjiywA7JI3i2j9wsqwZa6QowJ1G3Ntj73jVmiOZh0VfYy1Kw987X+jTnAna7zQ8l6p5SIz+Jk+A6voODSL0IK3kRRyapW1QJcGLRq17KPiJJX1CYESt2iuAOSgu3kv7L+4id0zl43YiTrEym2YPKicx0kxSux+TFavhnHccM5HYK1uuFZrcx2TbdEIIcmoq0epjK5JzodKQu2FvA==; 31:8IMpm1ESeJsiGrZuaksz3PJ8H0JG9G5I++zVereHaxeQrXpFVBxm5jgHYblGMlsC2+wQ3NFq75kCabWQ5kAEDGlANGsOOSd+70p191Hs7YoRn/zjNKXky26mgvbMuc4NiwMGqOX6POIGEqhVGD2d63Zccswkne6ZiI0iFUhU94LvCNpO+zyP++U0/xmshQpaYtBIut28VoF5CdsY8i5G4Ivz2RYKhLFAiICUl5yiICY= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:BQP51aJ2VtiXw65RA4uPWBdQuxARKGVi0EfVfajXUlusvtJ9dNk7tuKqEyn/WZyzUrKzpAWdzVVc5t9xWRU3P2gpgugCdVo9rLD44iJmqCAVk6rZ2yWtEaCqpBS4ptnY2bdvoP/4LghzRHYRm9UjNHu/28Lp1MXoj85vkU3N2jbwuSbep8/ndDVSo+Rp2cr+pMtR4bhRjNevv4HhkSyLdI6UZeZ1+ohqhCjh06UhvFwwgt2+g8fp9HYJsRFc4uf+VKOCRNeTGdVi1PwDx7oJPkvfWZ7hBfv5ANZu2ZyLydnnpmFgjKSTujndyqbIeF9GeY3FblUiWx44kFaRa5PRPUxmIRBz2H22MMkNIJWgKg3KKgToHLJ1eOhgzgwPnl40z1KXL4BWHyBnt9L1CSBPcrbt4k1YmP5OLFKJRSOu0RqbWcDqbMv9hlgoy+B6fvAqXCTrI4CsfONMAgBm5WB2XASqP/1zxUNNyPf7AIwvu3+DRmuaOUBQpdRcb74MFzJU; 4:dcZX3kKWWpROEHvMaEaGg/ZMMGYpzVPnUIIVluBWoC6q8Vy6h5J8abCMyIuSVwImqclgBFuGfFF/oU5DWOabWo8F89igWrmYhqB0ztLLqxyzZq1jsH3Ag8j+j0dMeHqaElsEs26T2xtqtg09cKnxgfSfoDZFPDs7RJwPt5io/ZwIktVHSi4ug36DHuktIN3Ae8PBhXFWjfaGA8UYWlxNU5jALR24IbFX0AcODdTmlrdU0wYNUNsBc5RzUbmwBgHmcbJ0WeYXX25iix/SHpWVAwI/uCi9LhQ0I0bnlqZQDVmVu3sqaz37fiDgQjiujjZWo/oUahYO0dtmKUmUa6rKrh4jdOBFEkIvAFeLZggY994= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:lfgqi72czGRPcICE3Tv68Db2C4kyodzZtl/w2Oxff?= =?us-ascii?Q?copvABHMqUmgylJOEuYdQoX/ruf3dexRN3A4IB8bnZM5qjz/iTC3imtnR1DF?= =?us-ascii?Q?gjeCt4/NHixsA8PhvU3uIWHnx19UCKVDjAUksnITcoOP3nuet9L0w/+xEHQy?= =?us-ascii?Q?yJLbnDCIGPw7J2WkZG96GImODnpAevTKUADqktoYr3HgioD6gNX4JK1ifKOI?= =?us-ascii?Q?N+lkdaFIOWo29Uy0L5Mt7sqaj83k0ZTovPX/UZuAH+DOQbOXL3x5QVFcG4a6?= =?us-ascii?Q?JEHPBhQe8z3w/RQxvopT2RVX0NxeDILzxAmJBYKorsm2aS3Krk+Jbzhfg1pc?= =?us-ascii?Q?c2SfgVnvpHZ6sY00yjdKiFzv446uykqeqdAO7q4y2Ag9XQjTx6TzxUg2nlNb?= =?us-ascii?Q?C+n+HuzbKT8JfY7yW+O0RiSdhnVQGyr15Uk0Uyo1nHI++PDUOTITGrUdMOrR?= =?us-ascii?Q?pkhKGdz65/Qcn7+G70jIk8xdXfWG1bVKuKnJqfumcSNjLAxWbYp5b3idVCaE?= =?us-ascii?Q?m+KGCDPPuH799PCT4uN2VQvxGuQSSTP5lKmKL5CPDfeLJFIAPdFdLw2kFamk?= =?us-ascii?Q?7Mt/qBm1r755kMIJ7kWX0ykR3Mxbu+xsH76KLE4hQxAJ7notQwnKH+XszIa1?= =?us-ascii?Q?lWOGCrjj/u9Gtc/SI6/g6NhEl1zsXH2/X851kZfXW5oEvN4cgCC6dD18SiX5?= =?us-ascii?Q?eFlMNBXE5UU0/w2bTkF6yrtB2SkoviaE9CH9XaHDclwz5jtT2QUPF3Y90BDW?= =?us-ascii?Q?/Vi2Vzw+LQ83iZhq6Xa+xNqRfqRLJyN4UkDCLSO1iixvC3Uq4l2Kfo47O7R/?= =?us-ascii?Q?hXFaoGL39mVdexBd3oN1ptXQjlTYJ15Y1MNAbEfMQQObj+hu/gJ3luhiinKG?= =?us-ascii?Q?S3SgUUoIxo9hGph07rsr9BnAOF3tPE9FMzH5gRbHS36pqiMX5igxMoKUu7Rs?= =?us-ascii?Q?LshSpUTTudRA1CUJRfTWqDCVylyalkCOuWV1cmTt91t42vAQL7n9T1ayxrgt?= =?us-ascii?Q?YdiX82oc4cRwHN3P0j3d3gc2ETJpR48r0iAbvrDfAwFCKak9RWQTNjI074fb?= =?us-ascii?Q?FRrbjeXWBhF+wd1oWwbpD1WRheWMGrrcmgl+D0/2tvVqohTo0duG1EN1os6w?= =?us-ascii?Q?zFMGLwUFbv6ZTPjoueSvYVdxiM4XysMdYcv+dVIcygcaVDdnkkRYujv+whgZ?= =?us-ascii?Q?K1jJKw/brlH5zToVcQQ3msUsbGEOqgWNZY3F4WaJo7A5Ms0jUcMUNv80acov?= =?us-ascii?Q?lDbXt75Xk9RuteHVOc=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:bwJTshTcFLyTCajBgUbjbpfDYmMfjOC64A/T7dYDl6pdla9oVVCDX08Hk2LIkfq9mYWUyAZGUvPNw5OV8zhbIxaiSOMTUDkvrZS15PUaGjMz3jkHiUCR5uU1+A/3mXnFt0/ib1k+SoZ0m62fPXmOCfIUlwkt4V2vgLvPvgORHVM838uAqZXIRjbcjTtEN0TsRCQgoKy5Ne0PwYu5E16fizuey3wTAwMmfh1vu9+SluWUtIvjO0gn0vFLpcPLC/oovFuAMigxjm4+ChA5WGo5tP6ciCSPdQzfR/IO2eNmh/GB+QCDNV2mpX7s16J+tlaZbjltZreE+wz8Mo+qpJFVTEFlWzjdY2kH57b1MWcWfjk=; 5:OdAe2yI6WzMLCnGB7RApgMLLQFXAEhCRZtjvA6/lGGzYS4zzGSQz5BzeulrUJ7duOdBxMX+X7EdD2JRJkgIyn1C4siYhU4AfcFxOZQXjK03PJZ8RtV/qky4CVhTfpuMI6DRxVvswDdnWbMQAU2HDR+v04fOAa9IxuIL1SB+QLxU=; 24:vxmaL5OY3EZ02f+LAZoMW+ZUOvw/r1YeegvvYvIKgLPpuseQ0Vq23rqZPirEfckdIMg8XRlfQ7L0VilxPJo7UNLQpK8v5+ljRT0dmVhTYy0=; 7:YLPhQ1xs9CEDko82bMOe1JUMPRNc9KhktxI7ESLXH2vf3yOFaIAINxkrlU1sPqm2vrx9zNsn4ENxranwn7UQ7IecNgX20moDG44AcjcIQxmte35SeoSrHo0HuEZomnqdVKeZw8dOTPgcdediJ+DnCA2mXXeDOwNNRCMILVqhycijpygqNSqNmyljtImgTstIU9t8BFmI9cVAUGGVAjZZg0r3bDPIC9ikfLq8hPSD7OYfbs89xVp3r15rdNsJSlUn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:05.3364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c32ca98-e645-45a3-c906-08d57d3c5744 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.115 Subject: [Qemu-devel] [PATCH 1/8] Fixing WHPX casing to match SDK X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixes an issue where the SDK that was releases had a different casing for t= he *.h and *.lib files causing a build break if linked directly from Windows K= its. Signed-off-by: Justin Terry (VM) --- configure | 10 +++++----- target/i386/whpx-all.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 39f3a43001..220b9ce52b 100755 --- a/configure +++ b/configure @@ -2475,20 +2475,20 @@ fi if test "$whpx" !=3D "no" ; then cat > $TMPC << EOF #include -#include -#include +#include +#include int main(void) { WHV_CAPABILITY whpx_cap; WHvGetCapability(WHvCapabilityCodeFeatures, &whpx_cap, sizeof(whpx_cap= )); return 0; } EOF - if compile_prog "" "-lwinhvplatform -lwinhvemulation" ; then - libs_softmmu=3D"$libs_softmmu -lwinhvplatform -lwinhvemulation" + if compile_prog "" "-lWinHvPlatform -lWinHvEmulation" ; then + libs_softmmu=3D"$libs_softmmu -lWinHvPlatform -lWinHvEmulation" whpx=3D"yes" else if test "$whpx" =3D "yes"; then - feature_not_found "winhvplatform" "winhvemulation is not insta= lled" + feature_not_found "WinHvPlatform" "WinHvEmulation is not insta= lled" fi whpx=3D"no" fi diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 0015b27509..eeee43e187 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -26,8 +26,8 @@ #include "qapi/error.h" #include "migration/blocker.h" =20 -#include -#include +#include +#include =20 struct whpx_state { uint64_t mem_quota; --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519669135366980.7599720277221; Mon, 26 Feb 2018 10:18:55 -0800 (PST) Received: from localhost ([::1]:60477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMPh-0001lS-Qd for importer@patchew.org; Mon, 26 Feb 2018 12:18:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLr-0007IO-Qz for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLo-0004dK-Bx for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:11 -0500 Received: from mail-sn1nam02on0115.outbound.protection.outlook.com ([104.47.36.115]:20112 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLo-0004c7-54 for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:08 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3Hat/5eEXr+s6Yr/JEl7m2EFaLLFQ1YCT+4JfWT/AA0=; b=CZdHcP6VVjawj03fDHFmfvqCvnP/MatSTpxTNGGNS+vUPJvWZ7c33NJi/pyZXrWI4ic8olJtbfe/++21qclIvGOjpbI9O97tt5gVr7Mh4BVn3eEatA5pFBoqb16ZEoUBIYy4dvofKQTMLZfiG2BH8pg5Z/BVrv7Tluyg/TL6OhM= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:30 -0800 Message-Id: <1519665216-1078-3-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d288e803-303b-4b3c-e05d-08d57d3c57c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:gjspjOkBEIxg48M6XS3IzomG3zVt85+uDnGzwO+wyoBfbXu0hyfV/3/fnK5L3DAwT10tQXYj5NXN6gs6+6/HJRD2U+7soGhGCyz2/9d5IDmBe9D3kphIj/lsJfo7VGpTJ7UJV4kzqnHF8HmmRpctabJuA/+nUsjbtFU2hgfEMqMC9nMqEEUXBVxfFuIGEH4PyXvdo2xkFjpOhIdsbEmDRoMe8WOzVbdnQ9ZrNwZFdVSmjAQZpecaINsTuFNL4a55; 25:vfxG/3CFYTcnpP2c4JNQ9G9BkEOdDO/+yv1lVxqNPPcrC85hPYxHkAqHQUGBtAmamwU9c+5vY2S2ZwKwVdyN5Sre/ZLqQfwYU0gMsCINpydf7ztX3CRn+dcdA94XNBILNZc8xfwQrf8ZpFbiLfTfmeFmAJsrWBeE29iezDJCTAsVoZ4qiU+bvQB9mCcei+Wg5av788AToi+XRwCz0SZwB8wEoXruBDebAinrxF6W5wx58zCms9iUah+c0xFqvjIhaIH0k6c6nbxBHqz9rGFB/j4rxTURu+xfCI72eQAGi0VZqaU3DVcb/wiQJL6ExAU/7ZJ0pAcRTuno6X3cwjUeyg==; 31:3tqCFyXZZMgf8aB5VkFvluAomOwEnoO5ieRkqVIkQsoVg6qN9m3jrmcBUaf/RWQ0M/FSPDklOsIopuB+pfBfV9UQmWLEJ232MlKMDXdBRvLqTdmUB9eEQr8diw7TzrRqxYMr8Cq/2YrHaUObwV2nnTN3yf/AvWZECNQyjVBjHwjNNR+jHUKs9QFrT6xUiJVLp9cZlMP+3CrY+9PBeW2GK6uWz1+psrZnupzGkebblsg= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:q2QzX3EH9FlfsrfWD+gJ6vnX0HjVqeQKw5O9vxmiv8OedbCdXIeRkRzi9jyy9O+mtFb9f9TiOwXuqEo9aSq+S7zNvkLSy2TWTAZ3Uo+o2C1tdIDhQwbVtOi3gpKgkOMV3TrC+PV9KAfe/NNNJuD9IEMpTZSIl1f31wvqYWfxGJkLVSdS4CpSJx7hnOtoEQevUvGbYUb3bEOeJW1giuJwhHgeOO/ZAX1umj80MPULzwea2ZdAUlLT24cKm6I+WV/J279YZBwyylVxxVqFlcDngTK15ZMfChIX0uJxgnmlwlD9l+ED4IrTZBPkaV0b4y8lBT5WSkL5HdDtYZ0A8+B1GQdgWQQWdl/4aQFfNLIYeIOSng+R8JZ7nz0XtaBC1rieXGdeo4Qhr898d8SZjlDwSY40xxjLDOnoN62E+bZNu8fReXNjSf1iRc+pS1jqAViiusfhQ0NhNXiri4g4qEomdCzwumYH4vhwjjGXwEttvPdFaTtjlZpD0eK0wR/3NjkM; 4:MBKa92OHpPBBqXOKnGQT91niO2kKqM4UFioluEhAWDiELbWb+cDlb907e0OMbx7OrrFBsf2kI0JxKsLks/Q4oJqr7PrbVGHKrJqLhl7pTtwaq4qGEZ90jt7Dj7HUQQB7rwI6wDSwXnba3DQYdJ0SN9y9t3jGYB/IDJzIWp4VIHb/G0nL879EBHzRxUFp+aQX0LkAE78hhlXykU2ShFLODOaeAmtw8ngfuu7mzUMlhKnknB8A1wCrb5Lzz52hhz+k2/3auMdZy+N8KvfIqwJnq7HFxIjZ9nXevswE7U0fZtTxx8p6Zr71yQcFFLQa96BOeqwtwlYvXQ8vMjTBPJqQmDHCW2NYCX937KEWCXDGTdA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:fQ4sreisQcuYH5LL4wgQqrv5ZvfSaMa5wazQ9VSX5?= =?us-ascii?Q?QhT3R1ZncxHAib753C/ZMFKnjPy4GpS3Z8uBTJgtexUEiLhRelWMmSXow8HT?= =?us-ascii?Q?xo5mAVoQwN+877JEWsAyJMsGpDog5PaopAfuq90vQzZ8m2hfZoOpXF5bSkZ0?= =?us-ascii?Q?2Kkyhys/9zT6ftg/k8TbY3v2icvy+irLLE5NoCIdL/6g4LCmWYoD4U+KBXND?= =?us-ascii?Q?EwemWxxRAYqcvLXeMxfa2+ryTqKImw7WbnzLjsVPRPVaPxJUayWHRZ3uiycF?= =?us-ascii?Q?Tp22wZ3e8OMYAJNvqLNZ7W4Z0as91pMNfIVip2V/sJQfxGAGoKlGouzU6he9?= =?us-ascii?Q?i/hZt68ctRyNN9vrzsGl2CZVJ9tWCREHTyhY4Zym7b7+V758Ru/xZw4cHcet?= =?us-ascii?Q?P/vsLYazj4y3JPrqb9hLL4WpfrUVoJX3LgHllyu0K0U1DeUjgwJdn+x4q3kv?= =?us-ascii?Q?qHWQeIJ0hp04tZ3mUKYlxfXkAQEtrrD7QISe2Zd1osstQgPCD9O1FHKCeZ4P?= =?us-ascii?Q?zosgaq/5c6DfHWQyUXjZwmacRowzhEf/2liQAtS3atUeMJovGKcG88wDrGV4?= =?us-ascii?Q?wJchc1bHAmESGq76vH3idnS6tfA7SI4blWKiSELSeTSRIoeFX9X67Be6NK8Y?= =?us-ascii?Q?D0zCoaQ6gU2Hb+8wPgjEdDATUD38daFCAlRbBJjALQ16K0AW+n6DmlzyNnOM?= =?us-ascii?Q?9jxza2XxZlMieoG01yQLbDAqzfC05CCv/8Vti0qkwaGqu9QuKsOwOR4Zz8Sr?= =?us-ascii?Q?Sgd6w/5CkiUvx8QTVJ5ZBiZfBQIkXqCtXs1IqWIJ+JhrwpfKrMzj5cQd2V0A?= =?us-ascii?Q?y1ydMQFJGp7waJWXxKZxe0yTALHRzVuSVr0O2O5lDtnCxgxDVomnT1mmoPbn?= =?us-ascii?Q?tz+pty9oL/hvpX6XuunzIEqN3VfbwtB//N67PefXW0tOmG9sgJ5er8fO+ciP?= =?us-ascii?Q?Lg9k/xo6pBkch/2GBC0ryPqydmcQDYxCr/SUcxxu3HCxJmfhdJLcsJ9TsFOE?= =?us-ascii?Q?gUp9li/7suqfMTFOPjG5lXYG1IXo1Z/Gk+oSWMhqXmNWlhYqmIZCc/C0vs4q?= =?us-ascii?Q?tI/PcY0dAXSiZLEpmpoZN8kcoxVbPW5mmqjI/3BRee6NZ7JmEzRyaJhVjvmH?= =?us-ascii?Q?2DAEVclidv8iEWscmTKGwvPVe08U+HPIMWQX20du34bOzTJYOfo2cnkIXIVb?= =?us-ascii?Q?ouHxe3kre7SHQn2ncsdbBVB46Q/FaOpnFVpy7U7viKx4Eu7hi04Tjibas/la?= =?us-ascii?Q?xgImGsabujPl8tkjz0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:i6ZZnFDuPfiSIOKmZEjKCo3udvKeIjjHYvbaeFqfvb2dKcZEQLtqo76jQfZkAGF0gZz9Z4n/NJZn8Asp5tuCdCc0uPrQ3SaloHHpm1k3Zs47yFCxYtmKXRganaj3wWa4WNBGu4TkXgxFcFayW+WiurlQm1FGZMMB0FyLdOlKEh8ZOWy9giTk2bBH2jFqCDze9BN3h4cYOAMMju0vn18msq17gBfh5A5aOZY0x16Ddq/081dWn/gCpxstNK6lq/KKr1cFkOcT5m2N1vzTwTODZmti2TrfZaCjogj2nf7xlNMI3xZ/EufWXC0eZ4bOWBbVyFkymwaCjsAYAhHLDcvh8NRdz10KfRT0Nr9j0bB5BMc=; 5:zFBXJxcbzGanr381fhh//z7zm8BvP4DobxQZsd7Ke787NZwvU9ys/5EOyCgzV4zpVaI8LpWfVLFGvf9SHV4fx0nY/AXCYtvFZJG9nLDx2hE9FqNJneFHWeZsSa9brfKjeN6s9Z2oxWghheWuEME5AViW9i67sW/BJ7bxCsT9zhY=; 24:ZeYsbkrnw0ZU9iVyw3trvYrQC1kx9BRiwb5HliSuL+FAmtlWmNbRbyF5IA4ukZt/6W1xNxxN+IX4yjE+gMnYmqsF/JtoxA2GAy31nOwmNdo=; 7:8rnSyGbAbgf8jPSKy0qDc+n2vjJBDWGYxBAbh7vNWQVlHc5M6VnGQ4sxC3kMWMQUV7PmPj6F2wQHkJV0cU45fG9yfKt0KLhjiUXPyDin5BLjebNjGmAgItap2RvVfeQp+Q6F1YleVp3VAQNWWqo8e4f5x5hKRSYvjPFvVdxVy24POTlpnerB0x+z+vUIelfbV3MrQEbIwGkFxPmp+jRQtVy7pY9ht08FJgDhRVv2i8yTXdnlOU88NllUl2fwIAgf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:06.2041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d288e803-303b-4b3c-e05d-08d57d3c57c8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.115 Subject: [Qemu-devel] [PATCH 2/8] Resolves WHPX breaking changes in SDK 17095 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 1. Fixes the changes required to the WHvTryMmioEmulation, WHvTryIoEmulation= , and WHvEmulatorCreateEmulator based on the new VpContext forwarding. 2. Removes the WHvRunVpExitReasonAlerted case. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index eeee43e187..969c2f5f93 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -613,6 +613,7 @@ static HRESULT CALLBACK whpx_emu_translate_callback( } =20 static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks =3D { + .Size =3D sizeof(WHV_EMULATOR_CALLBACKS), .WHvEmulatorIoPortCallback =3D whpx_emu_ioport_callback, .WHvEmulatorMemoryCallback =3D whpx_emu_memio_callback, .WHvEmulatorGetVirtualProcessorRegisters =3D whpx_emu_getreg_callback, @@ -626,7 +627,9 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_A= CCESS_CONTEXT *ctx) struct whpx_vcpu *vcpu =3D get_whpx_vcpu(cpu); WHV_EMULATOR_STATUS emu_status; =20 - hr =3D WHvEmulatorTryMmioEmulation(vcpu->emulator, cpu, ctx, &emu_stat= us); + hr =3D WHvEmulatorTryMmioEmulation(vcpu->emulator, cpu, + &vcpu->exit_ctx.VpContext, ctx, + &emu_status); if (FAILED(hr)) { __debugbreak(); error_report("WHPX: Failed to parse MMIO access, hr=3D%08lx", hr); @@ -649,7 +652,9 @@ static int whpx_handle_portio(CPUState *cpu, struct whpx_vcpu *vcpu =3D get_whpx_vcpu(cpu); WHV_EMULATOR_STATUS emu_status; =20 - hr =3D WHvEmulatorTryIoEmulation(vcpu->emulator, cpu, ctx, &emu_status= ); + hr =3D WHvEmulatorTryIoEmulation(vcpu->emulator, cpu, + &vcpu->exit_ctx.VpContext, ctx, + &emu_status); if (FAILED(hr)) { __debugbreak(); error_report("WHPX: Failed to parse PortIO access, hr=3D%08lx", hr= ); @@ -905,18 +910,8 @@ static int whpx_vcpu_run(CPUState *cpu) whpx_vcpu_kick(cpu); } =20 - for (;;) { - hr =3D WHvRunVirtualProcessor(whpx->partition, cpu->cpu_index, - &vcpu->exit_ctx, whpx->exit_ctx_si= ze); - - if (SUCCEEDED(hr) && (vcpu->exit_ctx.ExitReason =3D=3D - WHvRunVpExitReasonAlerted)) { - WHvCancelRunVirtualProcessor(whpx->partition, cpu->cpu_ind= ex, - 0); - } else { - break; - } - } + hr =3D WHvRunVirtualProcessor(whpx->partition, cpu->cpu_index, + &vcpu->exit_ctx, whpx->exit_ctx_size); =20 if (FAILED(hr)) { error_report("WHPX: Failed to exec a virtual processor," @@ -956,7 +951,6 @@ static int whpx_vcpu_run(CPUState *cpu) case WHvRunVpExitReasonX64MsrAccess: case WHvRunVpExitReasonX64Cpuid: case WHvRunVpExitReasonException: - case WHvRunVpExitReasonAlerted: default: error_report("WHPX: Unexpected VP exit code %d", vcpu->exit_ctx.ExitReason); @@ -1068,7 +1062,7 @@ int whpx_init_vcpu(CPUState *cpu) return -ENOMEM; } =20 - hr =3D WHvEmulatorCreateEmulator(whpx_emu_callbacks, &vcpu->emulator); + hr =3D WHvEmulatorCreateEmulator(&whpx_emu_callbacks, &vcpu->emulator); if (FAILED(hr)) { error_report("WHPX: Failed to setup instruction completion support= ," " hr=3D%08lx", hr); --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519673600502229.42220470843085; Mon, 26 Feb 2018 11:33:20 -0800 (PST) Received: from localhost ([::1]:60483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMRY-0003AY-L9 for importer@patchew.org; Mon, 26 Feb 2018 12:20:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLt-0007JU-IM for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLp-0004e8-Dv for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:13 -0500 Received: from mail-sn1nam02on0132.outbound.protection.outlook.com ([104.47.36.132]:37730 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLp-0004dW-6J for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:09 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=33eXzQTGVm3PuEDP//xdzul1groXbdvW/sDwN9hm9aE=; b=M5CrMYrDz3gcAchowIPgvHMpbuyNB3uYKwtkkTe3cFZTz1aJusjAIdGgOOFQFBDVmAyGZbMoLZ/b7n12y1jHd89k8IpSGMAbuDFNfuE9GrYUvZBGeoDVGlzhiv7+QRuOctoEN2MgTRcHufO1ITzEO9N0zoK21+g6YDGSQ5+hkc4= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:31 -0800 Message-Id: <1519665216-1078-4-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e72e97b5-15ac-4a3d-c691-08d57d3c5847 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:JJbPiQ/l3Mv7lal3d8j61wUg7tcxpEigA1VE65KD2UJDkD3HCEmpDy+OV7FnN9xwJ2RmKV6lazYXWLy71NUyBN/wcAHCvHkUY9MivuOhOPI1UUdwmuUvJsavCOeYur26559B/Rz8lX4ep0nx4w61A9QisVid1Mu6Yvb8/gBGz7gGi5O7V6R6eROTXIlyIQK9OL9GVMA0Gsmgut0moM1R9Cjm65sLTy6nZLB3KlfWceLLXD0ifIVtqaAqWNPqWfEx; 25:Zfa0AxHkhefHMeMukkbnbokyAQchzNqlDohBmsby1Wn87xDCK0t7fSuUkaRLesA3WRMFmsEP0dlIJonYmRj0b+2lfLiWSdp2jE6c9kapWWcPS+8nUZX6yUmHqpa78OzYCTYC+QqSVjlgzcjozsyUqpWzZelxmUODB27PPPdQ5FRQlNP822ddSAI4SDaInelO1AfiqwnSfQTPk9w02S5+wjBdkPxXG9Bnp0q0dGFDYgaWGor0CK+5E9MQIqDyHubrSdHt14nC4zPhXuLFDxStsKqmC3N2vjRBLzE1Cd6QnmQcaX7cfsNhYUHxYphCTe7fa7UrrPk3woxph3ix6Mu2Qw==; 31:V8FExPsa9yiVlrOphx1PmJdCIVsDvEGOewjV0d1sNjnhsxqECDPZTNl80/nIeuzWv62+MD7RuL+rGa/ILfUXrSbHL1lpVWOMfPZopho0yifKUYtML9//E4rjJkTuDLslxfjRWzEccfz7HZYUpo61SRQwaCCQsYMlgbnZwH4TJAb3hZolzTi3ICfeIy7PkTqZwICBZ6xMDacKB69+lgz53VWb9EcvxiQmFif2tSD5yBA= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:mmcZ1yuc2MDb0hCp+dTpUWfs3bQ5K3Zs/ae0H68rhEYRgl06zb3MAgJPH+R6oo3QyFeLfUTpM59DK2gEGXSlbuEfGLD6+R6HyeyOwttRMW7h0htqIpMPNRCI3+2ABI7ZqzOi+7Uk7A9IlAy+aoPTo83i16ZCf69i6zaR3fOtfl1eFKReN9dLxi8C9kLvWMM8Dl36wqA/KC1CkMozL/3EkQq6sAizBh/H5Yka/L0yMwq5V/8BH7v9ecHa1537PxBQlz8oJEhdpuWcieouLLYKk/o4L2Db/zNr6hKm1bOjuMa27HDMzanN1WGomaxaVIl2vz9fwkuJQI1ziJ0ngKA+mpSKLdwGPGPAIUJsCZM1Y3f8aZgkFpEMKTZOnb3KOpXahI8z1yGdIUld4iYMPMXgLogcjlnBCXVws4QatTqbG8anfx1xj8WXVD8Cg4aJKmuFEOWSndmem5vhwobBU5KVEV40Mdjgr2dV0NsRy5XBD16kFRSptnbcouXIFAQS0sSu; 4:y2kkgB17dyI6E07e3vm0CDbA1GfciNlFRH7cESgwBvx5RzEP2+zEnfbouvMvInANFw6hgGH5/DHC7XP8Pstyw/5UoBwmnWWJIx5Q4lol1k8qVv6dgHi2v3+pjh3lGqqRwRrjlMszlLTvcN7lSpk/0MQ26U0Sqj74yo/SBNDFQTCZVpSLbgR9SsCKcoXh4XdEm6RhEkElxOQpembVK6jFsM40G6nssZdMiZSs1mUoFM0Am6bgwpH3eePwPMpQG1Bi+Z7A4EJi2TG5EyBJRYSULdQxZg8UnM/ojFtqKF1c1H2YSErwG+pDZIYq+E2LcDd9a1AHSXvCRFCTK5XbeyPemug4cwOXsSRgmsn7WfXWyeQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(979002)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:FzHE5jGhzsB6R4vTcDbZ/3uxuOXMOeTUNYu16DFIU?= =?us-ascii?Q?ta5B1Tz9a/h52DiV67TPjkA174xuDa+L0XJLOZ+Ua60hevqYpjPRDc8OtFoL?= =?us-ascii?Q?rXY/4OXAczD2+fvTfwq+aKj8v+xiQHXhvDn4Jd0eLjkYhqQT02bQ9Vcpe5Hw?= =?us-ascii?Q?OV+GqvjvqMBRmORSacRDJUCeERmG4/3mYKrdNUnPh4VK0SBXKpKmpwrEwqCq?= =?us-ascii?Q?RTr8CXEBSsQKGpywSx3DSNEtSLBz9++7fTpJ8zS1D7QgYUPLbPAmSJnLNtVT?= =?us-ascii?Q?/YjnK5AUZIrjUgQw+0GCeEUVqpdUrniFT8VGXesnshY3VZx39ml8BO5r7IYo?= =?us-ascii?Q?MZzxCSehVG2yjC05RcDtuWR8o0D3ieI74YdSSNhM5qRCbYxQK/AgbvbsPJSb?= =?us-ascii?Q?lDsWACXlAOAffxaCxnMUU8dPpo9ArX9q/38ACgSYsoXqbHlfNxjOLf4RiZPj?= =?us-ascii?Q?7bvI4u+6Yv6iPuxNWVdPjtBeSqAo1wNlGNS8ps6DkMMLjqCNrfkNEE15Qsz/?= =?us-ascii?Q?piADjJGqyaB95mxftD0M8DXEiG7AJm94r9dDrlVkWQCWM5AUYWJ8TmozzCny?= =?us-ascii?Q?OjDbFIA2IXYUMfOoF5VCAXe5StMY0uZkWL3eB/WBqEipWN/j4e1FZlQ9xw9a?= =?us-ascii?Q?0+S+mzuUMcDlcEG/bUCZT9pjK7Z9Od+rDlFlzPPO3w7bxOj7MyiRmeOdZjvF?= =?us-ascii?Q?UgXC3NNQXhkapbzYwU/8ef7I2ir9nQCPD9j169A5fkbSmvhy+sL8ZU1Ert59?= =?us-ascii?Q?jF+vPEM9qj//tWdu4EYQZOh+BfLQ8b5BJDUnga7GrMyIlvYRSaJqcdLXkbsU?= =?us-ascii?Q?lCAz0iGLHTI0ysE6uZd/02EaoVO/3GXbdPdFAJqSEHqnkoGITePNI6NGBjnN?= =?us-ascii?Q?iTIkLChrLvfP37awnubOWiROFmrqa/12duwKxk+JfsdZzSJlIKPC6r5CNNIw?= =?us-ascii?Q?ld9bXuyhRl6A5cMUgga2t8XqyGQohg2iLzvrkXv4zfn8T5NlhnUY1GbX7BdO?= =?us-ascii?Q?hEfuwW7HFTdi5lRAGfNRmlF51zbWZKhlJAL1/jooCGs49FMi1jT7esDoHSK0?= =?us-ascii?Q?5fUIpeAoT1hXSAG7kNqPet+n5pA+Cz/x/1TNLw6OQbvmn8NTj8eejb5G798n?= =?us-ascii?Q?zgb0Q6/kQ3BwEmC6Qvczk85nskyQQflnkqPSeenvRwzhKsICnZ9myFRS5r/Z?= =?us-ascii?Q?CG6yDCSO4RQ5bcqCsdYaxrA8Wr1eDwhHajhOYRY/tLJPGTpUl4ym4M1INbRH?= =?us-ascii?Q?3zBFhwzx3tWCEtuOW2IXPVXL5iMa2eZXzEM+FYISjuhCxtQ1NOteR0OcUFU/?= =?us-ascii?Q?GJ+SUm3L0EwDxYLa31IyRsMkElNkfXExZ4JUS/CqJNzNN0CEmq5qSm8mN7dd?= =?us-ascii?Q?0zY0A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:hfd/a9glVvCowTVbBpOvsaPIOJjTlLDf2MZBIXkYAgGq93/Um0Sx8bSZfg1OCPW0qlPOGaWONsEa+iqb1u9AcIqRPoGFC7Pd9E92t10m2w9eFrK3am3nutWFVpoIhXc1y0BzUDLk8aW0/S3TYlK2gtJtVOwrsLXiSBw4nN6ltUa1n/GCatOwEBk4azBxnPxcZ7hwVPlv1LM8D3KRYcJMUtkgGWlJxDnpc3VVYXbrrdUFVH2wsG05pQPxG8ImwuBEfuSfIHuiH5TGIZgvGtNoaIrQIfiKU8tRLp5qKnTXAQomoZ5o2u+4cqsoCFPM3f/9K+v/cDhRNW82slGWAHv7Rp9o09SHgsNd61q8y/lJbKY=; 5:copzsU7qRhQUPup+Gx/N1cns0eiLJvu7jUx970WKjC78Me5+6Q9nv46BH6+KvKFalArY3jWOZa90A1YRwY6bXhE02shjsZ5L6wsfAEPBpSfIaaxpSTwkyoGTs1m+c/sZBf/8sMNPZpLaMFS9YUjxzlV6XUrwfqq9FQTv0cjXUkg=; 24:LumRk8+cygsx8vBaIKTTD9EWjvyYspehcT1RVW9k8m1MMT6dTyyIHu9/aqBVo7VvCZwxikZfb1ls806OoVnRUfSEW+GzJcBLcaIUfAfJ6CE=; 7:i1Vbpm1pWepb/R3ro1kgn849q8YMsAOObDOwUbesQneE6XnfhiMtohmxssDWxV0vGO4dOR2DaPWtokRDv8YG5vbDrwkY9qjuOgSKWMA2MjSYeCg403eTo+7PIw2PSFAHJNM3K7VSdCmbE2UjsO2+5H4LJcDnhmCXOUoXWCNAMH+FUU4g50+OiViUZC7V6DiW3nKBnl0jzSlJ+je4LhEvOH8SJi6SjKBgzalmANWn+SiTUBWGnQmvjn8WQlKT51eh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:07.0337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e72e97b5-15ac-4a3d-c691-08d57d3c5847 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.132 Subject: [Qemu-devel] [PATCH 3/8] Remove unnecessary WHPX __debugbreak(); X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Minor code cleanup. The calls to __debugbreak() are not required and should no longer be used to prevent unnecessary breaks. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 969c2f5f93..14ea732ec6 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -364,7 +364,6 @@ static void whpx_set_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor context, hr=3D= %08lx", hr); - __debugbreak(); } =20 return; @@ -391,7 +390,6 @@ static void whpx_get_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor context, hr=3D= %08lx", hr); - __debugbreak(); } =20 /* Indexes for first 16 registers match between HV and QEMU definition= s */ @@ -554,7 +552,6 @@ static HRESULT CALLBACK whpx_emu_getreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor registers," " hr=3D%08lx", hr); - __debugbreak(); } =20 return hr; @@ -576,7 +573,6 @@ static HRESULT CALLBACK whpx_emu_setreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor registers," " hr=3D%08lx", hr); - __debugbreak(); } =20 /* @@ -604,7 +600,6 @@ static HRESULT CALLBACK whpx_emu_translate_callback( Gva, TranslateFlags, &res, Gpa); if (FAILED(hr)) { error_report("WHPX: Failed to translate GVA, hr=3D%08lx", hr); - __debugbreak(); } else { *TranslationResult =3D res.ResultCode; } @@ -631,13 +626,11 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY= _ACCESS_CONTEXT *ctx) &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse MMIO access, hr=3D%08lx", hr); return -1; } =20 if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate MMIO access"); return -1; } @@ -656,13 +649,11 @@ static int whpx_handle_portio(CPUState *cpu, &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse PortIO access, hr=3D%08lx", hr= ); return -1; } =20 if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate PortMMIO access"); return -1; } @@ -716,7 +707,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (cpu->interrupt_request & CPU_INTERRUPT_SMI) { qemu_mutex_lock_iothread(); cpu->interrupt_request &=3D ~CPU_INTERRUPT_SMI; - __debugbreak(); qemu_mutex_unlock_iothread(); } } @@ -785,7 +775,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set interrupt state registers," " hr=3D%08lx", hr); - __debugbreak(); } } =20 @@ -812,7 +801,6 @@ static void whpx_vcpu_post_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get interrupt state regusters," " hr=3D%08lx", hr); - __debugbreak(); vcpu->interruptable =3D false; return; } --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151967549692643.79712076546218; Mon, 26 Feb 2018 12:04:56 -0800 (PST) Received: from localhost ([::1]:60484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMRf-0003Dn-D1 for importer@patchew.org; Mon, 26 Feb 2018 12:20:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLu-0007KA-Fs for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLq-0004eT-CQ for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:14 -0500 Received: from mail-sn1nam02on0130.outbound.protection.outlook.com ([104.47.36.130]:17056 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLq-0004eC-3k for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:10 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DsCgoygGgfK23OIa9+p4DAYItMpPzd8tQjgSYuhAKEE=; b=KU8W18Yn3DXfPRTlGSSoaTNiQNaWsDzSZBr6lP+56a8/oXQMyP07J52LXl04dUxxouIAkiKa0VaopXIIvn3Hv2ShY2yOn0mU8zYMVA+djXwM6BNIZS0loNac2nl6SMmqnDEmjZjFFmtkBTomryKaWzXKAr0BZksuBVs/MdjP1U4= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:32 -0800 Message-Id: <1519665216-1078-5-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 15d73a46-97df-4e66-4cee-08d57d3c58c5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:tYbct4Bp+trdanKtM/99r3+t/NaNHrP0Uh3XHEJnmpLP2Jrqu7jOVAvN8Et4d8//RCi5SvIpgiAGkJDBMHWcXs7UmhSHN7JUhsgqc7WKlmfo+fceIf3HRxkd1orlbTwhr9Qp/psW+TbiiFonPtsB8eLGRmBjVTKuIeFkgKJOcdnFb1Wjy9OvHGfZ6pxFVrHuntcUruEn8MmrXY3ni1j4NA7waeuRwE97Yc9JnBqZRcUQSUfJY9RVvIMHcLgF2LT+; 25:4ju7tJnOARMPs5fRcxjORd6l2xVB/fo34L1oJG0+Vh0kJLXdsI8Df2e0/2fBsikIQUXcezu0VdbeeHI/GuqHRURrgdeqvxLEiouu/Lag0n3zm64nhcZHEPHm1AKl86ntNkOs/RlkYQZEJpw5LIWffa3T+0S5Xz9MEhxurw674pNL9nJd8MbRXc/uLG9h4Lf2ciT40xslfnry3TvvYcUhSwmwpOR9fKK5is5v46JkPxJUzaxZ8dCyRhmzFUrs35SMUU4nkOD6jeUULcMjRbJgwsPwJeXkAyQ7ZQECbS8o0Usof3SvXjtF2Y0ZJ/Ox6/5GJ3O1i/Uza+mk6MBNb3ddmQ==; 31:RmjFAFUDojkoP4xgx/+5hVMHjuYZVm2fgdhzF27KCP/xmeMBAXreytCbg7JwQoV4KoY8+6MtLjFVSecEY/D9Q+LvAFygquvXS2/ZqkFeDz6szVaJj0tlynmfN9KqOUhG4GPUKvgWizR1gu1ZbvB7lePoDRAjhLU8vPp5kpcGhuiT3cugr7Ex0KCRETGYar7LSRyfRIq9+MNDFv8FV0Au1TVaBqzgtAbWjH+a+8sT6oo= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:EMxORV2gJXwJnvIjDIusF/t4dVyXHZmTAN8j3x5Z99WZbz6z0/s61VPrv6yXODOddOERPvMqbke4G3HdnthcbBO6XkyfUL0SVeUczDU95IndpAmfLvVFgXbCCBmK47VE5ngcWkGfE8Cjsxh0U17zGyjHu0akiraWlkUorcY28qNg9wbvG8l0KIsnOVsWU1jyOkWOkAjhrze7AtfMZCyvazOVZmxRiEBTm/TQ1eCtgDh4L25yb6NA3yyAuWK+XU2lrCl3NN3wK6OSNlmtbdaVKR6osYV14IPUEk6/WhrMffkEyQZKOvA9yEQXZ/C2H0rkl/D6t5P6ZWXvKNmlyqdDXsYyYNTd8z4LpZXWqHGrXUSN7trZ/aTfTNJ/ojOFrrkaYYuCQ5117/OcZub51Nk/2KodEwujoaDRHNyoVnUtaI9aUfjjTLV6j0wGylY4pZ1UmtLDLDxDCfp/BuV53JT+9pAb3fUp11oxamE30eQtxIYggDy4au4UeJZDsSHyWaV6; 4:uklKyXkNAfuy/kUwL+5ssCMPWfkm4zV9VrBoZvl2+Pf6mfW0dJhQ75zP1kQGe6qn+ViA/Pzt6YGGJeQ2W3zVE1zNu0V2Ne3kvfP7W+e0JX8B7KG7Ro4uiK+Cq7AiUKMvB6F3tye1+slVRUtSgtryyeG1+2WukHw+LIDYIhsziY6utWIWZO6Zj6Bs/f/YeVm+Zch/c0Bcrw4fXt2xOmwEHeh7dTY8L/ew4WvhrEXv29+6mX1eTmnr1ncIc5M5Y381nktwFg5xY29tOSLb71SLjRPG5GtV3ljqX40y39+Nfku27fVWMsJAimhRnschAt7LsG+NHzfyv3CmEtVzptz138CGX49iUqze/w493SyJJ+8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:aLA2mefr4Sqo4HcjvxEE+BPzXiPrRCGrC/+aDhtoq?= =?us-ascii?Q?iWD+qhH0bPU93ecUwPiy0ghAJG9S0zmIdySS8jVH9YfKWVwYOMLkHdFXUhpB?= =?us-ascii?Q?lbhbh6BoJ33nZEqg5bFN+nkpKIAzrn6eV4FQE0dTnZn8NrrPlcd6BDWSLED+?= =?us-ascii?Q?WmHBpRhKE+hvCJl3pV2MwlzX1D/LCT36QTHWQvLuLnMSka4NPVPuicmNOXEd?= =?us-ascii?Q?sCQxvgpUbdVVozYbN5b5Q6kBKH9WcntVkjo5frq0++tJrTGZACwxx41ENLME?= =?us-ascii?Q?hLr7ByH4w/Gkm+rt2atCymrj25GV8Zkyh1xp/InlNC5L8YBflb4ICyUs2tur?= =?us-ascii?Q?DN/yAfZkrIxF9ztJkTqEsYI5g0RJ4n5/HatDTzic7Swwd/omOpTeLDYAQI2w?= =?us-ascii?Q?gIsxzkJQlLyUqATDOvcBWynMpAKI//VVn8w4S7Ab1hxqHDD6XOj5juGqKeQb?= =?us-ascii?Q?SqxNDBOJM9Bn5xNVBq4x74zj6J+P/0bEhe2ZHFGUumT99MDfQMu5Mx/X8v/W?= =?us-ascii?Q?7HiQJ37DYIqTXQUSOksM2QjGwEujkFyHv42yyQnebJ19VAsz8tKHR7C3Pyo4?= =?us-ascii?Q?ZkElD4C0QadPS+qD4DEaxhz/eolXftprK7gSDAteG4te+0EoXn4OmMdLjX/H?= =?us-ascii?Q?N9PRLjEiZwxEm9IcMCPlQa1S8NwydNq2dGHiRIMfOsUTZEWgCIWmMh1LHUXv?= =?us-ascii?Q?4rLiDV5Oyu0/rBIoDHvd6crA4+7Ub82iZp5bUicud9emiECqCR0+ZSA0B46Z?= =?us-ascii?Q?mbdzoBadQUYSC2Le8Z2LZjNkEM9Rxuo9tLq7cPOln+ch3rngKN9/kgUNu12f?= =?us-ascii?Q?8praNtJBYa9bjLHtV6c8Egv9MlzMNSSGofBwgYaLdfcH03Psz0hehg8LfB0C?= =?us-ascii?Q?HPXkAK4zNNtGqWOgiFjrfZMwr+FKm3bpqf3MF5E3eyns3/ym6tGXaR4nFrIS?= =?us-ascii?Q?n8TdFRp8wITmDneZvRiqLQq8s66ho3ZRyzJV+g1ithz/NAfkMLVf+MsjwoX/?= =?us-ascii?Q?x0teKG7hNoGbD1wwmpnawZasLxmESnPV/+0/LrpPThBM7GxyBkVnFOVEmMvk?= =?us-ascii?Q?axK62pnXzoZ8yLB7H23FxCNPmOcIgAOEmD/46bI19zecOk9/vPOaf4hn7p/T?= =?us-ascii?Q?MU1qwjBQLpevMZEETsqy+elf19hlAFdvrEC+qhyL5mEy+SsmR2en1OT+9lzK?= =?us-ascii?Q?RJA1ruRFEn6dd/SKY6BJ5SFJwNtraopuqqJ71H0BNKEBQ8ivb7TJM8eETVH7?= =?us-ascii?Q?JkBhoDU9T2+8xwCqZ8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:XKke00nk8+5heNCgtEkLh05VgysBL0Gks+zsSYyzGROQNQMkV5cVyyxYAC6aLWx+3up8vUqUmx6MEhy5Ufa2hCfmzUOlw5LnT4+H85Npq6WzavKRFVHwpEtMa23JkgbrIt5oJgUyjqD4r0ZuA7V7v4TQTXPJvVl9eX9Bt2IagvwhHTjbCVv9SbINT7tZC2SdZBjLUUepQFunsxlyfILl+WHo1uR6zR45zgn9QJzagrH/ZSImvMFxOfsg9GLM9pgi6QDjsM9+32WQ/E4F8Pe98pt9oil5XSFGEUPXCRspuTyIBdN9QNjHf/a/5R13ea8XYym68HU7yC0M49QTNvZ5w9zA8jZeJeBVMI+wJZbkcmU=; 5:sP2/k6ZQTo6hL5E4t8Lbu+b8H3X7nUdo0dUBCg8sE+N1GDHUWaV7oEzw5Z7rhi81Efn2xHMDlP/ROQWwL8tYUwkv2cYHqCW1TtCCCnyXfZlZVKhXkF/jygeRlJGJ8ptd/6IRpRpYZQCapx+S/NeOtLoAfV0epVhNIwp5w9YiLP8=; 24:iPcGZ5HQlRNT4T9SmsdzXBBZaCkM8rf6FhArYxbTJZzZPfNuqckjuHA98GJ8q4IIhv//S+OjRipaaRPFmfZH0TfzqPCqRylrY4aJI5oSSYs=; 7:soYSwSTV9vi34YMIHYD32Fd5MTlwQMpf3IOYO9vG/Njh/weHQ35ZK8Xnes4gO9n92s4+KFs3MDln/X1/ooHv4+cv/VzqsN5scwu7YELWTIRV6XykS8lABTozo+sghqw17rexEgGPEhdUS8nAb0GpHQRnrPmE+rMySJahZr/eVqgG5C/OMJcCNVWC3hZavCTii8H+j/D1D+uA0SNaKyYCKjcu3tyB0ZUzq/OKpnmPsFxYoAmC2MOo/cvbV/gZ6SWY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:07.8574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15d73a46-97df-4e66-4cee-08d57d3c58c5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.130 Subject: [Qemu-devel] [PATCH 4/8] Fix WHPX additional lock acquisition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code already is holding the qemu_mutex for the IO thread. We do not need to additionally take the lock again in this case. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 14ea732ec6..74a8f4d599 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -705,9 +705,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) new_int.InterruptionVector =3D 2; } if (cpu->interrupt_request & CPU_INTERRUPT_SMI) { - qemu_mutex_lock_iothread(); cpu->interrupt_request &=3D ~CPU_INTERRUPT_SMI; - qemu_mutex_unlock_iothread(); } } =20 --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151967553006720.28635933592909; Mon, 26 Feb 2018 12:05:30 -0800 (PST) Received: from localhost ([::1]:60478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMPn-0001of-Is for importer@patchew.org; Mon, 26 Feb 2018 12:18:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLu-0007K9-FA for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLq-0004ed-LY for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:14 -0500 Received: from mail-sn1nam02on0130.outbound.protection.outlook.com ([104.47.36.130]:17056 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLq-0004eC-FW for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:10 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oFKtjGnFsSRQT1HexaXKQ93w4BFtx2tzawM8aklzYcc=; b=m9iuKYPhSncT1LHreR7JuUwNoKV1s+z7ympCiufYRptgKcIuMTxI10Tf8MFD8Q5G/5cegGn5X6TN5Y2rxG89dJ6LJEOMRM3afEu3Ovd9wrAIduht87KvRLsnS8g1uRKpu6Pv6O/AF8lgWDduey1r/Js5drcAQp1X1LxR/gseCSI= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:33 -0800 Message-Id: <1519665216-1078-6-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: caf5eb23-bf18-4ac9-2b90-08d57d3c5948 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:euvh9HH16YHZvCIkcwOTl61sEIIhX9LByhXqTY7026ZDIdhy9g77ykp6WBjnOrCgBstLzEcyMbHJKpgwPb8AtP3mo8aGSUEZx9bwB1mBDBq4VzwaOGgBFzbIWrelDv5/bR4+/3b59kmIwmDRIf52uNRCD9qG/5+/E3Q9xh0ukne9NM7nzYSLvcfFGSgGZU5jbJQFguVHjynFER5zdN1VCV7lum2WZNdfIjKwP4rwyw0guDNd6jIpapfOYb8y21Ym; 25:IyARn6wfJEIPDtF80TgHedMP98GGTQsxFxbSc6w6DB74vCagMagma2EiD9RXHU1RSdk3NWk9VYqyl69gP7nfgRM8LNjhBt0ylNzt++eFoMja1ddDEmU7BBeKL6IcpgkrDaB/ZA3nH29L749ByReTKsrkaDCFcpLQV1RyoqHOqqjUjlZGQ5u+uQHkA7CEhdwm/d2O9IcseZm9AmaIVwYbizPBiONrggqT/+07ffUqdOF1Cc+K6WvMmcuLQXlCuxKfmO5W9cgLcohXEEz6ipfOxUoz98j0GhnGJqaQXlEDWBOnGC76t4q+oxF5d0eYDksID+SPSAnuQevjw7kWlWf38g==; 31:0JAnsO30Y9xBYou5hwd0aqY0AmvZ1GLIVwIllKqNofdfvyordJc1T67tMnfsi0mkEoLCzrhqD65xquerZMeCFy5QCVDoY8XWdhUd5YjDe/aV1ssIUHjNoHQGmbON/vsMD+J+hP1acqvwaVEcvopFOEOPM1siZ8jb0lSJestmUMuhyyuBfMlJV4TNA+l+q+p7cN5FfX4JFgX7xIS9tPR44CbhSKBPy6DA1aYxacTMu2M= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:Nw0tq55M6hZQ4luw4T9CfxD85o9TC6e5XIfvutzV95hc+isJbkVvxwDVGfuch0YODWu62ys6qtriIrWK6QaSmVML7DnbD4lxqJCVeYUvurNiXsVaOvdTBh83zv4egeI8GJ4mgPfWQOsYqTxo5O2br79rroj1IWGyfmiOzeYLuD0QyXkgIXGtJZu/luo3FPL0xxJg1CK2MXNBTjtAoy2AZ3PViKjakf/Cnul/Bcm5/bQb4LZ0+OOqCteYWAy/Wbl2JCEyyQ+h4rweOWO2NH32dGxevETx96nGG/HMtbDlaapGAc+fr20LQ2WEHlBEYHGGJ6EnTkc1MIVrVXWs1SOQMA4trTZj5QARAQqO5YQHDNz1TB2XWb3d+5t7N4/swuibZ9Knj602GOOaA2CE45IW7eFiFFwgVItx0lvnpnQ1KRiXnMSgZhnCG42/YBMYPasv1XTeMZMM+j1zQo6pSO6VlqAeaAQMv5uRe29v7LQoQJRGtjIfY5TZC86vtdAn4ang; 4:/ixZjb+0HWEh9FqAKO4pbRIUc4TjOlMuAN9r7iV3qIHEe5QcEZokyQP1tuNnpfqfzSoEaxEmMD5isKjyMk3VsdW9DuR9h+zLwRXR3hak9POGecQUVW/0UqiamBei0XrSwd8jSZe5Ydhxy9ySrS1M/G1CE4scJAOYGXzcP9tZSl82KdtPxfeETaIFDpMlx5jqbUp3OOjKT6L9MczLJ5fAYZMqWosguETPmVaNk9+qYgsGxCNpW7aF6xQUuWi8eNqg3HgGuY/pI/dcRffxmwJ4c0XKGPVZ8u4LnKZzHIFWHmSHYsmOAix7v5MmXNEJBIxZiCd3hzG5uegRLbKux8V2h6mtm41uonIAdIw9yyP4ON4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:PKOHnvpUz/nMCdaNbWhmCaySmDGXsxLlMogOOPOKO?= =?us-ascii?Q?7kichoBGSbyJ36OD8CYxGMVikD3nsRyznB/jzbmyQW59E/Re5otViqsXav+y?= =?us-ascii?Q?HBieTHZeGC0l6cjVv/DooII9GblZvxVYDjcBvUHk/TgiEJSKXijF+HVnQEP9?= =?us-ascii?Q?KabE1ZxlDe/5oYG5ZwUXiP/w2nrtE17Ry3p+86vsSwdjh1rhZjPvnw/W2lyr?= =?us-ascii?Q?BvZnFYdy+vyR35YVfW9uJ0z1BnyY+oOUx0HrTWKHjKCAl3k2MoEiACyoFLsM?= =?us-ascii?Q?7ZJ7aHPrMXHw6yY1AlFkjgMmEeH0Mjg1fEqHhIZyKNf80XaAre52Xnqc+cDV?= =?us-ascii?Q?Cfonudmqlz+rKreCTgN5/u1bx6DdYrFXItBnpIywdzfZxDJ/dcWlgwjnqBG0?= =?us-ascii?Q?MAwTZl8WSm5/w4y9iYXeHVIfG3mkd4WY10/t1sNviLZ3XAAmDr/LnFmZ6O+P?= =?us-ascii?Q?DNg0kgvXH7TMWq+gs9JO1iq+eUucYiidNXFOtEgPR1Fe5/k8pu5Uqas90030?= =?us-ascii?Q?aSSYvzhVWhQPolGhPm6FTLRaoHrgIK6a+K5mzbDOR2wcgjO2gJXXxwK5VY0G?= =?us-ascii?Q?oiycdfvsNip2GpvVa1LwcSz4b7U5iA6vn+SWD9dUBaGzShKEjjW7G48rhYFG?= =?us-ascii?Q?qz7OdBboU8U12Sb5WXQFQFVpwoOuSJeyLubU1KJE1wZhH/oOHoIapaFqD+cA?= =?us-ascii?Q?TEUOqI/qmHXq91E54PfY17wcSpInWgPRkFqUkZWIkqiiuAU5KCTtEXCAZ4iI?= =?us-ascii?Q?PBvV1E7SrCxXFCbOMEgkGuNaJ4SRxc85RSxIvDvv/Zm3dsaK+Mp9l86O/a+k?= =?us-ascii?Q?vtRM/+YQuUpIciWgPXIG3zFSPYv1LkzVpvL97TXPWhWHV7CLk9wkxVFlaFwy?= =?us-ascii?Q?ZMLGwS9YT/Gfh9ZU/mXPstPPs9Ovt5IFDoqsuCf6XP1r+Ps1JpKz7QXuEEIW?= =?us-ascii?Q?GifkcZLhjNG9A6QHVb0XJPGOBGLyQPV0OPQl1r1X+4AnLZyzb0UZ6XumZ7NW?= =?us-ascii?Q?DtA8S4G4AMIcwvu2NvVxeg5rDgiun8wTPc9waea8RYC2gDewNMCNB0BO4ADq?= =?us-ascii?Q?16Ly9TJU+rTgxui9HhB0pzOlxAIgw3P1E6Y0m5z0ZuVOM2Swy10bWPafRuh1?= =?us-ascii?Q?OoRswXCtg3Mz1/sZnoyJdro83MOUnfT7X68E9wwqP3R6OVxNgVZwu/VhFs6P?= =?us-ascii?Q?AH27ssASexJdDLW6pfcFQJ8EHAqvWqdkA9eKq6J8XJlG2LfsWl2pc/xhFPhm?= =?us-ascii?Q?39COh9tb3Sn5urKXG0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:CEeK72MSUrGiK2Zyd/j9mBww3+qt/Vt46kYszrlV6dwfFV4Vd7rxPONTkEiG8KtBWN8qHAHXjn5QdjVKqVbFExEkg/G0T7I8x3VB4hYIn2bak8cIoXmn4uBFC0aJH3FiQ02dJj6lWErDX0FVs+OSVm4QI43OAyJxiKFJ7FbXMobhLno2g51fSRUsq0wCRG9w3pxvc5la0z23aeiTG9C6JnaXi87FLc0oudv33nsi2c3hKxX/EfXwJk+0z151seN+WOXpySOU2pmaxyS1lurZLO/Ce6ushBXzVm2dStdCTZ8fstIcgYi6yG1wzQerR7B+bco5zETzC7fcLUaiV++Tdbf8ATqzP6Mlo/oqidBY6wk=; 5:VSlvLlLDOMN5IvNR7g51JFw8bOnVc6Dcz5WqSoPGza9gYo5v5/kq2dCjgobcUV+y/LyB6lOhpKa3hSBhdfmKTxxg+8ANbw4U98UbH0NdteKHIxbrJzTx7ReM4Wb+iURTQ1x++gfSx1y6g7KEVM06UcGlghTH53RuCAY57/NFDR8=; 24:RyDdMSFIUSaydqibfnNlXQbyscs/Rb15snwrLAk382RjVLiQm57ghDbPENt8m+KqHQMwPTFn6ARdF1vzkug018TQQJuFKuaxdoFNFWR8E4M=; 7:UbjPJ/ib8ziTf4ivx0qVG2b0o+0d4EXTmWkrzHz9VO/zHuhnHTJccO8e47sxhw0gvj/Kl+JGn28Arzz3B3rlfy5RoK9j4q0DYpdAWUX578YUPOiYWiBHNy8ujP36VZkVg4B68YNB5b1aD1i+EtAX0Fj3kn/DF5QNLcf1w7+F+twWuBa1ZBMTu76guosd69nIK5zvRDZ24Vs9/r41tSlwDMnIxzPmKSIDAYy+hPXeoINT0IQ0mQNjwFNhXM7wp1P/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:08.7161 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: caf5eb23-bf18-4ac9-2b90-08d57d3c5948 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.130 Subject: [Qemu-devel] [PATCH 5/8] Fix WHPX typo in 'mmio' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Renames the usage of 'memio' to 'mmio' in the emulator callbacks. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 74a8f4d599..7e58d5f68c 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -527,7 +527,7 @@ static HRESULT CALLBACK whpx_emu_ioport_callback( return S_OK; } =20 -static HRESULT CALLBACK whpx_emu_memio_callback( +static HRESULT CALLBACK whpx_emu_mmio_callback( void *ctx, WHV_EMULATOR_MEMORY_ACCESS_INFO *ma) { @@ -610,7 +610,7 @@ static HRESULT CALLBACK whpx_emu_translate_callback( static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks =3D { .Size =3D sizeof(WHV_EMULATOR_CALLBACKS), .WHvEmulatorIoPortCallback =3D whpx_emu_ioport_callback, - .WHvEmulatorMemoryCallback =3D whpx_emu_memio_callback, + .WHvEmulatorMemoryCallback =3D whpx_emu_mmio_callback, .WHvEmulatorGetVirtualProcessorRegisters =3D whpx_emu_getreg_callback, .WHvEmulatorSetVirtualProcessorRegisters =3D whpx_emu_setreg_callback, .WHvEmulatorTranslateGvaPage =3D whpx_emu_translate_callback, --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519665733153783.7796460167261; Mon, 26 Feb 2018 09:22:13 -0800 (PST) Received: from localhost ([::1]:60497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMTY-0004Wo-F8 for importer@patchew.org; Mon, 26 Feb 2018 12:22:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLw-0007Lk-6t for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLs-0004fL-3L for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:16 -0500 Received: from mail-sn1nam02on0111.outbound.protection.outlook.com ([104.47.36.111]:45325 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLr-0004es-Rf for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:12 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cRWHX6nGZJP0Ab7+EeXzYymIXAT2PKvm+J1VOqrC8fY=; b=JdrcHCk704W7FlHW1sq/c0LCfJH5N8dIcyiuRZ+Joc/0dlpKke6FTSfYgb+GqlyAknkI5fvtOgqVLuybBpA7tvZAFehpockGIa/iZu0z1APjjWQm3+AhrtDdC+9E7FSFpRrO8hZSfikKVf/kKEeHbL8lWaqSlkdZ04gtE1izm7Y= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:34 -0800 Message-Id: <1519665216-1078-7-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 021576a2-274e-472b-6c7a-08d57d3c59d5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:6HD7e5BE5klpcuzdGJVB+mP2GHljIiM7tHZUS25ohLebAjy6Vrj15KTlS1GA+sLThAg9sne0iddawhF+bf4tzoMjJXy69UJUjXEdE8/v/ZCwBVbye8XZvNQgzY0s9K6IHXKwikNVaB4bulFycWE77cNSlzVTB/orGWm9vLaPIA8AR/JDhqZtBcgleO1T6mEoNzOtcnjhTY7Hh2e91KUtzKHrWJrFNetZWk16sYjl4MaFNI8JIYOsE/4t/yPwHl/l; 25:q2hoqCdfohd3cGSik9u6f7JlCH9whjQs2d7nBGrrY98L0wbh0+L1hC6Ebo+1aUZ89/7cdjzT/p3h+rlH3LBs0oAHv+Ex2tGxLWHsa/H1lMSXLOp4RGPb8tRWj7NZ7Je43R/Hq3wczGCysMvna+S8qbmOpHNyWDeS38AwCNSslPYAjzwMgcGL4+W+8/bc9y5DMC87azk6+zNzy4BS7nRTROuc+d5k+LPvnGlYbouo1girtrLKTwaGyfZJie5c3FcP2e8sFB07/07kHCrcoXcm9Lqt94H9MStHNxAfUzwRbt1BU1XWjbL4Y6D937TsFhixLFqMbmyvXMDAINUMKMNhaQ==; 31:bGYBt308nTPwL5uhKivPk1dpLowpUrWVGRG2bXubXXqa/4EcxAg0fXkphYYnbxoRb0kcZrU1wfqk4P8YgWn4+W9rUNc5bFTfVJVBzjqmcCINEBs2oFYaIup+AV7wnL5gBYy/9ByKzzLun4UnZDZtIn23NwZfhR/fNwLjPH2Hq1RBiW3loKRWpo6r3cjBcXymEpwMF3Rw4nGKakvkyX1Bgb/nHRLH1CJX8MRPkIMM6PQ= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:0bnUfWjPGJ52vp9/jkS3DMrOHBkkq3mBTEVomvNcS9NyTc9egMSd/mAU8XHtW1dskuNNzX1VrkjhMZAMaXl0AdzK4Ovye8fgme56YQuXHpdpfa41Sy6P8cmCS1T2sTk7YXMEGJdQrdFTI6B+kcG6624rnhJgKWsZ3GT1u8vF20542RcDbIkMPo8A6w7EqKxmiZxVoRjHxqtMeBMkmUVCN2ZyXkgd35Pa6jVH4A5Jvh29EfQ9tMAaniWobJ6X5VI7wwBsOugTUKNNhbOTLf7iYnpo98+YsuaBjcUL0tTeniKR7FdSnOqbGAVg6/d5OpmH83vRbdIftBzNcrULiRUmQN/CM50CAEjq67FvpQ7gt4Nsq/pd0+nRaDnFsLv7d95ErsWVWpWh6v0Zf1FindpLl/2gMrIzglx17uqHL5zkLfSRJT+jnZI1G3r+m+SFqyOJRwoL5HzmU2nCbkxtqAsrQ2ZtiNX1xdBw36SlAEoC/75r+v7bng9XV3rl0tAfaIx4; 4:uF/zCsOdY80HLxho2NOUPKB7TYKycwoFPwM4G6j6fzPP0fHxd4Fw7MBeigQyK8NK/QqXrfDAC/LT3zTZ9OHVUBlCVpRGZa7JiEBfzZ9ubsOgWxzrJjabQrXzmivLpfTlUv/Q457WyZDxkVBpXu4iPx/sYJiLjZYeN1uZddzRV0hajq++oFrrRDzBPwrC+oEVWJg7RZNyEz/pn8jEz2FxwNW9gP1RMWTxUrVzzTcmJp3bDqolf7LjG1WH7jiBTHzIQ5rAWhl0yhpbbnzrcS1a4BuqgUe6IXegeT4lBJXjOsO5wnLmStj3Vo+D/oAeULOwtSyj1TByS7Rp3aOMPeKRJ3D9MvnOFoRffDNRXm/RJEc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:eigvGOdiWdTlMDc2jcdgq2b0zFA4d+0YHFgq3LOPu?= =?us-ascii?Q?YMm8wNC0NpG8I2y3R2Si0GW58gm84WxIRSLscl3XeP+9q1xNZNLlxY6SRDCJ?= =?us-ascii?Q?Hi+9/LDsKqwC6ZkKFeoSV594yAtklsoXRGHWlLcCQVaGxKUorM9rQ3bpgoHg?= =?us-ascii?Q?LlPIuLEGfyWVpoxn3knFt/9W7pPlMKAYXDLlULPllt/vOSBOw41NBzgUdWih?= =?us-ascii?Q?yEs1b2gHjcxhl9gDgWKkuQf6gwq6HjvBq1xZTjorWZpST2BmzGvinSGIAAnI?= =?us-ascii?Q?rE2Ts47ZOJ++Jn/MiL/oAU8kPVkicDGrIXik+bDcoDY7/v486sfvipvPFfp3?= =?us-ascii?Q?QxOweljSwthMQRRJYQkH/ftkkmvMSYrllyExwzw2VrxS3cR1GgcpuI1DyOYG?= =?us-ascii?Q?ueGxEjkJYF7+8tn4iXE5gfJKfr04R1We3qTtO7moujVTsxgQ4SOIdNKNY23e?= =?us-ascii?Q?TGG5p8bwKG2uSqJ4fwsXHEv6znn8MRbx7QWZphpUFVMIldoaMz12rqdvctgT?= =?us-ascii?Q?Mq2rA9GTddWUpRl2/k4ZAPyhEmgjBKbITEdCFSs55Chg2RU4MGIbi1rKz1/e?= =?us-ascii?Q?oM2+P4bZGxhsODe0jYuWocjt8puzEubQfSsWkPaMMOmYbSzbVNygDcsllJSy?= =?us-ascii?Q?m7tfLHJUmTXYXdTliwOmrzyVcgCldSgIu7Ly5TJUEieGaIFekQ/IoXjKCqK7?= =?us-ascii?Q?6i1DX5oKTh69dNZVp9LZJPnwptYGAO0qzw6I1ufRkM9pnOUcJAoucNR8aTrx?= =?us-ascii?Q?ajAIXiJwnMY7gm5xuVXk0tC0aiKUw8C4kD5IowJfwk78ygdJE7WczN10hixY?= =?us-ascii?Q?y93ptqtywlcAQVItPn2dWRTwsdo1xa/ln6OnNXkA+zo4zM9pAX6gV0HMNh2s?= =?us-ascii?Q?pfgMuS4Gkgbsi5MJseGljhIeHXfnTj8QRTDrB03TuDei+s4mGHM542tjSmC3?= =?us-ascii?Q?JRy4mDYSdzDc6LwcJA59iDjMcDUlDJz6l1dxP75pS9/BDQRCfgV8imMn9YXK?= =?us-ascii?Q?CYfF+QuW5CcoofSFwW2D1Fc7by54dF7xjKNbu9j5iwzsG6yBoXJtzlbBfuIh?= =?us-ascii?Q?C7+BJimj8iWv0HWOInAjnCAkIgkrNb8VmROXIj2HX8tO44w4sTxGI7ehLa5j?= =?us-ascii?Q?2drbtgcVdHHgI3Fddz3zwqVs+saRlPSY1Uy5t574ZULhbZY0eUh19Wu7WCwv?= =?us-ascii?Q?2ZhTGkEZDpb/zdSivDWtwmVtCqHuByXUUe0A1XGT7Kz9M0G2t3o8C0YUJ/lw?= =?us-ascii?Q?crP1WsVIGP5h4rbnbs=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:91Hi/uVNuZa+1J0aMVWhr3Cmg5R13vJK/0Xv9WEDkjJnW+XUIaPZdQvdIilz7BfvjZ8PEgxA4aIWZNcSqqQzt+0Tj97X9WSKsvqIsSTsIlBSOR+MUKGQRfvuso65QB1uuoX8uEUCPEAm+IjUi4ixf/WEcMEtn8jmbMSz5pAobaZaunQKc/6jJLL3ZKkXLUYLZ5eTdQ5Up5wztbi40F2/9HGAXBgEIaMbuH1zkAPTkwfRgMhXAI0GEehZeDlkrq4Bfw0HnU9IwIQCUatKlQrSPimE/HciXNKg/sM7I4qUkqfVwmQucm3kVorHHTSksAjlZELud1HfCdwhpepmjtwuGN4C2nPz14gL+iJLjUvIC7w=; 5:iE177ic4ragjXF5xhkoyo8Z1kWYFFXlzUTNKRv4uukHQbqdMso8JHtwkvUKdquiAjazkupxcdq8NLT7f69HvZtZBs61K0KGFz2KfjX7QHnw/coJ8s5Bp7tgWbVkUswPNnX/moW8m219scJehvhBQjc0y/VT0172Z/HaDCksdPQ4=; 24:4TMSgbwipD/h+H0OsCVKcfQ+cu2yH0shhFjPtZOySOekyi5X8zI6kbdesI5CpFfhYdJlxeTTrsAQB8KSHQCpDxMGL1+0efunpLdxv2do0xk=; 7:gUkX29PCiKVIkQzGaENVDCB5TjROmzuoI9EPbFqqicbCRV+hFFRZbFS9+VNRDVQrWlBXM15aK3CW/0L7ZuL6Kn0ofW8237x2Tk/ouV5p3xUX+/atLJvXA6kwDqReRiN7D1jBrofjJiH+xOh5UQTiR4xvlG9/ocSJgTtPPEw5a0zyWb3WOL+LRqxHl+oE1DmPiPpiHVuvcgl7184lkVT2vEpHwFL5b1glup5iODT9L4a6EQrsiuLCctqfIPy354al SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:09.6308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 021576a2-274e-472b-6c7a-08d57d3c59d5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.111 Subject: [Qemu-devel] [PATCH 6/8] Fix WHPX issue leaking tpr values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixes an issue where if the tpr is assigned to the array but not a different value from what is already expected on the vp the code will skip incrementi= ng the reg_count. In this case its possible that we set an invalid memory sect= ion of the next call for DeliverabilityNotifications that was not expected. The fix is to use a local variable to store the temporary tpr and only upda= te the array if the local tpr value is different than the vp context. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 7e58d5f68c..47a6935288 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -687,6 +687,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) struct CPUX86State *env =3D (CPUArchState *)(cpu->env_ptr); X86CPU *x86_cpu =3D X86_CPU(cpu); int irq; + uint8_t tpr; WHV_X64_PENDING_INTERRUPTION_REGISTER new_int =3D {0}; UINT32 reg_count =3D 0; WHV_REGISTER_VALUE reg_values[3] =3D {0}; @@ -746,9 +747,10 @@ static void whpx_vcpu_pre_run(CPUState *cpu) } =20 /* Sync the TPR to the CR8 if was modified during the intercept */ - reg_values[reg_count].Reg64 =3D cpu_get_apic_tpr(x86_cpu->apic_state); - if (reg_values[reg_count].Reg64 !=3D vcpu->tpr) { - vcpu->tpr =3D reg_values[reg_count].Reg64; + tpr =3D cpu_get_apic_tpr(x86_cpu->apic_state); + if (tpr !=3D vcpu->tpr) { + vcpu->tpr =3D tpr; + reg_values[reg_count].Reg64 =3D tpr; cpu->exit_request =3D 1; reg_names[reg_count] =3D WHvX64RegisterCr8; reg_count +=3D 1; --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519675652933780.1974790616243; Mon, 26 Feb 2018 12:07:32 -0800 (PST) Received: from localhost ([::1]:60498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMTb-0004ZX-OL for importer@patchew.org; Mon, 26 Feb 2018 12:22:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLw-0007Li-5i for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLs-0004fV-EW for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:16 -0500 Received: from mail-sn1nam02on0111.outbound.protection.outlook.com ([104.47.36.111]:45325 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLs-0004es-7o for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:12 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p+uch34/nGnGOsD150UKkUzrFQZzF+coqc6GtN+O+W4=; b=DMwBzf5kYgC9UnlXxRK7DDStRaFoOHpRFsiTWsqyVvEZP1SnhcxiPOjlztulsc+gz27hpnYvIxdbl7rh/dAE28rkmFwTkkUP105chhNiqpt5PnnOfUxMmbVW7gNGD2HrEC5j9/ofOdaMsT7INXTV8017/9uJ2T/S/OyKhlAWJHY= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:35 -0800 Message-Id: <1519665216-1078-8-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f561f66a-3b2c-45e5-eb46-08d57d3c5a56 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:g4uYijfv6mHwVshjK4GSQMrLvKoSkq4EvpHWia2zA4vPBTIcHTIIamV1XaIj3w7/B7flSUOORLhGXcMk0D7OZM2RxTqbRpgVSapTgln0r6fF90nzn/pqmjAZWbt6WmwL9/hukwkKpAzpaYdUL/iySzcHytX22FFo1KiUuC2QYSD19JJhEw037b+9zr39qRvVKXXam4zHs08x7n8rq0y2I6x7HzPkig3hG/P7/ZYeog51zu59K0HQ6tcv7+VDc6eO; 25:DKi+jT5EfjBtbt0JOyKO+3lQLfh9Msqed3+mQuJljHfn5l+P7nmzkuqxrPxkgSrGG3XHK6UmfvYgQdLshZHIdvMaC/kId0S2GQEk6k+ACgQcLXGrjqucjOmBpbcxsv2yr8HjrglaeBQlklxADW6B1MQ+e/mx4lqJEdhrMlB0m4FPldCIXyZXoVMcZy4pNI2zjgTXuCCpUHjXZrPYBy5pa7OBmAP5NsgZWCKOBjL/sR9urkZlTk7XchYEAgLEx0fhsFkZvrvzWNnSI17rHv2w7DVXMXaWxgW3tFS+Hn1pXj13gLRZ89BMu0rIOzNpC0Dz8TeilwRGWowFc2MMCPs8ug==; 31:Q4nF18725LaB7qNK1wyRrr1D5HKz8TpXKZRvsXfXfAbg53HttwaynUqP7ltUKiHEoidPYAqvRd/XHZtkQoShlwVgsfaKDOkJxIqv6xqzbuxlDwTjbUZ4Z7FzqZoVXO2zqAZKyQzROT6+RRFKMHCmzyoNRb8nsQSTxI+0vdfxwOTAV3yrk6qd7IcTU0Dw1FclFYSULp3H5l5/C/vs4AEZiafCoJGeG92uHRBbe8bNfg4= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:mzcy2U8J4D1ev+tTW0kDip4GLhzjw6gnjxFK433bc1sA77F6NL8uCL9JpXP3ZcSElaNuZnPS7iq5cv6ZZRYAJe8wQLx4Aoibx+8nmVMMII+g5aVLT6J31h2EmYGzYqGfsCK5lJz9sEc3ZuQwiWOO25EhwODOy7O/LtJpmnHk36nG/9KVdX0XKT7Hi1RSnaYlWbEPWpnD8HsYg8PDN/B7oHGdU+H16re/3OxVXrgvPxwIHjH3g6oV1pHP/y9SI5ddb7FOb8jWnV3Fbr+3LfQt9oglA2tcMPwfAZfV3o/FOZTZzuCa4fZayzHkqfbiULFaxVHGpNbinTxhFzJ0eX+XDvcUG+jsAsIXcNa/DMYfF1D1pTAEL4TB79cUoiV62m+/guyS/t6+AD8Pqh0Qp1y9A5P1SEwcU6IsCu1F75JINfja+XT//XWEPb6xRteq/dhfLHwRmhbLHuhKo0ecBlrRxUw4+roxfTXGzIYdzxH00PQPyTnjrZA1v/+BC/LSrhqv; 4:37xMsubCuMCC+UO83E7+y6NKUor3b9T76+z/+plp57co3sFROFUeMweh/hfytvXcNHRS8hbwe+D2mdC8XTrlasn1YyjNYUlTSS9oujYdqAUXNB9konLDx9+gUjG1ERByaoxq6ftpSLAylyGamwCheRay43RSfoesWHgz4uMktQp0m21+UvuESyMp+c629ojxjk43NTBcE/38h42o98WzYfbzJHJFEfuqcwAPzPmw78bnyA4Kylst+I/Tdh0m5andMKlQG8MiQgnEzWsFlE7zW4UXHhD6IBUeEL/tGqKrkqLGufjpPe/4NQ8mhrRbi3zW/33rA35w85KrvbNzWerquOibpD0HXbVIpxXZmh8EY+c= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6029001)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007)(145603002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:yQ0qyof06pjbEwm+DF/5qB2evPvGifvR+XqKL82N1?= =?us-ascii?Q?M38fikoOTQ52EPmWtYKVNKRUKZtpN2OJd23/Kl+0XUzRy0HKoMHZJzmZDJ5S?= =?us-ascii?Q?MdWJj93+CD2+AY2/8gkVOMGAF0kd0ndtGEjEU2iI82BlCfkL/WQutI8Bg+Me?= =?us-ascii?Q?HqcTyWamNGQcvZu0IgD95uGy4IYG2i46hDE5Kegj4F32z3wuYyG/aFQ/7kIT?= =?us-ascii?Q?WfGkpBOz/CWQ8NbTXMbMQ5EPAJYIepGV/Ovegh9dVS/eV9Cim9WMCKDCR7Bp?= =?us-ascii?Q?JLmxCVaR+kDSZT6mPxFKzt8Rt2YIQbybFdF59+0bdGpQoAlEIZ7R1m3XDt0j?= =?us-ascii?Q?GGT/VYkxPQrOPGmjsVoYGs7XcXMh8iDITwiaG/xxhrgQ/e69ppu+XTWuy5IE?= =?us-ascii?Q?33opD6GCjN9AdnS+MH8o7lgSn4CoxfWCSXbhnQ74lIJNhTJvex14Xbk4ohLF?= =?us-ascii?Q?JRXlngNuhy+JbAOApunoFZ0MLxiwtNLGSdD6BWrVH6zLMuvI2oGeCVGGN1ay?= =?us-ascii?Q?hPb5XJf+M5oWfvMP0sP1Paf1jvmoUnnOEPfPnrbJ33mHPMgfCJOi0/HQoqpP?= =?us-ascii?Q?+oi59tm6NvL9dHdZViJH6mobaViCKOrxBpVtT/KIx5CN3epoyICsdjtxJzUw?= =?us-ascii?Q?QWunwHY4iFV4FzpgftJ/9IDMffwO49YXrFqsuvtSnPwaku64T/U3fxYyxLpY?= =?us-ascii?Q?I87Q9uByR9BWyYjKaj91nJS3aU0DDpLe7+PpWhmzmkmleOksUlC+YLwvnnP1?= =?us-ascii?Q?xl8TDOOa+QXMTHjfGsYDjZqL/ljisQabH95Z57SZO3gRIu2wzh/uMxnuwJGU?= =?us-ascii?Q?W1PJM8Kai/GSzRwWbwwvv+nGGQ1UI3qMY+3zVv/VC5jpqsdbCM9jow2hhAJu?= =?us-ascii?Q?2P2Qgi6Vu976Z0RLxgCH+rlcwkHBaF/iN9DaGg5guYwlOcieVj8snNh0SwLA?= =?us-ascii?Q?2FKiH37An2GmPBO1vy3HdFTkpOG0TNYgUmPrgLDFtU77uq9obOsrfmQ/sRJ6?= =?us-ascii?Q?2b2uk9JasCIAI+PyTcpVMGWbDfnJ+Bik35TAXI/lKbL11oc/hBTeRvMeI8wG?= =?us-ascii?Q?nvoB0xhM2zPqoZ7qVjNwA32zSYfvdc1+NF1bECi8/g58FJJqsaT/msPBrWy4?= =?us-ascii?Q?vgkoJVy72MoMjcBqDdCC8Ve/7mo+Bg+KI/abTwdU5VZKGEmBSwaSVD5NLQdd?= =?us-ascii?Q?X6Kn68QOxLIbWLTXQd7KEeTX+3srmI9DdjQxfBKI2ZK1xpKC3nfM1xBE3K67?= =?us-ascii?Q?2F+2zFTrjnse5CyRKKiOb/3ay71qi06wMEFK8NqheSjLXajKDKzcO4je+0iL?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:iku1af16a/bSLGCyIayzasUt0/B3lpXalXB990Li1m0TGMLXCNZFDw0b2V5/DTjGdDLqhbjxNnrSyRxyC3jjK9N5F6p7fEL7hPuyjCZI8LevicLgyMvJLfN8bd6DswKWGqWlfEC3Fiy6kgbOmD2HIshYMFENwImDDf5UCl6xBbf/xGwqCkpLShBV5zeNXNyc3il6GH54IsULLHEFm55RPhI1NksnhBzYRnh/EsxSu5W3urf+GyzgmakUgZLNyNdV/Xd5LOoHJczSBRlv6iwPboohncVH874KOaoNFL3lyioV68k62V9f9OuJ8MFMX/SqXZwIuVqxM0u1cMRu+3SAsUPbOi7Qg0Af6lZpNz6qit0=; 5:xNPtq29izlyJjtNUUWgep646rt13GA+kqGvO8vq+V/mZpIvfvYnYRHSqgA1IoIXlEZ6jzP17qoX2iQfm623YCwsdvuvtrYOEzFNGXjepfayykEp02Z+IdotVcskb7oDIoY1VUtbkuy6q1YbKEylK1scapdtVYh3jXr/OlnNwF7E=; 24:hHh6Uir6YuJLfbAyLFaL9gfAuBzA0Xl2kgv8U2Mytgg5Xlvt6fxqaxf6krc3VNw0ZO/A89Xr9WTM0a0W3Os1XLPNlZd1vDk/xMsej7Yxrdk=; 7:7dRdGwkILrUl/SOLPI6RJeOj6zJOzfOzDhmc7WKxx8PAZY64BPi6sGs1RdjKiundKxuKjjwzF9ukLzpMy+iDx1JMhySoa+JS8t8wZ9UmGm9FuVFgVR2UJUBW3RxN8yDH8yDvkno5XUeh2D21bBpYmTP3bBvT5ehFw9A5pRHZU9fIqCW9Hyt9vhci2AuQtfeuoOXZ9JQWwcXB5lickdJqV5z5PRuvEGB8BTTbDt++YvjVD9SbFbrNBOItVI0CzxU0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:10.4874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f561f66a-3b2c-45e5-eb46-08d57d3c5a56 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.111 Subject: [Qemu-devel] [PATCH 7/8] WHXP Removes the use of WHvGetExitContextSize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The use of WHvGetExitContextSize will break ABI compatibility if the platfo= rm changes the context size while a qemu compiled executable does not recompil= e. To avoid this we now use sizeof and let the platform determine which version of the struction was passed for ABI compatibility. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 47a6935288..24387bebad 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -32,7 +32,6 @@ struct whpx_state { uint64_t mem_quota; WHV_PARTITION_HANDLE partition; - uint32_t exit_ctx_size; }; =20 static const WHV_REGISTER_NAME whpx_register_names[] =3D { @@ -899,7 +898,7 @@ static int whpx_vcpu_run(CPUState *cpu) } =20 hr =3D WHvRunVirtualProcessor(whpx->partition, cpu->cpu_index, - &vcpu->exit_ctx, whpx->exit_ctx_size); + &vcpu->exit_ctx, sizeof(vcpu->exit_ctx= )); =20 if (FAILED(hr)) { error_report("WHPX: Failed to exec a virtual processor," @@ -1042,8 +1041,7 @@ int whpx_init_vcpu(CPUState *cpu) } } =20 - vcpu =3D g_malloc0(FIELD_OFFSET(struct whpx_vcpu, exit_ctx) + - whpx->exit_ctx_size); + vcpu =3D g_malloc0(sizeof(struct whpx_vcpu)); =20 if (!vcpu) { error_report("WHPX: Failed to allocte VCPU context."); @@ -1300,9 +1298,6 @@ static int whpx_accel_init(MachineState *ms) goto error; } =20 - whpx->exit_ctx_size =3D WHvGetRunExitContextSize(); - assert(whpx->exit_ctx_size); - whpx_memory_init(); =20 cpu_interrupt_handler =3D whpx_handle_interrupt; --=20 2.13.6 From nobody Fri Oct 24 09:58:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1519668508553126.66258542400772; Mon, 26 Feb 2018 10:08:28 -0800 (PST) Received: from localhost ([::1]:60468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMO9-0000Ni-8T for importer@patchew.org; Mon, 26 Feb 2018 12:16:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLx-0007NA-S3 for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLt-0004g9-QC for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:17 -0500 Received: from mail-sn1nam02on0137.outbound.protection.outlook.com ([104.47.36.137]:41302 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLt-0004fp-Hw for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:13 -0500 Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LN52OAAAWY9b49y9b7UE8JU9Hy4BgyV3WNKVkSTCrms=; b=lVXaqQkliaf+67GXqzGWHabhlA1AQoDLiHaXHaQrzApF3n8Mrf+kij1zS6jl6QFQoyNk523O3GbiXX/bw3NYzjdLtwag/P6tWy6wJxwlPfKxk3tGuPETJ9tUbZPJTO1CQqNfSK4v7IWszjQi7oXgygcgTdgZpaFbXMfI7JsTWHA= To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:36 -0800 Message-Id: <1519665216-1078-9-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0ddb4f9b-09b3-4cb7-94ec-08d57d3c5ad6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:B8FCgiO30qVieFdh8gWZ4iZRueuCW8NkIFoFpTzujiXYII7jsHOGmp37Gg5gIZCjBw6Pw07RvE+J8LHduMbSY20UC9XeolbBLIR1lbAJLDSeXzORTxeAErS/g9UJlMiK288Xp0kEBYJcn4Tn/ynzqoZ2H8igWcZbtylfHDwLxcAY7jQPhkagMmhe0N5E6c/kkIE8bu3TghX3LtGiOB3vQCh0XLfsW2fQI3oEtgiEmviyZG750Lav5hLp3ikAi1DK; 25:63qX7swv33W6qQ165UQqrq8joiditYbLYFhP/hLtvzIR3q6N3iSGkSmH9MM8EHMccdT35h0vs6KO+KGE6Ahse/7SJJpNZVPGjKMJFZ1TPZ6QeG/156g94iY+O4s1aQ6sWHQjl/0F4pU/pZ1seS8zrKhFGiiXcI8XQw1X0YaVi2KLOwzSk7uE7A6gMsenae0VBvKih83vUFgcbcRpClm10uGbDMgnt5a1SbQ4LccOQLm3HofSSYCld0qOcDaBuuhTM2N7NA0CBtcob8XeNtD3BDhzVM3hiG6uZntQTNNzJLF71Fm5wvfnZUqOvxiBxx22cq+LaUIRlXcoCGXN4Gcp0w==; 31:PEZDkMornmHiiYPE/XjVR9A9Q/z1knoH8sdj1WSug4bxatxiqKavikmk2J/KHPEMGQUHNXZ7hsRkMjZL5JM6vZ30QG9MpEXOSsxPAMucKlvCrtLUUNQanTfZkNiGNVQeIu9cZvq+Hicroh2+jVELRMIUTIRkN9jJVoMOrSPXWdzPsc+/b07BbpiDB5bZyjbflTsE74wIbOLTT+dQ33q8RaLeCvAB4NXFhbTwOBzkVkk= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:cr98+i7ePnrrSrfkzDyY1pBFWSeUhqw+0IX6su+MdXUscJM9kpC5tOvL8Xb9K1513w6gbDqAU9jRrIksFTWdrWMgVfOp2Smv65VunwMe5C51Swh796uv1eaHMpDUHd1dnwxEk7dW9w3eYXsk9N0pl11/l1v/6fJXJY9fV/CLn4JvzyUCsEGv6A0rbWeVNWBKykNNR+5GyKHTjVqvOcF7xj43aBc87DkkYSGbKSoh4Lnp/BBxItyZVKP0BvmHCIuoUqYztCtp1mIrFyZAtGOlbxlKbByKwutUIFttmBAgTlPIdlGSm9taf16N/Qo2YgYMKcrdv/DI6L7hUCa04KHsIlcOWXZB0UqCgU8xTKOFZcwvFnf1I8y8PkuKhPZ52+0GxNjRhABUkTU7IuIaDLgtOVHQJSMlYh8hbOZB49C2l0k0Q3V+b2FEfV7m8OdBryYJyI+CG+cqc1Vtg3oGJxGp11h1rrwdGLRBRVGXwqsZJlOYPpNdcu+Mzxx3i96jcO/t; 4:0rVJoRrTyvTzQ88DcoEJJa2S83/D5PXt76+AWyi/pHs0Sb/8BA0Phd6Yag9cJFBG0b8c7sQyyGtHA9fOCSXwwHw7A9xxpGEyx9gqVGRBMwf7aHFhXA/fD3yU9iiYCSj6QbPDKZISLMcdXVRxrZCoVXIS3WDHL62wNOSJ630Y6XSYFv7dA+dVAQT1QVzBClgSTKkebU5DNRe+WUxYsIlt3LrpKwn6TMQHuWSCVDyRPi/Ooie3oI1vLyAIQAcpzoio7adBbzRtcX++k8ulu8XQSf3xULd7WUqvYN9fa8iB5NcdQiRKUvK7wqFPpmWgXS7P46o9i1oG7jrjxh7q6UAvMJsAg8k2VPv5isnTDw3FxZs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(15650500001)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:kgH03GpGnTAcvHARc7HxeMd6b7XxtYN6P/v5DkqAK?= =?us-ascii?Q?SelLx2kqGE64D3BQ/Kn7rySjpSoUtaoHUfHYGDJhv5qXV/Y8ijSybQZqaf2Y?= =?us-ascii?Q?6Nm2HgAkHrUZKZFKFCw6VMMdAZosXy1eN2RRzcnC69UBhpVVrSls2P4MyuuR?= =?us-ascii?Q?3cmv1Xkiu1IgXZjelrcx34jYOcOiKiWqZr5NSaAdcvt7HX6iI3cO/Awfslhy?= =?us-ascii?Q?aG/Nd2gXZIjYt6bfYSrg+24TRN/HFjBj6ocoY0Af1/n/ACrDnS2JCmUydMLC?= =?us-ascii?Q?eidS5uSGxDZ7MkA3A5KIzHB8h74k1XXTdFX7Qqprok9lzgFUudWH3Q1Mmu17?= =?us-ascii?Q?rAzlfdK4EjE7YDoSmvf/RlWyQKi3SwGNAUhiBHWgtj5pw8h8t3FMTecngGhe?= =?us-ascii?Q?iRo/Uo0Q1zsxtuRGK1kcVa105IoqlrVGB1yCcpCxPIHTdEM7rI+8i2iexcZv?= =?us-ascii?Q?Cbcx2pYrrozoIyF8H1ycDlBg4HYYa5s+9pvicxcfo/zZD+t+CE3HuH4ShJBV?= =?us-ascii?Q?xi3TwINoxfg+g2vmyAbezMS/U7YatoZZov1B5Vts3phr5qi4cMmKH0uiWxUf?= =?us-ascii?Q?bX2Vh2VAxqLadYSreS0SYIidQyJMJP9sM/LwXAdCD0+spI8+Xr/hb+fpTtdy?= =?us-ascii?Q?bTHBocrlMYAkmQ9sQ+DWHj5UuLRZAq9ayC5o4iMrm1HdJbD9gUxOJDuX2q1u?= =?us-ascii?Q?61rsi6YpYiGIzOEZCiumAtEZL1I5qrWJC8QsVq1/vK70rGgBjrQqd/iv7Bkz?= =?us-ascii?Q?iNndo8id0wYpyqfpui0Rn/1oVYoqL3H2ytLvbfqN/8ljuhhyzAZOP+0i8KYf?= =?us-ascii?Q?tB1GvqVhZiN4/4uGPQr7E7S6fpL7QMRMrYVSi6lbsmt3NYVAiaCfOcdaXSRB?= =?us-ascii?Q?FjVm3eZ31lWLUKMtVkbU1eq3X6vzMUWoEDsottyBjsSOAVPxuxPQZkloQIzJ?= =?us-ascii?Q?hsTJOs8z79cE3tGWYURWpc6DgyrOhOV0ohSAQsCAEAQZka4UNzUC4dxvXTJL?= =?us-ascii?Q?IjdTczPr7UwpvexKPojbBZCfomwzwqVx+ook/iW24JlLBL+SMPlSBavBulYE?= =?us-ascii?Q?mS9vAWHXQFQJpADT5oTaUJMEuXYPesPwJoeJkxWthQez2P75EdgRtLh207Ek?= =?us-ascii?Q?4xyO1HjMK+kqhrWY/axm5f059D7sHhm5muPVAEJDthyaGknKC5FtMLnXqk33?= =?us-ascii?Q?x1k6/w3S5hOkMXpefDBqFknv6MyuTuVNWZzcrRfwWxX+PcBZ3pHZ5KkXjCy1?= =?us-ascii?Q?xaNJmQqtN0xN0hg3Q/+AtgXga8l4WyPLzhLwx9b?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:KNmw9lfUROeW19ynjfLuIiPz1JuxLUZtDpnT566XsqQ5CWt6AOvGqmvfmRnv7oE/iMzjdX7k2+vHhhsBZ4p9Fmta8fQL8TPY8pYovIOuje/HLW/davqJv5GTc0YN3yxMMkb1zzUnrc9I9BNy0eYRswSL0gv9HVkKITQyUliVpudAz6ohzJbV1w54y7eiA6tVXjlOiAPCQccwY0mJz/+XZu+6/euyaPrFFTgASyYO5dpTh0x94YEkd9lZAGHF2usvWSYf5vsY6ypaoJScpETFhbKJQ4k8shN+G+caeF2Mbw/fnEzandPw79JmJmcBVG7ciPBrEkpfsTtGPV7ARRx5+a4juWWC4fnpen3znLYuqz4=; 5:1CbluvFPyhFjxvzd7CFCDsPOkIvjUB+sFS4rIzS7tl7V3YhMCCaoBOenE3tAC5WYAmwRKemF2UlPm2RHvq70dDfZJVS744rytWCzstRGNp7G+ukDQO7qCPsWT7LDLOeR4rp6sX/0hn3W+GEewzVTKJAP4WariZhOsgGs+2FbX9s=; 24:ScK8M/QseuKBDlhmiDJ2JGGiurBIHHbHTw+a4bna9E+lHnfhdCPOkbTHJcthWT4EEViwMRSemF9RWcQ75BFq6NDrVMQ61eMN4G2N68nbi+U=; 7:rB8qeboXn5XWxVQNrp73Dz0rssUdoITBi+iJXi5wQ7iVe3xikQpwU4iyv99a/LCBfGelPOsA7nzON9lx02g1sQ+V3E/umENqCmqzFibOjYQWayQ3fTQmHyaPzxCqHDdeq4ifJCmMzoerH1nrcmBcsO5nhcFEUdG6iXYyzw0lf/yTYCg2NMzlajMq3chBoNvrWS3PqxL6Ksm8eP2RRcL9e3Df5/huRSEhh8AIhlQ+/vV5/N4qzF7S4HDnC3amoCEF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:11.3251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddb4f9b-09b3-4cb7-94ec-08d57d3c5ad6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.137 Subject: [Qemu-devel] [PATCH 8/8] WHPX improve interrupt notification registration X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Justin Terry \(VM\) via Qemu-devel" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Improves the usage of the InterruptNotification registration by skipping the additional call to WHvSetVirtualProcessorRegisters if we have already registered for the window exit. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 24387bebad..940bbe590d 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -756,12 +756,11 @@ static void whpx_vcpu_pre_run(CPUState *cpu) } =20 /* Update the state of the interrupt delivery notification */ - if (cpu->interrupt_request & CPU_INTERRUPT_HARD) { + if (!vcpu->window_registered && + cpu->interrupt_request & CPU_INTERRUPT_HARD) { reg_values[reg_count].DeliverabilityNotifications.InterruptNotific= ation =3D 1; - if (vcpu->window_registered !=3D 1) { - vcpu->window_registered =3D 1; - } + vcpu->window_registered =3D 1; reg_names[reg_count] =3D WHvX64RegisterDeliverabilityNotifications; reg_count +=3D 1; } --=20 2.13.6