From nobody Fri Oct 24 22:15:01 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518703435035679.9229347954728; Thu, 15 Feb 2018 06:03:55 -0800 (PST) Received: from localhost ([::1]:51424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emK8f-0005Hw-EB for importer@patchew.org; Thu, 15 Feb 2018 09:03:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emJxU-0001q3-K0 for qemu-devel@nongnu.org; Thu, 15 Feb 2018 08:52:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emJxQ-0000yg-1q for qemu-devel@nongnu.org; Thu, 15 Feb 2018 08:52:20 -0500 Received: from mail-db5eur01on0107.outbound.protection.outlook.com ([104.47.2.107]:9504 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emJxP-0000xE-Qa; Thu, 15 Feb 2018 08:52:15 -0500 Received: from vova-pc.sw.ru (195.214.232.6) by AM5PR0801MB2052.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 15 Feb 2018 13:52:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KpsfDInkkcrIPEvIDgvJnOpaARG2Upl8nlazv9G1vpM=; b=e6Eu1AXn9biaUaZI/Mh6cU1Jd4u6zTJbnTFPzGdIcA2stl5kXsrN7N/ThtsLdG7nm1Idi8Ww6g6kiBqdnpbKk+Cm8jQ8Mhf9a5OLwCISQn0zw1m59rnQeQd/1Hw4I75B2DCujHqINCGHC5AepAWg88nWAL3+rZEMdFihbzXsQzk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Thu, 15 Feb 2018 16:51:42 +0300 Message-Id: <1518702707-7077-5-git-send-email-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1518702707-7077-1-git-send-email-vsementsov@virtuozzo.com> References: <1518702707-7077-1-git-send-email-vsementsov@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR07CA0005.eurprd07.prod.outlook.com (2603:10a6:7:67::15) To AM5PR0801MB2052.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ccd010b8-f116-440a-a309-08d5747b516d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM5PR0801MB2052; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB2052; 3:xiykcFAqK1Wi5zfHFSzMY8z32A+9o0uzNtxv9ESu6YvzAfj3FIs/Jwf6nBX+VRmrgInKIIBBmNCfO3/umu5AOcUH1s6p3zdjl1wKYB2KbDTOqdM66m0JBusxRO29K73ZGcN28pzZ2D9k1ruoyKU09f2uif+oZIj5pPP9/V4HwbSjwY6qqy5wgbB7hm8jjQ6+43KZCy3RJ/sJSh5/6liQamfxga6TNV+lxlyoK5n6pglbyfb8VzcPrbMDQuEpqTKI; 25:8NDU52CPoALujO5S6f4orTxV2tnw6e268cXH8yXIWemY5ezpWVJIAsXRv4B3VdfgiQi6V4SgIMWDz28sE4aDmqG3aNZLLbk5D+o8LY/BAsUtRJ+R+aOFzmRr5Uj8JdOS6FirFTx75UrR4Twyze64JXvYi+Prkl0k/XmotSuU1EqrUXPGsLWjxY2+ODIzVnW0Ai9qKoVsXQ2RaeWtsxNP/9BEplizvvMc4qGrtU9YfFanJ95G1ZkMFC/srW0Js+KvVHuoWe/61J7yY/0wn57CVG2HCe9Xy+Ij7gaeWKe4437daVlqDpgLmRQKB1c3iBGDriqpB+s6a0RsdBrhnbo2Vw==; 31:VJ9p/+gmPTRmVojaZgvulypGLpkG9KNyHMiRO7wC9rlUsJZIMjcKJ2Z4yiE3XA+eB/7wg7SCpLqhLt8VovpZ5iEE8tOgpbZWgo0Bah+xLTu+gHAHsHFl3U7xpHsAe7lGe3puLNxmu2rFE2xTa/lHtiwR97ASf5ZmEIYKiV0LIRkLjwEwHDZjhDYRB14zf/blOGOMndOw3VCSNSDl4aaXy0g3urUv6vcwrQLcuyjq8e4= X-MS-TrafficTypeDiagnostic: AM5PR0801MB2052: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB2052; 20:Vd7bvR6JHxElN88e+JxX6QyXPsXFfI/JYkkPyrgKEHDbnL06nygjmpfBgrbPqFO5/148VO13mw4q6x/OCf6nXkx77aeCY+lgpYGF06tnfugxPZ9ZfmcbVHaMq2KgFsBaYrr1aZjTeB1tb6CHXgMpz+j8G+k50AIyE0R0Qp7r25s5UjUh8u1C7UD4edN6ypvQ4KoK6PwbGxop++PCfYiaZs9UQLVk3dNa1jSjxlcqE0ObDqWA/SyJu6l9LeuuJPf1w/bMOvoZaBDvmEn7Y9HTYuR34h0sVgccF/y/nFXyBQLNT58ZGknmy5wCAQg6Pp0Epou3LUogYBWofGTPe7AMnddhuJU6F6NHFyqm4R1CxijbafQwIh4YwvViOSyKNrzqk5VCNen2/lxx15A3iPAsrZCreWIdSw0SiHIvBWN78M/ICM7NQS2+4NzeGj0uS8ZqUgklTqxUsgVw0UFkY0sHpRf8De2pxKu2iLye88TrJADJpq9iTO8rtT40BjTAYCXg; 4:Aezp2OEHDgcfFVQvkEMg1HDStHqGVD9svhs0fj4sfGRcLyfvU1IFS2roM7R/2acUIPkY+rBkbPz2alAcFgkbcMk5wH2OPniSgZbfIulkwQ4HuoCZiFo/JL0xvEnFLzRu7YoKIiO5EgB5NO5N94DEnPizO3d/r5pakSePiIyMfT/loQBaHriGjaom7ptXTQsLu240MpMt9XUbMVwktdlG08vEUom6DwQMdeygZSIdpuiTl8aQuh03IKqnmRulg8GXT+b9g/FDq+jLyRLp69d9kg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231101)(944501161)(93006095)(93001095)(6041288)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR0801MB2052; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0801MB2052; X-Forefront-PRVS: 058441C12A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(39380400002)(376002)(346002)(39840400004)(366004)(189003)(199004)(105586002)(52116002)(305945005)(8676002)(81166006)(26005)(6512007)(51416003)(76176011)(5660300001)(81156014)(53936002)(25786009)(7736002)(97736004)(55236004)(16586007)(69596002)(6506007)(36756003)(47776003)(86362001)(66066001)(316002)(386003)(59450400001)(6486002)(106356001)(68736007)(50226002)(4326008)(53416004)(3846002)(2906002)(8936002)(478600001)(6116002)(16526019)(186003)(107886003)(48376002)(2950100002)(6666003)(50466002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0801MB2052; H:vova-pc.sw.ru; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0801MB2052; 23:UErq8WsQSKVDQkhu98NIi07II33r+ny1TFpgZOW?= =?us-ascii?Q?fyMORd63inQMD1vOEndLBi1TUh/HwF9MicK4hmLTVdhzDw2fb8/jQVtd+xD4?= =?us-ascii?Q?eHrBzZeFozUDx5xNpUVZLjWgT6oFKCmSnZow4Gn0qa7mO2v3OXeSTwfC/jFU?= =?us-ascii?Q?YQpL2ixGUr3YO0WcLNus5gOe/xPraVEEQquH6OyY5TO9Msv6MTphC+03SYIJ?= =?us-ascii?Q?FNn5ufN5TkH78CR+EnMnkqw63PxdQeoWM4bzfDdGTPBx7h5vefp6gxeaN9tZ?= =?us-ascii?Q?nQFfnSgkIG1n8CxwrRUeI3dKPWvZZZSUY7E5BNunwbYCrGMbSynQ5bFlQKa/?= =?us-ascii?Q?h9TmhNZYtsO9EBaMsduZjP5xotIRpiD/OorEewmbXffn09LygA5OhVg69tW9?= =?us-ascii?Q?KEgQJUpX41MJOEkk0wLJKgGEb9fO1PK9jRJp1WanPnAnW/y8wErV9rS1td4w?= =?us-ascii?Q?EIZRVuZL3u0VXOacvkawygQBnJdMAji1/YLZVYpTX8jHXejX32i02Glat3jL?= =?us-ascii?Q?hF74vgdiCVlEdDuwx4Yynx9YgQ1AVwj4a7OE/nGVq90w+ai7i1oQmPUjBVDx?= =?us-ascii?Q?Aty2uCtontSAvXCVUzS3m3RBGokqDz8RAKU8EMgYxDakX3zkGkX+hznxpaBe?= =?us-ascii?Q?JUFpRehUNBL93D0fLE8X7JVALp6Zj2hesV6Hh1wiWvJUD8XtnrOuqjc8sBM4?= =?us-ascii?Q?dwXTi/1mtcfAbtpQb0a6wX5vsggVQJBOo1oboJW1pRtIiE2WulKW6eNr2tQb?= =?us-ascii?Q?QNDtAmsuVewziXWxt/zCv9XROhIfpgA8BXQ7fxmgCADE0qsFxIOq/9fJNfYh?= =?us-ascii?Q?b12S87NxZqm9bHg3+ZaHQ6tUWdSRuE2cZ/6KJU4IdPEiIfndpXWUdGs852Xr?= =?us-ascii?Q?7dvbSWmdN3updIorBLgiEsABe5b0syFsDzcK7K2/JMI9cP04gZUClovu8GUj?= =?us-ascii?Q?dNIUE9hkYCGn1XnNnIILLYEciFqiVlTl+B0XP40Ag/f3Bfc2wUWyh35fWF7n?= =?us-ascii?Q?/mY9O2FN6Cs5KSEhVc5/5wYx+t6n/5LFFp0sdGHwxGbl9mfXIbByBn3WB5/h?= =?us-ascii?Q?YBwwDQObYS5Uy+0EsB8TwprYzjWk4GWG+qqnmiHnupVQNSYMLjM84WotOfbe?= =?us-ascii?Q?c6zVvpVi1ftC4+m/5mv763qDRrkrPhwtQJIycRnzAAZNIVTqFoUsamcoTKOk?= =?us-ascii?Q?9uhuouQlm5sRwy87Ta2fxZdAJ9k0yspiD8gMQLHbUIiRfcovikG1TtHZoqA?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB2052; 6:M1zafkIauHCW74di5PlJX/rs6A4Uy4FgudsZUo9dVVQhjBzJZ3JC8uW4QCR5HMHiJevEEd9uVXOfMlihLkqTuRRmT3lRIOM7eztB+Gybkh2PnX8aOMmCmrNtc23gZypfBf2nR9AFMVvI52XnSXV3d3odIs7/Nd2scBKeY7EJ4b/yMrVkiUABjMVj1kTKHO4KS57AHEfom8+pBejp8zl60IzGrSdovzhEWilPFTbL8qgmK34C70NKGaMFNiwLWrsc+ClKoJGYkqlcwhCRhl4vgbb5p9MqhPRyCXW4f00mQPBtZNqhk0FcaukuhEWUXpbUtfSyIppShZ6AcG3ZNTbi87gO3xwL4lYMXxFkj7r/KVo=; 5:M2iyldBKrrVLmtL2bkwIJJBktL2d0+dnmFZB4l2/rvEi+WWuJ8kqnd3TwrTwDURwTNhUVf3itDh0P2uEuJUmvsMAxIy+OfgCaWeQ8LuGzr1e6QrMElFsH69QcrClEh1whSAnd9/fMBBzMxwuDlutmdiVRyIB3VMFaRt6//ttTY8=; 24:eCnuDJ4QrNVyl7UDSpq76dVIIjhY3RQHwzH8LXUbfBeFa8SO2RixkwgQ5VOCgO0fIrA7HeuLxNxFBX8hQwjB96ak/xDObYBs72HQsTNTwG4=; 7:p3lpUAn5Fhst9ylH7GfHbAh4THl+xFPCM8qq+Q6kY6yEf6l5TcrJIqUODhZFu0E/Ez0okeMlYvu6iqLiUQlIl5dZhxJWihRfy/6MCOJT06jPWCOAk3gqKeWNBzhwq+qe2IR7oxIB/17CMhEhPbsDHJCC+QKEkhXDfj3sIuBIzevnbURvec42KXwxfhs0SeoC2BEsiBcQLy5wTwFtIrXDRbhe5DLiNzX0Zgo/GrnKTq8TmLCPMlohRscTKZZSrzj+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0801MB2052; 20:DuIAZUbKeQy3NB3mknb0TpGI9pyLZ6KTDsMswTL2aePIwBpyd2rHM6rizz+Msp3Zrfs1dcggaeSmlicMxmPL51fWgUy4Mt8Wy6BGwGgse4klpaI7kHOAIRFUQpWqZt9j/ommW/RvBQbVnwMIUpV7+hv5/ey25CTBqji+E5Ed10Y= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2018 13:52:13.2950 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccd010b8-f116-440a-a309-08d5747b516d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2052 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.2.107 Subject: [Qemu-devel] [PATCH 4/9] block/nbd-client: save first fatal error in nbd_iter_error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It is ok, that fatal error hides previous not fatal, but hiding first fatal error is a bad feature. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index 9206652e45..b1cbe95b13 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@ -481,6 +481,7 @@ static coroutine_fn int nbd_co_receive_one_chunk( =20 typedef struct NBDReplyChunkIter { int ret; + bool fatal; Error *err; bool done, only_structured; } NBDReplyChunkIter; @@ -490,11 +491,12 @@ static void nbd_iter_error(NBDReplyChunkIter *iter, b= ool fatal, { assert(ret < 0); =20 - if (fatal || iter->ret =3D=3D 0) { + if ((fatal && !iter->fatal) || iter->ret =3D=3D 0) { if (iter->ret !=3D 0) { error_free(iter->err); iter->err =3D NULL; } + iter->fatal =3D fatal; iter->ret =3D ret; error_propagate(&iter->err, *local_err); } else { --=20 2.11.1