From nobody Sun Feb 8 09:28:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151862963218855.87697860554135; Wed, 14 Feb 2018 09:33:52 -0800 (PST) Received: from localhost ([::1]:42815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1em0wI-0004vh-Bw for importer@patchew.org; Wed, 14 Feb 2018 12:33:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1em0uN-0003Ta-Hu for qemu-devel@nongnu.org; Wed, 14 Feb 2018 12:31:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1em0uJ-0002Gv-KR for qemu-devel@nongnu.org; Wed, 14 Feb 2018 12:31:51 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43248 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1em0uJ-0002GR-Eg; Wed, 14 Feb 2018 12:31:47 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 07DB4408501B; Wed, 14 Feb 2018 17:31:47 +0000 (UTC) Received: from thh440s.redhat.com (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0BAB2024CA4; Wed, 14 Feb 2018 17:31:45 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Date: Wed, 14 Feb 2018 18:31:45 +0100 Message-Id: <1518629505-22480-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 14 Feb 2018 17:31:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 14 Feb 2018 17:31:47 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When running configure with --with-pkgversion=3Dfoo there is no space anymore between the version number and the parentheses: $ m68k-softmmu/qemu-system-m68k -version QEMU emulator version 2.11.50(foo) Fix it by moving the space from the configure script to the Makefile. Fixes: 67a1de0d195a6185c39b436159c9ffc7720bf979 Buglink: https://bugs.launchpad.net/qemu/+bug/1673373 Signed-off-by: Thomas Huth --- Makefile | 2 +- configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 4ec7a3c..41adbc9 100644 --- a/Makefile +++ b/Makefile @@ -369,7 +369,7 @@ qemu-version.h: FORCE (cd $(SRC_PATH); \ printf '#define QEMU_PKGVERSION '; \ if test -n "$(PKGVERSION)"; then \ - printf '"$(PKGVERSION)"\n'; \ + printf '" ($(PKGVERSION))"\n'; \ else \ if test -d .git; then \ printf '" ('; \ diff --git a/configure b/configure index fe9eea9..1fc687c 100755 --- a/configure +++ b/configure @@ -1162,7 +1162,7 @@ for opt do ;; --disable-blobs) blobs=3D"no" ;; - --with-pkgversion=3D*) pkgversion=3D" ($optarg)" + --with-pkgversion=3D*) pkgversion=3D"$optarg" ;; --with-coroutine=3D*) coroutine=3D"$optarg" ;; --=20 1.8.3.1