From nobody Mon Feb 9 20:34:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518523726514947.4202703245134; Tue, 13 Feb 2018 04:08:46 -0800 (PST) Received: from localhost ([::1]:50486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elZO9-0000zt-LX for importer@patchew.org; Tue, 13 Feb 2018 07:08:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elZHA-0003xU-97 for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:01:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elZH6-0007US-Me for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:01:31 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elZH6-0007Ty-FC for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:01:28 -0500 Received: by mail-wm0-x242.google.com with SMTP id f3so15601269wmc.1 for ; Tue, 13 Feb 2018 04:01:28 -0800 (PST) Received: from 640k.lan ([82.84.102.245]) by smtp.gmail.com with ESMTPSA id f9sm6870298wmf.12.2018.02.13.04.01.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 04:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GxmuWDToXsaJWSzD43fSKlcs3ZmwN2srznMC12/B704=; b=swif60IHs6GyL2NrCq3ZhXT+SrqooHDOnnc1Mzf7Iic5Rkzu8OqdgTr+Ng4qOqDPto w32bcAlEe0Mo5pEaqhEQ+53KJdubRMsU6euWp/z+BuB9alhxmJXqh7KJV3EWweezY+oj uYGcrUdLSgS9w6HdhDzpbUV2WM8VJkRrlt5jpAYhpdihLoOxPEXKGu9L2Ch4Aj0x/tnK v2lw9ZmZ8wPJVZ8Nm5izJJ52Fda58DrR+SgO4bTWeAQoQI+uisjRY0gM8mplmQSXTBbI 5r7scrYJSFXonZIE0xXRulcsQm5dVjGMf/oiKCmpaYt06DTnpUULRWkHTRQjjbcj4twM S5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GxmuWDToXsaJWSzD43fSKlcs3ZmwN2srznMC12/B704=; b=OcNprNWalOi5TXriQnCW/vJTDdI5A4zrsff/Hh71Xa1hgtjLRVjeLcg1rNtyzmskGk giYbvjguqrc5eknlp5s/Xlqp4BmBBUD1KlErBPQLFj2x/HtaO6IVNr2ib+Yf9XnzohxW aW2oGMgc2Ofz9e+Jpen29YeX00Y55iEhwnKLRPkxaHsb5yi+CAmFWznBqytaVP77X1al KxbLJWdu9dGoscBnmFFwrfo8BNnyjoJcupsJQyNoQtu9Z+x7iOc06PK0lAWMrulGbuv5 EloRuPrvMc9SzIc4QKhndeiJo8HdGpMOs2fk+PyWOHzV3h/1NWDtBQ64MPhSVvf4UsGE AhAg== X-Gm-Message-State: APf1xPBij1OyQIMHeed7Q8XP2rZU7zWBdSjrtuqyzSdBpqSw4BT/KfkR HJvbGO6jjvjqNFw6eiSUiHexLiiF X-Google-Smtp-Source: AH8x227ZxgcUdw0JOyxqjE9eBn8gkeNBms84Ir/7eV+EeTYOl4M7Dy+RS57aEA5dOJfgg8nnT3GgYA== X-Received: by 10.28.134.140 with SMTP id i134mr1222951wmd.57.1518523286979; Tue, 13 Feb 2018 04:01:26 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 13 Feb 2018 13:00:05 +0100 Message-Id: <1518523252-49106-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1518523252-49106-1-git-send-email-pbonzini@redhat.com> References: <1518523252-49106-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 01/48] Revert "build-sys: silence make by default or V=0" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: "Daniel P. Berrange" This reverts commit 42a77f1ce4934b243df003f95bda88530631387a. The primary intention of this change was to silence messages like make[1]: '/home/berrange/src/virt/qemu/capstone/libcapstone.a' is up to d= ate. which we get when calling make recursively with explicit targets. The problem is that this change affected every make target, not merely the targets that triggered these "is up to date" messages. As a result any targets that were not invoking commands via "$(call quiet-command ...)" suddenly become silent. This is particularly bad for "make install" which now appears todo nothing. Rather than go through every make rule and try to identify places where we now need to explicitly print a message to show work taking place, just revert the change. To address the original problem of silencing "is up to date" messages, we simply add --quiet to the SUBDIR_MAKEVARS variable, so it only affects us on recursive make calls. Signed-off-by: Daniel P. Berrange Message-Id: <20180123164718.12714-2-berrange@redhat.com> Tested-by: Eric Blake Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Paolo Bonzini --- Makefile | 2 +- rules.mak | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 4ec7a3c..9b4291b 100644 --- a/Makefile +++ b/Makefile @@ -294,7 +294,7 @@ else DOCS=3D endif =20 -SUBDIR_MAKEFLAGS=3DBUILD_DIR=3D$(BUILD_DIR) +SUBDIR_MAKEFLAGS=3D$(if $(V),,--no-print-directory --quiet) BUILD_DIR=3D$(= BUILD_DIR) SUBDIR_DEVICES_MAK=3D$(patsubst %, %/config-devices.mak, $(TARGET_DIRS)) SUBDIR_DEVICES_MAK_DEP=3D$(patsubst %, %-config-devices.mak.d, $(TARGET_DI= RS)) =20 diff --git a/rules.mak b/rules.mak index 5fb4951..6e94333 100644 --- a/rules.mak +++ b/rules.mak @@ -131,8 +131,6 @@ modules: # If called with only a single argument, will print nothing in quiet mode. quiet-command =3D $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1= , @$1)) =20 -MAKEFLAGS +=3D $(if $(V),,--no-print-directory --quiet) - # cc-option # Usage: CFLAGS+=3D$(call cc-option, -falign-functions=3D0, -malign-functi= ons=3D0) =20 --=20 1.8.3.1