From nobody Mon Feb 9 01:01:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1517860968629939.9046106743269; Mon, 5 Feb 2018 12:02:48 -0800 (PST) Received: from localhost ([::1]:55064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimyV-0001Vl-Px for importer@patchew.org; Mon, 05 Feb 2018 15:02:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimSg-0004uI-CT for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eimSf-0005AS-9F for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:54 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:38697) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eimSf-0005AG-1Z for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:53 -0500 Received: by mail-wm0-x242.google.com with SMTP id 141so27960501wme.3 for ; Mon, 05 Feb 2018 11:29:52 -0800 (PST) Received: from 640k.lan ([82.84.122.246]) by smtp.gmail.com with ESMTPSA id g8sm20029891wra.18.2018.02.05.11.29.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 11:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TO3X8l/HPQO9VfUH8HjLeAcxUOWjRk5eUSTTk3BVMbI=; b=rcmG1wuvUA8wj7hl4eoXo4Txhwo6vu8gkhzLFSr+A6YW7tf/2n+NHGL09Uz9YJjyHL fj46qwTLNG2jYJXr5IkBy1njktrmGp0UUO0/5dzIv5frKvfzWm2nQ+bl72SIG8ycqxY3 ZbjSWcMnOYDpZM6NhSfmyKK4f71JaXlbqVlEE4talMt+yVsG9lsvlBa9FyT/XwY7PdXG D96S6Jp6+h9xYJIgV2WAtTb0MUruGloCQXCZaw4umtS3OMwrneeUjnNRDEFbqp+4KHQY aZ2IsjATJb+FijEB4mSy5QGRuP6XDAogYRgEx+RtMuz57SfrOf70pp7hciD2q6T9jDnS Xo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TO3X8l/HPQO9VfUH8HjLeAcxUOWjRk5eUSTTk3BVMbI=; b=KM6heqhFF8qBOFjVGcRycyL5ta3I38LJaSRxLnuM87Y0stW0VrndA+f9Q8SzxLj0Pj Hp/gPmWtcHZpbDDLTdX2GJHauJ1r7uAAt5UiOyE+Hz0YTRbTeuKgJdXiuqqUME9xkOqR Smai5W5vbFrYUuTlAisqz17cqm0lp6Thp21ELj2ttRe6I1vFp9cxPBB401rBteXwBfB7 eT9F0+13B0HsKm/auFITjVBnW8pYR62qhvrrcdUwy6a7uYaoxK1W6k1g5w91iagYKWSe 1hLAs65BPh3TxBVo0Byk/MmxHWDSljtKVTeHLBOP4n2hpnTxuYJbZVqNNj4y0DUDpUaI jJ6A== X-Gm-Message-State: APf1xPBSBbuwiaw66meeGZSYdKzIAJhX0pJvVvxJ9rv6cideEjP2m6n0 8dF0+k7J8tFFcF6Y2SzzHMlNcIbx X-Google-Smtp-Source: AH8x225oAsV+zWdJOBw8bs9tfNmlkBDlN05Ajojdx8HQvDZGnVGgDPY5D51/46I4A83hK5kCBRpALg== X-Received: by 10.28.129.70 with SMTP id c67mr340398wmd.160.1517858991635; Mon, 05 Feb 2018 11:29:51 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 5 Feb 2018 20:28:54 +0100 Message-Id: <1517858941-5538-41-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1517858941-5538-1-git-send-email-pbonzini@redhat.com> References: <1517858941-5538-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 40/47] tests: keep compiling failing vhost-user tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau Let's protect the failing tests under a QTEST_VHOST_USER_FIXME environment variable, so we keep compiling the tests and we can easily run them. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20180201132757.23063-6-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index ec6ac9d..713ff5c 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -30,8 +30,6 @@ #include #include =20 -#define VHOST_USER_NET_TESTS_WORKING 0 /* broken as of 2.10.0 */ - /* GLIB version compatibility flags */ #if !GLIB_CHECK_VERSION(2, 26, 0) #define G_TIME_SPAN_SECOND (G_GINT64_CONSTANT(1000000)) @@ -765,7 +763,7 @@ static void wait_for_rings_started(TestServer *s, size_= t count) g_mutex_unlock(&s->data_mutex); } =20 -#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TES= TS) +#if defined(CONFIG_HAS_GLIB_SUBPROCESS_TESTS) static inline void test_server_connect(TestServer *server) { test_server_create_chr(server, ",reconnect=3D1"); @@ -956,16 +954,19 @@ int main(int argc, char **argv) qtest_add_func("/vhost-user/migrate", test_migrate); qtest_add_func("/vhost-user/multiqueue", test_multiqueue); =20 -#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TES= TS) - qtest_add_func("/vhost-user/reconnect/subprocess", - test_reconnect_subprocess); - qtest_add_func("/vhost-user/reconnect", test_reconnect); - qtest_add_func("/vhost-user/connect-fail/subprocess", - test_connect_fail_subprocess); - qtest_add_func("/vhost-user/connect-fail", test_connect_fail); - qtest_add_func("/vhost-user/flags-mismatch/subprocess", - test_flags_mismatch_subprocess); - qtest_add_func("/vhost-user/flags-mismatch", test_flags_mismatch); +#if defined(CONFIG_HAS_GLIB_SUBPROCESS_TESTS) + /* keeps failing on build-system since Aug 15 2017 */ + if (getenv("QTEST_VHOST_USER_FIXME")) { + qtest_add_func("/vhost-user/reconnect/subprocess", + test_reconnect_subprocess); + qtest_add_func("/vhost-user/reconnect", test_reconnect); + qtest_add_func("/vhost-user/connect-fail/subprocess", + test_connect_fail_subprocess); + qtest_add_func("/vhost-user/connect-fail", test_connect_fail); + qtest_add_func("/vhost-user/flags-mismatch/subprocess", + test_flags_mismatch_subprocess); + qtest_add_func("/vhost-user/flags-mismatch", test_flags_mismatch); + } #endif =20 ret =3D g_test_run(); --=20 1.8.3.1