From nobody Tue Oct 28 02:10:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516115355462852.3798808502678; Tue, 16 Jan 2018 07:09:15 -0800 (PST) Received: from localhost ([::1]:39617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebSrS-0003oz-HI for importer@patchew.org; Tue, 16 Jan 2018 10:09:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebS4l-0003mB-UJ for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:19:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebS4f-0005W3-Rr for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:18:55 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:40842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebS4f-0005V4-MD for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:18:49 -0500 Received: by mail-wm0-x244.google.com with SMTP id v123so8966212wmd.5 for ; Tue, 16 Jan 2018 06:18:49 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-229-84.clienti.tiscali.it. [78.12.229.84]) by smtp.gmail.com with ESMTPSA id u10sm1537758wrg.6.2018.01.16.06.18.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 06:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=033LkzDn7bO2+4XP5OOr0CJLAPcCHZ4nUls9z7Z3jVw=; b=Sgrzc2NnQ7k1OScpelOClFcnMRVmWcqUzZ5ZZVQlWV3EpIgoU+HrKcbpgBZiEeCctA Ff8ebqDLkIsftxrJgL2F71AzIi9rMF6yLTi4QkGVpNE3inJGCjUpgAn29w42Zt3GjGeW pokHcaFchkJ/p1AbkiEMRtfZifqJSbkc4qqAwCt6ZXHZiEY8MdKW6wIPskJcHilgpDAJ YY3946DW32itBwaOK5OuLaNkex7mRAVzyu+ZaF8m1+j6LlUrUwxBQSUqWV2xXIS6HKz9 +cATKZTZeFRXhLDoNyju2RBoAevrbZpTTItK9/lNVDRrPDI+dAWG68trvwMLbsMq0hed pKdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=033LkzDn7bO2+4XP5OOr0CJLAPcCHZ4nUls9z7Z3jVw=; b=btKk1cKX/IKehyU9JK2c3W56P77bNjxNrSgbsMIiVJn12kcC4pFBWGG7N16n8/nBDJ Wc261QM81bC6cAW+B145Kw5v2jFyTAsjYEr2FrDqnX+NaFKAHBT8lhIqLxsDtXCq7LQY 71oIwTiY0X20T/KH1AfyxACpizfECgxpKZg9QrMsVIRs5e70bfCL9MCMQCE2OBkWe7Zq +2Ys8B3oGOyMvEbGJ1708dbcz3oYaBzgwunyp437SKYzp98c4fgfqWHmuX/48eLp5P8R Cs1PfLcAlKG7d354ZluGrGmgPokY6ZbT38PKLEchSD835o+LY1yNA6AkZ79QC+sIV5Me pXBQ== X-Gm-Message-State: AKwxytfbLXVnX+TmD55dMtYK0ctZoqAAhDkmBdBdx+o0+ZLewXhQ+9fI 8mKApBSrY2Ry9+Ul/mo6PdniPVss X-Google-Smtp-Source: ACJfBotPL3YflBJtF4c2A153ZGX4K3HprfOmH3V/Jnb6JEvXI7qSkrG5Vu89zka/cHzuNgXlfbowuw== X-Received: by 10.28.167.215 with SMTP id q206mr13353113wme.48.1516112328148; Tue, 16 Jan 2018 06:18:48 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 15:17:30 +0100 Message-Id: <1516112253-14480-49-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> References: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PULL 48/51] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Lieven Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Lieven in case of unaligned requests or on a target that does not support block provisioning we leave iTask uninitialized and check iTask.task for NULL later. Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Message-Id: <1515425247-21730-1-git-send-email-pl@kamp.de> Signed-off-by: Paolo Bonzini --- block/iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5c0a9e5..6a1c537 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -658,6 +658,8 @@ static int64_t coroutine_fn iscsi_co_get_block_status(B= lockDriverState *bs, uint64_t lba; int64_t ret; =20 + iscsi_co_init_iscsitask(iscsilun, &iTask); + if (!is_sector_request_lun_aligned(sector_num, nb_sectors, iscsilun)) { ret =3D -EINVAL; goto out; @@ -675,7 +677,6 @@ static int64_t coroutine_fn iscsi_co_get_block_status(B= lockDriverState *bs, =20 lba =3D sector_qemu2lun(sector_num, iscsilun); =20 - iscsi_co_init_iscsitask(iscsilun, &iTask); qemu_mutex_lock(&iscsilun->mutex); retry: if (iscsi_get_lba_status_task(iscsilun->iscsi, iscsilun->lun, --=20 1.8.3.1