From nobody Tue Oct 28 02:08:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516115110145172.3031643905823; Tue, 16 Jan 2018 07:05:10 -0800 (PST) Received: from localhost ([::1]:39574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebSnU-00007L-9T for importer@patchew.org; Tue, 16 Jan 2018 10:05:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebS4S-0003TE-Mb for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:18:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebS4Q-0005H0-1z for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:18:36 -0500 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:38690) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebS4P-0005Eu-Rz for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:18:33 -0500 Received: by mail-wr0-x243.google.com with SMTP id x1so11169657wrb.5 for ; Tue, 16 Jan 2018 06:18:33 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-229-84.clienti.tiscali.it. [78.12.229.84]) by smtp.gmail.com with ESMTPSA id u10sm1537758wrg.6.2018.01.16.06.18.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 06:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XpGusnd7R7MpGFIgZ/wEWOlLdX5OgpIFI/U/fl4T5P0=; b=WKORd0jvXC0lM1hftgvS23JhWYt7DDrkeK2M8pS4ubh7fpPLx0cvtm0OscV/PqxSme wy/xP9tOtKiE8qz/3whn6POAf1NPMbIBdQe3cUvd2uRcJxC5qbAqNhhgpEt54AIKAWZU 81OAAqP7wnZs6iV8ZIYgvurO8LEyuih4Pt5AoF8Ctwia8Rr1DrVFNFGMzDfTHHvI5QHN zVcqZ74TdCXxqnIdLuVHQCdzqPpr2amkqTi/NG/xT6JxAJczxymijFWQQR9KWhscNawW x+tvzHfnXYehAoxD1MS6tOfzR1m6E8iaOHPlos8Zko8hU7SmtvFgly8dO/aAOxeHHmEu BalQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XpGusnd7R7MpGFIgZ/wEWOlLdX5OgpIFI/U/fl4T5P0=; b=JWIoK2P1LrBlEFvvtRxMjsj/3087kNPEKP+mh39JjFjTb7HmEpyCxSWVt76EzSrTpc LYYDmfuvsCNX8eHxWHAgyhL4iRgdEw5KP0wDuXHmrSV1338QbYYDeoTgiOaeqxRYk+q7 /gzdaeJ1AmC340UxkCglPFBFXtE4z3Rdr+rDutX5m+bsVQNcSyJb7P+iNtZfcWGEWFbj 7KRHrUF6TdbPCdFbJLgs33tIatozUkEfUevyi0RA7aEV5JRZQBnKc/P0BXAPk3Wd/OYB X425E1vlWJJPn5qdwk3UJJjJp45TfQ7IvTgkmLx+4cBlxyT659FmSNp/zbPlISuh6rjV OGoA== X-Gm-Message-State: AKwxytf4GSVpQwou7B+Zbd1SIBwYDgK9JiePsbfR2Da4nhWRR/Ds8L8l UCHdBpqjyqhxTO95QH47F4UkdyZO X-Google-Smtp-Source: ACJfBotv4drTc8OQEIHqI9dxdApzjH54pmMkpVoga80asCjxdVNzzp5s9IxsaxnVmrI2lZaYag4M7A== X-Received: by 10.223.139.221 with SMTP id w29mr5257022wra.223.1516112312083; Tue, 16 Jan 2018 06:18:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 15:17:22 +0100 Message-Id: <1516112253-14480-41-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> References: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PULL 40/51] chardev: Use goto/label instead of do/break/while(0) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Eric Blake Use of a do/while(0) control flow in order to permit an early break is an unusual paradigm, and triggers a false positive with a planned future syntax check against 'while (0);'. Rewrite the code to use a goto instead. This patch temporarily keeps an extra level of indentation to highlight the change; the next patch cleans it up. Signed-off-by: Eric Blake Message-Id: <20171201232433.25193-4-eblake@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Paolo Bonzini --- chardev/char-serial.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index 2f8f838..10162f9 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -64,9 +64,14 @@ static void tty_serial_init(int fd, int speed, #endif tcgetattr(fd, &tty); =20 -#define check_speed(val) if (speed <=3D val) { spd =3D B##val; break; } +#define check_speed(val) \ + if (speed <=3D val) { \ + spd =3D B##val; \ + goto done; \ + } + speed =3D speed * 10 / 11; - do { + { check_speed(50); check_speed(75); check_speed(110); @@ -125,8 +130,10 @@ static void tty_serial_init(int fd, int speed, check_speed(4000000); #endif spd =3D B115200; - } while (0); + } =20 +#undef check_speed + done: cfsetispeed(&tty, spd); cfsetospeed(&tty, spd); =20 --=20 1.8.3.1