From nobody Tue Oct 28 02:08:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516112969595831.7237696907473; Tue, 16 Jan 2018 06:29:29 -0800 (PST) Received: from localhost ([::1]:39136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebSEy-00044Y-P1 for importer@patchew.org; Tue, 16 Jan 2018 09:29:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebS3i-0002cU-JW for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:17:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebS3a-0004QA-Oz for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:17:50 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:43472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebS3a-0004Ps-Ht for qemu-devel@nongnu.org; Tue, 16 Jan 2018 09:17:42 -0500 Received: by mail-wm0-x242.google.com with SMTP id g1so8671317wmg.2 for ; Tue, 16 Jan 2018 06:17:42 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-229-84.clienti.tiscali.it. [78.12.229.84]) by smtp.gmail.com with ESMTPSA id u10sm1537758wrg.6.2018.01.16.06.17.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 06:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=Jt0Xhb4SuzYe0b5ia2LvO8eJ8oboIxs2Kr861nHZqow=; b=W4KtLftA2uMupFBYtKUSJT6Tcw4VCUX7/z5jZyQ8BvEKLXEnXGriOeL2JMFWMMfitw mP6uSxnmMw5vrHWuzE92lYVBJtuTtJch+T6pmYhmm0d6hFhGvL+8Qno2ezbX8YK+VfuA qL+OUndvWQ9WTjckJjRVKvTL1f9nYCbVLovHqjFBwUu9K6fqnwVmE3L9PT5x2PAL27rO 5xXM3H70JTOkeh1xhMxG7PJhkGnO5wYsE7Z4D2vwyKFmEQSwRtoA43jyQ4SNtFY4q1OW nxKfwMvJ/PeFTaeYBDrPbn5mLPQgTfygpTJSWYiwbTJAK3p/Yf/yw/4q27kJvM4HwJWW esRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=Jt0Xhb4SuzYe0b5ia2LvO8eJ8oboIxs2Kr861nHZqow=; b=uN80iudaQvrkjV9wCvPjI9IHVbsvbeN/iSc/xnt4XASMKGqxaAaWLPDSA/vQ0sj5Kp QjIV2zSl4WF1j+SSUOaBdtkZK0TgzEH77bbBd7BjcDu4SmUsRya8hWvlCIpBSDniqY1R 0Ez/2L1yIdOgAY64ZWNofGbNNoIZwzHh0yOHPwucegLE1OmVHeO+C3HxNMfz+aSHSFK2 8fwpNDn571ggSCREb403jtGhIERAHJ+2eWE9LK0ivssIJsKrLyv5aWrqNSpUJ0L4AnnE a6MZ4drCvKlcY/kogpuQY5fJPWefIcdC4xVPBt0YwZobBN0AFM1IARRRpdDDLQHH9atC 9qTA== X-Gm-Message-State: AKwxytcXKP0mJEvaEkzDcI1y0CDzulzykpif1rZpxWVzgpry+KtFS4Vd EaDJ5JgP+TsbWz4/kfYhxyCHQ9yN X-Google-Smtp-Source: ACJfBosKVAUIMoH7kMHpa3bfxv8DGZ8Cmrr/kMTmJzU5Po7xUU4gcaJl+6htI+2w8awA6wbACUdA/Q== X-Received: by 10.28.149.17 with SMTP id x17mr5874042wmd.19.1516112260935; Tue, 16 Jan 2018 06:17:40 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 15:16:44 +0100 Message-Id: <1516112253-14480-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> References: <1516112253-14480-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 02/51] scsi: fix scsi_convert_sense crash when in_buf == NULL && in_len == 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" scsi_disk_emulate_command passes in_buf =3D=3D NULL when sent a REQUEST SENSE command. Check for in_len =3D=3D 0 before dereferencing in_buf. Fixes: f68d98b21fa74155dc7c1fd212474379ac3c7531 Reported-by: Roman Kagan Tested-by: Roman Kagan Signed-off-by: Paolo Bonzini --- scsi/utils.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scsi/utils.c b/scsi/utils.c index ddae650..8738522 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -322,18 +322,18 @@ int scsi_convert_sense(uint8_t *in_buf, int in_len, SCSISense sense; bool fixed_in; =20 + if (in_len =3D=3D 0) { + return scsi_build_sense_buf(buf, len, SENSE_CODE(NO_SENSE), fixed); + } + fixed_in =3D (in_buf[0] & 2) =3D=3D 0; - if (in_len && fixed =3D=3D fixed_in) { + if (fixed =3D=3D fixed_in) { memcpy(buf, in_buf, MIN(len, in_len)); return MIN(len, in_len); - } - - if (in_len =3D=3D 0) { - sense =3D SENSE_CODE(NO_SENSE); } else { sense =3D scsi_parse_sense_buf(in_buf, in_len); + return scsi_build_sense_buf(buf, len, sense, fixed); } - return scsi_build_sense_buf(buf, len, sense, fixed); } =20 int scsi_sense_to_errno(int key, int asc, int ascq) --=20 1.8.3.1