From nobody Tue Oct 28 01:56:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15154315186661000.0114332743465; Mon, 8 Jan 2018 09:11:58 -0800 (PST) Received: from localhost ([::1]:46112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYaxp-0001Yb-Qe for importer@patchew.org; Mon, 08 Jan 2018 12:11:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYawp-00015V-6w for qemu-devel@nongnu.org; Mon, 08 Jan 2018 12:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYawo-0002aK-90 for qemu-devel@nongnu.org; Mon, 08 Jan 2018 12:10:55 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:45770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYawo-0002XE-1o for qemu-devel@nongnu.org; Mon, 08 Jan 2018 12:10:54 -0500 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1eYawd-0002wL-Db; Mon, 08 Jan 2018 17:10:43 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 8 Jan 2018 17:10:42 +0000 Message-Id: <1515431442-23795-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergio Andres Gomez Del Real , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 In commit c97d6d2cdf97ed we accidentally added code to configure that uses '=3D=3D' for string equality testing. This is a bashism -- the portable way to write this is '=3D'. This fixes the "Unexpected operator error" complaint produced if the system /bin/sh is dash. Fixes: c97d6d2cdf97ed Reported-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Peter Maydell Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- As an aside, it's annoying that this doesn't make configure fail; otherwise it wouldn't have got through my build tests. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 56f9716..6a04082 100755 --- a/configure +++ b/configure @@ -5076,7 +5076,7 @@ fi =20 ################################################# # Check to see if we have the Hypervisor framework -if [ "$darwin" =3D=3D "yes" ] ; then +if [ "$darwin" =3D "yes" ] ; then cat > $TMPC << EOF #include int main() { return 0;} --=20 2.7.4