From nobody Mon Feb 9 14:50:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513790483169855.6190116226409; Wed, 20 Dec 2017 09:21:23 -0800 (PST) Received: from localhost ([::1]:60349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRi3A-0008DF-PF for importer@patchew.org; Wed, 20 Dec 2017 12:21:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRhy1-0004Hv-Sa for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRhy1-000710-0l for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:41 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:45819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRhy0-00070U-QZ for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:40 -0500 Received: by mail-wr0-x242.google.com with SMTP id h1so22876955wre.12 for ; Wed, 20 Dec 2017 09:15:40 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id f125sm2751101wme.45.2017.12.20.09.15.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 09:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1JyhuFz6vA+QwJlxJ3+wuthoUSv2p9/kdMuhTF+lpnU=; b=pT6CUXFctWWqtQ7kFu2Ho2R5cCK299YpIz7D1a+WqEbh66+iN3lNJBHrGT1aRm9DgE ap9jjifZcwYz8O79XPtvTIcjb/G3vg3AzjBr5PUuqrTy+2Z5LSCRXviIZ5NoaO8o2MvL Kahl03W6D62cD5CifgGp03+dEguBFgUQaRTBstRCiUTwTluG++RA7hW0xvFh7KKBvF/i JPqoV/0KTI9UHryIL1LGfYzA4EtakGzzMdTE9ARY47ygjl0Cs8F3RV5sl8Ud6mk2pk6c fu1U+AwVtmC6pw01HN5iR/KJaPreivTxwf/u1tml7ZYoqN6HhcObnO/hKQUsiMNtqod+ DmyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=1JyhuFz6vA+QwJlxJ3+wuthoUSv2p9/kdMuhTF+lpnU=; b=B/N8N+uSmdYJimFrIHVsTdD4pkNUZEUlH2QXA7xstjhBxGRrFanpSff2Hr2apxczV+ QBtdgz4rN1SbypbPUITp5KHIfQwCKxz7TH5AD4ygWBfHUGPi1CHDT6B00/wV3Zo+C+4K dLNhIBlnOSgPom/45wNz8nIfsMoF3FbaMzbcCp3GAbxko9AZlICFpmkUx6oPkSW3EQmt Wx8OkrSrI4OzW0qNnjp6fQB37l6XZVSGLFMe9faTgYmsu5CjDWzAEwIH+lvfMfGPXBOf 1XsWC8fkllGgGN0vA2or0qMTZjI+cYOOtoQCFtKZQU3SfuUBpz1zgz7yGgqNHlQmLlwg GfRw== X-Gm-Message-State: AKGB3mJNI9foz+ELfYSSf3SsJUIq7a1Q5J8EWBDO8tVX1kBgExAni1JY Ijiba3n64KsY00XkfPJtfw8I2giK X-Google-Smtp-Source: ACJfBou3XCtjFSxKJk1yb9ayhHKxQ8bmIOi07D4iMzixGl1UZndTzuYOrG+qhWlnDVF8Ho9rhsXx4Q== X-Received: by 10.223.131.132 with SMTP id 4mr8642502wre.217.1513790139484; Wed, 20 Dec 2017 09:15:39 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 20 Dec 2017 18:14:18 +0100 Message-Id: <1513790098-9815-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> References: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 06/46] scsi-block: Add share-rw option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Fam Zheng Scsi-block doesn't use the DEFINE_BLOCK_PROPERTIES() macro so it didn't gain the share-rw back when it was added to all other storage devices. This option is meaningful here, and need to be used when attaching a shared storage to guest. Signed-off-by: Fam Zheng Message-Id: <20171205071928.30242-1-famz@redhat.com> Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 870d9ae..e58833a 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -3004,6 +3004,7 @@ static const TypeInfo scsi_cd_info =3D { static Property scsi_block_properties[] =3D { DEFINE_BLOCK_ERROR_PROPERTIES(SCSIDiskState, qdev.conf), \ DEFINE_PROP_DRIVE("drive", SCSIDiskState, qdev.conf.blk), + DEFINE_PROP_BOOL("share-rw", SCSIDiskState, qdev.conf.share_rw, false), DEFINE_PROP_UINT16("rotation_rate", SCSIDiskState, rotation_rate, 0), DEFINE_PROP_END_OF_LIST(), }; --=20 1.8.3.1