From nobody Mon Feb 9 19:07:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513791524179715.9165579206991; Wed, 20 Dec 2017 09:38:44 -0800 (PST) Received: from localhost ([::1]:60503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRiK2-0006ra-VQ for importer@patchew.org; Wed, 20 Dec 2017 12:38:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRhye-0004wW-Uu for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:16:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRhye-0007Nn-0N for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:16:20 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:41770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRhyd-0007NS-Oy for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:16:19 -0500 Received: by mail-wm0-x242.google.com with SMTP id g75so11359434wme.0 for ; Wed, 20 Dec 2017 09:16:19 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id f125sm2751101wme.45.2017.12.20.09.16.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 09:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aFdL1TzJVew9BReY5PGjblOK0Vqr7SjxVR9xzjDH1mc=; b=LPD/MPCgR2HbF+/tyCSwtCJDeez9rywbbn9ZMbWbPWmM+XhNjDHGAUIxGoATH3ltkU VbbMezBE/ycjzgQDxazSiuvjSXYiyRGoQ9fpHe1WC3k1VATI6jVtWy9xPA3aWm4jNkny yzU6whAXLcW4P3p2KLkr8wYTQU4S59xKjjeDOz9qY/K77AWQjxEAzywr+rcotmV5xZXS nol6q/bk/hwP5wxh6Zlu7Dz4+IHRkAIxJbqqqTrOolifozm0AaKpvpQRVaRhVWnWdDJd WlyyzU65aY8c0PdbabdSVQxh2KqGy6DZHIJSYQmWiMX8F1zw60j8f3jyixfmRK4phw0X BLEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aFdL1TzJVew9BReY5PGjblOK0Vqr7SjxVR9xzjDH1mc=; b=Pb1mjZFdo+1jm10K2GTuFzSD+ZPGDfIBsLpWwXUUXt+McJNFG76A3eScbRRvvq3aHx okPnjYPkmk7kx1PCPFvNAu64pUpK/1+x3m3oZNImRuDKEQP84bEHanG3NeejnnxYy1Qg 8vXHYugIOXaF4B5SsxLCbaSQiiMdxsFX2V+6dwcPzXnp2RHQXmsQc2A2XpVRGyC6eTaS g/taXfmOw+CcasYK/7YAnM7ipCqv8j/U7sU0tpIXyLQP/CQvjr7U96eko+0SGgUhHctg t2hw5Wvp9fpUDJbnKESiU3L6jMN35bOvE4Acq3IL+2BzfIYzkN9Fp7obp1UMDguNMiag bORA== X-Gm-Message-State: AKGB3mI5vKHLRRJdNJ8sdWnHzsysYv49M7MIYJrQIbyoGLYRvjlZhd+c /sOYL79H6P5aJjv+7cGDo1YfdK0F X-Google-Smtp-Source: ACJfBosrUhATAX3S40+EYReOHISzGC99PHLnb+s4fPeEcrYRis3udFPe0J3D7DVlyAGV1wAvg0RXpQ== X-Received: by 10.28.30.213 with SMTP id e204mr6969505wme.40.1513790178521; Wed, 20 Dec 2017 09:16:18 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 20 Dec 2017 18:14:52 +0100 Message-Id: <1513790098-9815-41-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> References: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 40/46] checkpatch: volatile with a comment or sig_atomic_t is okay X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau This assumes that the comment gives some justification; "volatile sig_atomic_t" is also self-explanatory and usually correct. Discussed in: '[Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without = a process to debug"' Suggested-by: Fam Zheng Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20171215181810.4122-1-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 34df753..3dc27d9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2475,8 +2475,11 @@ sub process { =20 # no volatiles please my $asm_volatile =3D qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; - if ($line =3D~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { - ERROR("Use of volatile is usually wrong: see Documentation/volatile-con= sidered-harmful.txt\n" . $herecurr); + if ($line =3D~ /\bvolatile\b/ && $line !~ /$asm_volatile/ && + $line !~ /sig_atomic_t/ && + !ctx_has_comment($first_line, $linenr)) { + my $msg =3D "Use of volatile is usually wrong, please add a comment\n" = . $herecurr; + ERROR($msg); } =20 # warn about #if 0 --=20 1.8.3.1