From nobody Mon Feb 9 22:39:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513790639561659.0063874488725; Wed, 20 Dec 2017 09:23:59 -0800 (PST) Received: from localhost ([::1]:60368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRi5v-0002L7-9n for importer@patchew.org; Wed, 20 Dec 2017 12:23:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRhy8-0004OX-1R for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRhy7-000778-2a for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:48 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:44480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRhy6-00076Z-Q5 for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:46 -0500 Received: by mail-wm0-x243.google.com with SMTP id t8so11240968wmc.3 for ; Wed, 20 Dec 2017 09:15:46 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id f125sm2751101wme.45.2017.12.20.09.15.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 09:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9OB5Er0I9bZluXtDgSIF/pi2giQ9tMbfzNQOIaJ/0K8=; b=kyrp4JPIZSJKp2Z9rEt+FsMPe2S3Ec2PWylQZR57hkU/AfYt6jo0bVOQmyX0N24vIg Yj6DCr6+X8YTZwTgHqUeLDhHGNJqOMMrHLdMNIbVd0KGTcxy0GLirBw49aa1Gm/w1Tof Zt3aJxnS6kbWkj8/AEKvob2yHBcqgUBBAw0X3Zluvfirf/rao/FE+P5UC7mcKt9h6IaP bI/kJsLrEbusX6f6+ZaOTKPHzZ3OgvqhB8k9EfE/myDgqtHHcmNc2tLOr9xV4jPuZ2Vj uKap0IpGMZSyJjw5Pd05PnYLPIoaPwNJIGNtX1li1iy7rBmfaaXWUVbVo67LQltTmO8T haIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=9OB5Er0I9bZluXtDgSIF/pi2giQ9tMbfzNQOIaJ/0K8=; b=FV2F9h0iywucLlneyhy5bdMQgmbhSDlf+vGYvPBZtCiZuKg+tIEsb7x1k9pHqUDFDY yxdFDCC1ccbUGT6Sj2ct9NKA/E+RmSojd1H2a6aL/42VyhPtp8FZzF1wP/OWzW0Sv+uJ uMdlasZ1dSuxpWgxmTONc0LA4Ad/neMo619kxQB+J9w0wIeNl0nF0+Pyf+1FB8daW2Dp oxCXUeoQlKUvEznc7t7xmsGFDCWyE7SNOppEy4BWLsmWcnl2P8JNdhPOsI64YrAnYW1r 9htd5siUC+ThhdNpDDj0iXSy+vBCS/LqKBM84To7dZIrToRv6pHxjIOWolMMsFCTqIOT x02w== X-Gm-Message-State: AKGB3mKJQOLdCQMEd1hkPBi7gPtKPRxn0vQacpvvW+JeBFTnQSjhX1Rd oxUHEXkp5AHwht1BdqGH5QQHgVA7 X-Google-Smtp-Source: ACJfBosIm/nrAEUg51sSCdjMHDOe1tz3JTqtWIoxbrkqYxhUWrtOBrM8y8H7y1iduzOGd1j3Qvkobw== X-Received: by 10.28.19.195 with SMTP id 186mr7133419wmt.20.1513790145496; Wed, 20 Dec 2017 09:15:45 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 20 Dec 2017 18:14:23 +0100 Message-Id: <1513790098-9815-12-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> References: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 11/46] hyperv: make SynIC version msr constant X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Kagan Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Roman Kagan The value of HV_X64_MSR_SVERSION is initialized once at vcpu init, and is reset to zero on vcpu reset, which is wrong. It is supposed to be a constant, so drop the field from X86CPU, set the msr with the constant value, and don't bother getting it. Signed-off-by: Roman Kagan Message-Id: <20171122181418.14180-4-rkagan@virtuozzo.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.h | 1 - target/i386/kvm.c | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 17f1bb7..d605cc6 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1107,7 +1107,6 @@ typedef struct CPUX86State { uint64_t msr_hv_crash_params[HV_CRASH_PARAMS]; uint64_t msr_hv_runtime; uint64_t msr_hv_synic_control; - uint64_t msr_hv_synic_version; uint64_t msr_hv_synic_evt_page; uint64_t msr_hv_synic_msg_page; uint64_t msr_hv_synic_sint[HV_SINT_COUNT]; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 5d93391..351b64f 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -669,7 +669,6 @@ static int hyperv_handle_properties(CPUState *cs) } =20 env->features[FEAT_HYPERV_EAX] |=3D HV_SYNIC_AVAILABLE; - env->msr_hv_synic_version =3D HV_SYNIC_VERSION; } if (cpu->hyperv_stimer) { if (!has_msr_hv_stimer) { @@ -1715,10 +1714,10 @@ static int kvm_put_msrs(X86CPU *cpu, int level) if (cpu->hyperv_synic) { int j; =20 + kvm_msr_entry_add(cpu, HV_X64_MSR_SVERSION, HV_SYNIC_VERSION); + kvm_msr_entry_add(cpu, HV_X64_MSR_SCONTROL, env->msr_hv_synic_control); - kvm_msr_entry_add(cpu, HV_X64_MSR_SVERSION, - env->msr_hv_synic_version); kvm_msr_entry_add(cpu, HV_X64_MSR_SIEFP, env->msr_hv_synic_evt_page); kvm_msr_entry_add(cpu, HV_X64_MSR_SIMP, @@ -2082,7 +2081,6 @@ static int kvm_get_msrs(X86CPU *cpu) uint32_t msr; =20 kvm_msr_entry_add(cpu, HV_X64_MSR_SCONTROL, 0); - kvm_msr_entry_add(cpu, HV_X64_MSR_SVERSION, 0); kvm_msr_entry_add(cpu, HV_X64_MSR_SIEFP, 0); kvm_msr_entry_add(cpu, HV_X64_MSR_SIMP, 0); for (msr =3D HV_X64_MSR_SINT0; msr <=3D HV_X64_MSR_SINT15; msr++) { @@ -2286,9 +2284,6 @@ static int kvm_get_msrs(X86CPU *cpu) case HV_X64_MSR_SCONTROL: env->msr_hv_synic_control =3D msrs[i].data; break; - case HV_X64_MSR_SVERSION: - env->msr_hv_synic_version =3D msrs[i].data; - break; case HV_X64_MSR_SIEFP: env->msr_hv_synic_evt_page =3D msrs[i].data; break; --=20 1.8.3.1