From nobody Tue Feb 10 00:22:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513791028823838.8278035817827; Wed, 20 Dec 2017 09:30:28 -0800 (PST) Received: from localhost ([::1]:60406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRiCC-00005D-KB for importer@patchew.org; Wed, 20 Dec 2017 12:30:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRhy6-0004NA-Vu for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRhy5-00076K-W3 for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:46 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:40597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRhy5-00075V-O2 for qemu-devel@nongnu.org; Wed, 20 Dec 2017 12:15:45 -0500 Received: by mail-wm0-x242.google.com with SMTP id f206so11067847wmf.5 for ; Wed, 20 Dec 2017 09:15:45 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id f125sm2751101wme.45.2017.12.20.09.15.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 09:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=hp6H6xLXrewt/aU0u4d0Z6OgmBUIdDmHp+7nkyFNBp8=; b=HGRl+30NUCNWsfv2SAcavFBdf2LGsr16ObBAAXjoWHMqZQ3hu5FOZBYJsc7WnUxTdC WWAApqgUP4avAzhYI3D5JKgZLQP7mHI+FDRQoXiRYfsjIgQSIBx6WXCOPDKjbaKPFRFP 6X9o1n5DM4apazWOFmxLm5p4uRlkiZlToI6dlSijuwtZXpP3gNKMr5HsMSewVPsG3AhA mhAkplbjNbCSYnxfxVTojFCtTIRr+URdYPc/I3m1CPrd1AqCCaexWnlkv0T7aS9NBrMJ wXnkA8/X7IinUiIoSG8OUBdOaxWZM+lbHb34UO4FsyOD/YMlTVz3r7ghBUJ05Nekv9+G Rrig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=hp6H6xLXrewt/aU0u4d0Z6OgmBUIdDmHp+7nkyFNBp8=; b=LXC6qCL7P7WsPx4JCvAydElDo8n91U9bjPiSN2ZD4M+6tBhg9WbjArlpRm2gruoJ5a y+Z56Z4wGPIwbCpEdIYWS8nAOd9OcPWs84n0QwOR50bKF1IctEryGLewWRvc7++XHaqW yWgHAbTSEb4yVqHxkiEtR/KsOwTFnN4/m0HRaAGPuPcEZKUSGhuNAqiRckCCKIITMt3h cNT3BJbpKFUu+goLBNPdFKUiT/veqYaiO+1IsVIzGCu5ZYVEgChzCf3105mYUGfaWcoM 09LZ6RxsC7RxtrBtED0OKHQeYVcI/d63QBI2cR5GBAxr0H/y7uC6kN8CEvDGZY6ekiBm u8vA== X-Gm-Message-State: AKGB3mIdDGHFFr0F7AFnVql4FlvVk15s6wjcGzl9MBZ68v4iSvwKFSeQ USGLFDIbvxTc1TfFZuo+z3VEQCrR X-Google-Smtp-Source: ACJfBovCd2UU3f3IUinLVH5iD4v3cmdyfdZ1yd9g0MWa1YQu9d5FYuW2RUW92Uvc6DOq8FK/vO+9Pw== X-Received: by 10.28.149.203 with SMTP id x194mr7314699wmd.145.1513790144369; Wed, 20 Dec 2017 09:15:44 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 20 Dec 2017 18:14:22 +0100 Message-Id: <1513790098-9815-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> References: <1513790098-9815-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 10/46] hyperv: ensure SINTx msrs are reset properly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Kagan Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Roman Kagan Initially SINTx msrs should be in "masked" state. To ensure that happens on *every* reset, move setting their values to kvm_arch_vcpu_reset. Signed-off-by: Roman Kagan Message-Id: <20171122181418.14180-3-rkagan@virtuozzo.com> Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 89fa65e..5d93391 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -662,8 +662,6 @@ static int hyperv_handle_properties(CPUState *cs) env->features[FEAT_HYPERV_EAX] |=3D HV_VP_RUNTIME_AVAILABLE; } if (cpu->hyperv_synic) { - int sint; - if (!has_msr_hv_synic || kvm_vcpu_enable_cap(cs, KVM_CAP_HYPERV_SYNIC, 0)) { fprintf(stderr, "Hyper-V SynIC is not supported by kernel\n"); @@ -672,9 +670,6 @@ static int hyperv_handle_properties(CPUState *cs) =20 env->features[FEAT_HYPERV_EAX] |=3D HV_SYNIC_AVAILABLE; env->msr_hv_synic_version =3D HV_SYNIC_VERSION; - for (sint =3D 0; sint < ARRAY_SIZE(env->msr_hv_synic_sint); sint++= ) { - env->msr_hv_synic_sint[sint] =3D HV_SINT_MASKED; - } } if (cpu->hyperv_stimer) { if (!has_msr_hv_stimer) { @@ -1053,6 +1048,13 @@ void kvm_arch_reset_vcpu(X86CPU *cpu) } else { env->mp_state =3D KVM_MP_STATE_RUNNABLE; } + + if (cpu->hyperv_synic) { + int i; + for (i =3D 0; i < ARRAY_SIZE(env->msr_hv_synic_sint); i++) { + env->msr_hv_synic_sint[i] =3D HV_SINT_MASKED; + } + } } =20 void kvm_arch_do_init_vcpu(X86CPU *cpu) --=20 1.8.3.1