From nobody Thu May 9 01:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513700368585829.1107120955542; Tue, 19 Dec 2017 08:19:28 -0800 (PST) Received: from localhost ([::1]:52574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKby-0003GJ-FG for importer@patchew.org; Tue, 19 Dec 2017 11:19:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKaI-0002Hc-Kt for qemu-devel@nongnu.org; Tue, 19 Dec 2017 11:17:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKaH-00046t-PK for qemu-devel@nongnu.org; Tue, 19 Dec 2017 11:17:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56791) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRKaH-00046M-Ja; Tue, 19 Dec 2017 11:17:37 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 975122DACD8; Tue, 19 Dec 2017 16:17:36 +0000 (UTC) Received: from thh440s.str.redhat.com (dhcp-192-189.str.redhat.com [10.33.192.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD98018667; Tue, 19 Dec 2017 16:17:33 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Date: Tue, 19 Dec 2017 17:17:33 +0100 Message-Id: <1513700253-10045-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 19 Dec 2017 16:17:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Markus Armbruster , "Dr. David Alan Gilbert" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The "default" parameter of the "-mon" option is useless since QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That should have been long enough to let people update their scripts, so time to remove it now. Signed-off-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert --- monitor.c | 3 --- qemu-doc.texi | 9 --------- vl.c | 4 ---- 3 files changed, 16 deletions(-) diff --git a/monitor.c b/monitor.c index e36fb53..e53c6e1 100644 --- a/monitor.c +++ b/monitor.c @@ -4141,9 +4141,6 @@ QemuOptsList qemu_mon_opts =3D { .name =3D "chardev", .type =3D QEMU_OPT_STRING, },{ - .name =3D "default", /* deprecated */ - .type =3D QEMU_OPT_BOOL, - },{ .name =3D "pretty", .type =3D QEMU_OPT_BOOL, }, diff --git a/qemu-doc.texi b/qemu-doc.texi index d9861b3..6913b32 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -2401,15 +2401,6 @@ setting ``-machine kernel_irqchip=3Doff''. The ``-no-kvm'' argument is now a synonym for setting ``-machine accel=3Dtcg''. =20 -@subsection -mon default=3Don (since 2.4.0) - -The ``default'' option to the ``-mon'' argument is -now ignored. When multiple monitors were enabled, it -indicated which monitor would receive log messages -from the various subsystems. This feature is no longer -required as messages are now only sent to the monitor -in response to explicitly monitor commands. - @subsection -vnc tls (since 2.5.0) =20 The ``-vnc tls'' argument is now a synonym for setting diff --git a/vl.c b/vl.c index 2644400..4e7a7e4 100644 --- a/vl.c +++ b/vl.c @@ -2438,10 +2438,6 @@ static int mon_init_func(void *opaque, QemuOpts *opt= s, Error **errp) if (qemu_opt_get_bool(opts, "pretty", 0)) flags |=3D MONITOR_USE_PRETTY; =20 - if (qemu_opt_get_bool(opts, "default", 0)) { - error_report("option 'default' does nothing and is deprecated"); - } - chardev =3D qemu_opt_get(opts, "chardev"); chr =3D qemu_chr_find(chardev); if (chr =3D=3D NULL) { --=20 1.8.3.1