From nobody Tue Feb 10 16:57:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512683427201509.6535204305444; Thu, 7 Dec 2017 13:50:27 -0800 (PST) Received: from localhost ([::1]:34510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN43b-0006oO-Gv for importer@patchew.org; Thu, 07 Dec 2017 16:50:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN402-000426-7K for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:46:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN401-0006QJ-7M for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:46:34 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:38375) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN401-0006P2-0a for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:46:33 -0500 Received: by mail-pf0-x244.google.com with SMTP id u25so5674745pfg.5 for ; Thu, 07 Dec 2017 13:46:32 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id j62sm8796887pgc.35.2017.12.07.13.46.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:46:29 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 4A734DF0; Thu, 7 Dec 2017 15:46:25 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 367DE300092; Thu, 7 Dec 2017 15:46:23 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3lo9mOd7Qe/S5grO0QCpk+ZWH8dtXaq/JBE7TcbML0k=; b=M43Golz6DzC6On2kLpuoNBkRQuvzW2RGHlSicxd3Z+8YSqf5YJAtyyv3j/LNIvg5Ra USCQF4ItoPajhS7WtyezxRs2Wz5NaXYR80GEjnv7R9SoW+WLD/EOcd99UJcR/AbYtYne AI/2YSpeXH2ea5GfQwioJMR7QW2kFmuM0lEjCxQEO/eZ1hEkfCABxSLuVYZZYahBYZFL S68LJVnTmghPpyIOtvl9Oto6xe2CbHKZ/sOrxXZtvcuG7u33lSGqHwnQbcRx8YgwtPsr rweddtdiVbnqB4eF7iB0QZilw66wZiH78SMYHlOko91Rkxzy/cBqtgeZ/xx4qtWsxMYd +JTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3lo9mOd7Qe/S5grO0QCpk+ZWH8dtXaq/JBE7TcbML0k=; b=hSlGAIuvNzt5+HyOjvax21dpc+xWW8qOqPr2MZllCYsBoSsTLjjAPO6YFHQZrC6tn9 zVAEbnw4tT7tCdwfC3EL1IgxJcq/v8bUGFp65sRcdJwPfPeCokLWb1IOa2UQTX9gqSrP SlGoJExEJf8rF6nozGwEpdop7/3lYLytw3CCl4+dVDVxx3KdDD+OLqRzWGSzMB0n6LYY 55mgmh81ymdYVHIfrW3MHXIXVIhbI5JJNnqTzaT8JxxVXoaOUiXa8GZ2bUQntm40tCWI st2W+hc2x6fOhPeybOMb4hY5TouDha7ZOa99LWYLbnnsJHCmeo9WUVmL5nJnzF2ZUKAp oJHA== X-Gm-Message-State: AJaThX4vXiZNF+2s1WfHssHfDB4jUmEm2uv3gAN5TijVIrt2svOhU4Y2 gJBTLdrLtLbltxa0Et56wteh8KM= X-Google-Smtp-Source: AGs4zMYMYZWuzb0T/IH4a4gIUB/q4OZCtmcKwbmcleXIg1uBo2ipKJw8hK841AyqkocBQAXGYwjDBw== X-Received: by 10.99.112.89 with SMTP id a25mr26601135pgn.2.1512683191910; Thu, 07 Dec 2017 13:46:31 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:46:13 -0600 Message-Id: <1512683181-8420-7-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512683181-8420-1-git-send-email-minyard@acm.org> References: <1512683181-8420-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH 06/14] i2c:pm_smbus: Add interrupt handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Paolo Bonzini , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Add the necessary code so that interrupts actually work from the pm_smbus device. Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Paolo Bonzini --- hw/i2c/pm_smbus.c | 14 +++++++++++++- hw/i2c/smbus_ich9.c | 17 +++++++++++++++++ include/hw/i2c/pm_smbus.h | 2 ++ 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index eb2df4d..2fb00d0 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -205,6 +205,12 @@ error: return; } =20 +static bool +smb_irq_value(PMSMBus *s) +{ + return ((s->smb_stat & ~STS_HOST_BUSY) !=3D 0) && (s->smb_ctl & CTL_IN= TREN); +} + static void smb_ioport_writeb(void *opaque, hwaddr addr, uint64_t val, unsigned width) { @@ -300,7 +306,9 @@ static void smb_ioport_writeb(void *opaque, hwaddr addr= , uint64_t val, } =20 out: - return; + if (s->set_irq) { + s->set_irq(s, smb_irq_value(s)); + } } =20 static uint64_t smb_ioport_readb(void *opaque, hwaddr addr, unsigned width) @@ -352,6 +360,10 @@ static uint64_t smb_ioport_readb(void *opaque, hwaddr = addr, unsigned width) SMBUS_DPRINTF("SMB readb port=3D0x%04" HWADDR_PRIx " val=3D0x%02x\n", addr, val); =20 + if (s->set_irq) { + s->set_irq(s, smb_irq_value(s)); + } + return val; } =20 diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index 706b9ec..d029816 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -41,6 +41,8 @@ typedef struct ICH9SMBState { PCIDevice dev; =20 + bool irq_enabled; + PMSMBus smb; } ICH9SMBState; =20 @@ -50,6 +52,7 @@ static const VMStateDescription vmstate_ich9_smbus =3D { .minimum_version_id =3D 1, .fields =3D (VMStateField[]) { VMSTATE_PCI_DEVICE(dev, ICH9SMBState), + VMSTATE_BOOL(irq_enabled, ICH9SMBState), VMSTATE_STRUCT(smb, ICH9SMBState, 1, pmsmb_vmstate, PMSMBus), VMSTATE_END_OF_LIST() } @@ -111,11 +114,25 @@ static void ich9_smb_class_init(ObjectClass *klass, v= oid *data) dc->user_creatable =3D false; } =20 +static void ich9_smb_set_irq(PMSMBus *pmsmb, bool enabled) +{ + ICH9SMBState *s =3D pmsmb->opaque; + + if (enabled =3D=3D s->irq_enabled) { + return; + } + + s->irq_enabled =3D enabled; + pci_set_irq(&s->dev, enabled); +} + I2CBus *ich9_smb_init(PCIBus *bus, int devfn, uint32_t smb_io_base) { PCIDevice *d =3D pci_create_simple_multifunction(bus, devfn, true, TYPE_ICH9_SMB_DE= VICE); ICH9SMBState *s =3D ICH9_SMB_DEVICE(d); + s->smb.set_irq =3D ich9_smb_set_irq; + s->smb.opaque =3D s; return s->smb.smbus; } =20 diff --git a/include/hw/i2c/pm_smbus.h b/include/hw/i2c/pm_smbus.h index b1e1970..cfe596f 100644 --- a/include/hw/i2c/pm_smbus.h +++ b/include/hw/i2c/pm_smbus.h @@ -23,6 +23,8 @@ typedef struct PMSMBus { =20 /* Set by the user. */ bool i2c_enable; + void (*set_irq)(struct PMSMBus *s, bool enabled); + void *opaque; =20 /* Internally used by pm_smbus. */ =20 --=20 2.7.4