From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682516491422.51020867477223; Thu, 7 Dec 2017 13:35:16 -0800 (PST) Received: from localhost ([::1]:34422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3ov-0001aa-3G for importer@patchew.org; Thu, 07 Dec 2017 16:35:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kS-0005YV-Ob for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kO-0001uV-Eb for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:27 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:37619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kO-0001tP-85 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:24 -0500 Received: by mail-pf0-x243.google.com with SMTP id n6so5653091pfa.4 for ; Thu, 07 Dec 2017 13:30:24 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id k80sm12678231pfh.30.2017.12.07.13.30.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:22 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 09DAB96; Thu, 7 Dec 2017 15:30:19 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id A787430007F; Thu, 7 Dec 2017 15:30:17 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WTeBqdQtfRYcWqJwQfs3vBs8+Sgu29U16AqBLX3IgL8=; b=JM6cl0TyX0niGQoWXZaEibpniA5XEaKtzdjXv1E+cXKQPvy7YAL/oDwH6rvJISKvm5 NeQ+wFIwdWLBZCvxLS9+q5kscwyad9L8ZLMKuaKbHR1/rDl/LLWb4ckeLQdL1iPAcl8I X2RG2AeFh4nJx8R9kT/PWGRD6H7aFFxyhrIGaV5pQnF942zyC0V3Rgw86vRUqzLQ3QEi ZKGty75rslsOo/O08VVaoTh4rRvRTClgHFlTlIwW0t0cgRoDthUDwy836YtI/pY1nHNK 60Q3I/gE+IHIIQc3T3wBjq3Amopgf9lve9iVC0A5cG7/Gs+sI8Zy0nOv+f5lrn6FEbZ5 /LYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WTeBqdQtfRYcWqJwQfs3vBs8+Sgu29U16AqBLX3IgL8=; b=U7oLmWVdjJkUTFZN8DxqIUrgpOVHDaxeGSeN06zEG2EWjmG7LDtZ/2q2Yh2UBWaaXs lxMZs9xmCbi3AEfLVoMAQgmNaGIeFRkRH43Khe7bWXbH6rMM28q9AHEVjV1mFNGtMOsp cqilOmkzaiaxKtIoTMX/J3jWQyHWMhCFTpkJuni4qfMT9wdtNnKKVw+GEOHlaLSqX45O KoQ3g5shZaksRgEEmzyjYPIsKk1TVnxQca4q14tWpyc4wFFE128gBoEmbiFfD1WIQMVL zeGIH/o6TUPaXu/2xIiQMJn6wLv3CPsyq44QYRnW1iPDLK8/BvG2VK30y6eyzG8xUiHI gVSw== X-Gm-Message-State: AJaThX6ORSOrNZHROCiMJYT4mu8Mb40eFGrNvsl+6tw0VGbYYSh/8rNk oWkNO6osaLfJ6k0HeBaSbA== X-Google-Smtp-Source: AGs4zMZbCxkR29OyK0htWJ2YhP7ITAIQmB1XWvfGyoj1W/d4IUxiXoQtdvNGQf1nuHuBtVJ7OemhxQ== X-Received: by 10.84.133.111 with SMTP id 102mr27485178plf.136.1512682223080; Thu, 07 Dec 2017 13:30:23 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:06 -0600 Message-Id: <1512682213-4354-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Corey Minyard The minimum message size was on the wrong commands, for getting the time it's zero and for setting the time it's 6. Signed-off-by: Corey Minyard Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi_bmc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 277c28c..cc068f2 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1802,8 +1802,8 @@ static const IPMICmdHandler storage_cmds[] =3D { [IPMI_CMD_GET_SEL_ENTRY] =3D { get_sel_entry, 8 }, [IPMI_CMD_ADD_SEL_ENTRY] =3D { add_sel_entry, 18 }, [IPMI_CMD_CLEAR_SEL] =3D { clear_sel, 8 }, - [IPMI_CMD_GET_SEL_TIME] =3D { get_sel_time, 6 }, - [IPMI_CMD_SET_SEL_TIME] =3D { set_sel_time }, + [IPMI_CMD_GET_SEL_TIME] =3D { get_sel_time }, + [IPMI_CMD_SET_SEL_TIME] =3D { set_sel_time, 6 }, }; =20 static const IPMINetfn storage_netfn =3D { --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682361552505.21070470655604; Thu, 7 Dec 2017 13:32:41 -0800 (PST) Received: from localhost ([::1]:34409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3mW-0006hn-6V for importer@patchew.org; Thu, 07 Dec 2017 16:32:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kS-0005YW-OZ for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kQ-0001w4-IM for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:27 -0500 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:44678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kP-0001vK-TA for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:26 -0500 Received: by mail-pg0-x243.google.com with SMTP id j9so5352150pgc.11 for ; Thu, 07 Dec 2017 13:30:25 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id o184sm9349744pga.3.2017.12.07.13.30.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:23 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id A7F42B76; Thu, 7 Dec 2017 15:30:20 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 89B71302366; Thu, 7 Dec 2017 15:30:17 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xEV6SmV/vklWlR0FbWcQCRcVYfv2IMVPXqrDvll5yxI=; b=UXUEolZncxDn0BUGaWiGJEazVdhyzLRRERMw/C1HqucXd3LFJinv9N2+aPmO+NhEBe 6gtK0Gr183CY0WywSKh8IgU0gpi92zZSbkf567PDKQEavOwph7pM4uN1UGVICXUyDlZ4 9wIDtXxOUoaClfkUyFtQgyHmPZ5MoxwByOBvNBos1a+PDVwLnWuk16nz03yhypXwDgOU 1ZNi9lPOr5PVo8SPDdwwQLEt27MuXiNu6h5GLwpH1JQdMeCzeN5XAuAtsH0O/xT9Pw4I fptxwWLKmC2Ac3mYgY/ZQ0UK8TrsU6U83KQD/cqQDnyrUq1pTLTgZCuI9OznwtKqHXgI +KkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xEV6SmV/vklWlR0FbWcQCRcVYfv2IMVPXqrDvll5yxI=; b=LxBa8Dpbt2JCJpQyQkwDKad/xr0k7AZmwjPHdWgs7j3ZZu1+w09JBSPifIZewSJFjH aYAThEyrBRxPnrKI2xOX9emG9nLH4Ptdv6IMCRCWBc0YcnoOupQEZHopVGMHJ3w22j7q 4NxygBaZBT3RHoeQvPmHlkeoMbuShjO6Gm7IkLuJkGiI+apvDaqx9YGt/PC1dZgBwxPt PSPzabhhk4/tMN9lJhnaZm9gXv6haXt7UTZUee91YiprJ+QuOOe2GtYP8uria/lNg9C0 ypMqLqlxQjpXW9DlPKkGefrMBdpz37NmsZ69Uw+e+EgJ3lUfaoZ5UDDiPW1eU0Q5Y5JC OMZA== X-Gm-Message-State: AJaThX5nQXTAkFBLhHDGiQw7026DUhIxGxOZ1mK4zz4e+jN4XHgzLcas A0LX1r050I/hZZouezJZVD4NJp0= X-Google-Smtp-Source: AGs4zMZLEPzSrfchLGmoeAh2tohKCpkUm6LpBxW8RseShxN3Fwaqa+jc6nXuERggOMUt0hS9lld3cQ== X-Received: by 10.99.121.4 with SMTP id u4mr27365483pgc.235.1512682224805; Thu, 07 Dec 2017 13:30:24 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:07 -0600 Message-Id: <1512682213-4354-3-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PATCH 2/8] ipmi: Don't set the timestamp on add events that don't have it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Corey Minyard According to the spec, from section "32.3 OEM SEL Record - Type E0h-FFh", event types from 0x0e to 0xff do not have a timestamp. So don't set it when adding those types. This required putting the timestamp in a temporary buffer, since it's still required to set the last addition time. Signed-off-by: Corey Minyard Reviewed-by: C=C3=A9dric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index cc068f2..a0bbfd5 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -443,16 +443,21 @@ static void sel_inc_reservation(IPMISel *sel) /* Returns 1 if the SEL is full and can't hold the event. */ static int sel_add_event(IPMIBmcSim *ibs, uint8_t *event) { + uint8_t ts[4]; + event[0] =3D 0xff; event[1] =3D 0xff; - set_timestamp(ibs, event + 3); + set_timestamp(ibs, ts); + if (event[2] < 0xe0) { /* Don't set timestamps for type 0xe0-0xff. */ + memcpy(event + 3, ts, 4); + } if (ibs->sel.next_free =3D=3D MAX_SEL_SIZE) { ibs->sel.overflow =3D 1; return 1; } event[0] =3D ibs->sel.next_free & 0xff; event[1] =3D (ibs->sel.next_free >> 8) & 0xff; - memcpy(ibs->sel.last_addition, event + 3, 4); + memcpy(ibs->sel.last_addition, ts, 4); memcpy(ibs->sel.sel[ibs->sel.next_free], event, 16); ibs->sel.next_free++; sel_inc_reservation(&ibs->sel); --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682365078231.92724801071427; Thu, 7 Dec 2017 13:32:45 -0800 (PST) Received: from localhost ([::1]:34411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3mY-0006ke-Kf for importer@patchew.org; Thu, 07 Dec 2017 16:32:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kU-0005ZW-PL for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kT-0001yf-Ol for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:30 -0500 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:40948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kT-0001xq-GD for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: by mail-pf0-x241.google.com with SMTP id v26so5642460pfl.7 for ; Thu, 07 Dec 2017 13:30:29 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id y79sm10362139pfb.113.2017.12.07.13.30.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:26 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 65B8BDF0; Thu, 7 Dec 2017 15:30:21 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id BCE9030007E; Thu, 7 Dec 2017 15:30:17 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=789edMDauOWZHbsNILLacYVL9cPRbrYiExCSkLdLCNY=; b=HwPT+OthMbjNo3511agb2NJ/abeg2ChdcBgJsAWSEHFekJZlGat8+2+7xA4zdx5tK1 13U7EPC1ovuEdz6DnQhQfc4vUvixRBQrlazqIxI5NZieDWAsQLXM+nPdszDGHzKgEmdG bRoUkspIhABRZUw67OiFx5huLhG+oY1yijU6NYWyyuTBP08anF471vut4UwxUM9SnB+p 7czJeZwbfbYUIdQbElGaHL5bruuYBMMGCt1PU3dQrNJxtmNhnnokLUTuzsEohzkzxhwO IaOtKk5GdyXKVnbD2c0NpGLprkU3AsQiPAbREzyg/uZkx+Az4htVjg2Me6KJKmA2IEpr xwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=789edMDauOWZHbsNILLacYVL9cPRbrYiExCSkLdLCNY=; b=Vu8QqcZTb3RbXB4IEjkxZaWl4JnrEwrc4iUm7deA70AGK632O1y7iqbL290Ro/ZfnQ nyw4qcbVQZnsDsuPUaNFjSLweqvMHzuiu6kX+HyK5Y+iLo4iHe+fWhKOFFQ3pNqejJAt bOmMXY7Z6sxwuzx0p1B+CbnZwWcMsPzPFq9i8Kv8Oe7CjkZPTcMTY1Rd5cTADXXKvlei 2e4yxJm8rdqZJyfmzpzhWD8rdlhYT8xf+SHUp4TfTwkPtpHYSerXdJX9dsAfv7tbYCYK K2EOtexXdMcFUE4xAtUh96dVsNzMQWLwkmDNQIpdQSky6nrgMMhK15Jxyhfj3AdFDeep a6Vg== X-Gm-Message-State: AJaThX5WGqjmVVVoQuIKZuNWi/iQXMX4epan0kmendWqBPhdVqMSLCgo d7HUXZ2k9RE9dOaXjMzhgk72QOY= X-Google-Smtp-Source: AGs4zMa9TT0F21tZTRXUFcUilHgOb5QAA23Qz7ro504LfTzYwigjjuC+pZ5vSk8uDEiNjGDxCmFexQ== X-Received: by 10.101.77.201 with SMTP id q9mr26506669pgt.226.1512682228379; Thu, 07 Dec 2017 13:30:28 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:08 -0600 Message-Id: <1512682213-4354-4-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH 3/8] ipmi: Add the platform event message command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Corey Minyard This lets an event be added to the SEL as if a sensor had generated it. The OpenIPMI driver uses it for storing panic event information. Signed-off-by: Corey Minyard Reviewed-by: C=C3=A9dric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index a0bbfd5..e84d710 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -38,6 +38,7 @@ =20 #define IPMI_NETFN_SENSOR_EVENT 0x04 =20 +#define IPMI_CMD_PLATFORM_EVENT_MSG 0x02 #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a @@ -1581,6 +1582,28 @@ static void set_sel_time(IPMIBmcSim *ibs, ibs->sel.time_offset =3D now.tv_sec - ((long) val); } =20 +static void platform_event_msg(IPMIBmcSim *ibs, + uint8_t *cmd, unsigned int cmd_len, + RspBuffer *rsp) +{ + uint8_t event[16]; + + event[2] =3D 2; /* System event record */ + event[7] =3D cmd[2]; /* Generator ID */ + event[8] =3D 0; + event[9] =3D cmd[3]; /* EvMRev */ + event[10] =3D cmd[4]; /* Sensor type */ + event[11] =3D cmd[5]; /* Sensor number */ + event[12] =3D cmd[6]; /* Event dir / Event type */ + event[13] =3D cmd[7]; /* Event data 1 */ + event[14] =3D cmd[8]; /* Event data 2 */ + event[15] =3D cmd[9]; /* Event data 3 */ + + if (sel_add_event(ibs, event)) { + rsp_buffer_set_error(rsp, IPMI_CC_OUT_OF_SPACE); + } +} + static void set_sensor_evt_enable(IPMIBmcSim *ibs, uint8_t *cmd, unsigned int cmd_len, RspBuffer *rsp) @@ -1757,6 +1780,7 @@ static const IPMINetfn chassis_netfn =3D { }; =20 static const IPMICmdHandler sensor_event_cmds[] =3D { + [IPMI_CMD_PLATFORM_EVENT_MSG] =3D { platform_event_msg, 10 }, [IPMI_CMD_SET_SENSOR_EVT_ENABLE] =3D { set_sensor_evt_enable, 4 }, [IPMI_CMD_GET_SENSOR_EVT_ENABLE] =3D { get_sensor_evt_enable, 3 }, [IPMI_CMD_REARM_SENSOR_EVTS] =3D { rearm_sensor_evts, 4 }, --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682361708260.79647584626264; Thu, 7 Dec 2017 13:32:41 -0800 (PST) Received: from localhost ([::1]:34410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3mW-0006ic-0v for importer@patchew.org; Thu, 07 Dec 2017 16:32:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kS-0005YX-28 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kQ-0001wL-T0 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:28 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:32916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kQ-0001vq-M6 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:26 -0500 Received: by mail-pf0-x243.google.com with SMTP id y89so5652856pfk.0 for ; Thu, 07 Dec 2017 13:30:26 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id b6sm11067995pfe.57.2017.12.07.13.30.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:23 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 3D4B2BD7; Thu, 7 Dec 2017 15:30:21 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 4E86630000E; Thu, 7 Dec 2017 15:30:18 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=FPvbIQAJwDholvfOTmxL4gvQanZKI49FHyohI781HTI=; b=ZagYmN3aAolNkpqx5hAJ876JZmE5ZHPB+dXxnn+yqqLwwVx+eyAVe9rM6k3YMdekA7 VgLBbRIp1j2V8kTglFM3tSMVNaBejBKrtCzdLqOXpWn6gsu05aAwgZ+1JoRkBZOfgUwF /Kn6YoioVqZJalUMIKso2FT4uU4LKoHWquViHB88IwJYYATFefrFpe3T9EtbxgRqDKGc rA7kgeNrf6oXwhAUewTBSZy96cocmiAxM/FlSNOHWEKZvODZX8xphpXTAZjbYswkFv9M BXfGscPKdpUTgKegee4Lml32Acl0zbOgUBmVpBdUoZeeAXSLLE3LzC6h9UmTUdgeDyJ2 3gMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=FPvbIQAJwDholvfOTmxL4gvQanZKI49FHyohI781HTI=; b=akZuXZzGS2C7VYRMUwcecZDOAl5Ojf0eTMwz3WUJJOmFg/iWFY0dAtYuGC5lzy9eMd YucbNFXBkJSWNi/Bv4X69xdXL+lx9GEUYW+RuRQUDknANqS9Kg4S75fxoxEua6sJRhXp 0zOtVZhEmfqrd45nD1HOjE2zvLIi5DbiBAKvO9sjhVvC7oZpiLg0COXYErQqYWfrVttm 015/6MAn6R3k3GB+0eZmCGvUxRm3u8hL9Gc1pv7q903SDQifzwGxAUMyvPd8nItw1i7L YjkHkslSYHmLC87oRGBe1LDuUfi8AVLQshL0tXrv7kcTNoKTWIKkMnt9MrLgP0pFw8Dp o4aw== X-Gm-Message-State: AJaThX5qtV2oAESBWFoGXZEHQcwF2yOLOR/meKseOLr84z+hnuMFNlj6 BPwEPEQ+Cq76qa6VfsrXqQ== X-Google-Smtp-Source: AGs4zMZHsMMernkBzdXk3zAWUKhSse265kUKD2e0vA9qcRC1NByjOOrpMXIXM08kT7joni29NC6C4g== X-Received: by 10.99.97.200 with SMTP id v191mr25608159pgb.300.1512682225630; Thu, 07 Dec 2017 13:30:25 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:09 -0600 Message-Id: <1512682213-4354-5-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 4/8] ipmi: Fix macro issues X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. The macros were doing ((v) & 1) for a binary input, but that only works if v =3D=3D 0 or if v & 1. Changed to !!(v) so they work for all values. Remove some unused macros. Reported in https://bugs.launchpad.net/bugs/1651167 An audit of these changes found no semantic changes; this is just cleanups for proper style and to avoid a compiler warning. Signed-off-by: Corey Minyard Reviewed-by: Eric Blake --- hw/ipmi/isa_ipmi_bt.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 2fcc3d2..13a8c09 100644 --- a/hw/ipmi/isa_ipmi_bt.c +++ b/hw/ipmi/isa_ipmi_bt.c @@ -46,21 +46,21 @@ #define IPMI_BT_B2H_ATN_MASK (1 << IPMI_BT_B2H_ATN_BIT) #define IPMI_BT_GET_B2H_ATN(d) (((d) >> IPMI_BT_B2H_ATN_BIT) & 0x1) #define IPMI_BT_SET_B2H_ATN(d, v) ((d) =3D (((d) & ~IPMI_BT_B2H_ATN_MASK)= | \ - (((v) & 1) << IPMI_BT_B2H_ATN_BIT)= )) + (!!(v) << IPMI_BT_B2H_ATN_BIT))) =20 #define IPMI_BT_SMS_ATN_MASK (1 << IPMI_BT_SMS_ATN_BIT) #define IPMI_BT_GET_SMS_ATN(d) (((d) >> IPMI_BT_SMS_ATN_BIT) & 0x1) #define IPMI_BT_SET_SMS_ATN(d, v) ((d) =3D (((d) & ~IPMI_BT_SMS_ATN_MASK)= | \ - (((v) & 1) << IPMI_BT_SMS_ATN_BIT)= )) + (!!(v) << IPMI_BT_SMS_ATN_BIT))) =20 #define IPMI_BT_HBUSY_MASK (1 << IPMI_BT_HBUSY_BIT) #define IPMI_BT_GET_HBUSY(d) (((d) >> IPMI_BT_HBUSY_BIT) & 0x1) #define IPMI_BT_SET_HBUSY(d, v) ((d) =3D (((d) & ~IPMI_BT_HBUSY_MASK) |= \ - (((v) & 1) << IPMI_BT_HBUSY_BIT))) + (!!(v) << IPMI_BT_HBUSY_BIT))) =20 #define IPMI_BT_BBUSY_MASK (1 << IPMI_BT_BBUSY_BIT) #define IPMI_BT_SET_BBUSY(d, v) ((d) =3D (((d) & ~IPMI_BT_BBUSY_MASK) |= \ - (((v) & 1) << IPMI_BT_BBUSY_BIT))) + (!!(v) << IPMI_BT_BBUSY_BIT))) =20 =20 /* Mask register */ @@ -70,12 +70,12 @@ #define IPMI_BT_B2H_IRQ_EN_MASK (1 << IPMI_BT_B2H_IRQ_EN_BIT) #define IPMI_BT_GET_B2H_IRQ_EN(d) (((d) >> IPMI_BT_B2H_IRQ_EN_BIT) & 0x= 1) #define IPMI_BT_SET_B2H_IRQ_EN(d, v) ((d) =3D (((d) & ~IPMI_BT_B2H_IRQ_EN_= MASK) |\ - (((v) & 1) << IPMI_BT_B2H_IRQ_EN_B= IT))) + (!!(v) << IPMI_BT_B2H_IRQ_EN_BIT))) =20 #define IPMI_BT_B2H_IRQ_MASK (1 << IPMI_BT_B2H_IRQ_BIT) #define IPMI_BT_GET_B2H_IRQ(d) (((d) >> IPMI_BT_B2H_IRQ_BIT) & 0x1) #define IPMI_BT_SET_B2H_IRQ(d, v) ((d) =3D (((d) & ~IPMI_BT_B2H_IRQ_MAS= K) | \ - (((v) & 1) << IPMI_BT_B2H_IRQ_BIT)= )) + (!!(v) << IPMI_BT_B2H_IRQ_BIT))) =20 typedef struct IPMIBT { IPMIBmc *bmc; --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682353705363.8637253034219; Thu, 7 Dec 2017 13:32:33 -0800 (PST) Received: from localhost ([::1]:34408 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3mP-0006el-4V for importer@patchew.org; Thu, 07 Dec 2017 16:32:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kR-0005YU-RN for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kP-0001vE-4A for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:27 -0500 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:35133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kO-0001uS-UL for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:25 -0500 Received: by mail-pg0-x241.google.com with SMTP id q20so5367460pgv.2 for ; Thu, 07 Dec 2017 13:30:24 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id p126sm9195765pga.58.2017.12.07.13.30.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:22 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 36A5E8F4; Thu, 7 Dec 2017 15:30:20 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 753AF300092; Thu, 7 Dec 2017 15:30:18 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=rBynui1BWvAQbmQJGLXMHPfJKT8j+ILZ5vxFAoXOtimJn2nnUfLryVeiILgDsBGFg/ bDcdT3uQHzo0OoVCbPW9cbw6sIX8g4vkv9gv9F/DgD26/jQSgloJ4rYe6mEfy+liNjhb F3hqPKx1vqqkvyEzI72PICv3+9nY2fz9sJ+eMBEFQu+NR2psktPw7rW+6/4Ltqcfb1vS YtTDWxrtOMZXFNsxxHFh0RNLQMaflSuHkNoyLxKZsh+sZwzgndToQjmFKVClFP0m0wL6 bhFWxXKfVFvMJvVLPPchv3KhJZbVt2DDhBqyMEgW0zigIHT8b7wZsSQjvKYgSoMkSomY 9xsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=I0rVWIQIYWZEnr1eWkANhY+FGOHSx6Bbdwt5xGWMapKim9waHpc+iq55sY7t5vOhyX H0pLp0OFs7cLUrWyAEecy5Nit1gvvp0Sgt7B65aB8VoCZAkP5ad7k8uKIZBjYqZP93q0 S6giTspsWWAQwvElN/da44Z/MyaoMsRM8m9dAR6pSyoXXg+EuXMUL5PFhR8yOp5uRUs3 UQOyy/GgDP2QbQchRV4HADjodmC4BSj8aP7sqrDzAmY7LtnGjcbzwgd7EJERWov8KtfF l75p77jN5MAeskyxQXaIONO6P1+HrVLaUUq80xAV4Xdrlu+KQGE3uSVxMSN8S8JEmWZ0 2ZMg== X-Gm-Message-State: AKGB3mIYqmyP6Qyf1oDG4quFzLdVXe/kH+R3uXc4I4VRKDrXAYYbcHFT sAWkJHpeVnH/CwmnC028Mjs9psE= X-Google-Smtp-Source: AGs4zMaCBTzf1JCz+UHc7u55lbCvYPZw/tqmoRB3EMGvpUcW/pWqVApjQzlaV+rM7aJzgjbEPOrnjw== X-Received: by 10.84.235.139 with SMTP id p11mr5630340plk.391.1512682223831; Thu, 07 Dec 2017 13:30:23 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:10 -0600 Message-Id: <1512682213-4354-6-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Otherwise there's no way to clear them without an external command, and it could lock the OS in the VM if they were stuck. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bb..58ade79 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -424,6 +424,11 @@ static void chr_event(void *opaque, int event) return; } ibe->connected =3D false; + /* + * Don't hang the OS trying to handle the ATN bit, other end will + * resend on a reconnect. + */ + k->set_atn(s, 0, 0); if (ibe->waiting_rsp) { ibe->waiting_rsp =3D false; ibe->inbuf[1] =3D ibe->outbuf[1] | 0x04; --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682515918542.6295306843483; Thu, 7 Dec 2017 13:35:15 -0800 (PST) Received: from localhost ([::1]:34424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3oz-0001ev-HO for importer@patchew.org; Thu, 07 Dec 2017 16:35:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kV-0005aE-GX for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kU-0001zA-Ag for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:31 -0500 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:40636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kU-0001yK-3O for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:30 -0500 Received: by mail-pg0-x241.google.com with SMTP id k15so5361440pgr.7 for ; Thu, 07 Dec 2017 13:30:30 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id g9sm11584521pfk.0.2017.12.07.13.30.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:26 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 85D6FEE8; Thu, 7 Dec 2017 15:30:21 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 104B1302369; Thu, 7 Dec 2017 15:30:18 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=5+wWHqEUj1ugPkwebAYHCdGKbj4PXJLd76dY1MU+g2A=; b=fKSQ8nXcUL4es7Mp2U7IO3ycXAFeyZY4yUrcCcI/U9JXn3NSsgOUo8ub+NxzHsB3m9 sDMdR+rTZseuNi0gEy0ZKsgHWo0ONtCscKtGeGVjvNVgPL2tRgVLU7r9lX0cXNfo6WAg sJY2lRDwwPWQwmGNMAUsncc4EzkthB0bu2p6qUmBorw7u3e6hRpFBs/imeVqOc6xTiIr zokHylo0ne6FI4wp/OiDJEugQA05yAhxsuFIRhmKmG/Xzy/oNJiQdUrQ/g0hPqYWtCkc xvhHwTsN/KZ7XcGh3eShS0Cfw2POsQvjhDOo9qLa9Wlq8zkRnLVzqqhZUOOU95Ty9S9c cV2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=5+wWHqEUj1ugPkwebAYHCdGKbj4PXJLd76dY1MU+g2A=; b=a7MsPjwhz/zWlmVu7NCyvVRSC0Br/YlM3S+Pvh/c7+6/YPzmf/fn/y8z0S7i05/iHX QQE4GnKn0DkLFoUXCPzbJHLizm4zt+dKEyb8aEEs3PDyNMyz2If/rPoGVjhYwBHhWTAB wq8klwlb1VGGh0O+fWyCEYU81e5k5IHiqZx6c02HC65bqZ66szilRzz6+kjiUHPtW4Zy LMBozGUx8aDp5o0FInHDUmJlselCr3i3EZmSCF7cpJ0OioaIJgM1W0NnuxPaTi1ZRzGg Y0JPRTpmd2ydUTe07ZLEzC0g4vxfFDawAVBnVFQcCnKa9CRLgj3/PRPvnPlbmE+RM8Dm peLA== X-Gm-Message-State: AJaThX7s8BXSRPrIoDETK/AyS+sPYhnmWpJ0VcL250Vnc/wxhRqXyG0Y sScawLupi1iY3g7rvW3cpA== X-Google-Smtp-Source: AGs4zMZiwtmNkGPwg94f3ugYdBnpVP0td/FMxnwnPRb1AjLXO5P856Lr47iWNMp7vJ3WKUp3MvfPBw== X-Received: by 10.99.138.194 with SMTP id y185mr26394050pgd.290.1512682229080; Thu, 07 Dec 2017 13:30:29 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:11 -0600 Message-Id: <1512682213-4354-7-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Michael S. Tsirkin" Allowing arbitary file names on command line is setting us up for failure: future guests will look for a specific QEMU-specified name and will get confused finding a user file there. Signed-off-by: Michael S. Tsirkin [Change "warning" to "error" in the error report.] Signed-off-by: Corey Minyard --- vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 1ad1c04..fae9300 100644 --- a/vl.c +++ b/vl.c @@ -2400,8 +2400,9 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts,= Error **errp) return -1; } if (strncmp(name, "opt/", 4) !=3D 0) { - warn_report("externally provided fw_cfg item names " - "should be prefixed with \"opt/\""); + error_report("error: externally provided fw_cfg item names " + "should be prefixed with \"opt/\""); + return -1; } if (nonempty_str(str)) { size =3D strlen(str); /* NUL terminator NOT included in fw_cfg blo= b */ --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682653857675.0069583483171; Thu, 7 Dec 2017 13:37:33 -0800 (PST) Received: from localhost ([::1]:34440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3rF-0003TP-75 for importer@patchew.org; Thu, 07 Dec 2017 16:37:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kW-0005b5-Gk for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kV-000206-Ik for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:32 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:35336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kV-0001zJ-8f for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:31 -0500 Received: by mail-pf0-x244.google.com with SMTP id j124so5646359pfc.2 for ; Thu, 07 Dec 2017 13:30:31 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j79sm10998802pfe.129.2017.12.07.13.30.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:26 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 71BA5EB7; Thu, 7 Dec 2017 15:30:21 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 22C8B302367; Thu, 7 Dec 2017 15:30:18 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=903jbIjY5CaeOB9ZbI4Pqip2txlVQbIiiI0khfFZqp4=; b=nfVah41bhE4v93sa+DLMSRTge5TO3ug8GNic/Y7xSHbfP9L4b61zn42xir0qjr30YP T/rg/6PDQTS3vUpg/hlHUCOjgUg4Csp+XqcQp++2NSlK6NqvoPoxLmXuYf5e5GXDCuQS K/i4hdAZqqPcAbzoSDirS9uJlrki0fmjUwVkQkG29WikjcDBHr2VPw9fOZ4O6LGypRUB Pnc3yJ9Hru4T7B94m/hlcl5bV1H6Uw5s/cB2heb+1JeiOZF2PZqKk+mlRwthprMcZ33n wouicj8avtTHxPASsWUVeC48Qvfzyj8l6/DcSpP82pxh7R0I5BmR/DZh6VvB4I4fQZqP rKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=903jbIjY5CaeOB9ZbI4Pqip2txlVQbIiiI0khfFZqp4=; b=mBWaA1d/Cv6aVAhjBL1C1rgEWs3xQ4T9/xeMVzuw+NUdb91dUmXZCrVGdvdYk17YyY cnxQWF59F1NBiMG9motLHNxLB4GKOFrNuR9rAWrCZ/RtJDPdK9efoxG/SZVQ54EJDc14 NAKNqwMGu/RMPlHPgDQpdUCiPKww1hX3qoPzxSa6Lhikc/JooGlV2H+KXEkRhAfbh7At hgk3ENkszUlcxJN5NKhnj2POGAQ+l4xtbWkge3F5/pTZYTPeNnDkvk7preelgbwXgdRF fPx1opprAHrZfRXd52+w0h3PoR0qMLiLM1WJsVZdJh/VuGuiRKlgs51KRdbn9to/VeJX AWPQ== X-Gm-Message-State: AJaThX62tipBedA3dfoEi3lO3RAgUJYzgfwuAmttyJWl9FB5oget0A0K 3FZyWGhGZFxA2sVUZn9YVA== X-Google-Smtp-Source: AGs4zMbKoaoOLggx9iTdYyCMdYeiGnOuQQ/+D26K04yTOHAEsCsDOz0OBsfN02/u5fw/ZKUKlF4bZA== X-Received: by 10.99.127.14 with SMTP id a14mr27842879pgd.315.1512682230211; Thu, 07 Dec 2017 13:30:30 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:12 -0600 Message-Id: <1512682213-4354-8-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi_bmc_sim.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index e84d710..9b509f8 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -214,8 +214,8 @@ struct IPMIBmcSim { uint8_t device_rev; uint8_t fwrev1; uint8_t fwrev2; - uint8_t mfg_id[3]; - uint8_t product_id[2]; + uint32_t mfg_id; + uint16_t product_id; =20 uint8_t restart_cause; =20 @@ -867,11 +867,11 @@ static void get_device_id(IPMIBmcSim *ibs, rsp_buffer_push(rsp, ibs->fwrev2); rsp_buffer_push(rsp, ibs->ipmi_version); rsp_buffer_push(rsp, 0x07); /* sensor, SDR, and SEL. */ - rsp_buffer_push(rsp, ibs->mfg_id[0]); - rsp_buffer_push(rsp, ibs->mfg_id[1]); - rsp_buffer_push(rsp, ibs->mfg_id[2]); - rsp_buffer_push(rsp, ibs->product_id[0]); - rsp_buffer_push(rsp, ibs->product_id[1]); + rsp_buffer_push(rsp, ibs->mfg_id & 0xff); + rsp_buffer_push(rsp, (ibs->mfg_id >> 8) & 0xff); + rsp_buffer_push(rsp, (ibs->mfg_id >> 16) & 0xff); + rsp_buffer_push(rsp, ibs->product_id & 0xff); + rsp_buffer_push(rsp, (ibs->product_id >> 8) & 0xff); } =20 static void set_global_enables(IPMIBmcSim *ibs, uint8_t val) @@ -1997,6 +1997,13 @@ static Property ipmi_sim_properties[] =3D { DEFINE_PROP_UINT16("fruareasize", IPMIBmcSim, fru.areasize, 1024), DEFINE_PROP_STRING("frudatafile", IPMIBmcSim, fru.filename), DEFINE_PROP_STRING("sdrfile", IPMIBmcSim, sdr_filename), + DEFINE_PROP_UINT8("device_id", IPMIBmcSim, device_id, 0x20), + DEFINE_PROP_UINT8("ipmi_version", IPMIBmcSim, ipmi_version, 0x02), + DEFINE_PROP_UINT8("device_rev", IPMIBmcSim, device_rev, 0), + DEFINE_PROP_UINT8("fwrev1", IPMIBmcSim, fwrev1, 0), + DEFINE_PROP_UINT8("fwrev2", IPMIBmcSim, fwrev2, 0), + DEFINE_PROP_UINT32("mfg_id", IPMIBmcSim, mfg_id, 0), + DEFINE_PROP_UINT16("product_id", IPMIBmcSim, product_id, 0), DEFINE_PROP_END_OF_LIST(), }; =20 --=20 2.7.4 From nobody Wed Oct 29 06:47:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512682649427446.4768219704273; Thu, 7 Dec 2017 13:37:29 -0800 (PST) Received: from localhost ([::1]:34439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3r8-0003PG-Rq for importer@patchew.org; Thu, 07 Dec 2017 16:37:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eN3kT-0005Yi-Kc for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eN3kS-0001xb-OQ for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:29 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:42363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eN3kS-0001x4-I8 for qemu-devel@nongnu.org; Thu, 07 Dec 2017 16:30:28 -0500 Received: by mail-pg0-x244.google.com with SMTP id e14so5358402pgr.9 for ; Thu, 07 Dec 2017 13:30:28 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id i20sm10986365pfj.58.2017.12.07.13.30.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 13:30:26 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 526C0CF0; Thu, 7 Dec 2017 15:30:21 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id E60F030008F; Thu, 7 Dec 2017 15:30:18 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JYLKFt4NnQJJZeoSgND/OVW57fOBNc4r6PzUibfvyB8=; b=a0F9jRt9ADz8PAP7JFl5dC4uwo66UoyqGjP3IY8WnT4bD2m5WAk5aFJtaEsNC94SZ3 iLwRCujUL++mmUPzuHIbeCSaMaX6B4JCgQg2/xNDx6caI2ImHS0tBV/b3KO59Q4wlYXp 5gXfo86ovRf52G0ojHDZ/4gW12/yvFFkyzmYXxhS1+WMSOGCallAGw+u60CzcadkiXAh h2JPBfmwSiufyKEK1HhpGrcGrm185kIFGDaRic5gloiAKp1c6zFf5G+a2Ui72Gd9p8Yc eq3r7Qs2Kf2RWayIJEjuQ8AS6O04xbnW0lmikZyUYwMv0YViCkM6PwIp2GJ94/uekIqN icoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JYLKFt4NnQJJZeoSgND/OVW57fOBNc4r6PzUibfvyB8=; b=m8hYYmhLnHOaR+I4PekksNh1wNKl4CKeikKR7DHiRIXx7mi8zlj1DAu610+v0luo/i WUqYeH5FuG1kZiE5nTc1WIaM/R5X2wMM+9SOfnxkPk8HaJ2b0TyoebMlj4H7wsphIhz7 ooktOOkJDE1BK0fuXPkAc2WlKAzm3SJlZ8CzKMcEvdtgLJDsxuVJWjTLDCJE/OLVV3sK 4d2YtyfxdufvuthdK4WhituYE2GLmwRDugAICd9BOtPSv+ZEBfze8nLFWfNmSl0l7UGV wFlUNC9rC3MvgR39MDW2p14fhj2H8At8R594fO4AG2e7J9DIGAop52El5+OdbOD6yMIQ Ft4g== X-Gm-Message-State: AJaThX6LJkXRAx2T8No54IHspoirnbj4pGTS998T+lb2zBUG4p3wI5c0 LD6KmqQxM3oAyJlXjL92DQ== X-Google-Smtp-Source: AGs4zMbGGjziss6TlOyq/FxslUlLzGpFlUM7tY2GlInnnRYTUeYX5vBvb/iNEZzh2DGS0/vAQLH8oQ== X-Received: by 10.101.69.203 with SMTP id m11mr25934597pgr.200.1512682227508; Thu, 07 Dec 2017 13:30:27 -0800 (PST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 7 Dec 2017 15:30:13 -0600 Message-Id: <1512682213-4354-9-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org> References: <1512682213-4354-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Signed-off-by: Corey Minyard Acked-by: Marc-Andr=C3=A9 Lureau --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0255113..6483f79 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -924,6 +924,15 @@ F: tests/ahci-test.c F: tests/libqos/ahci* T: git git://github.com/jnsnow/qemu.git ide =20 +IPMI +M: Corey Minyard +S: Maintained +F: include/hw/ipmi/* +F: hw/ipmi/* +F: hw/smbios/smbios_type_38.c +F: tests/ipmi* +T: git git://github.com/cminyard/qemu.git master-ipmi-rebase + Floppy M: John Snow L: qemu-block@nongnu.org --=20 2.7.4