From nobody Mon Feb 9 20:58:49 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1510770036642385.85250883244987; Wed, 15 Nov 2017 10:20:36 -0800 (PST) Received: from localhost ([::1]:37284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF2IJ-0004Jo-PV for importer@patchew.org; Wed, 15 Nov 2017 13:20:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF2GU-0003Gr-Ia for qemu-devel@nongnu.org; Wed, 15 Nov 2017 13:18:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eF2GQ-000314-JM for qemu-devel@nongnu.org; Wed, 15 Nov 2017 13:18:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49814) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eF2GQ-00030i-D5 for qemu-devel@nongnu.org; Wed, 15 Nov 2017 13:18:18 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F6C8624CD; Wed, 15 Nov 2017 18:18:17 +0000 (UTC) Received: from redhat.com (ovpn-122-254.rdu2.redhat.com [10.10.122.254]) by smtp.corp.redhat.com (Postfix) with SMTP id 2F2EBB32BC; Wed, 15 Nov 2017 18:18:13 +0000 (UTC) Date: Wed, 15 Nov 2017 20:18:13 +0200 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <1510769835-31902-5-git-send-email-mst@redhat.com> References: <1510769835-31902-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1510769835-31902-1-git-send-email-mst@redhat.com> X-Mutt-Fcc: =sent X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 15 Nov 2017 18:18:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 04/10] test: fix detection of errors from iasl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Daniel P. Berrange" The conditional looking for errors while loading asl files would ignore errors from loading the expected data, if the actual data succeeded. Signed-off-by: Daniel P. Berrange Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index ee441f1..be05e8b 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data) exp_asl =3D normalize_asl(exp_sdt->asl); =20 /* TODO: check for warnings */ - g_assert(!err || exp_err); + g_assert(!err && !exp_err); =20 if (g_strcmp0(asl->str, exp_asl->str)) { if (exp_err) { --=20 MST