From nobody Sat Nov 1 07:22:07 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509712781398603.8493815803764; Fri, 3 Nov 2017 05:39:41 -0700 (PDT) Received: from localhost ([::1]:36523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAbFo-0001Cn-EE for importer@patchew.org; Fri, 03 Nov 2017 08:39:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAbEo-0000my-3p for qemu-devel@nongnu.org; Fri, 03 Nov 2017 08:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAbEn-0002Xr-7I for qemu-devel@nongnu.org; Fri, 03 Nov 2017 08:38:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45730) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eAbEg-0002Rj-Rp; Fri, 03 Nov 2017 08:38:10 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B92C66079D; Fri, 3 Nov 2017 12:38:08 +0000 (UTC) Received: from shankerd-ubuntu.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: shankerd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E835360313; Fri, 3 Nov 2017 12:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509712688; bh=bBmmM3HD1en8neI4O1iIadQqnIe6vXDU8LGHXGMDPvc=; h=From:To:Cc:Subject:Date:From; b=fmYsu5hdcB9nOCpUAPGcES7PVSuit1ZaWtUdm9jL9gxaNmXxUz6CgXokt+axjfDuV jE71cM4683zUR+S1kqKUqOsyQsKllIhskKAEdAQbJmsSqK+dfSfkcCp5MRZlUDqQlp Dys8rZycbm/eMzUTLfNpHgHPAPccjF4fxBej7US4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509712688; bh=bBmmM3HD1en8neI4O1iIadQqnIe6vXDU8LGHXGMDPvc=; h=From:To:Cc:Subject:Date:From; b=fmYsu5hdcB9nOCpUAPGcES7PVSuit1ZaWtUdm9jL9gxaNmXxUz6CgXokt+axjfDuV jE71cM4683zUR+S1kqKUqOsyQsKllIhskKAEdAQbJmsSqK+dfSfkcCp5MRZlUDqQlp Dys8rZycbm/eMzUTLfNpHgHPAPccjF4fxBej7US4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E835360313 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org From: Shanker Donthineni To: Eric Auger , Peter Maydell Date: Fri, 3 Nov 2017 07:37:51 -0500 Message-Id: <1509712671-16299-1-git-send-email-shankerd@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.145.29.96 Subject: [Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , qemu-devel , Shanker Donthineni Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save /restore") breaks the backward compatibility with the older kernels where vITS save/restore support is not available. The vmstate function vm_change_state_handler() should not be registered if the running kernel doesn't support ITS save/restore feature. Otherwise VM instance will be killed whenever vmstate callback function is invoked. Observed a virtual machine shutdown with QEMU-2.10+linux-4.11 when testing the reboot command "virsh reboot --mode acpi" instead of reboot. KVM Error: 'KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x00000000000001' Signed-off-by: Shanker Donthineni Reviewed-by: Eric Auger --- hw/intc/arm_gicv3_its_kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index 39903d5..9b00ce5 100644 --- a/hw/intc/arm_gicv3_its_kvm.c +++ b/hw/intc/arm_gicv3_its_kvm.c @@ -111,13 +111,13 @@ static void kvm_arm_its_realize(DeviceState *dev, Err= or **errp) error_free(s->migration_blocker); return; } + } else { + qemu_add_vm_change_state_handler(vm_change_state_handler, s); } =20 kvm_msi_use_devid =3D true; kvm_gsi_direct_mapping =3D false; kvm_msi_via_irqfd_allowed =3D kvm_irqfds_enabled(); - - qemu_add_vm_change_state_handler(vm_change_state_handler, s); } =20 /** --=20 Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologi= es, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux F= oundation Collaborative Project.