From nobody Sat Nov 1 22:24:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509044048813456.96251999645256; Thu, 26 Oct 2017 11:54:08 -0700 (PDT) Received: from localhost ([::1]:54207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7nHu-0002Jf-4E for importer@patchew.org; Thu, 26 Oct 2017 14:53:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7nH0-00021L-3G for qemu-devel@nongnu.org; Thu, 26 Oct 2017 14:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7nGw-0001jO-3D for qemu-devel@nongnu.org; Thu, 26 Oct 2017 14:52:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46172 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7nGv-0001iC-Sh for qemu-devel@nongnu.org; Thu, 26 Oct 2017 14:52:53 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9QIq3YP074347 for ; Thu, 26 Oct 2017 14:52:50 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dukanwkr3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 26 Oct 2017 14:52:49 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Oct 2017 14:52:48 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 26 Oct 2017 14:52:46 -0400 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9QIqkT437290038; Thu, 26 Oct 2017 18:52:46 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 45C0F124049; Thu, 26 Oct 2017 14:49:54 -0400 (EDT) Received: from collin-ThinkPad-W541.pok.ibm.com (unknown [9.12.76.182]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 337C4124037; Thu, 26 Oct 2017 14:49:54 -0400 (EDT) From: "Collin L. Walling" To: cohuck@redhat.com, borntraeger@de.ibm.com Date: Thu, 26 Oct 2017 14:52:45 -0400 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 17102618-0008-0000-0000-00000296C2D6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007956; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00936849; UDB=6.00472134; IPR=6.00717111; BA=6.00005660; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017728; XFM=3.00000015; UTC=2017-10-26 18:52:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102618-0009-0000-0000-000037208371 Message-Id: <1509043965-5852-1-git-send-email-walling@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-10-26_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710260238 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, bwalk@linux.vnet.ibm.com, david@redhat.com, alifm@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, pasic@linux.vnet.ibm.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output appears in a "stair case" pattern. Let's print \r\n on every occurrence of a new line in the string passed to write to amend this issue. This is in sync with the guest Linux code in drivers/s390/char/sclp_vt220.c which also does a line feed conversion in the console part of the driver.=20 This fixes the s390-ccw and s390-netboot output like $ virsh start test --console Domain test started Connected to domain test Escape character is ^] Network boot starting... Using MAC address: 02:01:02:03:04:05 Requesting = information via DHCP: 010 Signed-off-by: Collin L. Walling Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/sclp.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/sclp.c b/pc-bios/s390-ccw/sclp.c index 486fce1..f8ad5ae 100644 --- a/pc-bios/s390-ccw/sclp.c +++ b/pc-bios/s390-ccw/sclp.c @@ -68,17 +68,27 @@ void sclp_setup(void) long write(int fd, const void *str, size_t len) { WriteEventData *sccb =3D (void *)_sccb; + const char *p =3D str; + size_t data_len =3D 0; + size_t i; =20 if (fd !=3D 1 && fd !=3D 2) { return -EIO; } =20 - sccb->h.length =3D sizeof(WriteEventData) + len; + for (i =3D len; i > 0; i--) { + if (*p =3D=3D '\n') { + sccb->data[data_len++] =3D '\r'; + } + sccb->data[data_len++] =3D *p; + p++; + } + + sccb->h.length =3D sizeof(WriteEventData) + data_len; sccb->h.function_code =3D SCLP_FC_NORMAL_WRITE; - sccb->ebh.length =3D sizeof(EventBufferHeader) + len; + sccb->ebh.length =3D sizeof(EventBufferHeader) + data_len; sccb->ebh.type =3D SCLP_EVENT_ASCII_CONSOLE_DATA; sccb->ebh.flags =3D 0; - memcpy(sccb->data, str, len); =20 sclp_service_call(SCLP_CMD_WRITE_EVENT_DATA, sccb); =20 --=20 2.7.4