From nobody Tue Feb 10 20:14:25 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15082474068281014.1782241288441; Tue, 17 Oct 2017 06:36:46 -0700 (PDT) Received: from localhost ([::1]:39332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4S2p-0000Co-3Y for importer@patchew.org; Tue, 17 Oct 2017 09:36:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4RfO-0005Kx-V6 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 09:12:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4RfI-0006zE-S9 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 09:12:18 -0400 Received: from mail.ispras.ru ([83.149.199.45]:57268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4RfI-0006xy-3Y for qemu-devel@nongnu.org; Tue, 17 Oct 2017 09:12:12 -0400 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 1779E54006B; Tue, 17 Oct 2017 16:12:06 +0300 (MSK) From: Mihail Abakumov To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 16:12:03 +0300 Message-ID: <150824592353.6816.9060062121278536675.stgit@Misha-PC.lan02.inno> In-Reply-To: <150824572545.6816.5099701189660002212.stgit@Misha-PC.lan02.inno> References: <150824572545.6816.5099701189660002212.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH v2 34/43] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_6 Z_629925259 SPT_0 Added supporting of windbg breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 2 + windbgstub-utils.c | 62 +++++++++++++++++++++++++++++++++++= ++++ windbgstub.c | 11 +++++++ 3 files changed, 75 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index 468a874ab7..8cea2afdf1 100755 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -97,6 +97,8 @@ void kd_api_read_virtual_memory(CPUState *cpu, PacketData= *pd); void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd); void kd_api_get_context(CPUState *cpu, PacketData *pd); void kd_api_set_context(CPUState *cpu, PacketData *pd); +void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd); +void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd); void kd_api_read_control_space(CPUState *cpu, PacketData *pd); void kd_api_write_control_space(CPUState *cpu, PacketData *pd); void kd_api_unsupported(CPUState *cpu, PacketData *pd); diff --git a/windbgstub-utils.c b/windbgstub-utils.c index c363d905af..0f23f3c865 100755 --- a/windbgstub-utils.c +++ b/windbgstub-utils.c @@ -14,6 +14,8 @@ static InitedAddr KPCR; static InitedAddr version; =20 +static InitedAddr bps[KD_BREAKPOINT_MAX]; + InitedAddr *windbg_get_KPCR(void) { return &KPCR; @@ -71,6 +73,66 @@ void kd_api_write_virtual_memory(CPUState *cpu, PacketDa= ta *pd) stl_p(&mem->ActualBytesWritten, len); } =20 +void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd) +{ + DBGKD_WRITE_BREAKPOINT64 *m64c =3D &pd->m64.u.WriteBreakPoint; + target_ulong addr; + int i, err =3D 0; + + addr =3D ldtul_p(&m64c->BreakPointAddress); + + for (i =3D 0; i < KD_BREAKPOINT_MAX; ++i) { + if (!bps[i].is_init) { + err =3D cpu_breakpoint_insert(cpu, addr, BP_GDB, NULL); + if (!err) { + bps[i].addr =3D addr; + bps[i].is_init =3D true; + WINDBG_DEBUG("write_breakpoint: " FMT_ADDR, addr); + break; + } else { + WINDBG_ERROR("write_breakpoint: " FMT_ADDR ", " FMT_ERR, + addr, err); + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + return; + } + } else if (addr =3D=3D bps[i].addr) { + break; + } + } + + if (!err) { + stl_p(&m64c->BreakPointHandle, i + 1); + pd->m64.ReturnStatus =3D STATUS_SUCCESS; + } else { + WINDBG_ERROR("write_breakpoint: All breakpoints occupied"); + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } +} + +void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd) +{ + DBGKD_RESTORE_BREAKPOINT *m64c =3D &pd->m64.u.RestoreBreakPoint; + uint8_t index; + int err =3D -1; + + index =3D ldtul_p(&m64c->BreakPointHandle) - 1; + + if (bps[index].is_init) { + err =3D cpu_breakpoint_remove(cpu, bps[index].addr, BP_GDB); + if (!err) { + WINDBG_DEBUG("restore_breakpoint: " FMT_ADDR ", index(%d)", + bps[index].addr, index); + } else { + WINDBG_ERROR("restore_breakpoint: " FMT_ADDR ", index(%d), " + FMT_ERR, bps[index].addr, index, err); + } + bps[index].is_init =3D false; + pd->m64.ReturnStatus =3D STATUS_SUCCESS; + } else { + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } +} + void kd_api_unsupported(CPUState *cpu, PacketData *pd) { WINDBG_ERROR("Caught unimplemented api %s", diff --git a/windbgstub.c b/windbgstub.c index 5b0a15ea4e..489abe6d6c 100755 --- a/windbgstub.c +++ b/windbgstub.c @@ -156,6 +156,14 @@ static void windbg_process_manipulate_packet(ParsingCo= ntext *ctx) kd_api_set_context(cpu, &ctx->data); break; =20 + case DbgKdWriteBreakPointApi: + kd_api_write_breakpoint(cpu, &ctx->data); + break; + + case DbgKdRestoreBreakPointApi: + kd_api_restore_breakpoint(cpu, &ctx->data); + break; + case DbgKdReadControlSpaceApi: kd_api_read_control_space(cpu, &ctx->data); break; @@ -164,6 +172,9 @@ static void windbg_process_manipulate_packet(ParsingCon= text *ctx) kd_api_write_control_space(cpu, &ctx->data); break; =20 + case DbgKdClearAllInternalBreakpointsApi: + return; + default: kd_api_unsupported(cpu, &ctx->data); break;