From nobody Tue Feb 10 19:10:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506424935978792.167350438182; Tue, 26 Sep 2017 04:22:15 -0700 (PDT) Received: from localhost ([::1]:46776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwnwC-0001Ws-HN for importer@patchew.org; Tue, 26 Sep 2017 07:22:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwngr-0004c7-8C for qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwngp-00017s-Ta for qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:13 -0400 Received: from mail.ispras.ru ([83.149.199.45]:52056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwngp-00017X-Gu for qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:11 -0400 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id B8A355400CB; Tue, 26 Sep 2017 14:06:10 +0300 (MSK) From: Mihail Abakumov To: qemu-devel@nongnu.org Date: Tue, 26 Sep 2017 14:06:09 +0300 Message-ID: <150642396922.3900.13282234011521338171.stgit@Misha-PC.lan02.inno> In-Reply-To: <150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno> References: <150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and kd_api_read_virtual_memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 2 ++ windbgstub-utils.c | 47 +++++++++++++++++++++++++++++++++++= ++++ windbgstub.c | 8 +++++++ 3 files changed, 57 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index ca21af7c91..c1ff1cec57 100755 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -102,6 +102,8 @@ typedef struct SizedBuf { buf.size =3D 0; \ } while (false) =20 +void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd); +void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd); void kd_api_unsupported(CPUState *cpu, PacketData *pd); =20 SizedBuf kd_gen_exception_sc(CPUState *cpu); diff --git a/windbgstub-utils.c b/windbgstub-utils.c index e7b381f829..1bde60a1e9 100755 --- a/windbgstub-utils.c +++ b/windbgstub-utils.c @@ -30,6 +30,53 @@ typedef struct KDData { =20 static KDData *kd; =20 +void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd) +{ + DBGKD_READ_MEMORY64 *mem =3D &pd->m64.u.ReadMemory; + uint32_t len; + target_ulong addr; + int err; + + len =3D MIN(ldl_p(&mem->TransferCount), PACKET_MAX_SIZE - M64_SIZE); + addr =3D ldtul_p(&mem->TargetBaseAddress); + err =3D cpu_memory_rw_debug(cpu, addr, pd->extra, len, 0); + + if (!err) { + pd->extra_size =3D len; + mem->ActualBytesRead =3D ldl_p(&len); + } else { + pd->extra_size =3D 0; + mem->ActualBytesRead =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + + WINDBG_DEBUG("read_virtual_memory: No physical page mapped: " FMT_= ADDR, + (target_ulong) mem->TargetBaseAddress); + } +} + +void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd) +{ + DBGKD_WRITE_MEMORY64 *mem =3D &pd->m64.u.WriteMemory; + uint32_t len; + target_ulong addr; + int err; + + len =3D MIN(ldl_p(&mem->TransferCount), pd->extra_size); + addr =3D ldtul_p(&mem->TargetBaseAddress); + err =3D cpu_memory_rw_debug(cpu, addr, pd->extra, len, 1); + + pd->extra_size =3D 0; + if (!err) { + mem->ActualBytesWritten =3D ldl_p(&len); + } else { + mem->ActualBytesWritten =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + + WINDBG_DEBUG("read_write_memory: No physical page mapped: " FMT_AD= DR, + (target_ulong) mem->TargetBaseAddress); + } +} + void kd_api_unsupported(CPUState *cpu, PacketData *pd) { WINDBG_ERROR("Catched unimplemented api %s", diff --git a/windbgstub.c b/windbgstub.c index 50b4ef0dea..327fe83f70 100755 --- a/windbgstub.c +++ b/windbgstub.c @@ -133,6 +133,14 @@ static void windbg_process_manipulate_packet(ParsingCo= ntext *ctx) =20 switch (ctx->data.m64.ApiNumber) { =20 + case DbgKdReadVirtualMemoryApi: + kd_api_read_virtual_memory(cpu, &ctx->data); + break; + + case DbgKdWriteVirtualMemoryApi: + kd_api_write_virtual_memory(cpu, &ctx->data); + break; + default: kd_api_unsupported(cpu, &ctx->data); break;