From nobody Wed Feb 11 05:35:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506036904164148.72923915417232; Thu, 21 Sep 2017 16:35:04 -0700 (PDT) Received: from localhost ([::1]:55935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvAzc-0003CE-9C for importer@patchew.org; Thu, 21 Sep 2017 19:34:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvAiV-0004sK-60 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvAiU-0004QQ-29 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:17:11 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:34895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvAiT-0004P4-RD for qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:17:09 -0400 Received: by mail-wr0-x243.google.com with SMTP id n64so3849106wrb.2 for ; Thu, 21 Sep 2017 16:17:09 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id u186sm2596278wmd.19.2017.09.21.16.17.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 16:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=zfQSoMpFUNxI/gjn5SL4Rk+VM2GAdCvolpmwNHgwxsU=; b=XGcBHl40aUh8xtPtDQVFv0wphtrgIWjTg0lR0ev7v8VTgU9hHuao9MxaFedz5M35WN doHAHyNdv3LDKgGtgxXgoQDBPLRFFbqrUPuQjWBAxi7zFapZCmOVUs8s9QSVotZzgoPe 48Vd/xWgB/OVK5HRsDNifF90TKIMsChc9hZcPIHIKgZkMjWaa1QrKXyPLpXQ8qEpUBMN OsGNRozZoP1/dpR72+KivKbsSut2DIIrQeIriWZSq2Ir2/BXHd4bTx/BuJ8aO1ScYEM8 ffghj6QvBNDn3NrhiC/QHprHKgWQrSc5CDMhn0mLh9DuhE6Mch+Nb2GOE7nKqsLaS5Qa Ff3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=zfQSoMpFUNxI/gjn5SL4Rk+VM2GAdCvolpmwNHgwxsU=; b=F1oGmmFly3//VsYfmZA33QKt1EgHLDeAWKxCAxdQPxBEiEbNqWLSYSrXvugC/21AeY A6Sd1pndCVB0MYDG7658MA3Yc/BFwA9/mCZ/BQWyWAVid4cEz1P++HbQvnZDWMczCI8F Wp4WQHzBTU/wmVSNsO1aA+I3xwviJc/UbR6EKchVtiWQseWl4GFeHH7SE+4eaNs26bKM /I5kvVGTp46V8QrKwtpm2vTGhtjamjTsaO+3wlaMgHWpcql2eVDjl16mjsC/uyepZi20 r8iJoRABDhXMEKGLx/P8oaFrSWZDdXAGvo9MepBFO7U5rzysjpyopcNNsX+VWIyDoruj 6vLw== X-Gm-Message-State: AHPjjUhYP40xwN5F1U61jALXoAN383372OSmf+CVPfEkDezi1Uy2czjt 3wYMGXoFNbvsh6aITzt74KNi3N4+ X-Google-Smtp-Source: AOwi7QDly5r2NzD5uHHrVc3xMkVnBeln5OLWh/1HLXpWWmgt9OG3LsVsJTUYM/JDyfsAeAMrew1NSw== X-Received: by 10.223.147.39 with SMTP id 36mr2990795wro.175.1506035828608; Thu, 21 Sep 2017 16:17:08 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 22 Sep 2017 01:16:29 +0200 Message-Id: <1506035800-30509-22-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1506035800-30509-1-git-send-email-pbonzini@redhat.com> References: <1506035800-30509-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PULL 21/32] memory: Create FlatView directly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alexey Kardashevskiy This avoids usual memory_region_transaction_commit() which rebuilds all FVs. On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings down the boot time from 25s to 20s and reduces the amount of temporary FVs allocated during machine constructon (~800000 -> ~640000) and amount of temporary dispatch trees (~370000 -> ~300000), the total memory footprint goes down (18G -> 17G). Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-18-aik@ozlabs.ru> Signed-off-by: Paolo Bonzini --- memory.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/memory.c b/memory.c index aa7355b..706c385 100644 --- a/memory.c +++ b/memory.c @@ -1010,6 +1010,17 @@ static void address_space_set_flatview(AddressSpace = *as) } } =20 +static void address_space_update_topology(AddressSpace *as) +{ + MemoryRegion *physmr =3D memory_region_get_flatview_root(as->root); + + flatviews_init(); + if (!g_hash_table_lookup(flat_views, physmr)) { + generate_memory_topology(physmr); + } + address_space_set_flatview(as); +} + void memory_region_transaction_begin(void) { qemu_flush_coalesced_mmio_buffer(); @@ -2721,7 +2732,6 @@ void memory_region_invalidate_mmio_ptr(MemoryRegion *= mr, hwaddr offset, void address_space_init(AddressSpace *as, MemoryRegion *root, const char *= name) { memory_region_ref(root); - memory_region_transaction_begin(); as->root =3D root; as->current_map =3D NULL; as->ioeventfd_nb =3D 0; @@ -2729,8 +2739,8 @@ void address_space_init(AddressSpace *as, MemoryRegio= n *root, const char *name) QTAILQ_INIT(&as->listeners); QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link); as->name =3D g_strdup(name ? name : "anonymous"); - memory_region_update_pending |=3D root->enabled; - memory_region_transaction_commit(); + address_space_update_topology(as); + address_space_update_ioeventfds(as); } =20 static void do_address_space_destroy(AddressSpace *as) --=20 1.8.3.1