From nobody Tue Feb 10 05:10:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505824975236696.9695228035624; Tue, 19 Sep 2017 05:42:55 -0700 (PDT) Received: from localhost ([::1]:42620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHra-000603-BW for importer@patchew.org; Tue, 19 Sep 2017 08:42:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHf4-0003la-DZ for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:29:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHey-0005DA-II for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:29:58 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHey-0005Cz-CW; Tue, 19 Sep 2017 08:29:52 -0400 Received: by mail-wm0-x241.google.com with SMTP id r136so3737439wmf.3; Tue, 19 Sep 2017 05:29:52 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id k18sm1292878wmd.22.2017.09.19.05.29.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Snaki7eXgsmtEi7WAV7tkQ4dmsDWTEeCi8AZKyu8G8k=; b=cFXfSaKogGuyJV7Szhgh9N/LKFD9GDoptYiLQsoMgjAVIUEcyisECxxzCzfo+c39eE mwg5zcX1YEEj+NUZmEavLaq93EMCJFdQrdoXD+Y2iUaF/yQdMOn/ExbEanIaIxooqa/K 9sl8UAx/Omk1CipYmg1tsvkBf8TvvnVR51nunQkTlFOvmrqEBnZ/C77Hj0Vljp4WykEy ukWdNoJH2ZtROLP+4hr+yu9FANuC1CF6NJUHXPqzg3k45brByiSUYpHeXivBX1sHfwn4 fbq3zfXlZwaaImPdu2TyvchEnGAlA9vxuTEdisLVv0hg6b0o57zYdMrcbiBUnF6Vhw7O 8XRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Snaki7eXgsmtEi7WAV7tkQ4dmsDWTEeCi8AZKyu8G8k=; b=IwToh3LxxX/wLzB1lT0aK40HDPYF02dp7OB3weMv3VUx/zErauiQ2VIU+dp8CGISoX iJ6WQGSU1Agz/saMgkfnb0kApCrSKdVhOCt7olcIAmnXWoSsGYcnRo8tkLEdXU2kVcpA SVK0VLLIsj5PZ9SOEr/krVJG3zBweDnCEeiqn5GbIYQoHir4oIx/qb4T6f017vl4gbIA 5IV3RXcrmxXh6FuabU8NcAQWmRatbN8d0L58G7VZOTRicB95DX2F+oLRGexmYbOo875f qsdIM43BpACV8wLc3YCCdZ9dyiKcrKxw3W76BYk6W3AtaZ/azpMzx3pxUdI/mHHzvWgE vvcQ== X-Gm-Message-State: AHPjjUgaKDBELs6B/956Fw8WFrJd4LLXH41pZQYFxzEcz39SY7+CXfWa RzGGGp5t2pif78BWEeMIHXOJyebL X-Google-Smtp-Source: AOwi7QBScqCyfzZJSLGLLE5pDPUf49mc83RP3ZAvN0b7ba5JHpZ+q6omb6wzdWanHBYpfS2eOBJeGg== X-Received: by 10.28.154.138 with SMTP id c132mr923430wme.2.1505824191026; Tue, 19 Sep 2017 05:29:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 19 Sep 2017 14:28:56 +0200 Message-Id: <1505824179-21541-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> References: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 07/50] scsi-bus: correct responses for INQUIRY and REQUEST SENSE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hannes Reinecke , Hannes Reinecke , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Hannes Reinecke According to SPC-3 INQUIRY and REQUEST SENSE should return GOOD even on unsupported LUNS. Signed-off-by: Hannes Reinecke Message-Id: <1503049022-14749-1-git-send-email-hare@suse.de> Reported-by: Laszlo Ersek Fixes: ded6ddc5a7b95217557fa360913d1213e12d4a6d Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index e364410..ade31c1 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -516,8 +516,10 @@ static size_t scsi_sense_len(SCSIRequest *req) static int32_t scsi_target_send_command(SCSIRequest *req, uint8_t *buf) { SCSITargetReq *r =3D DO_UPCAST(SCSITargetReq, req, req); + int fixed_sense =3D (req->cmd.buf[1] & 1) =3D=3D 0; =20 - if (req->lun !=3D 0) { + if (req->lun !=3D 0 && + buf[0] !=3D INQUIRY && buf[0] !=3D REQUEST_SENSE) { scsi_req_build_sense(req, SENSE_CODE(LUN_NOT_SUPPORTED)); scsi_req_complete(req, CHECK_CONDITION); return 0; @@ -535,9 +537,28 @@ static int32_t scsi_target_send_command(SCSIRequest *r= eq, uint8_t *buf) break; case REQUEST_SENSE: scsi_target_alloc_buf(&r->req, scsi_sense_len(req)); - r->len =3D scsi_device_get_sense(r->req.dev, r->buf, - MIN(req->cmd.xfer, r->buf_len), - (req->cmd.buf[1] & 1) =3D=3D 0); + if (req->lun !=3D 0) { + const struct SCSISense sense =3D SENSE_CODE(LUN_NOT_SUPPORTED); + + if (fixed_sense) { + r->buf[0] =3D 0x70; + r->buf[2] =3D sense.key; + r->buf[10] =3D 10; + r->buf[12] =3D sense.asc; + r->buf[13] =3D sense.ascq; + r->len =3D MIN(req->cmd.xfer, SCSI_SENSE_LEN); + } else { + r->buf[0] =3D 0x72; + r->buf[1] =3D sense.key; + r->buf[2] =3D sense.asc; + r->buf[3] =3D sense.ascq; + r->len =3D 8; + } + } else { + r->len =3D scsi_device_get_sense(r->req.dev, r->buf, + MIN(req->cmd.xfer, r->buf_len), + fixed_sense); + } if (r->req.dev->sense_is_ua) { scsi_device_unit_attention_reported(req->dev); r->req.dev->sense_len =3D 0; --=20 1.8.3.1