From nobody Sat Feb 7 06:55:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505827064176957.2171545460617; Tue, 19 Sep 2017 06:17:44 -0700 (PDT) Received: from localhost ([::1]:42806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duIPH-0002GA-C8 for importer@patchew.org; Tue, 19 Sep 2017 09:17:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHfr-0004fc-Qz for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHfk-0005mv-HT for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:47 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33584) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHfk-0005mD-BN for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:40 -0400 Received: by mail-wm0-x243.google.com with SMTP id m127so3758122wmm.0 for ; Tue, 19 Sep 2017 05:30:40 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id k18sm1292878wmd.22.2017.09.19.05.30.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=J618FbINiVzuzahwHIub2uNRKEUuGuqqeon/mfKRfSQ=; b=ujNEwnqBfUMcK0b4y3kUeNhErin9h4Zenxg6Z3Z3GoKM8YomuT0ZWAJyKVPsiut1Ih SmPyyC2E+Idu+oF+iK4sEVl1O3doia/MjR1J0O8peI1cIPShCwWXGwOaVSSnEEdpqI7G K4kgftDWNsE/m+RFzPI/ifeVuMX2ks3PKxadR7Vz/nxqyV/Xqky0a6YVElX9yuyVeBza 4+5Dv79r0CDiQAyo3sZ71TniSYHOdU2KiyQ7Ora6pVz4HqWmGl4Pdp2CYKN+OHlDCbZB 2X2ptsGQtserlbzfxygJv7TGnuUjsI8XFANdbeF92VM0rKtyHSzc3CRnL/FrNWZ4BMaX CTGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=J618FbINiVzuzahwHIub2uNRKEUuGuqqeon/mfKRfSQ=; b=t0/rnA5wj6ZMwPzgaGj27iud+SVWQUSnfHDaM78RSQCpJrqSFhcqL7YUF70lYmrZok ICs6RNDpun40BDlYrsvyK3Nlf3cg7+t5DGAFZ3KMS0Hu3PvaOoQ+JQxpJMp6/PBY2UmX szaEWajSH+b2lv0AhdFREfs664tkdIgOQ2ZUQwq6YIAhs+RbfAxsZeSgX9SMs2IKoRSa oqBIhZV3VBziffeaHam7xSgB4QDWMbpwH9V0AFVcP+p1gulMjmo37HRii1FBllpti4YW AeO3mGSyttj5RtoUc060kCpaQere81YZ1SYft10YBx4wQukaZ1QhdrAZ65espdNMkkU/ mVzg== X-Gm-Message-State: AHPjjUid9L7Xn0FGnJ5/hv6QV5pQFRMQS6yqVHH1VyD5ZLGV9ysGCyR4 +w8EUes6Vt016lyVIdyjlPLwDyRe X-Google-Smtp-Source: AOwi7QB7/binwnt5IpsNXRRNRC/Q4Dj3QLth5fwYjXf5fdpmp9zdEU2/SejFWD9dzy8eu5A17SL7Ig== X-Received: by 10.28.144.132 with SMTP id s126mr922919wmd.103.1505824239003; Tue, 19 Sep 2017 05:30:39 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 19 Sep 2017 14:29:38 +0200 Message-Id: <1505824179-21541-50-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> References: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 49/50] default-configs: Replace $(and ...) with $(call land, ...) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Using $(and ...) is dangerous here: It only works as long as the first argument is set to 'y' or completely unset. It does not work if the first argument is set to 'n' for example. Let's use the "land" make function instead which has been written explicitely for this purpose. Signed-off-by: Thomas Huth Message-Id: <1505759538-15365-1-git-send-email-thuth@redhat.com> Signed-off-by: Paolo Bonzini --- default-configs/pci.mak | 2 +- default-configs/ppc-softmmu.mak | 2 +- default-configs/ppc64-softmmu.mak | 4 ++-- default-configs/s390x-softmmu.mak | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index a758630..187e438 100644 --- a/default-configs/pci.mak +++ b/default-configs/pci.mak @@ -43,4 +43,4 @@ CONFIG_VGA=3Dy CONFIG_VGA_PCI=3Dy CONFIG_IVSHMEM_DEVICE=3D$(CONFIG_IVSHMEM) CONFIG_ROCKER=3Dy -CONFIG_VHOST_USER_SCSI=3D$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) +CONFIG_VHOST_USER_SCSI=3D$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX)) diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.= mak index a3972c5..d7a3755 100644 --- a/default-configs/ppc-softmmu.mak +++ b/default-configs/ppc-softmmu.mak @@ -43,7 +43,7 @@ CONFIG_XILINX_ETHLITE=3Dy CONFIG_PREP=3Dy CONFIG_MAC=3Dy CONFIG_E500=3Dy -CONFIG_OPENPIC_KVM=3D$(and $(CONFIG_E500),$(CONFIG_KVM)) +CONFIG_OPENPIC_KVM=3D$(call land,$(CONFIG_E500),$(CONFIG_KVM)) CONFIG_PLATFORM_BUS=3Dy CONFIG_ETSEC=3Dy CONFIG_LIBDECNUMBER=3Dy diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-soft= mmu.mak index af32589..9086475 100644 --- a/default-configs/ppc64-softmmu.mak +++ b/default-configs/ppc64-softmmu.mak @@ -48,7 +48,7 @@ CONFIG_POWERNV=3Dy CONFIG_PREP=3Dy CONFIG_MAC=3Dy CONFIG_E500=3Dy -CONFIG_OPENPIC_KVM=3D$(and $(CONFIG_E500),$(CONFIG_KVM)) +CONFIG_OPENPIC_KVM=3D$(call land,$(CONFIG_E500),$(CONFIG_KVM)) CONFIG_PLATFORM_BUS=3Dy CONFIG_ETSEC=3Dy CONFIG_LIBDECNUMBER=3Dy @@ -56,7 +56,7 @@ CONFIG_SM501=3Dy # For pSeries CONFIG_XICS=3D$(CONFIG_PSERIES) CONFIG_XICS_SPAPR=3D$(CONFIG_PSERIES) -CONFIG_XICS_KVM=3D$(and $(CONFIG_PSERIES),$(CONFIG_KVM)) +CONFIG_XICS_KVM=3D$(call land,$(CONFIG_PSERIES),$(CONFIG_KVM)) # For PReP CONFIG_SERIAL_ISA=3Dy CONFIG_MC146818RTC=3Dy diff --git a/default-configs/s390x-softmmu.mak b/default-configs/s390x-soft= mmu.mak index 6ab2bc6..444bf16 100644 --- a/default-configs/s390x-softmmu.mak +++ b/default-configs/s390x-softmmu.mak @@ -1,6 +1,6 @@ CONFIG_PCI=3Dy CONFIG_VIRTIO_PCI=3D$(CONFIG_PCI) -CONFIG_VHOST_USER_SCSI=3D$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) +CONFIG_VHOST_USER_SCSI=3D$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX)) CONFIG_VIRTIO=3Dy CONFIG_SCLPCONSOLE=3Dy CONFIG_TERMINAL3270=3Dy --=20 1.8.3.1