From nobody Mon Feb 9 13:37:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505824302188718.6474050254111; Tue, 19 Sep 2017 05:31:42 -0700 (PDT) Received: from localhost ([::1]:42569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHgj-000524-08 for importer@patchew.org; Tue, 19 Sep 2017 08:31:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHev-0003ev-OB for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHet-00059p-3m for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:29:49 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:33609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHes-00059V-T7 for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:29:47 -0400 Received: by mail-wr0-x244.google.com with SMTP id b9so2160735wra.0 for ; Tue, 19 Sep 2017 05:29:46 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id k18sm1292878wmd.22.2017.09.19.05.29.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=/H+ZQbe2doe7HI1QEq7Y9aa4WX0rwPaLR11y6A8rgcg=; b=bo/MzAzYc0sdk8IXksELZWyQh71nqzRVSI2D43CRvKKnv48kbIF6xvZcfIp+rftyYi ZltNCAazpsje8q4Pr8pzA4OWv36BEzJ/3AZfpAm/QbrBvpd4kaAQqN0b75X1NNkPPY04 Vz/lBtlNXqAPVwf2MP5q8QtjYZpSS7GKOKfpUBb2ToiaAA3HBGBZuL8/hT0PWfqLYpe9 s2K5RhqngZc4+9fd2XIVeckmHU2kq2HVLvCShblBsPeoFYIfCa8HJxVWX94ymu/qh8wA lAYf0vKGghXQjqEHVPzsQ66l75twasK1PMxCeY0/lqd0idwPkSOnsO6MtQAWZ34QT9OH qzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=/H+ZQbe2doe7HI1QEq7Y9aa4WX0rwPaLR11y6A8rgcg=; b=U465BgULSzMEGKqubSZUyEuVj7DLYqW60MR4G1oUQPpXDoPqFFDG94wKq85f40oFDS 2DUmwzc0j1LAaCO4hkvAFlz1ZGLy3E15f7ajScAE532QBKHt40n99DC2w6dpzeTnqOQ4 x2wk+2lNbf8goUSEXcbJGdxa9wyU7DQxhX+pDNlTFTfzK1VWle7I9SVB8oPRIRw4dTLt SKAyfN9FjIDajTWCFGWX4oTe5A+p5XMStTD2zmkdrqTqHKhwVOglbctTlWyJR2+GEs8C xH3UcybMW2hghAGzoMqvIL9pOCBY+hdLDfjFMk44kX7ftDAyHHElNvxnpaSYnOrF/mxk hxWA== X-Gm-Message-State: AHPjjUip6QvDLTKlqx3/ZKRnNVUi8Mq4cAapBjGOKPmuwUhf+I9jtUGD P2Y8SB0f++bBnR78oTbAzuqVA7MX X-Google-Smtp-Source: AOwi7QCAA0T/CrBeXHWJ/CUmLgkXNEO2EivSptQBHu/Q19BnRk9y3b0gwWhDjvNtcSNA23a9r0heAA== X-Received: by 10.223.182.137 with SMTP id j9mr1271001wre.150.1505824185569; Tue, 19 Sep 2017 05:29:45 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 19 Sep 2017 14:28:51 +0200 Message-Id: <1505824179-21541-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> References: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PULL 02/50] target/i386: set rip_offset for further SSE instructions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joseph Myers Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Joseph Myers It turns out that my recent fix to set rip_offset when emulating some SSE4.1 instructions needs generalizing to cover a wider class of instructions. Specifically, every instruction in the sse_op_table7 table, coming from various instruction set extensions, has an 8-bit immediate operand that comes after any memory operand, and so needs rip_offset set for correctness if there is a memory operand that is rip-relative, and my patch only set it for a subset of those instructions. This patch moves the rip_offset setting to cover the wider class of instructions, so fixing 9 further gcc testsuite failures in my GCC 6-based testing. (I do not know whether there might be still further classes of instructions missing this setting.) Signed-off-by: Joseph Myers Message-Id: Signed-off-by: Paolo Bonzini --- target/i386/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index de0c989..a8986f4 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -4076,10 +4076,11 @@ static void gen_sse(CPUX86State *env, DisasContext = *s, int b, if (!(s->cpuid_ext_features & sse_op_table7[b].ext_mask)) goto illegal_op; =20 + s->rip_offset =3D 1; + if (sse_fn_eppi =3D=3D SSE_SPECIAL) { ot =3D mo_64_32(s->dflag); rm =3D (modrm & 7) | REX_B(s); - s->rip_offset =3D 1; if (mod !=3D 3) gen_lea_modrm(env, s, modrm); reg =3D ((modrm >> 3) & 7) | rex_r; --=20 1.8.3.1