From nobody Sat Feb 7 06:55:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505825488330576.9498353134011; Tue, 19 Sep 2017 05:51:28 -0700 (PDT) Received: from localhost ([::1]:42660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHzr-0004i6-Hz for importer@patchew.org; Tue, 19 Sep 2017 08:51:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHfS-0004GE-PG for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHfJ-0005Sv-2O for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:22 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHfI-0005SM-SF for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:13 -0400 Received: by mail-wm0-x241.google.com with SMTP id i131so3749837wma.1 for ; Tue, 19 Sep 2017 05:30:12 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id k18sm1292878wmd.22.2017.09.19.05.30.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=/BaqPddDhPMswY3yVQumVhtDfTSRHbBrrzgUlRFUHqc=; b=RvTzMqqdqmMTQQscYYQj/Et5yJ8kC9z7gaCiYfv44EHA6e9jfmXA3V17MJHnqBBhgW N9LFYOZ8QGRP6RZkz18FidbRjPvuzKFfhF1wTsvfSEBcDntZjisHDiF5L7ZkTW/uNQNP 0/gRyXVgxqP1yjg1v+K7B106gamGaqpIx94FmniqN/TKgxiGv+6jgLzJs+tLn8uqkW1l b6JfNmJiO+MyQCgdKCidIdLkj00jg5vLRAytGN7vgyn9eTw4HehxnbXIvnslIAKu/vDp T7soXH/MeejB++tERMalK6MzGdthc71nBBiC1FBPAelX1nGYNpC3u5bCvQZJpczw4CQD +huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=/BaqPddDhPMswY3yVQumVhtDfTSRHbBrrzgUlRFUHqc=; b=bOcrIFzL8x2/OCXBZwEV0CzkobOqpVI72OUckMEk0cmUVlTxPkPEioYhInaukEAa5H l9NoVMfY5Q7Q+XTjYtaw4eVoVAmxc/VK2D1gIZyiOB6vGhiWq9EOcHP2pBibZOVc8te7 2544gMf+WvNrhVzLV7vueI/bVK9iLjMcRrxeXLK4ZZ8+CpQzM9R1BwK6kyQntcvcQdS1 iLDiOro4N6oNYKBBcINsO5vxOulroMECuCQcd9fnfAhCHByMb9x+kEchZ1kjKttz4wsx TGvSaKD3OodfR9bTFj9d5+EndM5CPkURR8TupnO7IAdWln3yghrZ8OIEPex1loAzuic+ QFYg== X-Gm-Message-State: AHPjjUjEpoi2mpA3FzrTNlU+Con5h1WqLK719U4ooasdZkK1y1Su8tPa V2seYr4W/3IJDm/Vls5ytDnFe8ay X-Google-Smtp-Source: AOwi7QAHttXl1TqSa2DvBIuRnuNpCTnaNH/8XmmTCCaGHPyPIGz+NbFfYWzFRkR8yFEWxHYThwcGuw== X-Received: by 10.28.159.6 with SMTP id i6mr982771wme.119.1505824211592; Tue, 19 Sep 2017 05:30:11 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 19 Sep 2017 14:29:14 +0200 Message-Id: <1505824179-21541-26-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> References: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 25/50] multiboot: validate multiboot header address values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit While loading kernel via multiboot-v1 image, (flags & 0x00010000) indicates that multiboot header contains valid addresses to load the kernel image. These addresses are used to compute kernel size and kernel text offset in the OS image. Validate these address values to avoid an OOB access issue. This is CVE-2017-14167. Reported-by: Thomas Garnier Signed-off-by: Prasad J Pandit Message-Id: <20170907063256.7418-1-ppandit@redhat.com> Signed-off-by: Paolo Bonzini --- hw/i386/multiboot.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 6001f4c..c7b70c9 100644 --- a/hw/i386/multiboot.c +++ b/hw/i386/multiboot.c @@ -221,15 +221,34 @@ int load_multiboot(FWCfgState *fw_cfg, uint32_t mh_header_addr =3D ldl_p(header+i+12); uint32_t mh_load_end_addr =3D ldl_p(header+i+20); uint32_t mh_bss_end_addr =3D ldl_p(header+i+24); + mh_load_addr =3D ldl_p(header+i+16); + if (mh_header_addr < mh_load_addr) { + fprintf(stderr, "invalid mh_load_addr address\n"); + exit(1); + } + uint32_t mb_kernel_text_offset =3D i - (mh_header_addr - mh_load_a= ddr); uint32_t mb_load_size =3D 0; mh_entry_addr =3D ldl_p(header+i+28); =20 if (mh_load_end_addr) { + if (mh_bss_end_addr < mh_load_addr) { + fprintf(stderr, "invalid mh_bss_end_addr address\n"); + exit(1); + } mb_kernel_size =3D mh_bss_end_addr - mh_load_addr; + + if (mh_load_end_addr < mh_load_addr) { + fprintf(stderr, "invalid mh_load_end_addr address\n"); + exit(1); + } mb_load_size =3D mh_load_end_addr - mh_load_addr; } else { + if (kernel_file_size < mb_kernel_text_offset) { + fprintf(stderr, "invalid kernel_file_size\n"); + exit(1); + } mb_kernel_size =3D kernel_file_size - mb_kernel_text_offset; mb_load_size =3D mb_kernel_size; } --=20 1.8.3.1