From nobody Sat Feb 7 06:55:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1505824986504648.8020937336763; Tue, 19 Sep 2017 05:43:06 -0700 (PDT) Received: from localhost ([::1]:42621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHrl-0006EM-OQ for importer@patchew.org; Tue, 19 Sep 2017 08:43:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHfK-00046Y-TS for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHfB-0005Kq-Hu for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:14 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:37397) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHfB-0005KM-91 for qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:30:05 -0400 Received: by mail-wm0-x241.google.com with SMTP id f4so3732102wmh.4 for ; Tue, 19 Sep 2017 05:30:05 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.gmail.com with ESMTPSA id k18sm1292878wmd.22.2017.09.19.05.30.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 05:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=MQTppsDc8kCxok2t7AKfFaHLT6m/qeqKMeyvnn8SUSM=; b=oLf5RzyRYz5KfZsNVTFer1e7I3iObnsvcDlYG7nhktcKgpol7iH6cass8mhUJA7EAv zGoeYM7qn1wLqzrpddkekr1rpP6V9RryHnhbJBeMwBMS0p5imUQqHN6L/yeEn7082to+ HnjwAT/8SO2IeIi7TfndTCVCLqQarPpjPidhHYtxLuQ20MEPpJ2za0rBp31Du3xhc2eW n7N7I2f+pDJdb/748Vt7Ehyn8dvDfGMD8J/eb0Z8mvo/0OGxoNzISc68iwZK+/ZU6J+c TivlnQ0r+AMOPH4agGuL/kme/fGNQMF/h+EyKfbQXxaZUjn3X51CNwwSZ//3n1irIdOm jJeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=MQTppsDc8kCxok2t7AKfFaHLT6m/qeqKMeyvnn8SUSM=; b=QlOc+0rkFxSkgA9AHa3Q6zZYXOztQbJ903D1Q8YiVGCsJwXwp6+oE7mwKJ/9P/MY8x atuFHhAIF4+yDdFcmzHSSybvuX4ZFpN7U0GSz9Ayl5S8aGmTzv2gXEsIU1hORZ1xQ5Xs 5zIhrvT9Zn4v+zNs3ciqrF3zZkCPT6NX7r8yvQORKv+40wlJ8MITBQfTXDkRcfFueNIV N55TiNgB5+B7OlYZqkiHRdTSX3k+o6Nh8bSci5TBv91/eJXxCa83QAhIQWEkNflDyY8j zaQvjPO6H4NHUo6YPclpnFSMxBZBanJzvrX80+W87m+CB75fgmtJIssoobh6Hg/MeJ8W 2ZnQ== X-Gm-Message-State: AHPjjUiNT8/NjT6pmmNdfTTDxvNQhcVHVQrkwNDFaK+Wqyq+aILRpGe5 VFAd1hA5RAmRllD1sMVNIbjhHfNM X-Google-Smtp-Source: AOwi7QAFYBqHdZDwAn2DMrf1TDMgDf+ES3v2UFhhtY2ltgk7HbZ1/Rn3GNL50V0yWgs81d1MiAVVYQ== X-Received: by 10.28.230.198 with SMTP id e67mr917788wmi.8.1505824204000; Tue, 19 Sep 2017 05:30:04 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 19 Sep 2017 14:29:07 +0200 Message-Id: <1505824179-21541-19-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> References: <1505824179-21541-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 18/50] i386/kvm: use a switch statement for MSR detection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ladi Prosek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Ladi Prosek Switch is easier on the eye and might lead to better codegen. Signed-off-by: Ladi Prosek Reviewed-by: David Hildenbrand Message-Id: <20170807085703.32267-2-lprosek@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 75 +++++++++++++++++++++++----------------------------= ---- 1 file changed, 31 insertions(+), 44 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 6db7783..b14a0db 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1081,65 +1081,52 @@ static int kvm_get_supported_msrs(KVMState *s) int i; =20 for (i =3D 0; i < kvm_msr_list->nmsrs; i++) { - if (kvm_msr_list->indices[i] =3D=3D MSR_STAR) { + switch (kvm_msr_list->indices[i]) { + case MSR_STAR: has_msr_star =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_VM_HSAVE_PA) { + break; + case MSR_VM_HSAVE_PA: has_msr_hsave_pa =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_TSC_AUX) { + break; + case MSR_TSC_AUX: has_msr_tsc_aux =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_TSC_ADJUST) { + break; + case MSR_TSC_ADJUST: has_msr_tsc_adjust =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_IA32_TSCDEADLINE) { + break; + case MSR_IA32_TSCDEADLINE: has_msr_tsc_deadline =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_IA32_SMBASE) { + break; + case MSR_IA32_SMBASE: has_msr_smbase =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_IA32_MISC_ENABLE) { + break; + case MSR_IA32_MISC_ENABLE: has_msr_misc_enable =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_IA32_BNDCFGS) { + break; + case MSR_IA32_BNDCFGS: has_msr_bndcfgs =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D MSR_IA32_XSS) { + break; + case MSR_IA32_XSS: has_msr_xss =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_CRASH_CTL) { + break;; + case HV_X64_MSR_CRASH_CTL: has_msr_hv_crash =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_RESET) { + break; + case HV_X64_MSR_RESET: has_msr_hv_reset =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_VP_INDEX) { + break; + case HV_X64_MSR_VP_INDEX: has_msr_hv_vpindex =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_VP_RUNTIME)= { + break; + case HV_X64_MSR_VP_RUNTIME: has_msr_hv_runtime =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_SCONTROL) { + break; + case HV_X64_MSR_SCONTROL: has_msr_hv_synic =3D true; - continue; - } - if (kvm_msr_list->indices[i] =3D=3D HV_X64_MSR_STIMER0_CON= FIG) { + break; + case HV_X64_MSR_STIMER0_CONFIG: has_msr_hv_stimer =3D true; - continue; + break; } } } --=20 1.8.3.1