From nobody Mon May 6 02:27:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1504856930318538.8702542833742; Fri, 8 Sep 2017 00:48:50 -0700 (PDT) Received: from localhost ([::1]:43750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqE1w-0003oY-O8 for importer@patchew.org; Fri, 08 Sep 2017 03:48:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqE0x-0003Du-5v for qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqE0s-000121-OA for qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:47:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50284) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqE0s-0000zP-Iu for qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:47:42 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6B21C04B303; Fri, 8 Sep 2017 07:47:39 +0000 (UTC) Received: from thh440s.redhat.com (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 034735D6A3; Fri, 8 Sep 2017 07:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A6B21C04B303 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=thuth@redhat.com From: Thomas Huth To: Gerd Hoffmann , qemu-devel@nongnu.org Date: Fri, 8 Sep 2017 09:47:32 +0200 Message-Id: <1504856852-12425-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 08 Sep 2017 07:47:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] hw/usb: Disable 'usb-host' device when no USB is available in the target X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Laurent Vivier , David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The 'usb-host' device currently also shows up in the "-device help" list of all targets that do not support USB. That's ugly and kind of confusing for the users. We should only provide this device if both, the host and the target support USB. Signed-off-by: Thomas Huth --- hw/usb/Makefile.objs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs index 97f1c456..323d448 100644 --- a/hw/usb/Makefile.objs +++ b/hw/usb/Makefile.objs @@ -38,7 +38,9 @@ endif common-obj-$(CONFIG_USB_REDIR) +=3D redirect.o quirks.o =20 # usb pass-through -common-obj-y +=3D $(patsubst %,host-%.o,$(HOST_USB)) +common-obj-$(CONFIG_USB) +=3D $(patsubst %,host-%.o,$(HOST_USB)) +common-obj-$(call lnot,$(CONFIG_USB)) +=3D host-stub.o +common-obj-$(CONFIG_ALL) +=3D host-stub.o =20 ifeq ($(CONFIG_USB_LIBUSB),y) common-obj-$(CONFIG_XEN) +=3D xen-usb.o --=20 1.8.3.1