[Qemu-devel] [PATCH for-2.11] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist

Thomas Huth posted 1 patch 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1503551270-30648-1-git-send-email-thuth@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
tests/test-hmp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[Qemu-devel] [PATCH for-2.11] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist
Posted by Thomas Huth 6 years, 7 months ago
The problem with puv3 has been fixed with 0ac241bcf9f9d99a252a352a162f
('unicore32: abort when entering "x 0" on the monitor') and the problem
with tricore_testboard has been fixed with b190f477e29c7cd03a8fee49c96d
('qemu-system-tricore: segfault when entering "x 0" on the monitor').

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/test-hmp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/test-hmp.c b/tests/test-hmp.c
index 4382df0..9f286bf 100644
--- a/tests/test-hmp.c
+++ b/tests/test-hmp.c
@@ -192,8 +192,7 @@ static void add_machine_test_case(const char *mname)
     char *path;
 
     /* Ignore blacklisted machines that have known problems */
-    if (!strcmp("puv3", mname) || !strcmp("tricore_testboard", mname) ||
-        !strcmp("xenfv", mname) || !strcmp("xenpv", mname)) {
+    if (!strcmp("xenfv", mname) || !strcmp("xenpv", mname)) {
         return;
     }
 
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH for-2.11] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist
Posted by Dr. David Alan Gilbert 6 years, 7 months ago
* Thomas Huth (thuth@redhat.com) wrote:
> The problem with puv3 has been fixed with 0ac241bcf9f9d99a252a352a162f
> ('unicore32: abort when entering "x 0" on the monitor') and the problem
> with tricore_testboard has been fixed with b190f477e29c7cd03a8fee49c96d
> ('qemu-system-tricore: segfault when entering "x 0" on the monitor').
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  tests/test-hmp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/test-hmp.c b/tests/test-hmp.c
> index 4382df0..9f286bf 100644
> --- a/tests/test-hmp.c
> +++ b/tests/test-hmp.c
> @@ -192,8 +192,7 @@ static void add_machine_test_case(const char *mname)
>      char *path;
>  
>      /* Ignore blacklisted machines that have known problems */
> -    if (!strcmp("puv3", mname) || !strcmp("tricore_testboard", mname) ||
> -        !strcmp("xenfv", mname) || !strcmp("xenpv", mname)) {
> +    if (!strcmp("xenfv", mname) || !strcmp("xenpv", mname)) {
>          return;
>      }
>  
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK