[Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

Zhang Chen posted 3 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
net/colo-compare.c | 62 +++++++++++++++++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 22 deletions(-)
[Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by Zhang Chen 6 years, 7 months ago
In this serise, we do a lot of job to optimize COLO net performance.
Mainly focus on TCP protocol.

V4:
 - Remove the old patch1.

V3:
 - Rebase on upstream.
 - Remove origin p2.
 - Move the "checkpoint_time_ms" to CompareState,
   in order to aviod multi colo-compare instance conflict.
 - Add "TODO comments" for reset s->checkpoint_time_ms.
 - Add a new patch fix comments and scheme.

V2:
 - Rename p2's subject.


Zhang Chen (3):
  net/colo-compare.c: Optimize unpredictable tcp options comparison
  net/colo-compare.c: Adjust net queue pop order for performance
  net/colo-compare.c: Fix comments and scheme

 net/colo-compare.c | 62 +++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 40 insertions(+), 22 deletions(-)

-- 
2.7.4




Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by no-reply@patchew.org 6 years, 7 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
37052358b5 net/colo-compare.c: Fix comments and scheme
46824a6565 net/colo-compare.c: Adjust net queue pop order for performance
acea048383 net/colo-compare.c: Optimize unpredictable tcp options comparison

=== OUTPUT BEGIN ===
Checking PATCH 1/3: net/colo-compare.c: Optimize unpredictable tcp options comparison...
Checking PATCH 2/3: net/colo-compare.c: Adjust net queue pop order for performance...
Checking PATCH 3/3: net/colo-compare.c: Fix comments and scheme...
ERROR: space prohibited after that '-' (ctx:WxW)
#18: FILE: net/colo-compare.c:47:
+  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
                     ^

ERROR: space prohibited after that '-' (ctx:OxW)
#18: FILE: net/colo-compare.c:47:
+  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
                                               ^

ERROR: space required one side of that '--' (ctx:WxW)
#18: FILE: net/colo-compare.c:47:
+  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
                                                                   ^

total: 3 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by Jason Wang 6 years, 7 months ago

On 2017年08月22日 15:16, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
> Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>      echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>      if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>          failed=1
>          echo
>      fi
>      n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 37052358b5 net/colo-compare.c: Fix comments and scheme
> 46824a6565 net/colo-compare.c: Adjust net queue pop order for performance
> acea048383 net/colo-compare.c: Optimize unpredictable tcp options comparison
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/3: net/colo-compare.c: Optimize unpredictable tcp options comparison...
> Checking PATCH 2/3: net/colo-compare.c: Adjust net queue pop order for performance...
> Checking PATCH 3/3: net/colo-compare.c: Fix comments and scheme...
> ERROR: space prohibited after that '-' (ctx:WxW)
> #18: FILE: net/colo-compare.c:47:
> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>                       ^
>
> ERROR: space prohibited after that '-' (ctx:OxW)
> #18: FILE: net/colo-compare.c:47:
> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>                                                 ^
>
> ERROR: space required one side of that '--' (ctx:WxW)
> #18: FILE: net/colo-compare.c:47:
> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>                                                                     ^
>
> total: 3 errors, 0 warnings, 40 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@freelists.org

Fam, this looks like a false positive since it was actually an ascii 
graph inside a comment?

Thanks

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by Fam Zheng 6 years, 7 months ago
On Tue, 08/29 17:01, Jason Wang wrote:
> 
> 
> On 2017年08月22日 15:16, no-reply@patchew.org wrote:
> > Hi,
> > 
> > This series seems to have some coding style problems. See output below for
> > more information:
> > 
> > Type: series
> > Message-id: 1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
> > Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
> > 
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > 
> > BASE=base
> > n=1
> > total=$(git log --oneline $BASE.. | wc -l)
> > failed=0
> > 
> > git config --local diff.renamelimit 0
> > git config --local diff.renames True
> > 
> > commits="$(git log --format=%H --reverse $BASE..)"
> > for c in $commits; do
> >      echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> >      if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
> >          failed=1
> >          echo
> >      fi
> >      n=$((n+1))
> > done
> > 
> > exit $failed
> > === TEST SCRIPT END ===
> > 
> > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> > Switched to a new branch 'test'
> > 37052358b5 net/colo-compare.c: Fix comments and scheme
> > 46824a6565 net/colo-compare.c: Adjust net queue pop order for performance
> > acea048383 net/colo-compare.c: Optimize unpredictable tcp options comparison
> > 
> > === OUTPUT BEGIN ===
> > Checking PATCH 1/3: net/colo-compare.c: Optimize unpredictable tcp options comparison...
> > Checking PATCH 2/3: net/colo-compare.c: Adjust net queue pop order for performance...
> > Checking PATCH 3/3: net/colo-compare.c: Fix comments and scheme...
> > ERROR: space prohibited after that '-' (ctx:WxW)
> > #18: FILE: net/colo-compare.c:47:
> > +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
> >                       ^
> > 
> > ERROR: space prohibited after that '-' (ctx:OxW)
> > #18: FILE: net/colo-compare.c:47:
> > +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
> >                                                 ^
> > 
> > ERROR: space required one side of that '--' (ctx:WxW)
> > #18: FILE: net/colo-compare.c:47:
> > +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
> >                                                                     ^
> > 
> > total: 3 errors, 0 warnings, 40 lines checked
> > 
> > Your patch has style problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > 
> > === OUTPUT END ===
> > 
> > Test command exited with code: 1
> > 
> > 
> > ---
> > Email generated automatically by Patchew [http://patchew.org/].
> > Please send your feedback to patchew-devel@freelists.org
> 
> Fam, this looks like a false positive since it was actually an ascii graph
> inside a comment?
> 

Yes, let's just ignore this report.

Fam

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by Jason Wang 6 years, 7 months ago

On 2017年08月29日 18:45, Fam Zheng wrote:
> On Tue, 08/29 17:01, Jason Wang wrote:
>>
>> On 2017年08月22日 15:16, no-reply@patchew.org wrote:
>>> Hi,
>>>
>>> This series seems to have some coding style problems. See output below for
>>> more information:
>>>
>>> Type: series
>>> Message-id: 1503305719-2512-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
>>> Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
>>>
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>>
>>> BASE=base
>>> n=1
>>> total=$(git log --oneline $BASE.. | wc -l)
>>> failed=0
>>>
>>> git config --local diff.renamelimit 0
>>> git config --local diff.renames True
>>>
>>> commits="$(git log --format=%H --reverse $BASE..)"
>>> for c in $commits; do
>>>       echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>>>       if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>>>           failed=1
>>>           echo
>>>       fi
>>>       n=$((n+1))
>>> done
>>>
>>> exit $failed
>>> === TEST SCRIPT END ===
>>>
>>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>>> Switched to a new branch 'test'
>>> 37052358b5 net/colo-compare.c: Fix comments and scheme
>>> 46824a6565 net/colo-compare.c: Adjust net queue pop order for performance
>>> acea048383 net/colo-compare.c: Optimize unpredictable tcp options comparison
>>>
>>> === OUTPUT BEGIN ===
>>> Checking PATCH 1/3: net/colo-compare.c: Optimize unpredictable tcp options comparison...
>>> Checking PATCH 2/3: net/colo-compare.c: Adjust net queue pop order for performance...
>>> Checking PATCH 3/3: net/colo-compare.c: Fix comments and scheme...
>>> ERROR: space prohibited after that '-' (ctx:WxW)
>>> #18: FILE: net/colo-compare.c:47:
>>> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>>>                        ^
>>>
>>> ERROR: space prohibited after that '-' (ctx:OxW)
>>> #18: FILE: net/colo-compare.c:47:
>>> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>>>                                                  ^
>>>
>>> ERROR: space required one side of that '--' (ctx:WxW)
>>> #18: FILE: net/colo-compare.c:47:
>>> +  |   conn list   + - >      conn     + ------- >      conn     + -- > .......
>>>                                                                      ^
>>>
>>> total: 3 errors, 0 warnings, 40 lines checked
>>>
>>> Your patch has style problems, please review.  If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>>>
>>> === OUTPUT END ===
>>>
>>> Test command exited with code: 1
>>>
>>>
>>> ---
>>> Email generated automatically by Patchew [http://patchew.org/].
>>> Please send your feedback to patchew-devel@freelists.org
>> Fam, this looks like a false positive since it was actually an ascii graph
>> inside a comment?
>>
> Yes, let's just ignore this report.
>
> Fam

Thanks.

I've queued this series.


Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance
Posted by Zhang Chen 6 years, 7 months ago
Hi~ Jason.

Have any comments for this series?

Thanks

Zhang Chen


On 08/21/2017 04:55 PM, Zhang Chen wrote:
> In this serise, we do a lot of job to optimize COLO net performance.
> Mainly focus on TCP protocol.
>
> V4:
>   - Remove the old patch1.
>
> V3:
>   - Rebase on upstream.
>   - Remove origin p2.
>   - Move the "checkpoint_time_ms" to CompareState,
>     in order to aviod multi colo-compare instance conflict.
>   - Add "TODO comments" for reset s->checkpoint_time_ms.
>   - Add a new patch fix comments and scheme.
>
> V2:
>   - Rename p2's subject.
>
>
> Zhang Chen (3):
>    net/colo-compare.c: Optimize unpredictable tcp options comparison
>    net/colo-compare.c: Adjust net queue pop order for performance
>    net/colo-compare.c: Fix comments and scheme
>
>   net/colo-compare.c | 62 +++++++++++++++++++++++++++++++++++-------------------
>   1 file changed, 40 insertions(+), 22 deletions(-)
>

-- 
Thanks
Zhang Chen