From nobody Mon Feb 9 23:00:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502117573325471.462070871828; Mon, 7 Aug 2017 07:52:53 -0700 (PDT) Received: from localhost ([::1]:37719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dejOk-00045y-5k for importer@patchew.org; Mon, 07 Aug 2017 10:52:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dejIt-00079J-Uz for qemu-devel@nongnu.org; Mon, 07 Aug 2017 10:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dejIe-0003mN-GF for qemu-devel@nongnu.org; Mon, 07 Aug 2017 10:46:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54754) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dejIR-0003VU-35; Mon, 07 Aug 2017 10:46:19 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 018DA72FDD; Mon, 7 Aug 2017 14:46:17 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-254.ams2.redhat.com [10.36.116.254]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 413C17FE83; Mon, 7 Aug 2017 14:46:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2EF5111386D0; Mon, 7 Aug 2017 16:46:00 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 018DA72FDD Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=armbru@redhat.com From: Markus Armbruster To: qemu-devel@nongnu.org Date: Mon, 7 Aug 2017 16:45:15 +0200 Message-Id: <1502117160-24655-12-git-send-email-armbru@redhat.com> In-Reply-To: <1502117160-24655-1-git-send-email-armbru@redhat.com> References: <1502117160-24655-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 07 Aug 2017 14:46:18 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC PATCH 11/56] monitor: Drop unused HMP .args_type 'M' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, jcody@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The previous commit switched balloon from 'M' to 'o', rendering 'M' unused. It was never used for anything else. Drop it. Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- monitor.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/monitor.c b/monitor.c index 8b54ba1..3b2757e 100644 --- a/monitor.c +++ b/monitor.c @@ -101,8 +101,6 @@ * TYPEs that put an int64_t value with key NAME: * 'l' Argument is an expression (QEMU pocket calculator). * 'i' Like 'l' except value must fit into 32 bit unsigned. - * 'M' Like 'l' except value must not be negative and is multiplied - * by 2^20 (think "mebibyte"). * * TYPEs that put an uint64_t value with key NAME: * 'o' Argument is a size (think "octets"). Without suffix the @@ -134,7 +132,7 @@ * '?' Argument is optional, nothing is put when it is absent * (all types except 'O', '/', 'b'). * '.' Argument is optional, must be preceded by '.' if present - * (only types 'i', 'l', 'M') + * (only types 'i', 'l') */ =20 typedef struct mon_cmd_t { @@ -2913,7 +2911,6 @@ static QDict *monitor_parse_arguments(Monitor *mon, break; case 'i': case 'l': - case 'M': { int64_t val; =20 @@ -2944,12 +2941,6 @@ static QDict *monitor_parse_arguments(Monitor *mon, monitor_printf(mon, "\'%s\' has failed: ", cmd->name); monitor_printf(mon, "integer is for 32-bit values\n"); goto fail; - } else if (c =3D=3D 'M') { - if (val < 0) { - monitor_printf(mon, "enter a positive value\n"); - goto fail; - } - val <<=3D 20; } qdict_put_int(qdict, key, val); } --=20 2.7.5