From nobody Fri May 3 20:03:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501675927222832.3770037234009; Wed, 2 Aug 2017 05:12:07 -0700 (PDT) Received: from localhost ([::1]:47475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcsVN-0001Z6-Os for importer@patchew.org; Wed, 02 Aug 2017 08:12:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcpDz-0004gx-6E for qemu-devel@nongnu.org; Wed, 02 Aug 2017 04:41:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcpDv-0006pW-5q for qemu-devel@nongnu.org; Wed, 02 Aug 2017 04:41:51 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:33946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcpDu-0006ol-WC for qemu-devel@nongnu.org; Wed, 02 Aug 2017 04:41:47 -0400 Received: by mail-pg0-x242.google.com with SMTP id y192so5790322pgd.1 for ; Wed, 02 Aug 2017 01:41:45 -0700 (PDT) Received: from gmail.com ([117.196.126.40]) by smtp.gmail.com with ESMTPSA id f65sm13494499pfc.109.2017.08.02.01.41.40 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 02 Aug 2017 01:41:43 -0700 (PDT) Received: by gmail.com (sSMTP sendmail emulation); Wed, 02 Aug 2017 14:11:37 +0530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=wrySimVow/WOTe9vbCnQR/FxIelgHFkOPpjTVNcJMxA=; b=D45RzQ/Sg9V0J79mBZVpUZh0KiX8tPXtlFTmFJA56dyekX9t/9oy8iNUgLf9lQlexW SsHR3V9mmZlRGoEmo78d6DTLRjPAdtHjjSh4FjmSQFlLp5G7t01iRrqrScMkMPc4s4J7 scdBT4MGzK1OwRRZVP/ES/WvCeajafZN8t00SeeXw8AdK556qV07eH7GdpC6ZTUcpErq eAu7QX5mInSvDtMKMh3mSHlULB/1yOSHceVw4IZknS7a8dqm/umUX8a82+ZkgPQQrFOA FBTFnFEOuTET8mZSQzHQ0L//1iwGfo0wKBBD+Yng3O4o2kjbcDgPcPOeP2f4i59xKMO4 1wwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wrySimVow/WOTe9vbCnQR/FxIelgHFkOPpjTVNcJMxA=; b=KXtvoQELwItrcLm09I+biTRA9BRzMYHuoIZATOiC90gqIaxsdwp51jeZRx8NTKcRAv IEkYSjNKq2fYTkg/zVMxtfkrPYSubWIcSK8rbCiC47xQja9FXtimLoKj7XyHAs2YpuU9 Rr4aLQ/1f0m5jEKfY9+y/P8IZKVrvyTT66gOco1TDGSd2oYgs2YwD254UAl3H1BKNKn0 IFSSA97Px/V+ZZKxW0tJq2qPN5sm/WfNAkEfg5NVf7RshfQkupPeOihJ28KTQOlahrhB 8EXniSVFrEzXeaYZhTlJ6A+Cog6VJ1fps3PvnXh2X7vrwXoiN0+0n+vBVjGxZFQVyj3N h6eA== X-Gm-Message-State: AIVw112IVgjr3sNaiK4uJo5Ic5yPRmwbCpyOgoedZr3MYCdlsuUBd+rv IxcxtJJ1vJ19OQ== X-Received: by 10.99.117.20 with SMTP id q20mr21315686pgc.5.1501663304519; Wed, 02 Aug 2017 01:41:44 -0700 (PDT) From: Bhumika Goyal To: julia.lawall@lip6.fr, somlo@cmu.edu, mst@redhat.com, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Date: Wed, 2 Aug 2017 14:11:35 +0530 Message-Id: <1501663295-18774-1-git-send-email-bhumirks@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 X-Mailman-Approved-At: Wed, 02 Aug 2017 08:06:33 -0400 Subject: [Qemu-devel] [PATCH] firmware: add const to bin_attribute structures X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bhumika Goyal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add const to bin_attribute structures as they are only passed to the functions sysfs_{remove/create}_bin_file. The arguments passed are of type const, so declare the structures to be const. Done using Coccinelle. @m disable optional_qualifier@ identifier s; position p; @@ static struct bin_attribute s@p=3D{...}; @okay1@ position p; identifier m.s; @@ ( sysfs_create_bin_file(...,&s@p,...) | sysfs_remove_bin_file(...,&s@p,...) ) @bad@ position p!=3D{m.p,okay1.p}; identifier m.s; @@ s@p @change depends on !bad disable optional_qualifier@ identifier m.s; @@ static +const struct bin_attribute s=3D{...}; Signed-off-by: Bhumika Goyal Acked-by: Michael S. Tsirkin --- drivers/firmware/dell_rbu.c | 6 +++--- drivers/firmware/dmi-sysfs.c | 2 +- drivers/firmware/google/gsmi.c | 2 +- drivers/firmware/google/memconsole.c | 2 +- drivers/firmware/qemu_fw_cfg.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c index 2f452f1..a771360 100644 --- a/drivers/firmware/dell_rbu.c +++ b/drivers/firmware/dell_rbu.c @@ -675,18 +675,18 @@ static ssize_t write_rbu_packet_size(struct file *fil= p, struct kobject *kobj, return count; } =20 -static struct bin_attribute rbu_data_attr =3D { +static const struct bin_attribute rbu_data_attr =3D { .attr =3D {.name =3D "data", .mode =3D 0444}, .read =3D read_rbu_data, }; =20 -static struct bin_attribute rbu_image_type_attr =3D { +static const struct bin_attribute rbu_image_type_attr =3D { .attr =3D {.name =3D "image_type", .mode =3D 0644}, .read =3D read_rbu_image_type, .write =3D write_rbu_image_type, }; =20 -static struct bin_attribute rbu_packet_size_attr =3D { +static const struct bin_attribute rbu_packet_size_attr =3D { .attr =3D {.name =3D "packet_size", .mode =3D 0644}, .read =3D read_rbu_packet_size, .write =3D write_rbu_packet_size, diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c index d5de6ee..936e656 100644 --- a/drivers/firmware/dmi-sysfs.c +++ b/drivers/firmware/dmi-sysfs.c @@ -440,7 +440,7 @@ static ssize_t dmi_sel_raw_read(struct file *filp, stru= ct kobject *kobj, return find_dmi_entry(entry, dmi_sel_raw_read_helper, &state); } =20 -static struct bin_attribute dmi_sel_raw_attr =3D { +static const struct bin_attribute dmi_sel_raw_attr =3D { .attr =3D {.name =3D "raw_event_log", .mode =3D 0400}, .read =3D dmi_sel_raw_read, }; diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index c8f169b..1ad29f7 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -508,7 +508,7 @@ static ssize_t eventlog_write(struct file *filp, struct= kobject *kobj, =20 } =20 -static struct bin_attribute eventlog_bin_attr =3D { +static const struct bin_attribute eventlog_bin_attr =3D { .attr =3D {.name =3D "append_to_eventlog", .mode =3D 0200}, .write =3D eventlog_write, }; diff --git a/drivers/firmware/google/memconsole.c b/drivers/firmware/google= /memconsole.c index 166f07c..b11a02c 100644 --- a/drivers/firmware/google/memconsole.c +++ b/drivers/firmware/google/memconsole.c @@ -33,7 +33,7 @@ static ssize_t memconsole_read(struct file *filp, struct = kobject *kobp, return memconsole_read_func(buf, pos, count); } =20 -static struct bin_attribute memconsole_bin_attr =3D { +static const struct bin_attribute memconsole_bin_attr =3D { .attr =3D {.name =3D "log", .mode =3D 0444}, .read =3D memconsole_read, }; diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 0e20116..f254977 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -343,7 +343,7 @@ static ssize_t fw_cfg_sysfs_read_raw(struct file *filp,= struct kobject *kobj, return count; } =20 -static struct bin_attribute fw_cfg_sysfs_attr_raw =3D { +static const struct bin_attribute fw_cfg_sysfs_attr_raw =3D { .attr =3D { .name =3D "raw", .mode =3D S_IRUSR }, .read =3D fw_cfg_sysfs_read_raw, }; --=20 1.9.1