From nobody Mon Feb 9 10:12:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501604527297964.158738350676; Tue, 1 Aug 2017 09:22:07 -0700 (PDT) Received: from localhost ([::1]:43602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZvo-0007uD-LH for importer@patchew.org; Tue, 01 Aug 2017 12:22:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZrV-0004J5-6u for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcZrU-0007Aq-4F for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:36 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcZrT-0007AN-Th for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:36 -0400 Received: by mail-wm0-x243.google.com with SMTP id d40so3781576wma.3 for ; Tue, 01 Aug 2017 09:17:35 -0700 (PDT) Received: from 640k.lan (94-39-192-75.adsl-ull.clienti.tiscali.it. [94.39.192.75]) by smtp.gmail.com with ESMTPSA id u187sm1724160wmd.26.2017.08.01.09.17.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 09:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JzISVgl6Y2myrhMXijGdXCUSQYWboT1ZfEsQEyd8MMs=; b=HmhLDlUa/kTbg4iqw6i+wSEuj83aifkatXESdr+7w6LXbDhNQOLBdDk7eEhyb25RJF YnlHNvRDLljf4eMQqd8FxLFtRLx3BbH0fqLSMxF+wQihbj/h6e/VT7+NNw6vcixV4am1 JDHCkHaBrwDdtO5yGF5JzbrUVhqL2YZLU/J2D3qz44y9ilh9WQWCpWiiTEV4RDviBBbe 6jnRA+5hxkagBHIl0US9+dAKv13FHuzRcVaBt+q1TBZ7Kdu9qeQT9e5D9TPwEtHf0JLO bV7AeyyJEep7VfvhRTdItB/pH++TvearTKG302xE4LUdXQQYFY9wv10aAu/33mclDzCd KwyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JzISVgl6Y2myrhMXijGdXCUSQYWboT1ZfEsQEyd8MMs=; b=hz5zaQZp5xGvSnbbwF+Dny/s9htESDGXRlWqkULz5lk21jL7p/7kQTYuAViHDco47q QnY3EbcF8NBXXS+ApmF1zF7b+Fx84B72fxyeuAiMYdheksh009vhk5aJCWkpD+596mOy GdL1rjUJ571goj5LIo14av1O/IIQTreLq/ETnOUq5VGtAWJX0Tm2PkLpWr17uL/dMJXP EMqHxcIbiOpzLhpwNuUD4tbS2g13jpEQYsUHIHRmNoH2zb2Za0wCnDwTZurpwuw3pA3T 2Sdx7gK3/RDR+0KbfV6LZ6YcYzGDu/ynHglSSBbQlvPYf++71WCEs37sUuQQlBEHo+xF g2Ww== X-Gm-Message-State: AIVw111NRUPg0OZCC5ZWbF62W1exfSMw3H48NPCAJmWx4wQNhaCDQWEO JQ+KiojcnBWqBsmCsK8= X-Received: by 10.28.234.18 with SMTP id i18mr1897565wmh.89.1501604254544; Tue, 01 Aug 2017 09:17:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 1 Aug 2017 18:17:12 +0200 Message-Id: <1501604245-33460-5-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1501604245-33460-1-git-send-email-pbonzini@redhat.com> References: <1501604245-33460-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 04/17] char-fd: remove useless chr pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau Apparently unused since it was introduced in commit a29753f8aa79a34a324afebe340182a51a5aef11. Now, it can be trivially accessed by CHARDEV() of self. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20170720100046.4424-1-marcandre.lureau@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- chardev/char-fd.c | 1 - include/chardev/char-fd.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/chardev/char-fd.c b/chardev/char-fd.c index 1584a3d..6a62a54 100644 --- a/chardev/char-fd.c +++ b/chardev/char-fd.c @@ -141,7 +141,6 @@ void qemu_chr_open_fd(Chardev *chr, qio_channel_set_name(QIO_CHANNEL(s->ioc_out), name); g_free(name); qemu_set_nonblock(fd_out); - s->chr =3D chr; } =20 static void char_fd_class_init(ObjectClass *oc, void *data) diff --git a/include/chardev/char-fd.h b/include/chardev/char-fd.h index 55ae5b4..e7c2b17 100644 --- a/include/chardev/char-fd.h +++ b/include/chardev/char-fd.h @@ -29,7 +29,7 @@ =20 typedef struct FDChardev { Chardev parent; - Chardev *chr; + QIOChannel *ioc_in, *ioc_out; int max_size; } FDChardev; --=20 1.8.3.1