From nobody Mon Feb 9 11:51:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501604652097771.2138582917497; Tue, 1 Aug 2017 09:24:12 -0700 (PDT) Received: from localhost ([::1]:43611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZxq-0001VS-Mb for importer@patchew.org; Tue, 01 Aug 2017 12:24:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZrf-0004Vi-UX for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcZrf-0007Ku-1r for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:47 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:38110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcZre-0007KJ-Rd for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:17:46 -0400 Received: by mail-wr0-x242.google.com with SMTP id g32so1795886wrd.5 for ; Tue, 01 Aug 2017 09:17:46 -0700 (PDT) Received: from 640k.lan (94-39-192-75.adsl-ull.clienti.tiscali.it. [94.39.192.75]) by smtp.gmail.com with ESMTPSA id u187sm1724160wmd.26.2017.08.01.09.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 09:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=kwTYugsOtXBA1z7GXGdLajOiiFquJkpfb3q8FbH/wPM=; b=rmxw5xxfAIzLN8kbUeDSGeFpE+jyBltc6EFNjxFzsZXo3pgv7IqOC9ZOqk0FRKGlwJ ZyP3ck3eTF2OLt7gPIrVwvaXJwi8MRSeF6dxe+dwgVBGTUAcPLXKguP55hlTlUX/pWqz pB8bpTHo5CK/Vjn+ypNH9b1FGp903f3QEb+l3xalfLtEECgPWrVCcQNyR1Ojpv00yx2x mlsjAHsdCVwHlEG2JGvY2jZ6ep/8k7OA7KKgOKzCYwhmVKep4coYTCfjgAmeR+fVQyKP cpWjp4KWmeblOTcRTY6MXDT9axAMLkxM6ZtnB0TLu5DmmMHqRN9W5r2Rrx45hJMZMhwN kJSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=kwTYugsOtXBA1z7GXGdLajOiiFquJkpfb3q8FbH/wPM=; b=hw1WRRtlKMRxVHl+AmwHdmeKHA7kzUtkxk7nCwwMudEyTMXCf5ySRjs3rg3c2zewQ3 yV3RH5HA89UzKVHseR4810/sph2JIuRKH/uTFDUznwFqJDQa8pXRrUcOFlIQ/sdCqeBB C4S6G0GTMkLIT8/DClJ3is9OMil1Itp/H4GEbfpeeih1gvLmAsKnU0nWxMyBRl0DGrMN RAqSw2xffJpI4KCQcVwHICQlepUPwlDXgqyRi/0WMIY6ct8Xt7FiBlpDIU80Kc2/slnQ uK+MKbcFE1eXvY1yh8QozBRBDiagsHnX4FWUXCOO8/KmNYsFNuFb0N1qSUJKyb9Oxjan DLlw== X-Gm-Message-State: AIVw112plKh70xpe2LN5gNlzkyI8l2yurc/iFoOFssbdyB8PeZ0Z69l4 2piAjXeBQQ+IZbohhzk= X-Received: by 10.223.188.17 with SMTP id s17mr14227308wrg.201.1501604265721; Tue, 01 Aug 2017 09:17:45 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 1 Aug 2017 18:17:21 +0200 Message-Id: <1501604245-33460-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1501604245-33460-1-git-send-email-pbonzini@redhat.com> References: <1501604245-33460-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 13/17] hw/scsi/vmw_pvscsi: Convert to realize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mao Zhongyi , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Mao Zhongyi Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Reviewed-by: Dmitry Fleytman Cc: Paolo Bonzini Cc: Markus Armbruster Signed-off-by: Mao Zhongyi Message-Id: <20170726084153.10121-2-maozy.fnst@cn.fujitsu.com> Signed-off-by: Paolo Bonzini --- hw/scsi/vmw_pvscsi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index d92973e..77d8b6f 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1103,8 +1103,8 @@ static const struct SCSIBusInfo pvscsi_scsi_info =3D { .cancel =3D pvscsi_request_cancelled, }; =20 -static int -pvscsi_init(PCIDevice *pci_dev) +static void +pvscsi_realizefn(PCIDevice *pci_dev, Error **errp) { PVSCSIState *s =3D PVSCSI(pci_dev); =20 @@ -1144,8 +1144,6 @@ pvscsi_init(PCIDevice *pci_dev) /* override default SCSI bus hotplug-handler, with pvscsi's one */ qbus_set_hotplug_handler(BUS(&s->bus), DEVICE(s), &error_abort); pvscsi_reset_state(s); - - return 0; } =20 static void @@ -1278,7 +1276,7 @@ static void pvscsi_class_init(ObjectClass *klass, voi= d *data) PVSCSIClass *pvs_k =3D PVSCSI_DEVICE_CLASS(klass); HotplugHandlerClass *hc =3D HOTPLUG_HANDLER_CLASS(klass); =20 - k->init =3D pvscsi_init; + k->realize =3D pvscsi_realizefn; k->exit =3D pvscsi_uninit; k->vendor_id =3D PCI_VENDOR_ID_VMWARE; k->device_id =3D PCI_DEVICE_ID_VMWARE_PVSCSI; --=20 1.8.3.1