From nobody Tue Feb 10 12:57:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150122936775412.87010479223602; Fri, 28 Jul 2017 01:09:27 -0700 (PDT) Received: from localhost ([::1]:46660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1db0Kr-0002Co-3h for importer@patchew.org; Fri, 28 Jul 2017 04:09:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1db0J0-0000sh-76 for qemu-devel@nongnu.org; Fri, 28 Jul 2017 04:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1db0Ix-0001AK-2W for qemu-devel@nongnu.org; Fri, 28 Jul 2017 04:07:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51608) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1db0Iw-0001A3-Sl for qemu-devel@nongnu.org; Fri, 28 Jul 2017 04:07:27 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C9021974BB; Fri, 28 Jul 2017 08:07:25 +0000 (UTC) Received: from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com [10.66.15.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF844600C2; Fri, 28 Jul 2017 08:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C9021974BB Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=peterx@redhat.com From: Peter Xu To: qemu-devel@nongnu.org Date: Fri, 28 Jul 2017 16:06:19 +0800 Message-Id: <1501229198-30588-11-git-send-email-peterx@redhat.com> In-Reply-To: <1501229198-30588-1-git-send-email-peterx@redhat.com> References: <1501229198-30588-1-git-send-email-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 28 Jul 2017 08:07:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Andrea Arcangeli , Juan Quintela , Alexey Perevalov , peterx@redhat.com, "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This provides a way to start postcopy ASAP when migration starts. To do this, we need both: -global migration.x-postcopy-ram=3Don \ -global migration.x-postcopy-fast=3Don Signed-off-by: Peter Xu --- migration/migration.c | 9 ++++++++- migration/migration.h | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 5b2602e..efee87e 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1936,6 +1936,11 @@ bool migrate_colo_enabled(void) return s->enabled_capabilities[MIGRATION_CAPABILITY_X_COLO]; } =20 +static bool postcopy_should_start(MigrationState *s) +{ + return atomic_read(&s->start_postcopy) || s->start_postcopy_fast; +} + /* * Master migration thread on the source VM. * It drives the migration and pumps the data down the outgoing channel. @@ -2013,7 +2018,7 @@ static void *migration_thread(void *opaque) if (migrate_postcopy_ram() && s->state !=3D MIGRATION_STATUS_POSTCOPY_ACTIVE && pend_nonpost <=3D threshold_size && - atomic_read(&s->start_postcopy)) { + postcopy_should_start(s)) { =20 if (!postcopy_start(s, &old_vm_running)) { current_active_state =3D MIGRATION_STATUS_POSTCOPY= _ACTIVE; @@ -2170,6 +2175,8 @@ static Property migration_properties[] =3D { send_configuration, true), DEFINE_PROP_BOOL("send-section-footer", MigrationState, send_section_footer, true), + DEFINE_PROP_BOOL("x-postcopy-fast", MigrationState, + start_postcopy_fast, false), =20 /* Migration parameters */ DEFINE_PROP_INT64("x-compress-level", MigrationState, diff --git a/migration/migration.h b/migration/migration.h index 70e3094..e902bae 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -113,6 +113,8 @@ struct MigrationState =20 /* Flag set once the migration has been asked to enter postcopy */ bool start_postcopy; + /* Set the flag if we want to start postcopy ASAP when migration start= s */ + bool start_postcopy_fast; /* Flag set after postcopy has sent the device state */ bool postcopy_after_devices; =20 --=20 2.7.4