From nobody Tue Feb 10 08:27:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500990735747237.59948252378763; Tue, 25 Jul 2017 06:52:15 -0700 (PDT) Received: from localhost ([::1]:60927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da0Fu-0008Kb-A6 for importer@patchew.org; Tue, 25 Jul 2017 09:52:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da0CY-0005pv-P4 for qemu-devel@nongnu.org; Tue, 25 Jul 2017 09:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da0CX-0001NI-UP for qemu-devel@nongnu.org; Tue, 25 Jul 2017 09:48:42 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:37088) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1da0CX-0001Mw-NB for qemu-devel@nongnu.org; Tue, 25 Jul 2017 09:48:41 -0400 Received: by mail-wr0-x243.google.com with SMTP id 12so11896721wrb.4 for ; Tue, 25 Jul 2017 06:48:41 -0700 (PDT) Received: from 640k.lan (94-39-195-172.adsl-ull.clienti.tiscali.it. [94.39.195.172]) by smtp.gmail.com with ESMTPSA id q10sm19034944wrb.3.2017.07.25.06.48.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=338HV9i/rlAOELeU1l4LLN5teHeFWgGTnm19OcoP+Oc=; b=kxxrU+EzdZhlveb93qQYmvPPMOHYnI9zuXeMC6F9GVlspWnNLeBwL49mh04ELO8x7e Qk7EJLwlXPw2oY29Uu2slxnCBCrwOJ7mqrUJ7lk5SO38aOpSnUIV5XLNghBGF+lhK1jI 9s7oXPhdqitS7SiQLqgPvvcpt2Naj1i2WhEnWE1MuADukZvaiWndADyYgS6g72+fdxms l7PuBi96WZEwQAPti0Pln+HF3hnARlv/gNWVEjKzMfz56lEfU5Sgt2lCSL7Zb1YioCZ1 GRMWd6zELgFqaMMM2NWxDTxahgUvSSxGUBYCi7Zt0Ss8GoOvt7Yz+laCvkejOQ5VYxfy AhHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=338HV9i/rlAOELeU1l4LLN5teHeFWgGTnm19OcoP+Oc=; b=WDlPL6VnLQvFio4+lffZEppPxtNnl1wzOOdWbPWXAFEEaivasmWqGBGGsdc7sswICR +ga2jr06wxuTgdEJ2QH3pnCeYfZd9ZR/wJS/oChTiML/gsfNaQzIqVey+uTUK7mvrQC1 aJeHtYzZpbFxITSvEpztClBXChpkId+D12F/VSx7OiabYo4+EvNNZ3YcJsoJdNU2jtNM mRKktKTktH3FfY+BOKIqiwAyN2Io1E6Eg8KtnCN8CBUXegL9qUHg+RsL6vaZ9hwsOESb eXxQfw4jjVvTBmFKnkzMMebm4LKbKMEk39YNkUD06fVoZ1YQIxdyRWYbuuLSZtdvL2nR F/CA== X-Gm-Message-State: AIVw113uvf7z8Awg7xFtr4/GkGwWc9vnKWsn8qI5mzyfOFp9z2A1SA3R aPYyTdnKwSj5pRgwjok= X-Received: by 10.223.180.88 with SMTP id v24mr19394832wrd.29.1500990520226; Tue, 25 Jul 2017 06:48:40 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 25 Jul 2017 15:48:32 +0200 Message-Id: <1500990514-30326-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1500990514-30326-1-git-send-email-pbonzini@redhat.com> References: <1500990514-30326-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH 2/4] rtc-test: introduce more update tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.hao2@zte.com.cn, liu.yi24@zte.com.cn Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Test divider reset and UIP behavior. Signed-off-by: Paolo Bonzini --- tests/rtc-test.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 798cf5e..d7a96cb 100644 --- a/tests/rtc-test.c +++ b/tests/rtc-test.c @@ -325,6 +325,30 @@ static void set_datetime_bcd(int h, int min, int s, in= t d, int m, int y) cmos_write(RTC_DAY_OF_MONTH, d); } =20 +static void set_datetime_dec(int h, int min, int s, int d, int m, int y) +{ + cmos_write(RTC_HOURS, h); + cmos_write(RTC_MINUTES, min); + cmos_write(RTC_SECONDS, s); + cmos_write(RTC_YEAR, y % 100); + cmos_write(RTC_CENTURY, y / 100); + cmos_write(RTC_MONTH, m); + cmos_write(RTC_DAY_OF_MONTH, d); +} + +static void set_datetime(int mode, int h, int min, int s, int d, int m, in= t y) +{ + cmos_write(RTC_REG_B, mode); + + cmos_write(RTC_REG_A, 0x76); + if (mode & REG_B_DM) { + set_datetime_dec(h, min, s, d, m, y); + } else { + set_datetime_bcd(h, min, s, d, m, y); + } + cmos_write(RTC_REG_A, 0x26); +} + #define assert_time(h, m, s) \ do { \ g_assert_cmpint(cmos_read(RTC_HOURS), =3D=3D, h); \ @@ -559,6 +583,60 @@ static void register_b_set_flag(void) assert_datetime_bcd(0x02, 0x04, 0x59, 0x02, 0x02, 0x2011); } =20 +static void divider_reset(void) +{ + /* Enable binary-coded decimal (BCD) mode in Register B*/ + cmos_write(RTC_REG_B, REG_B_24H); + + /* Enter divider reset */ + cmos_write(RTC_REG_A, 0x76); + set_datetime_bcd(0x02, 0x04, 0x58, 0x02, 0x02, 0x2011); + + assert_datetime_bcd(0x02, 0x04, 0x58, 0x02, 0x02, 0x2011); + + /* Since divider reset flag is still enabled, these are equality check= s. */ + clock_step(1000000000LL); + assert_datetime_bcd(0x02, 0x04, 0x58, 0x02, 0x02, 0x2011); + + /* The first update ends 500 ms after divider reset */ + cmos_write(RTC_REG_A, 0x26); + clock_step(500000000LL - UIP_HOLD_LENGTH - 1); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, =3D=3D, 0); + assert_datetime_bcd(0x02, 0x04, 0x58, 0x02, 0x02, 0x2011); + + clock_step(1); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, !=3D, 0); + clock_step(UIP_HOLD_LENGTH); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, =3D=3D, 0); + + assert_datetime_bcd(0x02, 0x04, 0x59, 0x02, 0x02, 0x2011); +} + +static void uip_stuck(void) +{ + set_datetime(REG_B_24H, 0x02, 0x04, 0x58, 0x02, 0x02, 0x2011); + + /* The first update ends 500 ms after divider reset */ + (void)cmos_read(RTC_REG_C); + clock_step(500000000LL); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, =3D=3D, 0); + assert_datetime_bcd(0x02, 0x04, 0x59, 0x02, 0x02, 0x2011); + + /* UF is now set. */ + cmos_write(RTC_HOURS_ALARM, 0x02); + cmos_write(RTC_MINUTES_ALARM, 0xC0); + cmos_write(RTC_SECONDS_ALARM, 0xC0); + + /* Because the alarm will fire soon, reading register A will latch UIP= . */ + clock_step(1000000000LL - UIP_HOLD_LENGTH / 2); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, !=3D, 0); + + /* Move the alarm far away. This must not cause UIP to remain stuck! = */ + cmos_write(RTC_HOURS_ALARM, 0x03); + clock_step(UIP_HOLD_LENGTH); + g_assert_cmpint(cmos_read(RTC_REG_A) & REG_A_UIP, =3D=3D, 0); +} + #define RTC_PERIOD_CODE1 13 /* 8 Hz */ #define RTC_PERIOD_CODE2 15 /* 2 Hz */ =20 @@ -625,7 +703,9 @@ int main(int argc, char **argv) qtest_add_func("/rtc/basic/bcd-12h", basic_12h_bcd); qtest_add_func("/rtc/set-year/20xx", set_year_20xx); qtest_add_func("/rtc/set-year/1980", set_year_1980); - qtest_add_func("/rtc/misc/register_b_set_flag", register_b_set_flag); + qtest_add_func("/rtc/update/register_b_set_flag", register_b_set_flag); + qtest_add_func("/rtc/update/divider-reset", divider_reset); + qtest_add_func("/rtc/update/uip-stuck", uip_stuck); qtest_add_func("/rtc/misc/fuzz-registers", fuzz_registers); qtest_add_func("/rtc/periodic/interrupt", periodic_timer); =20 --=20 1.8.3.1