From nobody Mon Feb 9 09:52:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150041001962572.74251194692272; Tue, 18 Jul 2017 13:33:39 -0700 (PDT) Received: from localhost ([::1]:58488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXZBa-0000TU-Ea for importer@patchew.org; Tue, 18 Jul 2017 16:33:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXZ7W-00056y-B8 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXZ7U-000189-PV for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:29:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52358) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXZ7U-00017e-JT for qemu-devel@nongnu.org; Tue, 18 Jul 2017 16:29:24 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8479E3683C for ; Tue, 18 Jul 2017 20:29:23 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4452761F52 for ; Tue, 18 Jul 2017 20:29:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 758121138657; Tue, 18 Jul 2017 22:29:20 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8479E3683C Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=armbru@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8479E3683C From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 18 Jul 2017 22:29:18 +0200 Message-Id: <1500409760-20730-9-git-send-email-armbru@redhat.com> In-Reply-To: <1500409760-20730-1-git-send-email-armbru@redhat.com> References: <1500409760-20730-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 18 Jul 2017 20:29:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" qmp_query_migrate_parameters() and qmp_migrate_set_parameters() effectively duplicate QAPI_CLONE() inline. Add suitable TODO comments. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index bae9808..d0a1d13 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -427,6 +427,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error= **errp) MigrationParameters *params; MigrationState *s =3D migrate_get_current(); =20 + /* TODO use QAPI_CLONE() instead of duplicating it inline */ params =3D g_malloc0(sizeof(*params)); params->has_compress_level =3D true; params->compress_level =3D s->parameters.compress_level; @@ -703,6 +704,7 @@ void qmp_migrate_set_parameters(MigrationParameters *pa= rams, Error **errp) "is invalid, it should be positive"); } =20 + /* TODO use QAPI_CLONE() instead of duplicating it inline */ if (params->has_compress_level) { s->parameters.compress_level =3D params->compress_level; } --=20 2.7.5