From nobody Sun Feb 8 18:43:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500280423212627.0489714547514; Mon, 17 Jul 2017 01:33:43 -0700 (PDT) Received: from localhost ([::1]:48762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX1TJ-00045K-PS for importer@patchew.org; Mon, 17 Jul 2017 04:33:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX1My-0006yO-JD for qemu-devel@nongnu.org; Mon, 17 Jul 2017 04:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX1Mx-000288-NY for qemu-devel@nongnu.org; Mon, 17 Jul 2017 04:27:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX1Mx-00027d-Ea for qemu-devel@nongnu.org; Mon, 17 Jul 2017 04:27:07 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 72E344E4D9 for ; Mon, 17 Jul 2017 08:27:06 +0000 (UTC) Received: from pxdev.xzpeter.org.com (ovpn-12-53.pek2.redhat.com [10.72.12.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A0B8173C3; Mon, 17 Jul 2017 08:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 72E344E4D9 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=peterx@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 72E344E4D9 From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 17 Jul 2017 16:26:07 +0800 Message-Id: <1500279971-13875-8-git-send-email-peterx@redhat.com> In-Reply-To: <1500279971-13875-1-git-send-email-peterx@redhat.com> References: <1500279971-13875-1-git-send-email-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 17 Jul 2017 08:27:06 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost , Juan Quintela , "Dr . David Alan Gilbert" , Peter Xu , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Adding validity check for the migration parameters passed in via global properties. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela --- migration/migration.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 8c65054..5a7f22c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2109,6 +2109,39 @@ static void migration_instance_init(Object *obj) ms->parameters.tls_hostname =3D g_strdup(""); } =20 +static void migration_instance_post_init(Object *obj) +{ + MigrationState *ms =3D (MigrationState *)obj; + Error *err =3D NULL; + MigrationParameters params =3D { + .has_compress_level =3D true, + .compress_level =3D ms->parameters.compress_level, + .has_compress_threads =3D true, + .compress_threads =3D ms->parameters.compress_threads, + .has_decompress_threads =3D true, + .decompress_threads =3D ms->parameters.decompress_threads, + .has_cpu_throttle_initial =3D true, + .cpu_throttle_initial =3D ms->parameters.cpu_throttle_initial, + .has_cpu_throttle_increment =3D true, + .cpu_throttle_increment =3D ms->parameters.cpu_throttle_increment, + .has_max_bandwidth =3D true, + .max_bandwidth =3D ms->parameters.max_bandwidth, + .has_downtime_limit =3D true, + .downtime_limit =3D ms->parameters.downtime_limit, + .has_x_checkpoint_delay =3D true, + .x_checkpoint_delay =3D ms->parameters.x_checkpoint_delay, + .has_block_incremental =3D true, + .block_incremental =3D ms->parameters.block_incremental, + }; + + /* We have applied all the migration properties... */ + + if (!migrate_params_check(¶ms, &err)) { + error_report_err(err); + exit(1); + } +} + static const TypeInfo migration_type =3D { .name =3D TYPE_MIGRATION, /* @@ -2124,6 +2157,7 @@ static const TypeInfo migration_type =3D { .class_size =3D sizeof(MigrationClass), .instance_size =3D sizeof(MigrationState), .instance_init =3D migration_instance_init, + .instance_post_init =3D migration_instance_post_init, }; =20 static void register_migration_types(void) --=20 2.7.4