From nobody Tue Feb 10 03:44:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500235602908880.6701297042091; Sun, 16 Jul 2017 13:06:42 -0700 (PDT) Received: from localhost ([::1]:46709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWpoO-0002SE-Pq for importer@patchew.org; Sun, 16 Jul 2017 16:06:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWpmZ-0001Ag-8L for qemu-devel@nongnu.org; Sun, 16 Jul 2017 16:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWpmU-0008GR-Dz for qemu-devel@nongnu.org; Sun, 16 Jul 2017 16:04:47 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34963) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dWpmU-0008FI-6g for qemu-devel@nongnu.org; Sun, 16 Jul 2017 16:04:42 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DEE9E20A48; Sun, 16 Jul 2017 16:04:39 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sun, 16 Jul 2017 16:04:39 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id A90D97E84B; Sun, 16 Jul 2017 16:04:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ptJEv8AGQNj3rlJ dT8z7Rc7EXN+LFg0HLjp4xX7LfrE=; b=2ItJPX5nksmRRPrvz0jPI/93WwstVdi R4xl3SLc+TNFZeFSIu8cFU8itqP1NKf0FF2q7mqzDRaNiogHkxXVVtIs4dTHt26Z e/cXHHs0UXRIdID41zm5KgBioOcagtTQ9LiJuBZH3oisSbPeFhnHUML82uqzamNT IUPvs3qwzTgk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ptJEv8AGQNj3rlJdT8z7Rc7EXN+LFg0HLjp4xX7LfrE=; b=J17vBENl nYiSvc+Wq1l7v9yJU14cKk9qotv5eQBiPUp9QbksmZ7foiJBwqZ5Z056TaUasjco T9cNJ5Sggz92u8+dwZHCpST5Ooaqp6qBLEIwk0aIXQQdpSL5JgsYJtKv1GmQSr58 mDBG9kvfuoiE8FLqxDOK1FnoZXnp86SzayBKn4YAGZ0z5K8HWf+dDlZ+xyvr2Ea2 EBeRyUlZ9vEAV+i5OCXfCDpxQaL0vUYOZhij8nqdhDi++eljM0fKKabE+lp9icgi lawFo5aZ0hekbbMXMf6PfvtncCR1OlzZneqcyXhOQayYZVZelxdNu6oNa+kXiC/z q43cOlcxnLyDiQ== X-ME-Sender: X-Sasl-enc: 4/izT2Ko5TIhFPdH6Aw79Zq/JmPZCj2vtcHosa2imwkm 1500235479 From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Sun, 16 Jul 2017 16:03:44 -0400 Message-Id: <1500235468-15341-2-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500235468-15341-1-git-send-email-cota@braap.org> References: <1500235468-15341-1-git-send-email-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH v2 01/45] vl: fix breakage of -tb-size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Commit e7b161d573 ("vl: add tcg_enabled() for tcg related code") adds a check to exit the program when !tcg_enabled() while parsing the -tb-size flag. It turns out that when the -tb-size flag is evaluated, tcg_enabled() can only return 0, since it is set (or not) much later by configure_accelerator= (). Fix it by unconditionally exiting if the flag is passed to a QEMU binary built with !CONFIG_TCG. Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e Signed-off-by: Emilio G. Cota --- vl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index d17c863..9ece570 100644 --- a/vl.c +++ b/vl.c @@ -3933,10 +3933,10 @@ int main(int argc, char **argv, char **envp) configure_rtc(opts); break; case QEMU_OPTION_tb_size: - if (!tcg_enabled()) { - error_report("TCG is disabled"); - exit(1); - } +#ifndef CONFIG_TCG + error_report("TCG is disabled"); + exit(1); +#endif if (qemu_strtoul(optarg, NULL, 0, &tcg_tb_size) < 0) { error_report("Invalid argument to -tb-size"); exit(1); --=20 2.7.4