From nobody Mon Feb 9 23:18:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499957064547563.2913943561927; Thu, 13 Jul 2017 07:44:24 -0700 (PDT) Received: from localhost ([::1]:60448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVfLo-0001ro-Am for importer@patchew.org; Thu, 13 Jul 2017 10:44:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVf3p-0001N7-PL for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:25:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVf3o-00032A-NZ for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:25:45 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:36705) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVf3o-0002zq-GN for qemu-devel@nongnu.org; Thu, 13 Jul 2017 10:25:44 -0400 Received: by mail-wr0-x241.google.com with SMTP id 77so9410398wrb.3 for ; Thu, 13 Jul 2017 07:25:44 -0700 (PDT) Received: from 640k.lan (94-39-191-51.adsl-ull.clienti.tiscali.it. [94.39.191.51]) by smtp.gmail.com with ESMTPSA id k75sm6042448wmh.10.2017.07.13.07.25.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 07:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=qZUl2R0yHMtp9yzkBV8REVQflexZpi/wFrTNh1hDHJc=; b=rjAbt1Gqx5SGtI9jS1zloZW5PPT9/VLbfUQEluU0XOaCGC8T/BGwRkKt9teQIGzfDM owT4J4WvpzRxLStwZrKqrE8/EoLT6UmiC7OkOZfd7mok7Gup4dHszwkIwd8et4bHAT4c ZCj9DyyWrEflUneSzZTg+cg00+RC2KTeEKBknu5LoiBdqNotFhiUmEtfj/e8wQRITD+F E+tKo4VAB2z6wnygiAGwki/StmxNazJx87Yema4ms3DTWbB5gz0dVXYt+GSeXxEy6LVw 91S2rjoARP+MujPLkAHRP7M83kQcZMF6V3XoBXZ3SNgLti7SUfEBzQ0gdLkY8NP8nJep /IZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=qZUl2R0yHMtp9yzkBV8REVQflexZpi/wFrTNh1hDHJc=; b=Em03YoXTH8WrBL+L8oijTVEGXCKMB3gh8pF7FXhWF8b6SOaWls9FOuGEdTrrch2NA3 MQ9DtCHBO2+NcC5q+gjI2iZ4f/1UQN7FheTlsZ3OsavKhil8PpuPYKH+lVADDCYpj9Rk ZUmTG9luWETmOuQBB/92LenKBJkRbcVSZGxpZhtuXYfcpfpReh09aUMQK1egsedM8PFh sk23cEo/vF3IUDENN7AyVjWtdnSK2n3JmAFqTDmde83FOlNRiNYqZwaHnmUGOtjqQ9Zv Rgu3t3NwfxzBzpEQEhBleR+kCpRQdEpbn6zGpAyOAo6LMl2TBpkl+j1BoZdqlYcmQMFV VW0w== X-Gm-Message-State: AIVw112RJThCAueM360mudbajwjfqigFrLYc/4t8vm3jkG4EdoEjGLqx 3DeholLaRSLHSdg9crs= X-Received: by 10.223.151.67 with SMTP id r61mr1792187wrb.189.1499955943318; Thu, 13 Jul 2017 07:25:43 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 13 Jul 2017 16:24:34 +0200 Message-Id: <1499955874-10954-42-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1499955874-10954-1-git-send-email-pbonzini@redhat.com> References: <1499955874-10954-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 41/41] translate-all: remove redundant !tcg_enabled check in dump_exec_info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" This check is redundant because it is already performed by the only caller of dump_exec_info -- the caller was updated by b7da97eef ("monitor: Check whether TCG is enabled before running the "info jit" code"). Checking twice wouldn't necessarily be too bad, but here the check also returns with tb_lock held. So we can either do the check before tb_lock is acquired, or just get rid of it. Given that it is redundant, I am going for the latter option. Signed-off-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- accel/tcg/translate-all.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 0caf80d..4e1831c 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1851,11 +1851,6 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fp= rintf) =20 tb_lock(); =20 - if (!tcg_enabled()) { - cpu_fprintf(f, "TCG not enabled\n"); - return; - } - target_code_size =3D 0; max_target_code_size =3D 0; cross_page =3D 0; --=20 1.8.3.1