[Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13

Markus Armbruster posted 9 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1499952476-3454-1-git-send-email-armbru@redhat.com
Test FreeBSD passed
Test checkpatch failed
Test docker passed
Test s390x passed
block.c                        |   8 ++--
block/backup.c                 |  12 ++---
block/gluster.c                |   3 +-
block/iscsi.c                  |   6 +--
block/nfs.c                    |  12 ++---
block/rbd.c                    |   6 +--
block/ssh.c                    |   4 +-
blockdev.c                     |   2 +-
chardev/char-socket.c          |   4 +-
cpus.c                         |   2 +-
hw/9pfs/9p.c                   |   2 +-
hw/arm/highbank.c              |   6 +--
hw/arm/imx25_pdk.c             |   6 +--
hw/arm/kzm.c                   |   6 +--
hw/core/machine.c              |  10 ++--
hw/core/qdev-properties.c      |  10 ++--
hw/dma/xilinx_axidma.c         |   4 +-
hw/i386/acpi-build.c           |  10 ++--
hw/i386/kvm/pci-assign.c       |   6 +--
hw/i386/pc.c                   |  13 +++--
hw/i386/pc_piix.c              |   8 ++--
hw/i386/pc_q35.c               |   6 +--
hw/misc/aspeed_sdmc.c          |   8 ++--
hw/net/xilinx_axienet.c        |   4 +-
hw/nvram/fw_cfg.c              |   2 +-
hw/pci-host/piix.c             |   2 +-
hw/ppc/pnv.c                   |   6 +--
hw/ppc/spapr.c                 |   4 +-
hw/ppc/spapr_iommu.c           |   2 +-
hw/scsi/scsi-bus.c             |   6 +--
hw/usb/dev-smartcard-reader.c  |   6 +--
hw/usb/redirect.c              |   2 +-
include/qapi/error.h           |  11 +++++
include/qemu/error-report.h    |   7 +++
io/channel-websock.c           |   4 +-
net/tap-linux.c                |   2 +-
scripts/checkpatch.pl          |   7 ++-
target/i386/cpu.c              |  22 ++++-----
target/i386/kvm.c              |  12 ++---
target/s390x/cpu_models.c      |   6 +--
target/s390x/kvm.c             |   4 +-
tests/test-qdev-global-props.c |   6 +--
trace/control.c                |   8 ++--
util/error.c                   |  20 ++++++++
util/qemu-error.c              | 106 ++++++++++++++++++++++++++++++++++++++---
vl.c                           |  20 ++++----
46 files changed, 275 insertions(+), 148 deletions(-)
[Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13
Posted by Markus Armbruster 6 years, 8 months ago
The following changes since commit 31fe1c414501047cbb91b695bdccc0068496dcf6:

  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-07-11 17:13:49 +0100)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-error-2017-07-13

for you to fetch changes up to 88f83f3539fdedd5f315c5fe434ffcb7a010cc73:

  Convert error_report*_err() to warn_report*_err() (2017-07-13 13:50:24 +0200)

----------------------------------------------------------------
Error reporting patches for 2017-07-13

----------------------------------------------------------------
Alistair Francis (6):
      util/qemu-error: Rename error_print_loc() to be more generic
      error: Functions to report warnings and informational messages
      Convert error_report() to warn_report()
      char-socket: Report TCP socket waiting as information
      error: Implement the warn and free Error functions
      Convert error_report*_err() to warn_report*_err()

Eduardo Habkost (3):
      xilinx: Fix latent error handling bug
      block: Don't try to set *errp directly
      websock: Don't try to set *errp directly

 block.c                        |   8 ++--
 block/backup.c                 |  12 ++---
 block/gluster.c                |   3 +-
 block/iscsi.c                  |   6 +--
 block/nfs.c                    |  12 ++---
 block/rbd.c                    |   6 +--
 block/ssh.c                    |   4 +-
 blockdev.c                     |   2 +-
 chardev/char-socket.c          |   4 +-
 cpus.c                         |   2 +-
 hw/9pfs/9p.c                   |   2 +-
 hw/arm/highbank.c              |   6 +--
 hw/arm/imx25_pdk.c             |   6 +--
 hw/arm/kzm.c                   |   6 +--
 hw/core/machine.c              |  10 ++--
 hw/core/qdev-properties.c      |  10 ++--
 hw/dma/xilinx_axidma.c         |   4 +-
 hw/i386/acpi-build.c           |  10 ++--
 hw/i386/kvm/pci-assign.c       |   6 +--
 hw/i386/pc.c                   |  13 +++--
 hw/i386/pc_piix.c              |   8 ++--
 hw/i386/pc_q35.c               |   6 +--
 hw/misc/aspeed_sdmc.c          |   8 ++--
 hw/net/xilinx_axienet.c        |   4 +-
 hw/nvram/fw_cfg.c              |   2 +-
 hw/pci-host/piix.c             |   2 +-
 hw/ppc/pnv.c                   |   6 +--
 hw/ppc/spapr.c                 |   4 +-
 hw/ppc/spapr_iommu.c           |   2 +-
 hw/scsi/scsi-bus.c             |   6 +--
 hw/usb/dev-smartcard-reader.c  |   6 +--
 hw/usb/redirect.c              |   2 +-
 include/qapi/error.h           |  11 +++++
 include/qemu/error-report.h    |   7 +++
 io/channel-websock.c           |   4 +-
 net/tap-linux.c                |   2 +-
 scripts/checkpatch.pl          |   7 ++-
 target/i386/cpu.c              |  22 ++++-----
 target/i386/kvm.c              |  12 ++---
 target/s390x/cpu_models.c      |   6 +--
 target/s390x/kvm.c             |   4 +-
 tests/test-qdev-global-props.c |   6 +--
 trace/control.c                |   8 ++--
 util/error.c                   |  20 ++++++++
 util/qemu-error.c              | 106 ++++++++++++++++++++++++++++++++++++++---
 vl.c                           |  20 ++++----
 46 files changed, 275 insertions(+), 148 deletions(-)

-- 
2.7.5


Re: [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13
Posted by no-reply@patchew.org 6 years, 8 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1499952476-3454-1-git-send-email-armbru@redhat.com
Subject: [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1499952476-3454-1-git-send-email-armbru@redhat.com -> patchew/1499952476-3454-1-git-send-email-armbru@redhat.com
Switched to a new branch 'test'
43225f4 Convert error_report*_err() to warn_report*_err()
dc458e0 error: Implement the warn and free Error functions
018d8da char-socket: Report TCP socket waiting as information
8713482 Convert error_report() to warn_report()
f75e632 error: Functions to report warnings and informational messages
65bc053 util/qemu-error: Rename error_print_loc() to be more generic
739dd32 websock: Don't try to set *errp directly
ca32b14 block: Don't try to set *errp directly
818cfa7 xilinx: Fix latent error handling bug

=== OUTPUT BEGIN ===
Checking PATCH 1/9: xilinx: Fix latent error handling bug...
Checking PATCH 2/9: block: Don't try to set *errp directly...
Checking PATCH 3/9: websock: Don't try to set *errp directly...
Checking PATCH 4/9: util/qemu-error: Rename error_print_loc() to be more generic...
Checking PATCH 5/9: error: Functions to report warnings and informational messages...
Checking PATCH 6/9: Convert error_report() to warn_report()...
ERROR: line over 90 characters
#725: FILE: tests/test-qdev-global-props.c:235:
+    g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3 has invalid class name\n*");

WARNING: line over 80 characters
#729: FILE: tests/test-qdev-global-props.c:237:
+    g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not used\n*");

ERROR: line over 90 characters
#730: FILE: tests/test-qdev-global-props.c:238:
+    g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has invalid class name\n*");

total: 2 errors, 1 warnings, 571 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/9: char-socket: Report TCP socket waiting as information...
Checking PATCH 8/9: error: Implement the warn and free Error functions...
Checking PATCH 9/9: Convert error_report*_err() to warn_report*_err()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13
Posted by Peter Maydell 6 years, 8 months ago
On 13 July 2017 at 14:27, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 31fe1c414501047cbb91b695bdccc0068496dcf6:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-07-11 17:13:49 +0100)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-error-2017-07-13
>
> for you to fetch changes up to 88f83f3539fdedd5f315c5fe434ffcb7a010cc73:
>
>   Convert error_report*_err() to warn_report*_err() (2017-07-13 13:50:24 +0200)
>
> ----------------------------------------------------------------
> Error reporting patches for 2017-07-13
>
> ----------------------------------------------------------------
> Alistair Francis (6):
>       util/qemu-error: Rename error_print_loc() to be more generic
>       error: Functions to report warnings and informational messages
>       Convert error_report() to warn_report()
>       char-socket: Report TCP socket waiting as information
>       error: Implement the warn and free Error functions
>       Convert error_report*_err() to warn_report*_err()
>
> Eduardo Habkost (3):
>       xilinx: Fix latent error handling bug
>       block: Don't try to set *errp directly
>       websock: Don't try to set *errp directly

On my FreeBSD test setup test-char resulted in a warning:


TEST: tests/test-char... (pid=68152)
  /char/null:                                                          OK
  /char/invalid:                                                       OK
  /char/ringbuf:                                                       OK
  /char/mux:                                                           OK
  /char/stdio:                                                         OK
  /char/pipe:                                                          OK
  /char/file:                                                          OK
  /char/socket:                                                        main-loop
: WARNING: I/O thread spun for 1000 iterations
OK
  /char/udp:                                                           OK
  /char/serial:                                                        OK
PASS: tests/test-char

but I can't repro that and it doesn't look like it ought to be
related to the patches in this series, so I'm going to assume it
was just that the box got heavily loaded briefly or something.

Applied to master, thanks.

-- PMM