From nobody Sat May 4 17:01:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499949551197569.3461686841383; Thu, 13 Jul 2017 05:39:11 -0700 (PDT) Received: from localhost ([::1]:59639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVdOd-0006Wi-3k for importer@patchew.org; Thu, 13 Jul 2017 08:39:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVdNQ-0005sY-JG for qemu-devel@nongnu.org; Thu, 13 Jul 2017 08:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVdNP-0001u3-P9 for qemu-devel@nongnu.org; Thu, 13 Jul 2017 08:37:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50176) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVdNN-0001tT-PX; Thu, 13 Jul 2017 08:37:49 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B124EC04B952; Thu, 13 Jul 2017 12:37:48 +0000 (UTC) Received: from noname.redhat.com (ovpn-117-143.ams2.redhat.com [10.36.117.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEBFD6C1EB; Thu, 13 Jul 2017 12:37:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B124EC04B952 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kwolf@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B124EC04B952 From: Kevin Wolf To: qemu-block@nongnu.org Date: Thu, 13 Jul 2017 14:37:43 +0200 Message-Id: <1499949463-22531-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 13 Jul 2017 12:37:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] vpc: Remove useless parameters in get_sector_offset() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" All callers of get_sector_offset() pass write=3Dfalse and err=3DNULL. Remove the parameters. Signed-off-by: Kevin Wolf --- Based on my block branch, specifically Peter's 'block/vpc.c: Handle write failures in get_image_offset()' block/vpc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index bccc981..471f9ab 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -508,10 +508,9 @@ static inline int64_t get_image_offset(BlockDriverStat= e *bs, uint64_t offset, } =20 static inline int64_t get_sector_offset(BlockDriverState *bs, - int64_t sector_num, bool write, - int *err) + int64_t sector_num) { - return get_image_offset(bs, sector_num * BDRV_SECTOR_SIZE, write, err); + return get_image_offset(bs, sector_num * BDRV_SECTOR_SIZE, false, NULL= ); } =20 /* @@ -721,7 +720,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(Blo= ckDriverState *bs, (sector_num << BDRV_SECTOR_BITS); } =20 - offset =3D get_sector_offset(bs, sector_num, false, NULL); + offset =3D get_sector_offset(bs, sector_num); start =3D offset; allocated =3D (offset !=3D -1); *pnum =3D 0; @@ -744,7 +743,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(Blo= ckDriverState *bs, if (nb_sectors =3D=3D 0) { break; } - offset =3D get_sector_offset(bs, sector_num, false, NULL); + offset =3D get_sector_offset(bs, sector_num); } while (offset =3D=3D -1); =20 return 0; --=20 1.8.3.1