From nobody Wed Nov 5 09:32:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149958708268680.21007104939008; Sun, 9 Jul 2017 00:58:02 -0700 (PDT) Received: from localhost ([::1]:35272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dU76P-0001h8-AD for importer@patchew.org; Sun, 09 Jul 2017 03:58:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dU6zJ-0004RA-71 for qemu-devel@nongnu.org; Sun, 09 Jul 2017 03:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dU6zD-0002zQ-W5 for qemu-devel@nongnu.org; Sun, 09 Jul 2017 03:50:41 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48077) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dU6zD-0002vI-O3 for qemu-devel@nongnu.org; Sun, 09 Jul 2017 03:50:35 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DFEFE208A9; Sun, 9 Jul 2017 03:50:31 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sun, 09 Jul 2017 03:50:31 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id AEED4248B9; Sun, 9 Jul 2017 03:50:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=75J Lo4dc9KwImbl+4veFfhnV0oQ4RAG9xZmBEKM9Ed0=; b=nOmR8GwSrJ7OD6bJqrM tpG+MgNnpRPp+WJCxlgUZ+JqEDPffxFrN2ng8GjcWiXGaZVZjaYiAVseyFKJRRhO pSuUMuTnFUCdLu8NtsMy9WPlX8Ro/2to+uYUpx71J6Fc/ohLQeZhIy9ANDZRgGxs UWOa8cHi5DELhKqNNyNqQ+6Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=75JLo4dc9KwImbl+4veFfhnV0oQ4RAG9xZmBEKM9E d0=; b=fQR2HmWb+DXG3k6E1CoDtQWOhI+rEzMiYoDCmeP+oAUo4S52kZtxqQSKk YoRsf603JkGPk9kpIo8Lk2/jzNPcGEb3SfLrzvkJt43/duyaAdKPZg83p+hYN+IK mc7W5hqGu2GrYyNi51j3emuwGXFwhgUH9f8Psxw7oDVLAzptWxtYeh/QPKP6TpYr 84pBful1Np3mfjtdtQZ+sOdJ0HpdeokVOtr7F2+HNtQq54xSecWOLUCXj4QadrPK Alzmt1Xw+BnOkLQFae9KMGNMJmeQJ0oP7gpPC4M132zosJZjISQKBJjPyDAPVJNc EeuapdzYeIVbAfKwDX1NkBpcs4KBA== X-ME-Sender: X-Sasl-enc: 7ejjnVkYEqt1yA4l7L8+hISYhQkCa7k42wHevTtKYBen 1499586631 From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Sun, 9 Jul 2017 03:49:54 -0400 Message-Id: <1499586614-20507-3-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499586614-20507-1-git-send-email-cota@braap.org> References: <1499586614-20507-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 Subject: [Qemu-devel] [PATCH 02/22] translate-all: remove redundant !tcg_enabled check in dump_exec_info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This check is redundant because it is already performed by the only caller of dump_exec_info -- the caller was updated by b7da97eef ("monitor: Check whether TCG is enabled before running the "info jit" code"). Checking twice wouldn't necessarily be too bad, but here the check also returns with tb_lock held. So we can either do the check before tb_lock is acquired, or just get rid of it. Given that it is redundant, I am going for the latter option. Signed-off-by: Emilio G. Cota Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- accel/tcg/translate-all.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index dfb9f0d..f768681 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1851,11 +1851,6 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fp= rintf) =20 tb_lock(); =20 - if (!tcg_enabled()) { - cpu_fprintf(f, "TCG not enabled\n"); - return; - } - target_code_size =3D 0; max_target_code_size =3D 0; cross_page =3D 0; --=20 2.7.4