From nobody Mon Apr 29 23:26:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499264428457719.4973484028545; Wed, 5 Jul 2017 07:20:28 -0700 (PDT) Received: from localhost ([::1]:46472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSlAG-0003WV-5F for importer@patchew.org; Wed, 05 Jul 2017 10:20:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSko3-0003PR-1q for qemu-devel@nongnu.org; Wed, 05 Jul 2017 09:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSkny-0005WK-B8 for qemu-devel@nongnu.org; Wed, 05 Jul 2017 09:57:27 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:21124) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSkny-0005VN-4o for qemu-devel@nongnu.org; Wed, 05 Jul 2017 09:57:22 -0400 X-IronPort-AV: E=Sophos;i="5.40,312,1496102400"; d="scan'208";a="438846937" From: Anoob Soman To: , Date: Wed, 5 Jul 2017 14:56:35 +0100 Message-ID: <1499262995-11621-1-git-send-email-anoob.soman@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 X-Mailman-Approved-At: Wed, 05 Jul 2017 10:07:36 -0400 Subject: [Qemu-devel] [PATCH] xen/pt: Fixup addr validation in xen_pt_pci_config_access_check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: anthony.perard@citrix.com, sstabellini@kernel.org, Anoob Soman Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" xen_pt_pci_config_access_check checks if addr >=3D 0xFF. 0xFF is a valid address and should not be ignored. Signed-off-by: Anoob Soman Acked-by: Anthony PERARD --- hw/xen/xen_pt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index b6d71bb..375efa6 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -85,7 +85,7 @@ void xen_pt_log(const PCIDevice *d, const char *f, ...) static int xen_pt_pci_config_access_check(PCIDevice *d, uint32_t addr, int= len) { /* check offset range */ - if (addr >=3D 0xFF) { + if (addr > 0xFF) { XEN_PT_ERR(d, "Failed to access register with offset exceeding 0xF= F. " "(addr: 0x%02x, len: %d)\n", addr, len); return -1; --=20 1.8.3.1