From nobody Sun May 5 09:00:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499177839062306.2142616374023; Tue, 4 Jul 2017 07:17:19 -0700 (PDT) Received: from localhost ([::1]:41643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSOdf-0007o2-9P for importer@patchew.org; Tue, 04 Jul 2017 10:17:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSH7V-0006pW-PA for qemu-devel@nongnu.org; Tue, 04 Jul 2017 02:15:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSH7S-00060A-Cq for qemu-devel@nongnu.org; Tue, 04 Jul 2017 02:15:33 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:50149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSH7S-0005gK-1q for qemu-devel@nongnu.org; Tue, 04 Jul 2017 02:15:30 -0400 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 4 Jul 2017 06:05:56 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v646EDj2035391; Tue, 4 Jul 2017 14:14:13 +0800 (GMT-8) (envelope-from peng.hao2@zte.com.cn) Received: from localhost.localdomain ([10.74.120.79]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017070414141586-3041568 ; Tue, 4 Jul 2017 14:14:15 +0800 X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170704140556 From: Peng Hao To: mst@redhat.com Date: Wed, 5 Jul 2017 06:33:32 +0800 Message-Id: <1499207612-3560-1-git-send-email-peng.hao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-04 14:14:16, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-04 14:14:09, Serialize complete at 2017-07-04 14:14:09 X-MAIL: mse01.zte.com.cn v646EDj2035391 X-HQIP: 127.0.0.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 63.217.80.70 X-Mailman-Approved-At: Tue, 04 Jul 2017 10:15:41 -0400 Subject: [Qemu-devel] [PATCH] vhost: fix a memory leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Hao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" vhost exists a call for g_file_get_contents, but not call g_free. Signed-off-by: Peng Hao Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/virtio/vhost-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index 4e31de1..2c481d6 100644 --- a/hw/virtio/vhost-backend.c +++ b/hw/virtio/vhost-backend.c @@ -52,11 +52,13 @@ static int vhost_kernel_memslots_limit(struct vhost_dev= *dev) &s, NULL, NULL)) { uint64_t val =3D g_ascii_strtoull(s, NULL, 10); if (!((val =3D=3D G_MAXUINT64 || !val) && errno)) { + g_free(s); return val; } error_report("ignoring invalid max_mem_regions value in vhost modu= le:" " %s", s); } + g_free(s); return limit; } =20 --=20 1.8.3.1