From nobody Sat Feb 7 07:15:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162919211868.0339927545467; Tue, 4 Jul 2017 03:08:39 -0700 (PDT) Received: from localhost ([::1]:40078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKkz-0005DV-Qt for importer@patchew.org; Tue, 04 Jul 2017 06:08:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXz-0002CZ-GK for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXy-0000bk-Ns for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:07 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXy-0000bA-FW for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:06 -0400 Received: by mail-lf0-x244.google.com with SMTP id z78so4904847lff.2 for ; Tue, 04 Jul 2017 02:55:06 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id j76sm4869194lfk.17.2017.07.04.02.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4R87KcPOoL+7Y2wsdvgPeiuolpWrBD9es4URbgEk13A=; b=QkxCj1orfGusF5nygnuVPgwAvgDauRMue6flB8l3xrJlq86sSB4n6Gdr9Y1dSGCCYU A4Yzg9DNvbWw+Ww55mpxIuXnVACKfzy3SGID82f/N3TWP39TmjF5p7QSgogjJCjNd7PU 5kHZILehlkrXKDlK85FJdAFXrYXMQ/Zrv0dePt3Ip0tQRHiDxL+x3mbPv4NBYPGS/Hd3 NhhYDC+1j8M3URM29dMlTS/enckr3kJt60rmwpBYFikYSBWN/bmTulakMB/n8SblIXIT 32ODRJ03yJuDHqUG5i+rDsGPrDVcUuDbIHtSzoI196CzfsvdhJPEzavVRh1cZC7wTjwT LJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4R87KcPOoL+7Y2wsdvgPeiuolpWrBD9es4URbgEk13A=; b=k6Qi32Qj/ctTTS2iu1gvWmQZdnkLABAwof6xBrvjQ7cFc4DGSMmdDvEyrcde1wBDX2 vmqgfrGtvnDFMdfC6zPuQOFRf5YxuZBFT1bdehlPEWN3iCbV/N6zOWoEgN81k2+Sn4jj gQYENKQrXceyXH1dyNZJskQiSrcpuWlVvU0Ehl0UNRb1CP45keE+6D1+QdfFuySvt7FL rVGhI/ILhb+wwGZkw+C1Nza5kr966U6g3jEhvhR5Dt/tbeFbv0kiZPpHDGLaVq1+FipT VBDa63EumD2L7Tk3ZOn9Mzqe0qGnF2L6FvCCBN43aWOEqjKx+jGTG9r3VO0lst8KuTka ZzQg== X-Gm-Message-State: AKS2vOxRiQnNI3nwR6Fln0+Ypa1LDjVBhkVUHxJItUIZdkMGW63MxaOz bGopdWIFm7xGOsfO X-Received: by 10.25.20.93 with SMTP id k90mr13704609lfi.29.1499162104958; Tue, 04 Jul 2017 02:55:04 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:42 +0200 Message-Id: <1499162088-1562-12-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 11/17] target-microblaze: dec_barrel: Use extract32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 4136a8e..e959de7 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -670,8 +670,8 @@ static void dec_barrel(DisasContext *dc) return; } =20 - s =3D dc->imm & (1 << 10); - t =3D dc->imm & (1 << 9); + s =3D extract32(dc->imm, 10, 1); + t =3D extract32(dc->imm, 9, 1); =20 LOG_DIS("bs%s%s r%d r%d r%d\n", s ? "l" : "r", t ? "a" : "l", dc->rd, dc->ra, dc->rb); --=20 2.7.4