From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149916244415716.253803683458955; Tue, 4 Jul 2017 03:00:44 -0700 (PDT) Received: from localhost ([::1]:40042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKdN-0007Ut-Nb for importer@patchew.org; Tue, 04 Jul 2017 06:00:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXo-00022I-OS for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXm-0000Vu-OD for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:56 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34397) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXm-0000Te-Hv for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:54 -0400 Received: by mail-lf0-x242.google.com with SMTP id g21so17212172lfk.1 for ; Tue, 04 Jul 2017 02:54:52 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id m16sm3063781ljb.26.2017.07.04.02.54.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=67Z8ZrfVmDhA3BsgMCEw0mv+SDYcsVjK+wKrmM/sKe0=; b=kgOqEOvh/ATOB8EWdvNVugc71ZQngjoHewR6ii/cDn3f5oqQi6atX7qoOj8mBMWQqy lHQ8DJZssCIN+q6EEKejNJ+UNBOKx20WxUap5ClE7CHh0I6Ju6/jv13pltuEONm91ykh yWCKMuKlMC2D5mLzENycvKPdCmEy4MnYgVSgg6ZRKGrCJroGMy/tcvxKmPOkbcPAiVjA UL9127YXXn+T+zmAchI7mITJZEicpe1BrkIq6X8UT77SzXvA5VUtRw2WziDrOxC2TsVQ XuYqmTBv9Anq+LLII0l8Yd9h2SjTD8Pa5viqDoi3hVHvwb1uUQO2qqtQcCobLgypxgQE qYCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=67Z8ZrfVmDhA3BsgMCEw0mv+SDYcsVjK+wKrmM/sKe0=; b=CXcsxXrBhmodQ9OXKDBxxMig/DK2vrFm9TipaCPejL5SzA6X60iDNcizLgDLT3URi5 6IX43nqnbXSQKdU5p4wTb68JFMUsn80+DUGPXSFUqTjrmTuIP2rsFJrBSWLZnful+N7I TmegROyh4TMjv9wa8rdXcOYwbId3nucpoxQbIDaQ1DMnkOXg4WIDZv0CBGAvHEpfcuIU FSkj8S/0x/6gBixKZcoprKB5K1CvXzNzYiqUWslHzJserZHGJl+4xBld4DnH5ff06gC0 dSZ3vmCd+A9JNKE3G3KEWQ0OeGQxO9Ug8atmrrnnHuX3gpcFQkMdU73XQPgqFxIsKcb/ C6Vg== X-Gm-Message-State: AIVw111MRzj1IQvmWDovx6TDhCbYoCVwSs3ZI1IbOyRNUbngqNkoJgjp AB4AaJsUBNY0Ea93 X-Received: by 10.46.84.72 with SMTP id y8mr1665780ljd.101.1499162091486; Tue, 04 Jul 2017 02:54:51 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:32 +0200 Message-Id: <1499162088-1562-2-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 01/17] disas/microblaze: Add missing 'const' attributes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Stefan Weil Making the opcode list 'const' saves memory. Some function arguments and local variables needed 'const', too. Add also 'static' to two local functions. Reviewed-by: Edgar E. Iglesias Signed-off-by: Stefan Weil [EI: Removed old prototypes to fix the build] Signed-off-by: Edgar E. Iglesias --- disas/microblaze.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/disas/microblaze.c b/disas/microblaze.c index 7795a0b..598ecbc 100644 --- a/disas/microblaze.c +++ b/disas/microblaze.c @@ -272,7 +272,7 @@ enum microblaze_instr_type { =20 #define MAX_OPCODES 280 =20 -static struct op_code_struct { +static const struct op_code_struct { const char *name; short inst_type; /* registers and immediate values involved */ short inst_offset_type; /* immediate vals offset from PC? (=3D 1 for bra= nches) */ @@ -596,10 +596,6 @@ static char * get_field_imm15 (long instr); #if 0 static char * get_field_unsigned_imm (long instr); #endif -char * get_field_special (long instr, struct op_code_struct * op); -unsigned long read_insn_microblaze (bfd_vma memaddr,=20 - struct disassemble_info *info, - struct op_code_struct **opr); =20 static char * get_field (long instr, long mask, unsigned short low) @@ -664,8 +660,8 @@ get_field_unsigned_imm (long instr) } */ =20 -char * -get_field_special (long instr, struct op_code_struct * op) +static char * +get_field_special(long instr, const struct op_code_struct *op) { char tmpstr[25]; char spr[6]; @@ -729,14 +725,14 @@ get_field_special (long instr, struct op_code_struct = * op) return(strdup(tmpstr)); } =20 -unsigned long +static unsigned long read_insn_microblaze (bfd_vma memaddr,=20 struct disassemble_info *info, - struct op_code_struct **opr) + const struct op_code_struct **opr) { unsigned char ibytes[4]; int status; - struct op_code_struct * op; + const struct op_code_struct *op; unsigned long inst; =20 status =3D info->read_memory_func (memaddr, ibytes, 4, info); @@ -772,7 +768,7 @@ print_insn_microblaze (bfd_vma memaddr, struct disassem= ble_info * info) fprintf_function fprintf_func =3D info->fprintf_func; void * stream =3D info->stream; unsigned long inst, prev_inst; - struct op_code_struct * op, *pop; + const struct op_code_struct *op, *pop; int immval =3D 0; bfd_boolean immfound =3D FALSE; static bfd_vma prev_insn_addr =3D -1; /*init the prev insn addr */ --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149916219455942.39107629417083; Tue, 4 Jul 2017 02:56:34 -0700 (PDT) Received: from localhost ([::1]:40024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKZN-0003Ew-CO for importer@patchew.org; Tue, 04 Jul 2017 05:56:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXo-00022K-Od for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXm-0000Vi-Li for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:56 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:35773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXm-0000Uy-DU for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:54 -0400 Received: by mail-lf0-x243.google.com with SMTP id z78so4904185lff.2 for ; Tue, 04 Jul 2017 02:54:54 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id e8sm3756843ljb.58.2017.07.04.02.54.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=odfOuIYWQ15q10Tr/CnkXEiuh4t6YA0KbZzRIUObE1A=; b=oNeaBx4ERBqVd/PBDPrKjds7ST6sWkXYKHiD8l/PLYm8Az7zF7XvHooUkIaZeYX0HO 7Kd3P8dTtIjJ1mciCY14CuiFocYcwEcPFXOCjF2Cl8IjaEMoVvW3BDZpvrGYfURXSzVt GGhEtf6iYgaSLWERYqei4KKWqw5GpXxEFj2+Qss4B3Hq/fZ8TveHnzVBHuNRaTvSwF/d paxrvBWFGiiie5iY+ybzyS5xL2OlOYKOB/yWiDWebwrbNxgEhGqq0Ii9J3GRiSvKPyYu laAShSw5dW6qltd2R+QCyFxuKeyn+l3MLWo5tM/DJg9/CR1CN6F0F1e3g70eJ6UwZ8WL 6Z5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=odfOuIYWQ15q10Tr/CnkXEiuh4t6YA0KbZzRIUObE1A=; b=baUUs8FBOVt6K2K1EGnK1Nzmti2559yS0faXGBAjTyDNLNvxNT9og0rUSTVfZhKoER mQdzi08MNCK1YTZmgF4ffrZ/MesmU1ltGWPuDFhVRghK3l3dvMJKzdnCg3wR8EVad/pB LUohHmUaZDr49KyGMwqrmPa50dapMqxA2uSd3hX8x/2uPOtsuUic3D/wc+0lbVjPfZW8 JVsElVoNpZHKQvwjqAjSTqB9uXEVQPdSJ0kjTUlUUL1ZwxgJlp1gSuQv/SYGslVtzWH4 f/OAqEaV85RG3mpoKt1sGCxvZrmb5lsJUquGzFQbdXgB+pw5OsGaHTYHeHa4XASIwimn 7QJQ== X-Gm-Message-State: AKS2vOz6M0/zFM8R3PbKp6iw2uuzOAKhwArE67X/s6hnujByPzzf4mDG qfcNEbfnI5BoK6Vs X-Received: by 10.46.69.137 with SMTP id s131mr10423010lja.31.1499162092800; Tue, 04 Jul 2017 02:54:52 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:33 +0200 Message-Id: <1499162088-1562-3-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PULL v1 02/17] target-microblaze: Correct bit shift for the PVR0 version field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Correct bit shift for the PVR0 version field. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 2 +- target/microblaze/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 3d58869..af70faa 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -182,7 +182,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) (cpu->cfg.use_fpu ? PVR0_USE_FPU_MASK : 0) | (cpu->cfg.use_mmu ? PVR0_USE_MMU_MASK : 0) | (cpu->cfg.endi ? PVR0_ENDI_MASK : 0) | - (version_code << 16) | + (version_code << PVR0_VERSION_SHIFT) | (cpu->cfg.pvr =3D=3D C_PVR_FULL ? PVR0_PVR_FULL_MA= SK : 0); =20 env->pvr.regs[2] |=3D (cpu->cfg.use_fpu ? PVR2_USE_FPU_MASK : 0) | diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index bf6963b..68c33e8 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -129,6 +129,8 @@ typedef struct CPUMBState CPUMBState; #define PVR0_USER1_MASK 0x000000FF #define PVR0_SPROT_MASK 0x00000001 =20 +#define PVR0_VERSION_SHIFT 8 + /* User 2 PVR mask */ #define PVR1_USER2_MASK 0xFFFFFFFF =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162325483818.3602560483558; Tue, 4 Jul 2017 02:58:45 -0700 (PDT) Received: from localhost ([::1]:40030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKbT-00057l-5H for importer@patchew.org; Tue, 04 Jul 2017 05:58:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXo-00022H-OH for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXn-0000WU-Q2 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:56 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:36794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXn-0000W0-Il for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:55 -0400 Received: by mail-lf0-x242.google.com with SMTP id f28so17185976lfi.3 for ; Tue, 04 Jul 2017 02:54:55 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id 88sm3863975lja.19.2017.07.04.02.54.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZLy39RYpXszA27PfQLIVUT5PnzWjF8ixsDhez+Jfm7c=; b=vcBPjKHbjLdROszS/25NLE4OA6Q+qF4M3sOgw/CQ/lLMu2Uj3JKvJxBT2O3Ms1qtKq it8pLulbdKoNZKqmUZbkOvHEKC96ZunrGa2KSEljmL1UtqVEcjnmgpveFwOl5/+BOu95 RYozknf0t5IAY4Lhom+OoHgh71De3G3mN8TAtN+NQGcjPipMh0C+J7VekgTcoChMAwv0 YvJOh+mihf3aTGyXux8eE+Q9l6hsyFXRl0J67lyTi0LY1TfY8kQgcET/Y6MM511pyF3a hV+IWI4zW5LmRG6RP1TgDAFr5gPJXDmCpHGCTskiDTUwuBPF/5o7Hx5lztKrct0jGI/s oTbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZLy39RYpXszA27PfQLIVUT5PnzWjF8ixsDhez+Jfm7c=; b=S0KQEqxmYujNcRuaJLLsxnkGpjE9BOElAOfZTBWAdhhl484eU/4jnC7uEaUpF5KPY5 2zOS/A9S3FNbvU8Nxs1Y6hENeSCmsom7g7fWiqUpH5B1q2EFApAlcYBHzFIsOCg+MdLp X59aBif75io06hrqNf8PvJk6ZXQleR1eLMqlZ3CVtssoaEJove4Hmj1o1L81zaWe4wPm wRnUcsbs4HGjUjsa1bWbPgSpAT6nspUHmB+r4bnu/DX94Peuad3yZm5+zvpqW8yTxC4h BQgHo13gYtBxAtinQneItHLJM02jUikoBK7LdwraGbEuAyb0+oMZwGkPIBaxV9HICl4v zcSQ== X-Gm-Message-State: AKS2vOzOcMxrd/9zLKauTJqm5I+G6x+EokoyYI1AqKdu1zQUNZ8Ttx4S 6S0/CBe3eYv0f1uT X-Received: by 10.46.80.69 with SMTP id v5mr12354405ljd.6.1499162094077; Tue, 04 Jul 2017 02:54:54 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:34 +0200 Message-Id: <1499162088-1562-4-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 03/17] target-microblaze: Don't hard code 0xb as initial MB version X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Don't hard code 0xb as initial MB version. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index af70faa..4bc77df 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -152,8 +152,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR0_USE_HW_MUL_MASK \ | PVR0_USE_EXC_MASK \ | PVR0_USE_ICACHE_MASK \ - | PVR0_USE_DCACHE_MASK \ - | (0xb << 8); + | PVR0_USE_DCACHE_MASK; env->pvr.regs[2] =3D PVR2_D_OPB_MASK \ | PVR2_D_LMB_MASK \ | PVR2_I_OPB_MASK \ --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162193089972.2624557981878; Tue, 4 Jul 2017 02:56:33 -0700 (PDT) Received: from localhost ([::1]:40023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKZL-0003ER-NK for importer@patchew.org; Tue, 04 Jul 2017 05:56:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXp-000235-W3 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXp-0000XW-9b for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:58 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXp-0000Wi-2O for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:57 -0400 Received: by mail-lf0-x244.google.com with SMTP id t72so17250627lff.0 for ; Tue, 04 Jul 2017 02:54:56 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id d203sm4213386lfg.59.2017.07.04.02.54.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H+uVSOX226pntgbZ9IR872ow6yDxIA2X8AjsYULsOAE=; b=Tx7lkt4j4gA0jnXhp8cVTsHRO8SVAD2lYYIxofoxYshvF8p+LST8AGPvwcsCFDBZjp S6lVdtABrZ+HIFRl/Atey+KJeU+dsyUM1jvhZRjGR+YW8/nCbnSooVvsuXo/4fmpaySi RXen46o95vk2CSM0lTVFYGAuZhB+sG3N6DPzqsFzz/vSHTRx6CjTk2WH2nXkiPITCBXX I2jg2bAGFY66RiEQ14SChB9OQM/yjm8oidAyEhJwh9Xzt7fjkBsSStbW0JGZVzDxEAA/ 0OnRxn4t+0eq+fd/W1pZAtYwQ8UUqLMrybStYpqlNswWiF12E+8C9qEmBkFJH+2ejOqS VVqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H+uVSOX226pntgbZ9IR872ow6yDxIA2X8AjsYULsOAE=; b=tp20cP2dH6o6TK99tJG0jVtZgEAsbp+Z9BH42hCKLDKLknTGB0spu760F3LoS89USo 81v/xI+GA2lNOblQYRLZQ8MM3SgcJd6xPFtw+83nXHvj12WxKHO4sDbnhAE6+j1IHdI0 EHE22C0opvOs3FfDULURV8QufX71NSiKhlANjW83fy8LeHd305HRn0Ry7yFRnIxLUDUR BmemDOs/ruh3mEQJjrhlQ7gH7DIk2o6WqrBuwbWmHf1Nsu6pBSv89B/n5Z6hNARu/ADO PtX91qfd5/TryrV0/vVXKNmYpSgU8rn/S5gwNJXCK+F/rKvPtTy7yX2i/JhoPaQ5Sto2 RnwA== X-Gm-Message-State: AIVw112LFtzHjOnpibztan1uVGZ1t7cs2PbNKBixVDiGgCXVHIkcSld3 fX++lb9HrnA+ryO2 X-Received: by 10.25.26.81 with SMTP id a78mr3418844lfa.164.1499162095444; Tue, 04 Jul 2017 02:54:55 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:35 +0200 Message-Id: <1499162088-1562-5-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 04/17] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add CPU versions 9.4, 9.5 and 9.6. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 4bc77df..982cb61 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -64,6 +64,9 @@ static const struct { {"9.1", 0x1D}, {"9.2", 0x1F}, {"9.3", 0x20}, + {"9.4", 0x21}, + {"9.5", 0x22}, + {"9.6", 0x23}, {NULL, 0}, }; =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162396954889.2569057383542; Tue, 4 Jul 2017 02:59:56 -0700 (PDT) Received: from localhost ([::1]:40035 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKcd-0006nn-KE for importer@patchew.org; Tue, 04 Jul 2017 05:59:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXr-00024C-LX for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXq-0000YF-LG for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:59 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:33144) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXq-0000Xi-EL for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:54:58 -0400 Received: by mail-lf0-x242.google.com with SMTP id t72so17250686lff.0 for ; Tue, 04 Jul 2017 02:54:58 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id l67sm4851845lfg.18.2017.07.04.02.54.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xs2kYA4ICPjEHediD5stfUmYr8t+e5E1uof4BVm28GY=; b=ZzLk6M8pSSWqxBddynnEca1UynHmcgN0iGowIVYZGoAT6MggJQFKjavdOYJEQ1UYKy s6cVo3/ASqKQ09uc1hDvR0N2FkcG7tFIjKzcet+XDqMH1eSwsi1aaywbNA+IbnFwGF71 EG6wQHwz9+5JaCffRjBDYUSjpzFklJP8OE+w+/81tgVAz1T3V1qARIUMdQmpXPMTtt2m U2LU4sKdwhx/Xm54nCM+7jFkkzMeDS7Pggak5bW2+K9BaRSs4p+gYOR+eunB+1RShzBI kAFga+KWLFayQnYDhMRKCItuyJeBwKR0z/6+e1+BuyEHTWZ5xJIgEdilE8euk+tLs4ul sOuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xs2kYA4ICPjEHediD5stfUmYr8t+e5E1uof4BVm28GY=; b=hJ92r42LHPaqafTTwJ//U4xaN5YXiWdSAwpgCc4/931jtJ/Ous+BYRNd9KwT4bmbfB cSPEY7UVgOuKsAbLmb3zosWXjWZi+VwQrsHw4lByY0E5+VAxaPgP4qVplnPPFbr0/FX5 abnWPRq/T5W39g9YN8L9mw5Hxvv+kibi7rJGo52nIPIPpUDG78P0A/ub6lvo8ZykxgNC wMOOihlTln6ne0w/GBUWj0csfsZkPElcHksXzKDLXpM9VosobXXxpacS9JrR2kWyv5sH +AEIYesh+AdtvCZM2nfDK6AONRwo88MJnhoheDeDL+bs4cZQUzncG7+Gb5vBbeRC8yr4 Dgig== X-Gm-Message-State: AKS2vOxCM87nBql+FkgcL3dZFm0mrhavob9EP9KB3aUnVt5250M9XczB S3ybgPvyE/nFD9yd X-Received: by 10.25.145.71 with SMTP id y7mr12872892lfj.39.1499162096888; Tue, 04 Jul 2017 02:54:56 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:36 +0200 Message-Id: <1499162088-1562-6-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 05/17] target-microblaze: Introduce a use-barrel property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Introduce a use-barrel property making barrel shifter instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 +++++---- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 982cb61..bae47b5 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -150,8 +150,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 qemu_init_vcpu(cs); =20 - env->pvr.regs[0] =3D PVR0_USE_BARREL_MASK \ - | PVR0_USE_DIV_MASK \ + env->pvr.regs[0] =3D PVR0_USE_DIV_MASK \ | PVR0_USE_HW_MUL_MASK \ | PVR0_USE_EXC_MASK \ | PVR0_USE_ICACHE_MASK \ @@ -162,7 +161,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR2_I_LMB_MASK \ | PVR2_USE_MSR_INSTR \ | PVR2_USE_PCMP_INSTR \ - | PVR2_USE_BARREL_MASK \ | PVR2_USE_DIV_MASK \ | PVR2_USE_HW_MUL_MASK \ | PVR2_USE_MUL64_MASK \ @@ -182,13 +180,15 @@ static void mb_cpu_realizefn(DeviceState *dev, Error = **errp) =20 env->pvr.regs[0] |=3D (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) | (cpu->cfg.use_fpu ? PVR0_USE_FPU_MASK : 0) | + (cpu->cfg.use_barrel ? PVR0_USE_BARREL_MASK : 0) | (cpu->cfg.use_mmu ? PVR0_USE_MMU_MASK : 0) | (cpu->cfg.endi ? PVR0_ENDI_MASK : 0) | (version_code << PVR0_VERSION_SHIFT) | (cpu->cfg.pvr =3D=3D C_PVR_FULL ? PVR0_PVR_FULL_MA= SK : 0); =20 env->pvr.regs[2] |=3D (cpu->cfg.use_fpu ? PVR2_USE_FPU_MASK : 0) | - (cpu->cfg.use_fpu > 1 ? PVR2_USE_FPU2_MASK : 0); + (cpu->cfg.use_fpu > 1 ? PVR2_USE_FPU2_MASK : 0) | + (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0); =20 env->pvr.regs[5] |=3D cpu->cfg.dcache_writeback ? PVR5_DCACHE_WRITEBACK_MASK : 0; @@ -235,6 +235,7 @@ static Property mb_properties[] =3D { * are enabled */ DEFINE_PROP_UINT8("use-fpu", MicroBlazeCPU, cfg.use_fpu, 2), + DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_writeba= ck, false), diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 68c33e8..2a4a65a 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -298,6 +298,7 @@ struct MicroBlazeCPU { bool stackprot; uint32_t base_vectors; uint8_t use_fpu; + bool use_barrel; bool use_mmu; bool dcache_writeback; bool endi; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 0bb6095..26b221c 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -665,7 +665,7 @@ static void dec_barrel(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && !(dc->cpu->env.pvr.regs[0] & PVR0_USE_BARREL_MASK)) { + && !dc->cpu->cfg.use_barrel) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); return; --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162326162631.5566252099362; Tue, 4 Jul 2017 02:58:46 -0700 (PDT) Received: from localhost ([::1]:40031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKbU-00058H-0a for importer@patchew.org; Tue, 04 Jul 2017 05:58:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXs-00025c-W8 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXs-0000Yp-37 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:01 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXr-0000YZ-Ri for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:00 -0400 Received: by mail-lf0-x244.google.com with SMTP id f28so17186157lfi.3 for ; Tue, 04 Jul 2017 02:54:59 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id v196sm4862176lfa.16.2017.07.04.02.54.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aiv3S4c1iWhH+JYE8V/Mn2XqxpRqa06eTNsxnv7tT/I=; b=CT83TpB3N2tXA8KmrlqnkSvTJQ5hxoFeSH4Grz+Ka22Mwi6QDRGjgxukf70nTPgwkm C5OcMEv0e2NAvzLVmozwLONcWH3w6yYbG2/QfeFxmPq3UIoY27f+rMf/lHwcy538QkCB Seolgxms409r5dSGGgx2Lr8SApdQfLjvC3jT/L4MjAoG9ziUw1VzhUKTz3Ouk/y2k/yU bGz6shUtyQ94xsoziynKGbYmXkyP6iq/H6nx+GY+vDGFPoT07tmLa8umNSZZcgsRZwCQ 97B09OSoGXdLHk7+iGoKgDxH++Lt4QTjjzQgIWxkKxJ1TR/kEsnZM39keSDosC41tYqE 0ylQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aiv3S4c1iWhH+JYE8V/Mn2XqxpRqa06eTNsxnv7tT/I=; b=S5Libie4IIQ152cwdW0scV0E3QIGGOF4YisPd4ZgCYem5XLqrNoGtpAifaxPAh9U0T hs8PgEDGgH5y37kkeOoQXPcRoGnadWGV0PnBlKmTfw3oN+iS+ugCPbc+0Lr/XhU7gp2O fU458cr8m4LFPSKnIIFUyFXNIcHUqyFvmdmvljSVopnZOhK092zY9Yi1ihcOYeiKIryn WSoZIQ2CaTXLmsECJh9OnDh5oPofkSxofYFKlmLHk5EFWjjiOxipBopzXum1+H1TLhqi Bz3C4AkzaLWJjgT3Mvq641TPeH3RlUN+3mp1x2vJVtn6FBMepC6uEiEpCvnxrekyxyRH E1tw== X-Gm-Message-State: AKS2vOwiizE9wg5YvGf+8Vj1kIVo9n5gW51L2Wwx1cqxmbnHkzbQIrSH h0E2XA3eR8hNu7L7 X-Received: by 10.25.33.203 with SMTP id h194mr12884207lfh.81.1499162098250; Tue, 04 Jul 2017 02:54:58 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:37 +0200 Message-Id: <1499162088-1562-7-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 06/17] target-microblaze: Introduce a use-div property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Introduce a use-div property making division instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 +++++---- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index bae47b5..5bf2a29 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -150,8 +150,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 qemu_init_vcpu(cs); =20 - env->pvr.regs[0] =3D PVR0_USE_DIV_MASK \ - | PVR0_USE_HW_MUL_MASK \ + env->pvr.regs[0] =3D PVR0_USE_HW_MUL_MASK \ | PVR0_USE_EXC_MASK \ | PVR0_USE_ICACHE_MASK \ | PVR0_USE_DCACHE_MASK; @@ -161,7 +160,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR2_I_LMB_MASK \ | PVR2_USE_MSR_INSTR \ | PVR2_USE_PCMP_INSTR \ - | PVR2_USE_DIV_MASK \ | PVR2_USE_HW_MUL_MASK \ | PVR2_USE_MUL64_MASK \ | PVR2_FPU_EXC_MASK \ @@ -181,6 +179,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) env->pvr.regs[0] |=3D (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) | (cpu->cfg.use_fpu ? PVR0_USE_FPU_MASK : 0) | (cpu->cfg.use_barrel ? PVR0_USE_BARREL_MASK : 0) | + (cpu->cfg.use_div ? PVR0_USE_DIV_MASK : 0) | (cpu->cfg.use_mmu ? PVR0_USE_MMU_MASK : 0) | (cpu->cfg.endi ? PVR0_ENDI_MASK : 0) | (version_code << PVR0_VERSION_SHIFT) | @@ -188,7 +187,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 env->pvr.regs[2] |=3D (cpu->cfg.use_fpu ? PVR2_USE_FPU_MASK : 0) | (cpu->cfg.use_fpu > 1 ? PVR2_USE_FPU2_MASK : 0) | - (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0); + (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0) | + (cpu->cfg.use_div ? PVR2_USE_DIV_MASK : 0); =20 env->pvr.regs[5] |=3D cpu->cfg.dcache_writeback ? PVR5_DCACHE_WRITEBACK_MASK : 0; @@ -236,6 +236,7 @@ static Property mb_properties[] =3D { */ DEFINE_PROP_UINT8("use-fpu", MicroBlazeCPU, cfg.use_fpu, 2), DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), + DEFINE_PROP_BOOL("use-div", MicroBlazeCPU, cfg.use_div, true), DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_writeba= ck, false), diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 2a4a65a..4397338 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -299,6 +299,7 @@ struct MicroBlazeCPU { uint32_t base_vectors; uint8_t use_fpu; bool use_barrel; + bool use_div; bool use_mmu; bool dcache_writeback; bool endi; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 26b221c..afe4bd4 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -643,7 +643,7 @@ static void dec_div(DisasContext *dc) LOG_DIS("div\n"); =20 if ((dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && !((dc->cpu->env.pvr.regs[0] & PVR0_USE_DIV_MASK))) { + && !dc->cpu->cfg.use_div) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); } --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162443101673.2069570906378; Tue, 4 Jul 2017 03:00:43 -0700 (PDT) Received: from localhost ([::1]:40043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKdN-0007V2-GZ for importer@patchew.org; Tue, 04 Jul 2017 06:00:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXu-00027D-GD for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXt-0000ZR-HI for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:02 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXt-0000Z3-9c for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:01 -0400 Received: by mail-lf0-x244.google.com with SMTP id f28so17186236lfi.3 for ; Tue, 04 Jul 2017 02:55:01 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id i77sm4866932lfk.29.2017.07.04.02.54.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QJjLxUIcIccuEeRSnmDlmw5G8s9vdbFH4v5pD3q/kmM=; b=H8Lsla4MHZXyc2T7YLYYGhGHNMKF79mX1u+OK/l7+3QdPBGKsl6glZhFEna93c4bHA SsWLDuNGs9OTKAwKpFEWld+BL5TC8l6pxMlfECc0Bp/vccRZAC+D5Ltl8xA0GipX0p7o aJ4Mp37Kcn+feAdBbPvbavKgnHcyo9KPmEj/7cBW/8FxTUhOe25iGOWYq3QxW5/V+iAm /zhYDZOgr+rY7jE1Y1t4Ad2ohIGTWNRuvwj6IV5DM1zrdR8UlDdlhOKzLdtHbvGd83fs 3IDOcWI/qiNm8I/VWRd+5P8mdd1j6BceG3cH+MpRFSoDohyeg91jm+wMqXceimkczrmv 7JCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QJjLxUIcIccuEeRSnmDlmw5G8s9vdbFH4v5pD3q/kmM=; b=NJF2aCIQwwUw+rZZuk8oOD7bObyGxetp699XXvWbmgYTSgi92L3IDBeHeU6bMhumIz rnucI9uH6XnR7sjWeBsSpf24+vRxFnInRFarHExKauh91+qVJrSPi8YxGSmSB/uiXj0F +kicK+DrsaWvtG1eT+sGzG9ydtClhyWPUra0bVDFOULXGdA6yTwjkJ8mRAukpJG00WqY KpYJCYEeXuOT4sST/eUHqh7sXA1ozvhZ4Vm2apLlCNCJ0f1KtuoBPYjxAurgWwBpnKzu lUc/NplElLewiqzhTB3ZVVFMxxXtKiRHNYMWNt8SlaOcWhbHmyIHvRbFmL6EEDC1t9lr be5w== X-Gm-Message-State: AKS2vOxgjcSKUlUC5A/4Dz3fKvsqGEzsaUTq5l4RA4IIHpz+ryYczKn5 s4sOTLI5RLM4iBHM X-Received: by 10.46.84.83 with SMTP id y19mr6437411ljd.134.1499162099735; Tue, 04 Jul 2017 02:54:59 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:38 +0200 Message-Id: <1499162088-1562-8-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 07/17] target-microblaze: Introduce a use-hw-mul property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Introduce a use-div property making multiplication instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 12 ++++++++---- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 5 ++--- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 5bf2a29..70e4743 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -150,8 +150,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 qemu_init_vcpu(cs); =20 - env->pvr.regs[0] =3D PVR0_USE_HW_MUL_MASK \ - | PVR0_USE_EXC_MASK \ + env->pvr.regs[0] =3D PVR0_USE_EXC_MASK \ | PVR0_USE_ICACHE_MASK \ | PVR0_USE_DCACHE_MASK; env->pvr.regs[2] =3D PVR2_D_OPB_MASK \ @@ -160,8 +159,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR2_I_LMB_MASK \ | PVR2_USE_MSR_INSTR \ | PVR2_USE_PCMP_INSTR \ - | PVR2_USE_HW_MUL_MASK \ - | PVR2_USE_MUL64_MASK \ | PVR2_FPU_EXC_MASK \ | 0; =20 @@ -178,6 +175,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 env->pvr.regs[0] |=3D (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) | (cpu->cfg.use_fpu ? PVR0_USE_FPU_MASK : 0) | + (cpu->cfg.use_hw_mul ? PVR0_USE_HW_MUL_MASK : 0) | (cpu->cfg.use_barrel ? PVR0_USE_BARREL_MASK : 0) | (cpu->cfg.use_div ? PVR0_USE_DIV_MASK : 0) | (cpu->cfg.use_mmu ? PVR0_USE_MMU_MASK : 0) | @@ -187,6 +185,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) =20 env->pvr.regs[2] |=3D (cpu->cfg.use_fpu ? PVR2_USE_FPU_MASK : 0) | (cpu->cfg.use_fpu > 1 ? PVR2_USE_FPU2_MASK : 0) | + (cpu->cfg.use_hw_mul ? PVR2_USE_HW_MUL_MASK : 0) | + (cpu->cfg.use_hw_mul > 1 ? PVR2_USE_MUL64_MASK : 0= ) | (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0) | (cpu->cfg.use_div ? PVR2_USE_DIV_MASK : 0); =20 @@ -235,6 +235,10 @@ static Property mb_properties[] =3D { * are enabled */ DEFINE_PROP_UINT8("use-fpu", MicroBlazeCPU, cfg.use_fpu, 2), + /* If use-hw-mul > 0 - Multiplier is enabled + * If use-hw-mul =3D 2 - 64-bit multiplier is enabled + */ + DEFINE_PROP_UINT8("use-hw-mul", MicroBlazeCPU, cfg.use_hw_mul, 2), DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), DEFINE_PROP_BOOL("use-div", MicroBlazeCPU, cfg.use_div, true), DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 4397338..e202229 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -298,6 +298,7 @@ struct MicroBlazeCPU { bool stackprot; uint32_t base_vectors; uint8_t use_fpu; + uint8_t use_hw_mul; bool use_barrel; bool use_div; bool use_mmu; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index afe4bd4..36caa03 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -589,7 +589,7 @@ static void dec_mul(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && !(dc->cpu->env.pvr.regs[0] & PVR0_USE_HW_MUL_MASK)) { + && !dc->cpu->cfg.use_hw_mul) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); return; @@ -604,8 +604,7 @@ static void dec_mul(DisasContext *dc) } =20 /* mulh, mulhsu and mulhu are not available if C_USE_HW_MUL is < 2. */ - if (subcode >=3D 1 && subcode <=3D 3 - && !((dc->cpu->env.pvr.regs[2] & PVR2_USE_MUL64_MASK))) { + if (subcode >=3D 1 && subcode <=3D 3 && dc->cpu->cfg.use_hw_mul < 2) { /* nop??? */ } =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162747034797.808625895449; Tue, 4 Jul 2017 03:05:47 -0700 (PDT) Received: from localhost ([::1]:40068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKiG-00030T-EN for importer@patchew.org; Tue, 04 Jul 2017 06:05:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXx-0002Ac-PA for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXu-0000a2-Qt for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:05 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:33146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXu-0000ZV-Ir for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:02 -0400 Received: by mail-lf0-x242.google.com with SMTP id t72so17250904lff.0 for ; Tue, 04 Jul 2017 02:55:02 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id j76sm4869162lfk.17.2017.07.04.02.55.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+BozcNzXQ3Klsr53Kx9a3RkKMjX0hR4M08KIIKfEDLg=; b=odNDa4Jb8zqhdBg6BBtFT2ePZBBh2odMo/sPUENk+u7lNwtW/6/4rsCdAuHbHEywEO noUjdlYzLx8uogzUucSvEH4S3CK+EYltxbGCtFZ/KolqbNQ5oPJk5AcFpnAzAuPQseFj aeH92FpR5eigi4VhclZqwPZYYbK6KaUqjrs/1aeGjG6zm4El1YHZKqnBAPH2YBCgZci6 bFyWOMsIycskcwTOY/6y9ZnAUS8ib73/RJKzl8IlZhXZHOVEedOW9ev43jIwKJeT5XgV 8b3CObrniQ0Zt7WGlSGWClIen0hLuskgprFW5i4CTOGeF97dD2TcfTUAGzHYEledGN9I NBAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+BozcNzXQ3Klsr53Kx9a3RkKMjX0hR4M08KIIKfEDLg=; b=uDZLP0AEC7DWERdHNti0pkTLbGUMX2MzJO/+Z9uZ+3eET/ApulPgDoOJamb/QPb962 mFstEfKXVR+TXzlcn93fqAEWGgjA1a0LP/AZdWRrDLEylauGq0uCQnZduN5KfctxfC65 x2Hx4EF6Ls/abNUPP634kNltFijDqrvpOkheCRkKjYsp51cGJCSaFbzIjLD3THlD3o70 XVMyYFaUwEpVS/kHTnSBeIaw6RuLHWikFuJD+BiM4YIf4XDFDRYCLi+RpzQBafDusRt1 xYwgIqmFN1pnhv4RhMufU6s+SEArBi8v3gvPhT26TXTkxVyygGsHHoACh1rfuFISaLXw INJw== X-Gm-Message-State: AKS2vOxwdfBpkCYNafICAuoLIEJP8AU1rQWeq6DHPigN3E/Kv1zItxxU a0zrc1TrvwDuIFBt X-Received: by 10.46.22.5 with SMTP id w5mr10633404ljd.26.1499162101044; Tue, 04 Jul 2017 02:55:01 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:39 +0200 Message-Id: <1499162088-1562-9-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 08/17] target-microblaze: Introduce a use-msr-instr property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Introduce a use-msr-instr property making msr instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 70e4743..bc96505 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -157,7 +157,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR2_D_LMB_MASK \ | PVR2_I_OPB_MASK \ | PVR2_I_LMB_MASK \ - | PVR2_USE_MSR_INSTR \ | PVR2_USE_PCMP_INSTR \ | PVR2_FPU_EXC_MASK \ | 0; @@ -188,7 +187,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) (cpu->cfg.use_hw_mul ? PVR2_USE_HW_MUL_MASK : 0) | (cpu->cfg.use_hw_mul > 1 ? PVR2_USE_MUL64_MASK : 0= ) | (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0) | - (cpu->cfg.use_div ? PVR2_USE_DIV_MASK : 0); + (cpu->cfg.use_div ? PVR2_USE_DIV_MASK : 0) | + (cpu->cfg.use_msr_instr ? PVR2_USE_MSR_INSTR : 0); =20 env->pvr.regs[5] |=3D cpu->cfg.dcache_writeback ? PVR5_DCACHE_WRITEBACK_MASK : 0; @@ -241,6 +241,7 @@ static Property mb_properties[] =3D { DEFINE_PROP_UINT8("use-hw-mul", MicroBlazeCPU, cfg.use_hw_mul, 2), DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), DEFINE_PROP_BOOL("use-div", MicroBlazeCPU, cfg.use_div, true), + DEFINE_PROP_BOOL("use-msr-instr", MicroBlazeCPU, cfg.use_msr_instr, tr= ue), DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_writeba= ck, false), diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index e202229..5c960d0 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -301,6 +301,7 @@ struct MicroBlazeCPU { uint8_t use_hw_mul; bool use_barrel; bool use_div; + bool use_msr_instr; bool use_mmu; bool dcache_writeback; bool endi; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 36caa03..bb1bdfa 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -443,7 +443,7 @@ static void dec_msr(DisasContext *dc) LOG_DIS("msr%s r%d imm=3D%x\n", clr ? "clr" : "set", dc->rd, dc->imm); =20 - if (!(dc->cpu->env.pvr.regs[2] & PVR2_USE_MSR_INSTR)) { + if (!dc->cpu->cfg.use_msr_instr) { /* nop??? */ return; } --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162588698242.5631937948408; Tue, 4 Jul 2017 03:03:08 -0700 (PDT) Received: from localhost ([::1]:40053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKfi-0000t8-DD for importer@patchew.org; Tue, 04 Jul 2017 06:03:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXx-0002AT-NI for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXw-0000aQ-3i for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:05 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:36798) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXv-0000aB-Sa for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:04 -0400 Received: by mail-lf0-x242.google.com with SMTP id f28so17186397lfi.3 for ; Tue, 04 Jul 2017 02:55:03 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id h6sm3887656lji.59.2017.07.04.02.55.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QDHXqR7+DwZN6od8trR/fzebNHQCJA5noYiA2xAkZdA=; b=EF6Uf4YFu59zhwZzizS4praiEeJxX5QiG4HPezuTvEQKaOhy0kgw/fiXPVFSk4u58s 60Vi4RuQj3dUe5bsLLmMyOWO4HUeYwKqr/M6XFwdi4TXXtg3dzDGAreq7TA0wpY3LhG3 kFes/eeRD640sYrR2z9emHJVTKTj1bVo1tTkFKkHv5HDg1H9B1fWCILXJhUYo93+/0xY SihwvgDdPlO7FkOjHoNfjCSwMB8kBDjW4sk58RVxcpVUX2m/XvNQqki4DCfoVyT+2T5I m5gSNzJoYRzgWZv2fLUnG3Miu4RqYbiPUtgkSv/67fvT86H1Up291loCBVQTnygjUPRQ WOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QDHXqR7+DwZN6od8trR/fzebNHQCJA5noYiA2xAkZdA=; b=Lsxa/py6m/zTxZh6YZxgWViSN4Y8X0DAqxY2W8rDoonaXz0uRaj5H3WJpcBjjE3YBL HV9rAPfqgCb5RolADjTxWOR+i6mvCahPemTp9gry4uEQiNrBIhUweYyC+VgNc3DA7Sh5 jQIXtvquwWsdW3tjOhZOE8kd9Q+Ekp5BlTs8qvT1OHKQLRStBJrRNe0LjdYmWAw0osLH jIeWB3TYAXGKkzua37KHm83QULmcivic0jBbaW+mTPii2YgPge7a5UmxhHRjqya2UUsN lrWJmzRFQY7lvmfuBkqxvN3c3+kyYV7svM2kkibPx5SpwnyALAoO7wVShrV/B9L/kP7j bhqg== X-Gm-Message-State: AKS2vOwYMe2PIbtYov5QoLyQxEdpf2OENcZeNNIFj1+ry0k5EyN852C4 vxcxhJJSN4/sEQns X-Received: by 10.25.72.145 with SMTP id v139mr11191412lfa.18.1499162102370; Tue, 04 Jul 2017 02:55:02 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:40 +0200 Message-Id: <1499162088-1562-10-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 09/17] target-microblaze: Introduce a use-pcmp-instr property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Introduce a use-pcmp-instr property making pcmp instructions optional. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 6 +++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index bc96505..6e27c3c 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -157,7 +157,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) | PVR2_D_LMB_MASK \ | PVR2_I_OPB_MASK \ | PVR2_I_LMB_MASK \ - | PVR2_USE_PCMP_INSTR \ | PVR2_FPU_EXC_MASK \ | 0; =20 @@ -188,7 +187,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) (cpu->cfg.use_hw_mul > 1 ? PVR2_USE_MUL64_MASK : 0= ) | (cpu->cfg.use_barrel ? PVR2_USE_BARREL_MASK : 0) | (cpu->cfg.use_div ? PVR2_USE_DIV_MASK : 0) | - (cpu->cfg.use_msr_instr ? PVR2_USE_MSR_INSTR : 0); + (cpu->cfg.use_msr_instr ? PVR2_USE_MSR_INSTR : 0) | + (cpu->cfg.use_pcmp_instr ? PVR2_USE_PCMP_INSTR : 0= ); =20 env->pvr.regs[5] |=3D cpu->cfg.dcache_writeback ? PVR5_DCACHE_WRITEBACK_MASK : 0; @@ -242,6 +242,7 @@ static Property mb_properties[] =3D { DEFINE_PROP_BOOL("use-barrel", MicroBlazeCPU, cfg.use_barrel, true), DEFINE_PROP_BOOL("use-div", MicroBlazeCPU, cfg.use_div, true), DEFINE_PROP_BOOL("use-msr-instr", MicroBlazeCPU, cfg.use_msr_instr, tr= ue), + DEFINE_PROP_BOOL("use-pcmp-instr", MicroBlazeCPU, cfg.use_pcmp_instr, = true), DEFINE_PROP_BOOL("use-mmu", MicroBlazeCPU, cfg.use_mmu, true), DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_writeba= ck, false), diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 5c960d0..5ce4c82 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -302,6 +302,7 @@ struct MicroBlazeCPU { bool use_barrel; bool use_div; bool use_msr_instr; + bool use_pcmp_instr; bool use_mmu; bool dcache_writeback; bool endi; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index bb1bdfa..fbb8bb4 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -326,7 +326,7 @@ static void dec_pattern(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && !((dc->cpu->env.pvr.regs[2] & PVR2_USE_PCMP_INSTR))) { + && !dc->cpu->cfg.use_pcmp_instr) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); } @@ -762,11 +762,11 @@ static void dec_bit(DisasContext *dc) case 0xe0: if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && !((dc->cpu->env.pvr.regs[2] & PVR2_USE_PCMP_INSTR))) { + && !dc->cpu->cfg.use_pcmp_instr) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); } - if (dc->cpu->env.pvr.regs[2] & PVR2_USE_PCMP_INSTR) { + if (dc->cpu->cfg.use_pcmp_instr) { tcg_gen_clzi_i32(cpu_R[dc->rd], cpu_R[dc->ra], 32); } break; --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162528243848.9113146434066; Tue, 4 Jul 2017 03:02:08 -0700 (PDT) Received: from localhost ([::1]:40050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKej-00005Q-PL for importer@patchew.org; Tue, 04 Jul 2017 06:02:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXy-0002Az-4k for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXx-0000b0-E6 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:06 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXx-0000aa-60 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:05 -0400 Received: by mail-lf0-x244.google.com with SMTP id z78so4904788lff.2 for ; Tue, 04 Jul 2017 02:55:04 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id j12sm3854262lfh.23.2017.07.04.02.55.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AJL2fiO7N1F18qv76lpakxL2Ds0prNhZn8GX7aae2XA=; b=HKBVtBj5+Xv0Oawozvw8+HXp1lPB/nj4lRCR1SDP5vU3pnK67n5gkiPAYEbUbJLYv2 HVgkzQDFl2Nkh91edxqfFy/yQfxgWaS1BtB9LjJGqmdP9ZMn7trIpNYrtj9qGCw6LJWE 3J9cy4Y5mePwETXpRDi5uiiud73Gz5mlF3Tb+vU5Hu7M5iN3wusKwpUi8qNm/Pkj7v0/ NSFLMePJrSY9pPZjnT33d/4M25/HUdC4b9WIdB0LoasOkvp3Sl0LZ9vXehx8Ouy81X2q scth3JfHNSEoS8e+DT7JETrZcsYAzvf3gklCDjcP2jKYDvBSHK9CcfIHWKoV5/gDptcS 75wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AJL2fiO7N1F18qv76lpakxL2Ds0prNhZn8GX7aae2XA=; b=OrxjwzbyIprYdctyNYmwNlk1StmtV6Ng5IqiTW/Oqp0uGWI1sfX6Z9Ou66KsaqXud9 lKIa+4DQTiQwpDNVFXQN2Vtm7x+rGcjv6KW6FpU2vzh/Tj2ftrTx9GBhD0/4bMuU7Jnq izmb7tCN8UYNtXm0n/986QJExnoUX4SAiGR8ne9KbkjCMsr3IA6OoaJEtJB+CcN0odaG lE64zmpGmx1mNgdKn2054MiWnjGOIKDW+PFSQHOg+mmluLKY+VZl3p2u3H6tykTbIFsS un8tRfrJGP7228XGYQtvx7xj9n/rU9CfBPGvw2QeS1wd7sfMMQWX7tM4E940MuzjZVgf YCOA== X-Gm-Message-State: AKS2vOwSbug/oRWQ6a9AwkdmQJpVa7SgLlQHHT7puLyL/w5FbY4ab6jv 2jQGj+Dw2xFzsw0I X-Received: by 10.25.1.130 with SMTP id 124mr13083787lfb.138.1499162103691; Tue, 04 Jul 2017 02:55:03 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:41 +0200 Message-Id: <1499162088-1562-11-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 10/17] target-microblaze: dec_barrel: Use bool instead of unsigned int X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index fbb8bb4..4136a8e 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -660,7 +660,7 @@ static void dec_div(DisasContext *dc) static void dec_barrel(DisasContext *dc) { TCGv t0; - unsigned int s, t; + bool s, t; =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162919211868.0339927545467; Tue, 4 Jul 2017 03:08:39 -0700 (PDT) Received: from localhost ([::1]:40078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKkz-0005DV-Qt for importer@patchew.org; Tue, 04 Jul 2017 06:08:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKXz-0002CZ-GK for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXy-0000bk-Ns for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:07 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXy-0000bA-FW for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:06 -0400 Received: by mail-lf0-x244.google.com with SMTP id z78so4904847lff.2 for ; Tue, 04 Jul 2017 02:55:06 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id j76sm4869194lfk.17.2017.07.04.02.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4R87KcPOoL+7Y2wsdvgPeiuolpWrBD9es4URbgEk13A=; b=QkxCj1orfGusF5nygnuVPgwAvgDauRMue6flB8l3xrJlq86sSB4n6Gdr9Y1dSGCCYU A4Yzg9DNvbWw+Ww55mpxIuXnVACKfzy3SGID82f/N3TWP39TmjF5p7QSgogjJCjNd7PU 5kHZILehlkrXKDlK85FJdAFXrYXMQ/Zrv0dePt3Ip0tQRHiDxL+x3mbPv4NBYPGS/Hd3 NhhYDC+1j8M3URM29dMlTS/enckr3kJt60rmwpBYFikYSBWN/bmTulakMB/n8SblIXIT 32ODRJ03yJuDHqUG5i+rDsGPrDVcUuDbIHtSzoI196CzfsvdhJPEzavVRh1cZC7wTjwT LJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4R87KcPOoL+7Y2wsdvgPeiuolpWrBD9es4URbgEk13A=; b=k6Qi32Qj/ctTTS2iu1gvWmQZdnkLABAwof6xBrvjQ7cFc4DGSMmdDvEyrcde1wBDX2 vmqgfrGtvnDFMdfC6zPuQOFRf5YxuZBFT1bdehlPEWN3iCbV/N6zOWoEgN81k2+Sn4jj gQYENKQrXceyXH1dyNZJskQiSrcpuWlVvU0Ehl0UNRb1CP45keE+6D1+QdfFuySvt7FL rVGhI/ILhb+wwGZkw+C1Nza5kr966U6g3jEhvhR5Dt/tbeFbv0kiZPpHDGLaVq1+FipT VBDa63EumD2L7Tk3ZOn9Mzqe0qGnF2L6FvCCBN43aWOEqjKx+jGTG9r3VO0lst8KuTka ZzQg== X-Gm-Message-State: AKS2vOxRiQnNI3nwR6Fln0+Ypa1LDjVBhkVUHxJItUIZdkMGW63MxaOz bGopdWIFm7xGOsfO X-Received: by 10.25.20.93 with SMTP id k90mr13704609lfi.29.1499162104958; Tue, 04 Jul 2017 02:55:04 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:42 +0200 Message-Id: <1499162088-1562-12-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 11/17] target-microblaze: dec_barrel: Use extract32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 4136a8e..e959de7 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -670,8 +670,8 @@ static void dec_barrel(DisasContext *dc) return; } =20 - s =3D dc->imm & (1 << 10); - t =3D dc->imm & (1 << 9); + s =3D extract32(dc->imm, 10, 1); + t =3D extract32(dc->imm, 9, 1); =20 LOG_DIS("bs%s%s r%d r%d r%d\n", s ? "l" : "r", t ? "a" : "l", dc->rd, dc->ra, dc->rb); --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162699916617.131065737651; Tue, 4 Jul 2017 03:04:59 -0700 (PDT) Received: from localhost ([::1]:40059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKhS-0002Le-OU for importer@patchew.org; Tue, 04 Jul 2017 06:04:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY0-0002Es-Nx for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKXz-0000dm-TR for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:08 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKXz-0000c9-M7 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:07 -0400 Received: by mail-lf0-x242.google.com with SMTP id z78so4904904lff.2 for ; Tue, 04 Jul 2017 02:55:07 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id 19sm3666593ljv.62.2017.07.04.02.55.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=INr7l+BB2F8rmnk2E2vpeBamlgnojMRgfIdSF7r9grs=; b=k81kcDOG4pp1fqF2mdD9j79UKMXq9tshn0fCkrdKSEPPhFiSemqf9itzv8i8ednGrf vawO6P4In3KzGJqBwRzHSVG8pWeqdeWy6/wVeUc7sw5Whh4SDcSLpHuJgdY8kBdW6S12 HKw287QpfHIJUXveJV7uR1rd0HyN10OBlLhkQlJHf6p4evGS6+ffvnFhyKEjBjAYVlho L6aNjLA+cnYuaYwqNEPX/DHTTXqWQYNIUNcjlGyrd2PTvu4Z76vOIIpISw1j3P3kJAVI mMPzEYlRayLgaWyGzs+1hTGtRuvNUaRlDJIAGGIkaCXRpk2sFbRz6jurfksItGy9IRdt NkJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=INr7l+BB2F8rmnk2E2vpeBamlgnojMRgfIdSF7r9grs=; b=pwshPvM+3lb9KjMwViDiV4zM3uLtY8dBeYPhV6NVdqJxeg2SUmzO4PjVLeci0KCP73 DT+OldUretva2QgIY0GXczoEBdsesQD5dpQPAUECyxLDJ5TKas4WZAfQXCHkNLJIVc/I Aa/xgMFH2Q7JbPq2WGbooxE27FwmpLkEZTYto0nEcO3+B6hn/rnliAY1IKIkUxEevYHa YJt16kAymdvztyPIsiRcvZ/KuC56tYfOIUMINKgbyDaIXrxhYIrL68guu9wyCJA/mr3t eRRZC4ZL5VVCTZ9Udp4N7b7scbaEvHoIebVSI2Pkr9j4FyNzjz3kCUlARKR8yxgTHjHW oqhQ== X-Gm-Message-State: AKS2vOz6Reav3FTfGM8LpsmU60HgFT13jJi3KuQWCe6iDVfuOzpFkdne 1mXpf1eq72Q9A54x X-Received: by 10.25.242.73 with SMTP id d9mr12175046lfk.114.1499162106187; Tue, 04 Jul 2017 02:55:06 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:43 +0200 Message-Id: <1499162088-1562-13-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 12/17] target-microblaze: dec_barrel: Add braces around if-statements X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add braces around if-statements. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index e959de7..504ed88 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -681,13 +681,14 @@ static void dec_barrel(DisasContext *dc) tcg_gen_mov_tl(t0, *(dec_alu_op_b(dc))); tcg_gen_andi_tl(t0, t0, 31); =20 - if (s) + if (s) { tcg_gen_shl_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); - else { - if (t) + } else { + if (t) { tcg_gen_sar_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); - else + } else { tcg_gen_shr_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); + } } } =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162828105570.59407304586; Tue, 4 Jul 2017 03:07:08 -0700 (PDT) Received: from localhost ([::1]:40074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKjV-0003zs-NO for importer@patchew.org; Tue, 04 Jul 2017 06:07:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY2-0002GT-0I for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKY1-0000ft-AO for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:10 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:36802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKY1-0000eL-2p for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:09 -0400 Received: by mail-lf0-x243.google.com with SMTP id f28so17186596lfi.3 for ; Tue, 04 Jul 2017 02:55:08 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id 78sm4890172lfs.19.2017.07.04.02.55.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ri7kTARnttum4ZYxO8DYUAguNieC63l4RzH7XLp8xxA=; b=vhe+LVdojJm+xHho4I8RUkzOuFSP+X5MrqJ0OtUnwBF6nl4BoorPgliVtgObLXJwLo FRtI9zxxnjjqzqfkP6A9K0WP6dB2DwDn27swi1oVhoGR5BsmhvDUsZLYeMRBn92FTkT1 6SpGoEeqj9by4R5grlyeJrmV6FfwUQOgTFBIpGRLguziM2wbzHhu8bikIjPZwCbDl8Gw aIGqK6CyFjTjgTaGFrqsgn9sabKsenFlzwbRtfxBWTMgECqJSxOmLeZBWREyFVRqpQac wNDgnekogPqWdnPlj4451H3cyTEirTjMjN6PCn1c1tnGcrdIflqWDOC5MDhXz4MOdl/o MSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ri7kTARnttum4ZYxO8DYUAguNieC63l4RzH7XLp8xxA=; b=ZIk9nHdh3TOMmYMFHe1gjbd8E+zykPgAV9O2d2FF6kNCHhSPf/JghqjavSlk1oOeFn O61qzjA/JZtMo8uz3pDqAYSQ7bjenfHXkUrHASVzyHNMAXWchjhXNp+8nYtUEcVH6nmr clJYaS9AVl9deuXAIoyDBJGNnX7mLNbtmFmTUhZIZrUbuNb5EAeE3Fj5jS05t94cJITD aj/MVMPKg/8yLgvtHjG86lvwC+rzoL0Z3QuDcCk/1W8yhjvbIgaV15kxLchfqeEFbA7x m6W2YlSjPqE/PNnFvd4TT9j+/lQTU6HCzcVYoDkGyDI1B9i0ShHMqHTFK1UhIzc+4ES/ vAow== X-Gm-Message-State: AKS2vOwmunY+vcJsW9DCGlRUqhCGKo7J1IjJqqEq6tbEcQh64IncP2F3 DiFYlA9RstcwFAAX X-Received: by 10.46.69.198 with SMTP id s189mr11607364lja.0.1499162107588; Tue, 04 Jul 2017 02:55:07 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:44 +0200 Message-Id: <1499162088-1562-14-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PULL v1 13/17] target-microblaze: dec_barrel: Plug TCG temp leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Plug TCG temp leak. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 504ed88..6ee4885 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -690,6 +690,7 @@ static void dec_barrel(DisasContext *dc) tcg_gen_shr_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); } } + tcg_temp_free(t0); } =20 static void dec_bit(DisasContext *dc) --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162589097307.9343075904527; Tue, 4 Jul 2017 03:03:09 -0700 (PDT) Received: from localhost ([::1]:40054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKfh-0000tE-Uv for importer@patchew.org; Tue, 04 Jul 2017 06:03:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY3-0002JV-Ar for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKY2-0000gu-In for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:11 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:33153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKY2-0000g9-BJ for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:10 -0400 Received: by mail-lf0-x243.google.com with SMTP id t72so17251327lff.0 for ; Tue, 04 Jul 2017 02:55:10 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id b123sm4832335lfb.22.2017.07.04.02.55.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3NLzeipQ5BH4jA/WwfsqH7uS7CoDn8xtRrqi1tbMW4o=; b=qWmlrH/ZVipRHaGx00ZRa4+lDWia76hKw8z5Wwm0tHo8PklyVcAp8HAnqsFQ4p/LQQ EqNY3NVko1KEJyTaQK52E9ENqgF2H2OtCsUH3cwP4nEgtKlFk7GsWlbyxS4gkzqyYzcK 8X8lQT7oT4slr0FxMyXIKwllsFQh1d8G+Voa2xVk+aSW/lVbpMcxXtXjxasj6N/AT6u+ nhD8i56pB7rjFNGClOym4wwPxQUjqrFlKVYywltq5IilHhsivKdjEDyrerooNbnAXw/z tuQN+l7qyVDDe8n3LnYoW5jQeLnTr1S4BZTW2nh7LMn+gOFBbhYap7kH18mEg+MJdiEO Dadg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3NLzeipQ5BH4jA/WwfsqH7uS7CoDn8xtRrqi1tbMW4o=; b=nujSjs5k+9oCik6WGVelmr4+TdKR4tlW1wqKJ9exoNYUmIJyQVkGKMZV9AkcG7tueT QUNlKGwvYjMXTyEA8B71ds/ZF/rJL3M0nDMQeAXEjtjfOoDWml4FF6JdR1eW8UVIkjID NNv3adkwsSUHQ8pzs2ZvQElYxui/CTgjy66UxM8yNbxRwUvDu8Q3fthSvlFUi58SSglh DdWjVxNK+wrGgq5vqhpHifZbg3dqE2nnUCigP4h09EMGg/2zCbq4HPAJnPauarM6yFsa 0dD066gxy+kPDpKX3KcWJceGark5r9mgMstr6vnNoAc9UOTntesUJm5wys164sNnHMmi VBkQ== X-Gm-Message-State: AKS2vOz2TLp41AWbt6wzLx4Yqj/OXO172USuwM5M30SbgUkHgpAFl3DL AaV2Pp+TfhCjrQ4o X-Received: by 10.46.32.16 with SMTP id g16mr10703237ljg.125.1499162108792; Tue, 04 Jul 2017 02:55:08 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:45 +0200 Message-Id: <1499162088-1562-15-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PULL v1 14/17] target-microblaze: dec_barrel: Add BSEFI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add support for BSEFI. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 42 ++++++++++++++++++++++++++++++---------= --- 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 6ee4885..3fad13c 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -660,7 +660,8 @@ static void dec_div(DisasContext *dc) static void dec_barrel(DisasContext *dc) { TCGv t0; - bool s, t; + unsigned int imm_w, imm_s; + bool s, t, e =3D false; =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) @@ -670,27 +671,44 @@ static void dec_barrel(DisasContext *dc) return; } =20 + if (dc->type_b) { + /* Insert and extract are only available in immediate mode. */ + e =3D extract32(dc->imm, 14, 1); + } s =3D extract32(dc->imm, 10, 1); t =3D extract32(dc->imm, 9, 1); + imm_w =3D extract32(dc->imm, 6, 5); + imm_s =3D extract32(dc->imm, 0, 5); =20 - LOG_DIS("bs%s%s r%d r%d r%d\n", + LOG_DIS("bs%s%s%s r%d r%d r%d\n", + e ? "e" : "", s ? "l" : "r", t ? "a" : "l", dc->rd, dc->ra, dc->rb); =20 - t0 =3D tcg_temp_new(); + if (e) { + if (imm_w + imm_s > 32 || imm_w =3D=3D 0) { + /* These inputs have an undefined behavior. */ + qemu_log_mask(LOG_GUEST_ERROR, "bsefi: Bad input w=3D%d s=3D%d= \n", + imm_w, imm_s); + } else { + tcg_gen_extract_i32(cpu_R[dc->rd], cpu_R[dc->ra], imm_s, imm_w= ); + } + } else { + t0 =3D tcg_temp_new(); =20 - tcg_gen_mov_tl(t0, *(dec_alu_op_b(dc))); - tcg_gen_andi_tl(t0, t0, 31); + tcg_gen_mov_tl(t0, *(dec_alu_op_b(dc))); + tcg_gen_andi_tl(t0, t0, 31); =20 - if (s) { - tcg_gen_shl_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); - } else { - if (t) { - tcg_gen_sar_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); + if (s) { + tcg_gen_shl_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); } else { - tcg_gen_shr_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); + if (t) { + tcg_gen_sar_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); + } else { + tcg_gen_shr_tl(cpu_R[dc->rd], cpu_R[dc->ra], t0); + } } + tcg_temp_free(t0); } - tcg_temp_free(t0); } =20 static void dec_bit(DisasContext *dc) --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162747742784.5576310712621; Tue, 4 Jul 2017 03:05:47 -0700 (PDT) Received: from localhost ([::1]:40069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKiH-00031F-FO for importer@patchew.org; Tue, 04 Jul 2017 06:05:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY6-0002O4-IA for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKY3-0000hr-ST for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:14 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKY3-0000hF-KM for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:11 -0400 Received: by mail-lf0-x242.google.com with SMTP id z78so4905132lff.2 for ; Tue, 04 Jul 2017 02:55:11 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id 2sm1985398lju.0.2017.07.04.02.55.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YtC8bm7MGc04FUoVeXe+QVFnjQbU8hI+RX2KKevPMg0=; b=d4kpPFzNM+7Xq0dobEf8ycJkCzRhPAjiv5hqBT3X6AhwlSLhYjsRw+f7Jq2Htz/1W0 bU55pTf5W0D0/qkj8+NQw+u465wvUogeYVHW+K+kGAM8X09Ih28lg+BTclKN5WxIfhwS 6jkGw3ItBD0IJ7MR5n6Rgj2et31W9glhoYzp7V9fKfi3XjP+7oz7S31GnKlTxVdAj283 /ZfMdxFl6QabZrx3ctWr7g7oOfFVSX7BkqVt/MjIDFGEEisT7yG0P4WebtDDjfrB4Tfz 44mNfT6xqb0HOx4RGoqsmI8A3mNemMon6G7qnkySA/4hTB4aMEMYKmdFUVRC2OQwihv4 +YZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YtC8bm7MGc04FUoVeXe+QVFnjQbU8hI+RX2KKevPMg0=; b=DdxOqasVMA+yGOYDGoIZmEZsR+pF9AEpf/rG1ul+Rqjb/JwassY5X6bgbOp1hxzDH6 Hn7ThrcauIvCdgWmqj9GrnDpIFWlC9cSqw6rYII/cHINtGLmnogOK3+PsuYcOJOgue6t LvOzwnDLHmFzPV4Qigx95qHiEEjOq8b6A0WuFgEzreRHQVoK4xqc3mXGEpguGZ+5HfDI HyEpqzzc+//jsTQhDLeNsGs3or1RhNluMSRcnKv5bLTSDqcY9rqoMnRXtEiQ/esh0kxk /bJLvi08SWIznmC5Ib0t+5dyLoJimjeExP9uQBv6TNiMiv8C3hwDteez3VVjMgXkqZnJ 46yA== X-Gm-Message-State: AKS2vOxxnZbKq2xKleVDCoVEfGlGt3ObOlGlfYerW+SmdQb43QhCaUZ4 3pdFiHl95OthHh2k X-Received: by 10.46.77.70 with SMTP id a67mr12539439ljb.103.1499162110105; Tue, 04 Jul 2017 02:55:10 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:46 +0200 Message-Id: <1499162088-1562-16-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PULL v1 15/17] target-microblaze: dec_barrel: Add BSIFI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add support for BSIFI. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 3fad13c..cb65d1e 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -661,7 +661,7 @@ static void dec_barrel(DisasContext *dc) { TCGv t0; unsigned int imm_w, imm_s; - bool s, t, e =3D false; + bool s, t, e =3D false, i =3D false; =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) @@ -673,6 +673,7 @@ static void dec_barrel(DisasContext *dc) =20 if (dc->type_b) { /* Insert and extract are only available in immediate mode. */ + i =3D extract32(dc->imm, 15, 1); e =3D extract32(dc->imm, 14, 1); } s =3D extract32(dc->imm, 10, 1); @@ -692,6 +693,17 @@ static void dec_barrel(DisasContext *dc) } else { tcg_gen_extract_i32(cpu_R[dc->rd], cpu_R[dc->ra], imm_s, imm_w= ); } + } else if (i) { + int width =3D imm_w - imm_s + 1; + + if (imm_w < imm_s) { + /* These inputs have an undefined behavior. */ + qemu_log_mask(LOG_GUEST_ERROR, "bsifi: Bad input w=3D%d s=3D%d= \n", + imm_w, imm_s); + } else { + tcg_gen_deposit_i32(cpu_R[dc->rd], cpu_R[dc->rd], cpu_R[dc->ra= ], + imm_s, width); + } } else { t0 =3D tcg_temp_new(); =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499162216162868.5821745359528; Tue, 4 Jul 2017 02:56:56 -0700 (PDT) Received: from localhost ([::1]:40026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKZi-0003YF-VF for importer@patchew.org; Tue, 04 Jul 2017 05:56:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY6-0002O3-Hl for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKY5-0000iI-5r for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:14 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:34420) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKY4-0000i2-V7 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:13 -0400 Received: by mail-lf0-x241.google.com with SMTP id g21so17213120lfk.1 for ; Tue, 04 Jul 2017 02:55:12 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id n15sm3845842lje.12.2017.07.04.02.55.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l86KM+ckCKMTJvnJK1n8gBV0vb0HtBUWHXyTajNjo+w=; b=OsR+DgdDqO5KNKNZZXdFXq1Za1QVZK2/mhGwKBXCwHrgE+8B4Uz5WMLATJCg2rma0l 5NM92swFiGSZhpR1rxSGkF1YpKD5Qj7Q9qWRz+bWBDJqBx43WB6AiPStSty8AtUGgERX 1Vc/qUnRJw7+iDBDB1qyg8qbF05TQhP8jn/LlpUoJlL/JUBaISE6JqSiZqfUphpP0TJ1 glEKLngfkEVw2ZWPXk3BcQEAE+l4SR/scQ5Jp7ZICgy5D/rzPOWQFhHuVoOVLS9z98wz Ts4QZXbAIlQkeoYPkXbfEef1JT7cvLza+C7gr/ZscbvUhesCnk7nEMsYfMso/3KC9iIM PMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l86KM+ckCKMTJvnJK1n8gBV0vb0HtBUWHXyTajNjo+w=; b=UVdSyGmuugS/Medpfj/vwduoNghU3Xe1Xjkc0cBK6CcSnAXn7uZ8SPzlCGFr3mAYbV qZw8CaNKFFA0cPMEo8c0OC+XkoIo74bG9tL5zIfGXVGZRLIpGkECp7uADHj3Bn47c0qY Vxq6Zyka/JbSxAAoW78kUWIv7Hm1uMIjkM8BfZEKoOUSwVAkseT4/tPILhDBpossFmFB JDdnNXw1i5KIMs89i7efvcaP3NNjMbwz7+aT8Bjt5liUGpnI3f/UVNO6NDRpuoYC9eL3 mzNpcb9yqaPNNd4pNk9PrXENlaoxxZNJOJtS1DG+eMhyQ7V/KC35fussbki+04JeUSxe 0MCg== X-Gm-Message-State: AKS2vOwr4ipNpw9uff+bC2sBr0SlCJQtJxPDz82JJmT6qBUEwCQOG8Bl XhCe8GRzxqoVQkVw X-Received: by 10.25.149.71 with SMTP id x68mr12721117lfd.136.1499162111354; Tue, 04 Jul 2017 02:55:11 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:47 +0200 Message-Id: <1499162088-1562-17-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PULL v1 16/17] target-microblaze: Add CPU version 10.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add CPU version 10.0. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 6e27c3c..f85ff01 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -67,6 +67,7 @@ static const struct { {"9.4", 0x21}, {"9.5", 0x22}, {"9.6", 0x23}, + {"10.0", 0x24}, {NULL, 0}, }; =20 --=20 2.7.4 From nobody Wed May 1 05:23:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149916286911281.71946199831086; Tue, 4 Jul 2017 03:07:49 -0700 (PDT) Received: from localhost ([::1]:40076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKkC-0004Zy-R5 for importer@patchew.org; Tue, 04 Jul 2017 06:07:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKY7-0002OY-37 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKY6-0000il-B3 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:15 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSKY6-0000iS-37 for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:55:14 -0400 Received: by mail-lf0-x244.google.com with SMTP id f28so17186841lfi.3 for ; Tue, 04 Jul 2017 02:55:13 -0700 (PDT) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id j88sm3787936lfi.57.2017.07.04.02.55.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 02:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5JgL8M1hcohBfdKW9brHFOCR2GKKUQpSFZ2AUXPZMB4=; b=QE4VXvtAryeDZnZaY9YOyrSOwloqc061FrIJ8Ymd6oBwhvtPCLPkH8fi+I+K0BxQrr 08FfOZm8ILsE4oUYG3G9xjqkaTbJW9pr/Q/xTxSZQBxHmoRqGTpvptSVJz0Vne1KFq5n ER+H02OxL6IyDFyckUlHbqiivJwk+Q1savD+hb5eFJ8XkpXpiZ8y2qA3Cg2B8Hak5lBM 4iMFbPGW7s1Z9sXWTXpNLXtu9Te9VYax7xjKSoRpSb7EU54JrQ8ar0HWJtiUGpmAPrbX /OT9MjHGY14BilusmCXq2XtljyX/0tlyGVk1L004Awa49ee1jwU//UGnu3onnFwe51zg 6Rew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5JgL8M1hcohBfdKW9brHFOCR2GKKUQpSFZ2AUXPZMB4=; b=MQuwX/hpl/5YXu8zVyjApU6h20oXf5j4QXfaQ/mhDP2/Kn9/ztCRLvnSZgUmpAWuVN yVh0fVRvca1sQ7SVqjks7ktt3eV5DJ3SX78cmx4I/zkJaqUQ74smWGiZFBzsS/VUIvZ3 9Iz4GBn7EeGccnh804keSVSYh+i3s5NXkZY8nVo1uEkEeyi1ALkWwIRY1HzLscYrI2YE dQgcPW74xnGkW9PsABKrkp8acFziJSgNCeLAtxvkFMP6ylsPs6HeYRYU287JCpS/ZmPz ZHtkMLDCDMfqe4ZDNevbjSSEH7N0uecVAeeBHuzKI+YIaxiSj2x0qOSC8ku1D7cXjyzI shPA== X-Gm-Message-State: AKS2vOwxLY9wY690PjS4Tu2JtJzcy3wRFaYtgojE8G5UZswPhSenGCTr syEz2JQ+YcvMmXfG X-Received: by 10.46.77.197 with SMTP id c66mr11404325ljd.71.1499162112596; Tue, 04 Jul 2017 02:55:12 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 4 Jul 2017 11:54:48 +0200 Message-Id: <1499162088-1562-18-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> References: <1499162088-1562-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PULL v1 17/17] xilinx-dp: Add support for the yuy2 video format X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com, alistai@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add support for the yuy2 video format. Reviewed-by: KONRAD Frederic Acked-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/display/xlnx_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index f7b7b80..a77d7db 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -624,6 +624,9 @@ static void xlnx_dp_change_graphic_fmt(XlnxDPState *s) case 0: s->v_plane.format =3D PIXMAN_x8b8g8r8; break; + case DP_NL_VID_Y0_CB_Y1_CR: + s->v_plane.format =3D PIXMAN_yuy2; + break; case DP_NL_VID_RGBA8880: s->v_plane.format =3D PIXMAN_x8b8g8r8; break; --=20 2.7.4