From nobody Mon Feb 9 13:38:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1498728659276789.3790469916102; Thu, 29 Jun 2017 02:30:59 -0700 (PDT) Received: from localhost ([::1]:37968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQVmp-0003Bu-UC for importer@patchew.org; Thu, 29 Jun 2017 05:30:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQVlS-0002C8-Fx for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQVlM-0001Xc-LP for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:29:30 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:43371 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQVlM-0001Ws-Fl for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:29:24 -0400 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D0BCA81463; Thu, 29 Jun 2017 11:29:22 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wx_C5DVrTXvN; Thu, 29 Jun 2017 11:29:22 +0200 (CEST) Received: from wifi-guest-252.act-europe.fr (wifi-guest-252.act-europe.fr [10.10.126.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id B528F8147B; Thu, 29 Jun 2017 11:29:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at eu.adacore.com From: KONRAD Frederic To: qemu-devel@nongnu.org Date: Thu, 29 Jun 2017 11:28:53 +0200 Message-Id: <1498728533-23160-4-git-send-email-frederic.konrad@adacore.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1498728533-23160-1-git-send-email-frederic.konrad@adacore.com> References: <1498728533-23160-1-git-send-email-frederic.konrad@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 194.98.77.210 Subject: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, frederic.konrad@adacore.com, alistair@alistair23.me, alex.bennee@linaro.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This helps the board developer by asserting that system_clock_rate is not null. Using systick with a zero rate will lead to a deadlock so better show= ing the error. Signed-off-by: KONRAD Frederic --- hw/timer/armv7m_systick.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/armv7m_systick.c b/hw/timer/armv7m_systick.c index df8d280..745efb7 100644 --- a/hw/timer/armv7m_systick.c +++ b/hw/timer/armv7m_systick.c @@ -54,6 +54,9 @@ static void systick_reload(SysTickState *s, int reset) s->tick =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); } s->tick +=3D (s->reload + 1) * systick_scale(s); + + /* system_clock_scale =3D 0 leads to a nasty deadlock, better aborting= */ + assert(systick_scale(s)); timer_mod(s->timer, s->tick); } =20 --=20 1.8.3.1